- 30 Mar, 2020 40 commits
-
-
Anders Hartvoll Ruud authored
We are approaching our current 16-bit limit for flags, and last time I exceeded this limit locally (and hence redefined CSSProperty::Flags to uint32_t), it took a while to understand why things didn't work. The reason was that the Longhand/Shorthand constructors truncated the integer to uint16_t. No new flags are planned at the moment, but I still want to eliminate this trap for when we _do_ add a new flag. Change-Id: I4527b7ed16b9f289135a3a37665cbcf319d8bb7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124252Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#754432}
-
Tim van der Lippe authored
This updates the version of clang-format to a more recent version, as the previous version was almost 3 years old. R=hans@chromium.org CC=thakis@chromium.org Fixed: 993206 Change-Id: I2b8944197948c91287d5f49f515137445a0e7ba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124653Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#754431}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d1dae2a33653..e7603d3ab878 git log d1dae2a33653..e7603d3ab878 --date=short --first-parent --format='%ad %ae %s' 2020-03-30 eseckler@google.com chromium: Fix reference to license file. Created with: gclient setdep -r src/third_party/perfetto@e7603d3ab878 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1065336 Tbr: perfetto-bugs@google.com Change-Id: Ide77fb2be9e161c914be47bb6f7c1547b6f9f52d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126486Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754430}
-
arthursonzogni authored
V8 provides two primitives for Chrome to block/allow 'eval': 1) AllowCodeGenerationFromStrings(bool) 2) SetModifyCodeGenerationFromStringsCallback(callback). Different parts of the Chrome codebase independently call either of those, effectively stepping on each others toes. This patch makes the |callback| to be called independently from the execution context's CSP. There is only one location where CSP are checked for eval: CodeGenerationCheckCallbackInMainThread (and only one) AllowCodeGenerationFromStrings is kept for disabling temporarily eval checks for: - Inspector's injected scripts. - Extensions's injected scripts. Bug: 1024786 Change-Id: I668107242e6c2923951b91d0a35f1befbaf35827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007451Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#754429}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/bfe4c5957fc5..344bd0889ac9 git log bfe4c5957fc5..344bd0889ac9 --date=short --first-parent --format='%ad %ae %s' 2020-03-30 johnkslang@users.noreply.github.com Merge pull request #2162 from ntfshard/small_fix 2020-03-30 cepheus@frii.com Fix #2163: improve comments for addProcess() and the preamble. Created with: gclient setdep -r src/third_party/glslang/src@344bd0889ac9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,cnorthrop@google.com Change-Id: I262e241ce86076e8830b5b8dbe98bfe3c17d0ee5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126474Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2ee638f5e93f..cef0a5f63a68 Created with: gclient setdep -r src-internal@cef0a5f63a68 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I8a73f3d001d193aeef6910713ea60522657f5c96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126483Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#754427}
-
Alice Wang authored
This CL moves the util method AccountManagerFacade.createAccountFromName to AccountUtils to facilitate the extraction of AccountManagerFacade interface later. Bug: 1064887 Change-Id: I7aab9a05a2d6d008fb9da2ae633697dab64d2fbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2122024Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#754426}
-
Anders Hartvoll Ruud authored
This is necessary to avoid a circular #include via CSSInterpolationEnvironment in a subsequent CL. There should be no behavioral change. Change-Id: I733a84bba7e8ce19259c079f7a170ee9ee9965f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124375Reviewed-by:
-
Jia authored
Bug: 1063887 Change-Id: I41ebe4e6eb7237581afa1028ea74d482604500f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126410Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#754424}
-
Stephan Hartmann authored
nullptr_t is defined in namespace std. Bug: 819294 Change-Id: Ia3e8257ece1331319272ead84472eefcc7259268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126289Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#754423}
-
Lin Sun authored
In Intel graphics driver version schema, the build number that determines if you have the latest driver installed is only part of whole version number. The others are the identifier numbers that represents operation system version or other information, which are meaningless when comparing two version numbers. Bug: 1015647, 363721, 908069, 890227 Change-Id: I121ebab2e401c85a01a2bc37b10bebfcb788cc5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124108 Commit-Queue: Lin Sun <lin.sun@intel.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#754422}
-
Bartek Nowierski authored
Change-Id: Iba4b711d600fa25a4207b917cc32933a2787eaf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124342 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I8c395a77e96c43a4f494f5696bf9f06eae78ebdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126477Reviewed-by:
-
Mathias Bynens authored
The filter color matrices are now based on the following research paper: Gustavo M. Machado, Manuel M. Oliveira, and Leandro A. F. Fernandes “A Physiologically-based Model for Simulation of Color Vision Deficiency”. IEEE Transactions on Visualization and Computer Graphics. Volume 15 (2009), Number 6, November/December 2009. pp. 1291-1298. https://www.inf.ufrgs.br/~oliveira/pubs_files/CVD_Simulation/CVD_Simulation.html Bug: chromium:1003700 Change-Id: Ib60d6d740f5842f2d4a3271fc48594a631611507 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124500Reviewed-by:Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#754419}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2af68a4c4d57..e9bc857b39c2 git log 2af68a4c4d57..e9bc857b39c2 --date=short --first-parent --format='%ad %ae %s' 2020-03-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 f2bee3043a5e..1b2dd6f92a6b (18 commits) 2020-03-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 2cb42d2f..af1924a6 (483 commits) Created with: gclient setdep -r src/third_party/skia@e9bc857b39c2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: michaelludwig@google.com Change-Id: I35e87b4fb819f8f5799b1c131be5f8707c4d20a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126473Reviewed-by:
-
David Jean authored
Take II, ignore previous CL GaiaAuthFetcherIOSNSURLSessionBridgeTest.FetchWithRedirect GaiaAuthFetcherIOSNSURLSessionBridgeTest.FetchWithCookieStore GaiaAuthFetcherIOSNSURLSessionBridgeTest.FetchWithEmptyCookieStore TBR=jlebel@chromium.org Bug: 1065349 Change-Id: Iec5f3f84ea9f56c9f2e701e6271c47538383b512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124451Reviewed-by:
David Jean <djean@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#754417}
-
Colin Blundell authored
This better reflects the current state of the world. Bug: 1035052 Change-Id: I6fed6c8daf79973e695ccca9e38bc67e604dbd5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124667Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Sam Goto <goto@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#754416}
-
Hitoshi Yoshida authored
In general, we can use VectorOf<T> to describe a vector type of T, if T is fully defined beforehand. However, in generated code, there is a case of cyclic reference of classes, and we need a forward declaration to break it. As a result, there is a use case of VectorOf<T> without T's definition. This CL avoids the compile error with using HeapVector<T> explicitly for obvious cases. This CL works only in the new code generator, which is enabled behind a flag, thus it doesn't change any production code. Bug: 839389, 1060478 Change-Id: Ifa7e2bf41c016fb527bd8cd0ac70f87ec3af1e52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123577 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
Alex Danilo authored
Bug: 1061310 Change-Id: Ic446c0f3ea99c7f6f289703d2e15b30a87287d16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123959 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#754414}
-
Julie Jeongeun Kim authored
This CL is a follow-up of https://crrev.com/c/2120664. It renames intrinsic-min-width-applies-with-fixed-width.html to flex-minimum-width-flex-items-014.html. Bug: 1063749 Change-Id: I66932589a9d05c4c8fed68e4f55e751bfaa82fbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123694Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#754413}
-
Kenichi Ishibashi authored
To identify why we activate a waiting version when the active (existing) version is still controlling clients. Bug: 1015692 Change-Id: I8b11f488b58ed667133a6473c7f61cd6928da0a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126407 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#754412}
-
Anand K. Mistry authored
SmbFsShare accesses VolumeManager on destruction. However, it is not valid to obtain another KeyedService on KeyedService destruction. Namely, accessing VolumeManager on SmbService destruction. KeyedService provides a Shutdown() function that can be used to clean up before destruction. Bug: 1065271 Change-Id: I1704ed05ef96cb6c58132a35c8dbeff3700d0882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123580Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bdca68298023..2ee638f5e93f Created with: gclient setdep -r src-internal@2ee638f5e93f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I7cdc7956511dd9c95f1eefc884a5480b281f4ed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126374Reviewed-by:
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Id2cbcd0dafb470fb368722f3b1eed9e22a39df3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108212 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#754409}
-
Andrey Kosyakov authored
Bug: 1059577, 1064852 Change-Id: I2994be49f53aa8fc52fbd7cee543fa65521670f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121434 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#754408}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3aee4845b503..2af68a4c4d57 git log 3aee4845b503..2af68a4c4d57 --date=short --first-parent --format='%ad %ae %s' 2020-03-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 3ca41df3d3ba..1c29477aa06e (9 commits) Created with: gclient setdep -r src/third_party/skia@2af68a4c4d57 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: michaelludwig@google.com Change-Id: I443560aa87a3e1bfd8ed6c495ce43bdfcbbd9381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126375Reviewed-by:
-
Raul Tambre authored
itervalues() has been removed in Python 3. Use values() which is functionally same on both Python 2 and 3 in this case. Traceback (most recent call last): File "../../third_party/blink/renderer/build/scripts/make_origin_trials.py", line 128, in <module> json5_generator.Maker(OriginTrialsWriter).main() File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\json5_generator.py", line 337, in main writer = self._writer_class(args.files, args.output_dir) File "../../third_party/blink/renderer/build/scripts/make_origin_trials.py", line 52, in __init__ for features in self._trial_to_features_map.itervalues()) AttributeError: 'dict' object has no attribute 'itervalues' Bug: 941669 Change-Id: I474ae78b34dae62089dbcbd7f77d3358bf854733 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125729 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: -
Raul Tambre authored
func_name has been removed in Python 3. __name__ does the same thing and exists in both Python 2 and 3. Traceback (most recent call last): File "../../third_party/blink/renderer/build/scripts/core/css/parser/make_atrule_names.py", line 11, in <module> class AtRuleNamesWriter(json5_generator.Writer): File "../../third_party/blink/renderer/build/scripts/core/css/parser/make_atrule_names.py", line 53, in AtRuleNamesWriter def generate_implementation(self): File "C:\Google\chromium\src\third_party\blink\renderer\build\scripts\gperf.py", line 74, in wrapper generator_internal.func_name = generator.func_name AttributeError: 'function' object has no attribute 'func_name' Bug: 941669 Change-Id: I8eac2f3e67c235bb0cad5520c71916aa5f6fd13a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124613 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: -
Julian Watson authored
This will make it easier to move crostini_registry_service into guest_os. Bug: 1049453 Change-Id: I9cb25c03689dec04883eb83500fe610d88c377aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114315 Commit-Queue: Julian Watson <juwa@google.com> Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Auto-Submit: Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#754404}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: I6bdb732edbc909a096cffbe12ec7e379104d9236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109670 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
-
Raul Tambre authored
Initial conversion performed using "2to3 -f print .". Imports added and duplicate parentheses removed manually. There are no functional changes. Bug: 941669 Change-Id: I32f540c49bfdf183a1514755ea140592b502e58c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124612 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Alan Cutter authored
This CL fixes the context menus of web apps while the DesktopPWAsTabStrip flag is enabled to no longer have two radio buttons checked. Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=439506&signed_aid=5Uz5Wc8hNehCVzvIOIGVDQ==&inline=1 After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=439505&signed_aid=S6xeaj0fgJdJwF5VO5qdZA==&inline=1 Bug: 1065757 Change-Id: I067bec39520817a6d3f492d836fd1f433e44acc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126335 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
-
Raul Tambre authored
Python 2 seems to implicitly create a list in some cases. Python 3 doesn't do that. Surround with brackets to make this explicit, so it works on both. File "../../third_party/blink/renderer/bindings/scripts/generate_global_constructors.py", line 123 for name in 'RuntimeEnabled', 'ContextEnabled', 'SecureContext' ^ SyntaxError: invalid syntax Bug: 941669 Change-Id: I1043faf33eab77fc220072b2e575182b4a015ecd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124755 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by: -
Julie Jeongeun Kim authored
This CL migrates this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose and adds 10x10-green.png. Bug: 1063749 Change-Id: I46e877a6aa10126fd86b05c29756786c2293433f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123499 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
-
Austin Tankiang authored
The button does nothing, so remove it to prevent confusion. Also make sure that the progress panel treats format and sync panels as progress panels to use when calculating the summary panel's progress. Bug: 1065274 Change-Id: If91d64837de635c94caeb1143329ab42c3608f21 Tests: browser_tests --gtest_filter="FileManagerJsTest.FilesDisplayPanel" Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123574Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#754398}
-
Bartek Nowierski authored
Change-Id: I563a9b3633245196de4e608ca3374e1888fb2045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123505Reviewed-by:
-
Timothy Loh authored
Currently we log a PluginVm.SetupResult histogram which breaks down failure cases into which stage of the installation failed. As we have a more granular enum value, this CL makes us log that instead. We also take the opportunity to simplify the installer observer to only have a single callback for installation failed, as the failure reason enum is sufficient. Bug: 1063748 Change-Id: I0ec8171275a21f6c139a9a5a2baf77111ce16c29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123497 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#754396}
-
Shik Chen authored
Bug: 982201,b:148045035 Test: Call getUserMedia() with resizeMode = "crop-and-scale", check the camera stream is cropped properly. Change-Id: Ib5c8ff0f97cb6ee9b6883fd55dc53faa4e248c00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041712Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#754395}
-
Alan Cutter authored
This CL updates a DCHECK for kDesktopPWAsTabStrip being enabled to only occur if we're updating an app to use the experimental tabbed mode. Previously it was possible to hit this DCHECK when the experiment is disabled and the user is setting the window mode to something other than tabbed mode. Bug: 897314 Change-Id: Ie1bc99cf9967d45c4f9f3048ff8bf88025ed34d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126334 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#754394}
-
Julie Jeongeun Kim authored
This CL migrates this test out of third_party/blink/web_tests/css3/flexbox and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: I9e3ce8c44ad2ca7852aeae25e99d4ebbf6c959f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124130 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
-
