- 21 Sep, 2018 40 commits
-
-
Vladimir Levin authored
This patch introduces the above function in an effort to do fewer invalidations if only a descendant needs an update instead of self. Fixes up two call sites: - Unnecessary selection rect on a layout replaced - Missing dirty bit on table section overflow changes This also cleans up SetNeedsPaintPropertyTreeUpdate a bit. R=pdr@chromium.org, chrishtr@chromium.org, wangxianzhu@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib1bdd8b08bf21f69f9ae17a85d12592a689a6c11 Reviewed-on: https://chromium-review.googlesource.com/1237246 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#593369}
-
Dmitry Gozman authored
We don't need these anymore, since we handle initiator on the browser side already. Bug: none Change-Id: I22203de6b20319fa4bab11bbe3eda82013744fa7 Reviewed-on: https://chromium-review.googlesource.com/1239421Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#593368}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/92df4e63abbe..0dc1fa046374 git log 92df4e63abbe..0dc1fa046374 --date=short --no-merges --format='%ad %ae %s' 2018-09-21 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@0dc1fa046374 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ibe604e0221d5ba50ccf681d3688374f0d1b86a6d Reviewed-on: https://chromium-review.googlesource.com/1238864Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593367}
-
Ella Ge authored
This CL turns on zoom-for-dsf on M71 And also fix a webview unittest that doesn't count dsf. And rebaseline pixel tests.(difference see: http://chromium-browser-gpu-tests.commondatastorage.googleapis.com/view_test_results.html?2082aa2352cae2409ea1f102c52d7daa53daa13a_android_marshmallow_arm64_rel_telemetry) Bug: 737777 TBR: avi@chromium.org (feature flag) Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4f3c56101333a0bfdbcb353fe1841fa01a8e082a Reviewed-on: https://chromium-review.googlesource.com/1234014 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#593366}
-
James Cook authored
It's only used in ash code. It also has aura dependencies, which is unexpected for general-purpose views code (which supports non-aura Views on Mac). This makes it easier to find when we audit code in ash for mustash. Bug: 887780 Test: ash_unittests Change-Id: I0380d94f695ac747475f3e7527059d7f8e597041 Reviewed-on: https://chromium-review.googlesource.com/1238545Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#593365}
-
Min Qin authored
This CL adds implementation of OfflineItemModel. Some of the common functionalities between OfflineItemModel and DownloadItemModel are moved to DownloadUIModel. Bug: 881499 Change-Id: Ic2e4835f4eb16422f152d0ed641dba3e9646defb Reviewed-on: https://chromium-review.googlesource.com/1239334 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#593364}
-
Fady Samuel authored
Bug: none Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I76d7a947196be09cdffc45dc3fd86b9f5a5b17aa Reviewed-on: https://chromium-review.googlesource.com/1239415Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#593363}
-
Adam Klein authored
This flag has been enabled by default for quite some time now. Bug: 642912, 875009, v8:8015 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2d1638c4b93eeff8e864eb7dbdc360b34e02e526 Reviewed-on: https://chromium-review.googlesource.com/1239335Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#593362}
-
Jordy Greenblatt authored
In addition to the existing behavior of handling clicks on the 'new user' notification by opening setup flow, we want clicks on the 'host switched' and 'chromebook added' notifications to open the settings subpage. This CL adds a ShowConnectedDevicesSettings to the system tray mojo service and has those notification clicks call it. Bug: 876928 Change-Id: I5f49275abb5e24d3973385af5720376de967852b Reviewed-on: https://chromium-review.googlesource.com/1239113Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#593361}
-
Bo Liu authored
Inline two methods that's has a single call site. Rename methods to add/removeConnection since BindingManager isn't based on LRU anymore. Change-Id: I292a9a596c89720ab17f0bade704fa5c30d11d15 Reviewed-on: https://chromium-review.googlesource.com/1239345Reviewed-by:
Siddhartha S <ssid@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#593360}
-
Nico Weber authored
Bug: 832676 Change-Id: Ia5a1810b329d05e9357376cf00ac3f7d144ee96a Reviewed-on: https://chromium-review.googlesource.com/1237454Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#593359}
-
Brandon Wylie authored
Bug: 882970 Change-Id: I26400cecff3137842a73692317d05a503ce029bb Reviewed-on: https://chromium-review.googlesource.com/1239416Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#593358}
-
Dale Curtis authored
Mechanically done via: git grep --name-only "FROM_HERE, base::Bind(" | \ xargs sed -i "s/FROM_HERE, base::Bind(/FROM_HERE, base::BindOnce(/g" This replaces all instances of Bind with PostTask to use BindOnce. It does not catch multiline variants of this pattern unfortunately, so is just a subset of the usage. BUG=none TEST=cq, compiles Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I9d477b028841f6b14b32ab49a49fc695c223385c Reviewed-on: https://chromium-review.googlesource.com/1239342 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#593357}
-
Xianzhu Wang authored
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iba7a5721a587ad1713e1e7e5f7eae0611af389d3 Reviewed-on: https://chromium-review.googlesource.com/1239203Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#593356}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/15abb5c68f71..32261ee689fe git log 15abb5c68f71..32261ee689fe --date=short --no-merges --format='%ad %ae %s' 2018-09-21 sadrul@chromium.org dashboard: Include metric name for rendering alerts. 2018-09-21 benjhayden@chromium.org Fix bbc test case in system_health_report 2018-09-21 jbudorick@chromium.org Use vpython and remove vendored pymock. 2018-09-21 anthonyalridge@google.com Introduces state management for results.vue. Created with: gclient setdep -r src/third_party/catapult@32261ee689fe The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:870324,chromium:878777,chromium:777865,chromium:866423 TBR=sullivan@chromium.org Change-Id: I42b47c5cb63f2cac87c9c82cbbdaf9b7eea42e9e Reviewed-on: https://chromium-review.googlesource.com/1239158Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593355}
-
Yuri Wiitala authored
Multiple fixes around RenderFrameHostImpl not always notifying its RenderProcessHostImpl that audio streams have been added/removed. Before these fixes, RenderProcessHostImpl was sometimes leaving a render process backgrounded indefinitely, or sometimes leaving it non-backgrounded indefinitely. Bug: 887208 Change-Id: I1713887c96382b8bdf032c82bb49723fc0219f71 Reviewed-on: https://chromium-review.googlesource.com/1232475 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#593354}
-
Stephen Martinis authored
This CL sorts all .pyl files which are inputs to the //testing/buildbot/generate_buildbot_json.py script, and ensures that future changes must keep those files sorted. It does this using python ast parsing. NOTRY=true Change-Id: I6742aa9ef1c63d9c1e5143a2790886c0c763e588 Reviewed-on: https://chromium-review.googlesource.com/1232531 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#593353}
-
Scott Violet authored
And replaces with hit_test_data_.size(). BUG=none TEST=none Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I0bd21c5cfe5ced5df871dc9ed419a291b4633018 Reviewed-on: https://chromium-review.googlesource.com/1239168Reviewed-by:
Ria Jiang <riajiang@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#593352}
-
Dale Curtis authored
base::ResetAndReturn is deprecated and .is_null() syntax is onerous. Mechanically done via: git grep --name-only "base::ResetAndReturn(\&" | \ xargs sed -i "s/base::ResetAndReturn(\&/std::move(/g" git grep --name-only -e "_cb_\.is_null\(\)" *.cc | \ xargs sed -ri "s/!([a-zA-Z0-9_]*)_cb_\.is_null\(\)/\1_cb_/g" git grep --name-only -e "_cb_\.is_null\(\)" *.cc | \ xargs sed -ri "s/([a-zA-Z0-9_]*)_cb_\.is_null\(\)/\!\1_cb_/g" git grep --name-only -e "_cb\.is_null\(\)" *.cc | \ xargs sed -ri "s/!([a-zA-Z0-9_]*)_cb\.is_null\(\)/\1_cb/g" git grep --name-only -e "_cb\.is_null\(\)" *.cc | \ xargs sed -ri "s/([a-zA-Z0-9_]*)_cb\.is_null\(\)/\!\1_cb/g" Bug: none Test: compiles, passes cq Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I7bb2bd9da08a4749b69bfbc6d3f471a1cfc1d6c0 Reviewed-on: https://chromium-review.googlesource.com/1239200Reviewed-by:Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#593351}
-
Eric Karl authored
If we're backgrounded, the OS may aggressively kill procs we try to start. Avoid creating the Viz proc while backgrounded, instead wait for us to come to foreground. Bug: 866631 Change-Id: I01c73707bbb65dcbc87eda1b344de2ce72647b5d Reviewed-on: https://chromium-review.googlesource.com/1239219 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#593350}
-
Kyle Horimoto authored
Previously, the multi-device setup flow ran in a normal user session; when the user wanted to set up a device, the user would be prompted to enter a password before continuing. When the password is entered successfully, an auth token is fetched and is passed to the SetHostDevice() API function. Now, we are adding support for the setup flow as part of OOBE. In OOBE mode, the user has just entered a password in order to sign in, so there is no need to prompt the user a second time. However, since the API function requires that a valid auth token be passed, it is not applicable for this case. This CL creates a new Mojo interface which exposes a function to set a host device without the need for an auth token. The interface is designed to be used only be OOBE. Bug: 884056 Change-Id: Ice02f1d38ed722a97497d5be8b6f603455f8461a Reviewed-on: https://chromium-review.googlesource.com/1235305 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#593349}
-
rbpotter authored
Making divs actionable left the hand pointer on them even when they are disabled. Ensure they are only actionable when not disabled. Bug: 887823 Change-Id: I35ab8355c7ed10d457e3106cd1639b42eb96fd54 Reviewed-on: https://chromium-review.googlesource.com/1239255Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#593348}
-
Leonard Grey authored
Bug: 850098 Change-Id: I8d18484774982a8ec0272f62f0bd77a43668eb0d Reviewed-on: https://chromium-review.googlesource.com/1238796Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#593347}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0464dbfe8e21..835cc9ad9eb5 git log 0464dbfe8e21..835cc9ad9eb5 --date=short --no-merges --format='%ad %ae %s' 2018-09-21 bhthompson@google.com Add bvt-inline to grunt paladin Created with: gclient setdep -r src/third_party/chromite@835cc9ad9eb5 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ie8c18f652f8664889e0c23d01d02b2225ebf8f96 Reviewed-on: https://chromium-review.googlesource.com/1239205Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593346}
-
liberato@chromium.org authored
It wasn't included in TestExpectations by https://chromium-review.googlesource.com/c/chromium/src/+/1237235 but it looks like it failed all the same. NOTRY=true TBR=majidvp@chromium.org Bug: 887659 Change-Id: Iabb8204a4b4b05515838cf20378e61d07062ea51 Reviewed-on: https://chromium-review.googlesource.com/1239446Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#593345}
-
sczs authored
Bug: 888107 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I4672a36b92128b3a0fccdfca6f1181b7bcacd0a0 Reviewed-on: https://chromium-review.googlesource.com/1239344Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#593344}
-
Wan-Teh Chang authored
The bitstream for AV1 is frozen now. Change-Id: I3a27762732a6163986720de389a721bb64b0fbbb Reviewed-on: https://chromium-review.googlesource.com/1238657Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#593343}
-
David Black authored
AssistantWebView observed |content_view_| but did not stop observing it prior to its destruction. When |content_view_| was destroyed, it would attempt to notify AssistantWebView which, in the case of this bug, was already destroyed itself. Note that |content_view_| is owned by ManagedWebContents in chrome/browser. Bug: b:116246256 Change-Id: I5839f60a6ba4c1ba07f0ce0977cdb6e0c4f48158 Reviewed-on: https://chromium-review.googlesource.com/1237412 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#593342}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ab5fb5edb186..9d84ccbaf233 git log ab5fb5edb186..9d84ccbaf233 --date=short --no-merges --format='%ad %ae %s' 2018-09-21 fjhenigman@chromium.org Vulkan: renderer->finish() before reading buffers. Created with: gclient setdep -r src/third_party/angle@9d84ccbaf233 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Iccf52144b656d9d7ce92ab324226522d030ec124 Reviewed-on: https://chromium-review.googlesource.com/1238860Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593341}
-
Vladislav Kaznacheev authored
This reverts commit 2c775257. Reason for revert: this CL removed badges from ALL search results instead of just local/drive (which is what the bug was for). A better fix is at: crrev.com/c/1238997. Original change's description: > Removes icon badges from app list search result list > > Bug: 872404 > Change-Id: I6b169bf470d9af2ef3c7fca9ef59081615ece5cf > Reviewed-on: https://chromium-review.googlesource.com/1208692 > Reviewed-by: Weidong Guo <weidongg@chromium.org> > Commit-Queue: Kevin Strohbehn <ginko@google.com> > Cr-Commit-Position: refs/heads/master@{#589207} TBR=weidongg@chromium.org,ginko@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 872404 Change-Id: I2ed3f40361473ed590ffbb914fbd7a1e2722aec7 Reviewed-on: https://chromium-review.googlesource.com/1238827Reviewed-by:
Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Cr-Commit-Position: refs/heads/master@{#593340}
-
Charles Zhao authored
This will enable HourAppLaunchPredictor to forget old records so that: (1) Recent actions are more considered. (2) App launching records that have not been used for several months will be deleted from the saved model file. Bug: 871674 Change-Id: Iab08dfedc3b10cb9985030f1141a179529e30798 Reviewed-on: https://chromium-review.googlesource.com/1236614 Commit-Queue: Charles . <charleszhao@chromium.org> Reviewed-by:Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#593339}
-
Robert Ogden authored
Removes the random query param hack and prevents the timeout logic from running in all tests. Bug: 887962, 885252 Change-Id: Icc001d2e6d584228027ae56a12813c02dcaf0b42 Reviewed-on: https://chromium-review.googlesource.com/1239393Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#593338}
-
Francois Doray authored
This CL updates the ProactiveTabFreezeAndDiscard testing config to match variation params that will be used to experiment on stable. Note that we will also experiment with other variation params to assess their impact. The CL also updates the study name to "TooManyTabs", which is the study name used in the server-side config file. Bug: 844426 Change-Id: I3ab5d0d0005843f00c8bb0382ecb66a97670c0fb Reviewed-on: https://chromium-review.googlesource.com/1238996Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#593337}
-
Evan Stade authored
1. Remove AshFrameSizeButton dependency on PhantomWindowController via a new interface. For Mash Chrome browser frames, this will be implemented via Mojo (for now, that's a TODO). 2. Add ash::TabletMode utility to //ash/public/cpp, which allows code in //ash/public/cpp to get the status of tablet mode from any process (each process has to provide a callback). 3. Move the files from private Ash to the new directory. Bug: 887051 Change-Id: Ib790a89fae89f02b92b36e1b165d59c9e28b59f7 Reviewed-on: https://chromium-review.googlesource.com/1228978 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#593336}
-
Eric Karl authored
CompositorImplAndroid had sizing logic for gpu::SharedMemoryLimits which was not propogated to Viz. Adding this in. Bug: 886816 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I15b0c75a3a5778bcd912cebd37fa8273736d97d8 Reviewed-on: https://chromium-review.googlesource.com/1237405Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#593335}
-
Lukasz Anforowicz authored
This CL also fixes a missing lock that was found by the compile-time analysis in ChildProcessSecurityPolicyImpl::HasPermissionsForFileSystemFile. Bug: 887645 Change-Id: I940ade66bb2d754669c2b5bd408b63c91a1a8d5a Reviewed-on: https://chromium-review.googlesource.com/1237145 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#593334}
-
Michael Giuffrida authored
ArcRobotAuthCodeFetcher will crash if there is no CloudPolicyClient, which can happen when the device hasn't been online since boot. Bug: 875504 Test: ArcRobotAuthCodeFetcherOfflineBrowserTest Change-Id: Ia5412be9a85cfe5028aa30caf74a7b4562d342e7 Reviewed-on: https://chromium-review.googlesource.com/1237255 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#593333}
-
Kenneth Russell authored
The bots have been upgraded to 10.13.6 and the graphs had to be updated as well. Bug: 885337 Tbr: zmo@chromium.org No-Try: True Change-Id: I676817f3595fee7667c521437bdb907299c08bab Reviewed-on: https://chromium-review.googlesource.com/1239413 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#593332}
-
Tarun Bansal authored
This reverts commit d4d1506d. Reason for revert: Hitting the DCHECK on Chromium startup. crbug.com/888087 Original change's description: > [X11] Don't clear WM state bits when a window is unmapped > > _NET_WM_STATE holds the window state which may be eg: maximized, fullscreen, > minimized, etc. In shutdown, Chrome queries this state so that it can restore > browser windows to the correct state on the next launch. The problem is that > Chrome queries this state (hundreds of times, in fact) after the window has > already gone away. The EWMH spec requires window managers to delete the > _NET_WM_STATE property when a window is unmapped [1], so the state that Chrome > was getting was invalid. > > This CL saves the state when a window becomes unmapped, and includes some small > cleanups. > > [1] https://standards.freedesktop.org/wm-spec/wm-spec-1.3.html#idm140130317598336 > > BUG=882258 > R=sky > > Change-Id: Iacc43563cd54ade77ac83a580ed24434b6802c91 > Reviewed-on: https://chromium-review.googlesource.com/1226645 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592570} TBR=sky@chromium.org,thomasanderson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 882258,888087 Change-Id: Iac2776b33ec366235e233878dcdbfd8530e2ea0b Reviewed-on: https://chromium-review.googlesource.com/1239355 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#593331}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cd5e40e994a7..f4a7342c6fc4 git log cd5e40e994a7..f4a7342c6fc4 --date=short --no-merges --format='%ad %ae %s' 2018-09-21 hjd@google.com trace_processor: Fix sched_tracker_unittest.cc Created with: gclient setdep -r src/third_party/perfetto@f4a7342c6fc4 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I64c2d4c5b6c154815bdb93d1d2875e03b0d7291c Reviewed-on: https://chromium-review.googlesource.com/1238847Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593330}
-