Commits · e0531f62260f851d508286f786108988f61b5ea6 · eriksson monteiro / tangled

15 Jan, 2020 40 commits

Cleanup unnecessary system_webview_apk_tmpl · e0531f62

Clark DuVall authored Jan 15, 2020

This is no longer needed now that we have system_webview_apk_or_module_tmpl

Change-Id: I3b026070499896e3061e60179d5f92bc11e52f85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001742
Auto-Submit: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732045}

e0531f62

OOBE: Don't set metrics consent in test code. · 34e66466

Miriam Zimmerman authored Jan 15, 2020

This is now handled by an autotest API, added in
https://crrev.com/c/1929983 and https://crrev.com/c/1928367.

TEST=tast run dut platform.KernelWarning
BUG=None

Change-Id: I47fa9923cc2949f928784f1b038a10d33427d5bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001019Reviewed-by: Ian Barkley-Yeung <iby@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732044}

34e66466

Unify CSP: Mojoify ContentSecurityPolicyHeader. · 35a95c7a

arthursonzogni authored Jan 15, 2020

Remove content::ContentSecurityPolicyHeader in favor of a mojo struct in
network. This is the last step before being able to replace the
content:: structs by the network::mojom ones for IPC.

See UnifyCSP:
https://docs.google.com/document/d/1v5mJnXJ5dSVXE_rgvJnNM9bzH0ni0YzdhPQ7GLqyhao

Bug: 1021462
Change-Id: Ieba10983f4e5182eee7af656ccc241aff36409b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992322Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732043}

35a95c7a

Fix font fallback unittests for Mac · a7edc3f4

Etienne Bergeron authored Jan 15, 2020

This is the same issue than this CL, but for MAC:
 https://chromium-review.googlesource.com/c/chromium/src/+/1824104

The MAC API is returning ".Noto Sans Universal" which is not
recognized by Skia (i.e. SkTypeface). To work with the API
that converts codepoint to glyphs, the same NativeFont must be kept
and pass to the SkTypeface_Mac constructor. The goal is to avoid
loosing information and keep the exact selected fallback font.

Bug: 1022455
Change-Id: If15d7a1306131fe2469406b45fb614d3d3bcdb39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994158Reviewed-by: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732042}

a7edc3f4

Update the smart card error icon on Login Screen · fe74e5f6

Maksim Ivanov authored Jan 15, 2020

Update the icon according to the latest SVG file provided by the UX
designers, and adjust the color as requested.

Also fix the icon's canvas size, so that the icon is rendered with
the expected size - 28 pixels.

Bug: 1006439
Test: create a smart card user, unplug the reader, try to login, take a screenshot, verify the error icon size is 28px
Change-Id: Idb5d94328463a9e6b3e18f526babde21630a9e1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002576Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732041}

fe74e5f6

Create temporary LegacyChromeFeatureList. · d96e1470

Henrique Nakashima authored Jan 15, 2020

It acts exactily like ChromeFeatureList, but will be what downstream
classes will reference while ChromeFeatureList is moved to the .flags
package.

This is CL 1/5 for moving ChromeFeatureList to the .flags package.

Bug: 1041468
Change-Id: Iff75ebb592c4acb883d668537f4a15d755b105bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001582Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732040}

d96e1470

Fix for dropped events on composited scrollbars. · a66b207e

Rahul Arakeri authored Jan 15, 2020

This fixes an issue where mouse event handlers for mousedown/up
were not getting fired when interacting with the scrollbar on the
compositor thread. The fix is to add a modifier to the MouseEvent(s)
and forward it to the main thread and on the main thread side, if
that modifier is found, avoid passing the event to the scrollbar.

Bug: 1038549
Change-Id: Iedebdd98eb3d339bc594d319e6db02b6b6fddde6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986308Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Rahul Arakeri <arakeri@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#732039}

a66b207e

Suppress webgl2 failure on Linux/GL/NVIDIA/passthrough · f0525b17

Jonah Ryan-Davis authored Jan 15, 2020

Failing test: conformance/uniforms/out-of-bounds-uniform-array-access.html fails on Linux/GL/NVIDIA/passthrough
First failure on Dec 14 2020

Bug: angleproject:4298
Tbr: kbr@chromium.org
Change-Id: I84635f54554bf4505a991f29d8647bb2a2dda8df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002928Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Cr-Commit-Position: refs/heads/master@{#732038}

f0525b17

Roll src/third_party/swiftshader cd55f0518d68..63468081e52e (2 commits) · c4dbea86

chromium-autoroll authored Jan 15, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/cd55f0518d68..63468081e52e

git log cd55f0518d68..63468081e52e --date=short --first-parent --format='%ad %ae %s'
2020-01-15 capn@google.com Refactor binary group operations
2020-01-15 capn@google.com Replace positive/negative_inf() with infinity()

Created with:
gclient setdep -r src/third_party/swiftshader@63468081e52e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: Ie208979f193f90bc4c61218687c4c305d128e27a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002864Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732037}

c4dbea86

Re-enabling cache reset tests. · a1a43c66

Eric Robinson authored Jan 15, 2020

These tests were flaky after crrev.com/c/1918392 and I was able
to reproduce somewhat reliably after 10-20 runs locally. The issue
was a race condition so added synchronizing similar to that found in
"net/disk_cache/backend_unittest.cc". This seems to have fixed, as
I haven't been able to reproduce the bug after 100 runs locally.

Bug: 1998181
Change-Id: I7dda37f263f991a3bdd6b7418cbe9224630aa63c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001239Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Commit-Queue: Eric Robinson <ericrobinson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732036}

a1a43c66

[BlobStorage] Implement & test writing to file with unknown blob size · 3d8117a4

Daniel Murphy authored Jan 15, 2020

This patch implements & tests using the WriteBlobToFile API where the
blob has an unknown size. This can happen if the blob was created as a
V8 File object using a file picker.

This patch also does a little bit of test readability cleanup and fixes
an error condition where the file modification time option wasn't set.

R=mek@chromium.org
TBR=palmer@chromium.org

Bug: 1024966, 1036415, 1015214
Change-Id: Idc34cca75867843e513ffedae5bc63c6aa61a982
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994095
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732035}

3d8117a4

DL: Rename activation blocking count functions & fix bug. · 6aa7f33f

Vladimir Levin authored Jan 15, 2020

The functions tracking blocking display locks were a bit misleading.
They track locks that block _all_ activation. If a lock allows _some_
activation it wouldn't be counted.

One area was using the wrong check, erroneously determining that the
activation was not blocked.

R=chrishtr@chromium.org, rakina@chromium.org

Fixed: 1041989
Change-Id: Ic17dfec33ef972a3851b91855d6dfaf17280b4a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001585Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732034}

6aa7f33f

Add WebXr Permissions to Desktop content settings UI · 5e622bc4

Alex Cooper authored Jan 15, 2020

This CL adds the AR and VR permission item to the Site Settings and
Content Settings pages.

Bug: 1033592
Change-Id: I95431423e735bdb67d1d810ab8f6e9ad5e51003d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992014
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732033}

5e622bc4

Roll src/third_party/skia bd1466cd4e88..435adfe71a0a (5 commits) · 6a472755

chromium-autoroll authored Jan 15, 2020

https://skia.googlesource.com/skia.git/+log/bd1466cd4e88..435adfe71a0a

git log bd1466cd4e88..435adfe71a0a --date=short --first-parent --format='%ad %ae %s'
2020-01-15 herb@google.com Simplify translation calculation for mustRegenerate
2020-01-15 mtklein@google.com add a note about P3 gamuts
2020-01-15 egdaniel@google.com Remove various uses of GrPixelConfig from GrSurfaceProxy.
2020-01-15 bryct@amazon.com rm CanvasKit.HEAPU8.buffer caching (fix UAF bug).
2020-01-15 kjlubick@google.com Add support for reading .skp files in CanvasKit.

Created with:
gclient setdep -r src/third_party/skia@435adfe71a0a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: mtklein@google.com
Change-Id: If532a6192e65050095bff90e8fb1ea4aca7075a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002970Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732032}

6a472755

Handle Multilogin in fake_gaia · 5c0f0d5c

Anastasiia Nikolaienko authored Jan 15, 2020

Add a response handler for /oauth/multilogin GAIA call

Bug: 977137
Change-Id: I0f33f7b8ebbe140967e0954f93193fdc2991e7c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969830Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Kush Sinha <sinhak@chromium.org>
Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732031}

5c0f0d5c

Roll src/third_party/webrtc b42aeaa3fb21..ccab06fb72be (53 commits) · 62d569e0

chromium-autoroll authored Jan 15, 2020

https://webrtc.googlesource.com/src.git/+log/b42aeaa3fb21..ccab06fb72be

git log b42aeaa3fb21..ccab06fb72be --date=short --first-parent --format='%ad %ae %s'
2020-01-15 guidou@webrtc.org Revert "Replaces SynchronousMethodCall with rtc::Thread::Invoke."
2020-01-15 danilchap@webrtc.org Change H264 depacketizer to implement VideoRtpDepacketizer interface
2020-01-15 hbos@webrtc.org Move DegradationPreference logic to the encoder queue.
2020-01-15 eshr@google.com Don't pace audio by default
2020-01-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 65afcfa0..2638d764 (731779:731908)
2020-01-15 danilchap@webrtc.org Change Av1 depacketizer to implement VideoRtpDepacketizer interface
2020-01-15 srte@webrtc.org Revert "Using simulated rtc::Thread for peer connection scenario tests."
2020-01-15 srte@webrtc.org Using simulated rtc::Thread for peer connection scenario tests.
2020-01-15 mbonadei@webrtc.org Add data dependency to event_log_visualizer.
2020-01-15 srte@webrtc.org Allow overwriting current thread in ThreadManager.
2020-01-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision c85b2ddb..65afcfa0 (731677:731779)
2020-01-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e61d470d..c85b2ddb (731529:731677)
2020-01-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 81b1889c..e61d470d (731328:731529)
2020-01-14 srte@webrtc.org Adds scenario test for transport wide feedback based retransmission.
2020-01-14 jonasolsson@webrtc.org Concatenate string literals at compile time.
2020-01-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision a989226e..81b1889c (731140:731328)
2020-01-14 saza@webrtc.org AEC3: Restrict default logging of some delay changes to VERBOSE
2020-01-14 srte@webrtc.org Use RTX SSRCs in scenario test framework.
2020-01-14 srte@webrtc.org Cleanup: Prepares for simulated time peer connection tests.
2020-01-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d6f6958d..a989226e (731013:731140)
2020-01-14 yura.yaroshevich@gmail.com Fixed timeout overflow in sctp reliability test.
2020-01-14 jerome.humbert@microsoft.com Suppress C5041 constexpr warning for MSVC 2019
2020-01-14 phoglund@webrtc.org Extract an interface from the perf results logger.
2020-01-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 69c66e43..d6f6958d (730870:731013)
2020-01-13 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 0792dc5f..69c66e43 (730752:730870)
2020-01-13 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 210e7907..0792dc5f (730612:730752)
2020-01-13 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b581de5b..210e7907 (730447:730612)
2020-01-13 natim@webrtc.org Refactoring AudioSender api out of AudioSendStream for more abstraction to reuse AudioTransportImpl for voip api
2020-01-13 hbos@webrtc.org Move DegradationPreference logic out of VideoSourceSinkController.
2020-01-13 yura.yaroshevich@gmail.com [iOS] Reset VT session when H264 decoder malfunction error happen
2020-01-13 srte@webrtc.org Cleanup: Merges Thread and MessageQueue.
2020-01-13 danilchap@webrtc.org Delete RtpGenericDepacketizer as no longer used
2020-01-13 saza@webrtc.org Change log level of AEC3 buffer info to VERBOSE
2020-01-13 danilchap@webrtc.org In TaskQueueWin fix race in canceling MutlimediaTimer
2020-01-13 saza@webrtc.org Add saza@ and peah@ to OWNERS of some audio files
2020-01-13 yvesg@webrtc.org More lenient double comparison for RunningStatistics.FullSimpleTest
2020-01-13 srte@webrtc.org Separates simulated TaskQueue and simulated ProcessThread.
2020-01-13 hbos@webrtc.org VideoStreamEncoder configuring source/sink with VideoSourceController.
2020-01-13 hbos@webrtc.org Introduce ResourceAdaptationModuleListener and VideoSourceRestrictions.
2020-01-13 jerome.humbert@microsoft.com Avoid [[nodiscard]] warning C4834 with MSVC 2019
2020-01-13 mbonadei@webrtc.org Revert "Reland "Reland "Reland "Distinguish between send and receive video codecs""""
2020-01-13 jerome.humbert@microsoft.com Add missing header for dchecked_cast on UWP
2020-01-13 jonaso@webrtc.org Flip goog_ping_announce default to false
2020-01-12 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d794106d..b581de5b (730346:730447)
2020-01-12 srte@webrtc.org Using tasks to process packets in FakeNetworkSocketServer.
2020-01-11 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision bd2395cd..d794106d (730226:730346)
2020-01-10 kron@webrtc.org Reland "Reland "Reland "Distinguish between send and receive video codecs"""
2020-01-10 shampson@webrtc.org Adding deadbeef to sctp/OWNERS and removing myself.
2020-01-10 srte@webrtc.org Replaces SynchronousMethodCall with rtc::Thread::Invoke.
2020-01-10 srte@webrtc.org Cleanup: Replace MessageQueue pointers with Thread pointers.
2020-01-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 54a7cb4b..bd2395cd (730109:730226)
2020-01-10 yvesg@webrtc.org Unflake P2PTransportChannelTest.TurnToTurnPresumedWritable.
2020-01-10 mbonadei@webrtc.org Revert "In RtpBitrateConfigurator ignore new parameters when set to default values."

Created with:
gclient setdep -r src/third_party/webrtc@ccab06fb72be

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1029452,chromium:1029737
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: I0600cf2738cbd905c48476dbcca05dac5b5bbffc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002969Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732030}

62d569e0

Enable SafeBrowsing policies on Chrome OS. · 961f1a5a

Sergey Poromov authored Jan 15, 2020

Some policies were already marked as supported on Chrome OS from 81 in
https://crrev.com/c/1846475, but the policy handler list and policy
test cases were not updated.
Also, URLsToCheckForMalwareOfUploadedContent policy was missing in
policy_templates.json.

Policies being enabled for Chrome OS in this CL:
(*) DelayDeliveryUntilVerdict
(*) BlockLargeFileTransfer
(*) AllowPasswordProtectedFiles
(*) CheckContentCompliance
(*) URLsToCheckComplianceOfDownloadedContent
(*) URLsToCheckForMalwareOfUploadedContent
(*) URLsToNotCheckComplianceOfUploadedContent

Bug: 1012048
Change-Id: Ifb96a59778026074c88f53df645ec387e951130e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000794Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Sergey Poromov <poromov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732029}

961f1a5a

Add methods to read and write floats to SharedPreferencesManager. · c6fffb8c

Henrique Nakashima authored Jan 15, 2020

Bug: 1022108
Change-Id: I61dd80749a19c584671f83578d0a0910f9882b0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001720
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Natalie Chouinard <chouinard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732028}

c6fffb8c

Clean up SyncModelTypeByMacro histogram suffix · c05976fc

Mikel Astiz authored Jan 15, 2020

Follow up to
https://chromium-review.googlesource.com/c/chromium/src/+/1937370 where
the two affected histograms were marked as obsolete.

In this patch, the histogram suffix itself is marked as obsolete and
any references to SyncModelTypeByMacro removed from code comments.

Change-Id: Ia2a55892fe6dc53534d21f5499f9643e692a49db
Bug: 995514,1019744
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000704Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Alex Ilin <alexilin@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732027}

c05976fc

Move pref from ChromeActivitySessionTracker to ChromePreferenceKeys · de0cb07a

Henrique Nakashima authored Jan 15, 2020

Register it in ChromePreferenceKeys and use SharedPreferencesManager
consistently instead of SharedPreferences directly.

Bug: 1022108
Change-Id: I94885edd31cd9b95446c1b96f617d356bcf9ae52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993750Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732026}

de0cb07a

Remove original_message_type from Sharing AckMessage · 5f8a402e

Richard Knoll authored Jan 15, 2020

This field was only used to collect metrics, however, we can actually
just store that information on the sender side and avoid sending it back
via FCM.
We never used the suffixed version of Sharing.MessageReceivedType so
this also removes that while keeping the aggregate one.

Bug: None
Change-Id: Ie598d33e60381341170bbca2716cb70be09be0e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000764Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732025}

5f8a402e

[iOS] Add option to clear browsing data in SignOut · c12ee167

Nohemi Fernandez authored Jan 15, 2020

Adds an option to the SignOut method in the Authentication Service API to sign out and
clear browsing data unconditionally for all accounts.

Bug: 1005509
Change-Id: I20d803b6e92d52eef73284bce84c4d8f7e1780ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1995399Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732024}

c12ee167

Reformat all gn files in /ios/chrome/browser/ui/tab_grid. · 566eca74

Nico Weber authored Jan 15, 2020

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=edchin@chromium.org

Bug: 1041419
Change-Id: Ia9a5cb6244b89db613231c78fa7e8158f2fe52dc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998650
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732023}

566eca74

[hangs] Add time since last memory pressure crash key in hang reports. · 3df44aff

François Doray authored Jan 15, 2020

This CL adds a crash key with the number of seconds since the last
critical memory pressure signal in hang reports. The goal is to
facilitate filtering of reports that are likely caused by memory
pressure.

Many things can cause hangs, memory pressure is just one of them.
More crash keys could be added in separate CLs to get a full
understanding of hangs.

Change-Id: I0ef482d0b6df7d0661b3d0141c4ee44766942a32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987204Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732022}

3df44aff

Always warn when a users downloads a .hta file on Windows · e0eb9333

Ross Gibb authored Jan 15, 2020

Description here:
https://docs.google.com/document/d/12y2QHPQV6Gnvm1mG-ScvbNzPwx8uUuSw-5wZpxeEa1g/edit#


BUGS: 1042091

Change-Id: I0f1d20137bc0671533aa13edc4a39dda1adcb4c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001253
Auto-Submit: Ross Gibb <rossgibb@google.com>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732021}

e0eb9333

Revert "[smart-charging] Collect last charge features" · 47fec230

Saman Sami authored Jan 15, 2020

This reverts commit e6beeda6.

Reason for revert: DCHECK failure during startup

Original change's description:
> [smart-charging] Collect last charge features
> 
> Adds code to collect last charge related features.
> 
> Bug: 1028853
> Change-Id: I2b152139db0777acbd40534128ed8c92004799b5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994035
> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org>
> Reviewed-by: Jia Meng <jiameng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#731862}

TBR=jiameng@chromium.org,thanhdng@chromium.org

Change-Id: I319bc2f2310ca617b400c786bdd98e85de6dd716
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1028853,1042262
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002726Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732020}

47fec230

Update and clarify view ownership for app-list views. · fe842ad4

Allen Bauer authored Jan 15, 2020

Bug: 648382
Change-Id: I0d000accee686dd67b2db1e14cea20ff893835c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001399
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732019}

fe842ad4

Roll src/third_party/devtools-frontend/src 5933290adf49..e6a9868686ae (5 commits) · d4bc490c

chromium-autoroll authored Jan 15, 2020

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5933290adf49..e6a9868686ae

git log 5933290adf49..e6a9868686ae --date=short --first-parent --format='%ad %ae %s'
2020-01-15 tvanderlippe@chromium.org Migrate javascript_metadata/ to ESM internally
2020-01-15 aerotwist@chromium.org Migrates resources/ to ESM internally
2020-01-15 aerotwist@chromium.org Migrates quick_open/ to ESM internally
2020-01-15 tvanderlippe@chromium.org Migrate screencast/ to ESM internally
2020-01-15 tvanderlippe@chromium.org Migrate settings/ to ESM internally

Created with:
gclient setdep -r src/third_party/devtools-frontend/src@e6a9868686ae

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1006759
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I06f6c518c78a95536b955476c6c5bfa6b411e1f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002860Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732018}

d4bc490c

Roll src/third_party/shaderc/src 99ca03e1ac3a..df0e683b5835 (1 commits) · e2f9d367

chromium-autoroll authored Jan 15, 2020

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/99ca03e1ac3a..df0e683b5835

git log 99ca03e1ac3a..df0e683b5835 --date=short --first-parent --format='%ad %ae %s'
2020-01-15 rharrison@google.com Fix incorrect casing on flags in docs (#957)

Created with:
gclient setdep -r src/third_party/shaderc/src@df0e683b5835

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/shaderc-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: radial-bots+chrome-roll@google.com
Change-Id: I1c876d2cd5d5d8d8c912715a7b2b158d535b0051
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002857Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732017}

e2f9d367

Suppress flaky webgl2 test on Mac/Intel/Validating · d384201c

Jonah Ryan-Davis authored Jan 15, 2020

Test is conformance2/textures/canvas_sub_rectangle/tex-3d-r11f_g11f_b10f-rgb-half_float.html
Flakes began Dec 19 2019

TBR=kbr@chromium.org

Bug: 1042011
Change-Id: I3270f077dfbc8c7abc3cea0f3023175f1bd1aedf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002888
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Behdad Bakhshinategh <behdadb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732016}

d384201c

[Passwords] Fix extra prompt to save credentials on reload · a4fd001d

Jaeyong Bae authored Jan 15, 2020

PasswordFormManager is not fully updated on credentials save
and PasswordFormManager::pending_credentials_ has the state before manual save.
So, we have to update PasswordFormManager when fetch completed.

Bug: 904427
Change-Id: I3c2f0af7db909d25ded412a5780a93006d1d24da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984787
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732015}

a4fd001d

Fail with appropriate error message when user creation fails due to password complexity reasons · a10f7630

Rakesh Soma authored Jan 15, 2020

Bug: 1042157
Change-Id: I7b410e6b4fd3bc9044814c959d514b2d6983e506
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001363
Auto-Submit: Rakesh Soma <rakeshsoma@google.com>
Reviewed-by: Tien Mai <tienmai@chromium.org>
Commit-Queue: Rakesh Soma <rakeshsoma@google.com>
Cr-Commit-Position: refs/heads/master@{#732014}

a10f7630

Reformat all gn files in /build/config. · 33c370bc

Nico Weber authored Jan 15, 2020

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=dpranke@chromium.org

Bug: 1041419
Change-Id: I490a7c39e7121c8f7129edfedc10680061732645
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998138
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732013}

33c370bc

blink: Allow use of base::void_t in //third_party/blink/ · d6ccab6f

Yuki Shiino authored Jan 15, 2020

base::void_t is the same feature as std::void_t, which is supported
in C++17.  Chromium currently follows C++14 and base::void_t is an
exceptional support of a C++17 feature.

void_t is a simple mapping from arbitrary type(s) to type void and
nothing is harmful.
https://en.cppreference.com/w/cpp/types/void_t

This patch adds base::void_t to the allowed list of Blink.

FYI, Blink somehow already uses base::void_t at two places:
//third_party/blink/renderer/platform/heap/finalizer_traits.h
//third_party/blink/renderer/platform/wtf/type_traits.h

Change-Id: I1e1f0447027df58c85b6a8f20db10df4aac2796b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002552Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732012}

d6ccab6f

[iOS][coordinator] Modernize Snackbar Coordinator. · d0c369ad

Nazerke authored Jan 15, 2020

This CL modernizes the SnackbarCoordinator
 - to use the superclass -initWithBaseViewController:browser:
initializer,
 - to remove the public property for dispatcher,
 - to update the naming and usage of ‘dispatcher’ parameters to
match the usage guidelines.
 - the unit test has not been converted and has been removed.

Bug: 1029346
Change-Id: I4607703e5fe5f504d53642e4c0834589fa3cb924
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999199
Commit-Queue: Nazerke Kalidolda <nazerke@google.com>
Auto-Submit: Nazerke Kalidolda <nazerke@google.com>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732011}

d0c369ad

Reland "[base] Migrate the Mac/iOS MessagePump to DoSomeWork" · 9eb4f5aa

Etienne Pierre-doray authored Jan 15, 2020

This is a reland of de5ec163

Reason for revert: rendering.desktop/frame_times regressions
Fix: SetWorkBatchSize(2) in gpu_main to keep previous behavior.

Original change's description:
> [base] Migrate the Mac/iOS MessagePump to DoSomeWork
>
> Recycling https://chromium-review.googlesource.com/c/chromium/src/+/1470938/13
> This CL also fixes DetachToBrowserTabDragControllerTest.PressEscapeWhileDetached
> to make CQ happy.
>
> Bug: 885371
> Change-Id: I0b54ade1fd3481a9248c89ec2993738b20fce002
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906337
> Reviewed-by: Allen Bauer <kylixrd@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#722094}

Bug: 885371, 1032188
Change-Id: Id1d6916a83e1c72cacc554c100d60fd0c78c6b7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992161
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732010}

9eb4f5aa

Reformat all gn files in /ios/showcase. · 68d23406

Nico Weber authored Jan 15, 2020

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=edchin@chromium.org

Bug: 1041419
Change-Id: Ib28835e0fe99bfe6c4d6226ba60c4ab26f5707a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998748
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732009}

68d23406

[Sheriff] Mark iframe-popup-same-origin-allow-popups.https.html flaky · 4f53a186

Marina Ciocea authored Jan 15, 2020

Bug: 1042199
Change-Id: I9880a7358f6ff6356ee238bc7fcde1269f17f5c0
TBR: pmeuleman@chromium.org
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002810Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732008}

4f53a186

[Controls Refresh] Bugfix - Issue 1021225: Upon autofill pre-filling, the... · 6bf32580

Sam Sebree authored Jan 15, 2020

[Controls Refresh] Bugfix - Issue 1021225: Upon autofill pre-filling, the border styles unexpectedly change

This bug fix addresses the issue of darker than normal borders on text inputs when autofill is being used.

Bug: 1021225
Change-Id: I0f62bd5d3cb4bbd07c88e9cab090da09481416e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918439Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Alex Keng <shihken@microsoft.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Sam Sebree <sasebree@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#732007}

6bf32580

Revert "Add EXT_texture_norm16 extension for WebGL" · a9cc3e16

Jamie Madill authored Jan 15, 2020

This reverts commit d432e7b7.

Reason for revert: Suspected for breaking ANGLE CQ.
See bug for details.

Bug: 1042252

Original change's description:
> Add EXT_texture_norm16 extension for WebGL
> 
> Expose to WebGL 2 only as first stage.
> 
> Implementation includes hooking up ANGLE implementation and that in cmd decoder.
> 
> Bug: 1000354
> Change-Id: I0f856d5ce693cb8da8275eda5179a582068880ed
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907195
> Auto-Submit: Shrek Shao <shrekshao@google.com>
> Reviewed-by: Zhenyao Mo <zmo@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Shrek Shao <shrekshao@google.com>
> Cr-Commit-Position: refs/heads/master@{#731823}

TBR=dcheng@chromium.org,zmo@chromium.org,jdarpinian@gmail.com,shrekshao@google.com

Change-Id: Ic7411e4fecb5b86e55129d448eb2f9a5035c5025
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1000354
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003028Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732006}

a9cc3e16