- 21 Sep, 2018 40 commits
-
-
Valeriya Sinevich authored
Also retry fetching access token if it failed but count retries for all tokens together. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I1c8d131faa7fba5a6d4c43714b998bc140642864 Reviewed-on: https://chromium-review.googlesource.com/1199424 Commit-Queue: Valeriya Sinevich <valeriyas@google.com> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#593170}
-
Mario Sanchez Prada authored
This isn't strictly needed since iOS will always use net-in-process, but is good for consistency with the rest of the code that ios shares with chrome that has switched to SimpleURLLoader. Bug: 879770 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I49665d4b6054c1a882a42d4661f03162bfceebc7 Reviewed-on: https://chromium-review.googlesource.com/1235722 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#593169}
-
Rune Lillesveen authored
We used a separate SetChildNeedsReattachLayoutTree() before calling MarkForWhitespaceReattachment() for the ancestors which meant we passed a dirty_node/common_ancestor a level higher up the chain which caused the layout_tree_rebuild_root_ to update incorrectly. Instead use an arbitrary child to invoke MarkForWhitespaceReattachment() on. Note that none of the children are actually dirty after a node removal. We only need to make sure we traverse down to the siblings of a removed node to check if its whitespace siblings need reattachment. Since the arbitrary child may be a text node, we have to handle that in RootElement(). Bug: 884456, 884449 Change-Id: I06c50f6f996e41b813f7e847351fc87d42336857 Reviewed-on: https://chromium-review.googlesource.com/1235997 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#593168}
-
Adrienne Porter Felt authored
This reverts commit 2b3cf454. Reason for revert: <INSERT REASONING HERE> Original change's description: > Remove the SPKI fingerprint for auth.impulse.com from captive portals list > > Bug: 870038 > Change-Id: I856efd083382cb27f01ea37abbfcbb04941ec0c4 > Reviewed-on: https://chromium-review.googlesource.com/1176582 > Commit-Queue: Adrienne Porter Felt <felt@chromium.org> > Reviewed-by: Adrienne Porter Felt <felt@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593084} TBR=felt@chromium.org,meacer@chromium.org Change-Id: I0c158c192ebd88c3cd586da3fca7cd6963f594f4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 870038 Reviewed-on: https://chromium-review.googlesource.com/1238375Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Commit-Queue: Adrienne Porter Felt <felt@chromium.org> Cr-Commit-Position: refs/heads/master@{#593167}
-
Kyoko Muto authored
In this CL, We add the functions that support to call slotchange event when nodes are assigned from assign function. Previous implementation CL: crrev.com/c/1201513 Bug: 869308 Change-Id: I44cfc94c26141630aa82ea725566a8c7273eacf5 Reviewed-on: https://chromium-review.googlesource.com/1226477 Commit-Queue: Kyoko Muto <kymuto@google.com> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#593166}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/9bfe0eb25e3d..575af7ecfc21 git log 9bfe0eb25e3d..575af7ecfc21 --date=short --no-merges --format='%ad %ae %s' 2018-09-21 antiagainst@google.com [kokoro] Add test job for disabling effcee (#1911) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@575af7ecfc21 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iee584865c392206d1036571c480491894e8114c5 Reviewed-on: https://chromium-review.googlesource.com/1238321Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593165}
-
Rayan Kanso authored
Update the BackgroundFetchDownloadClient to handle the new DownloadService contract. The Background Fetch scheduler will attempt to start all active downloads on start-up. The ones that are actually resuming will be ignored by the client. Since the response metadata and the actual response are propagated in different calls, the response metadata will be propagated twice to account for restarts. This will be fixed in a follow-up CL where all of the information associated with the response will be sent once to the Background Fetch scheduler. Bug: 881314 Change-Id: I4d806c0eec2cb9c35a42da568613fb2d5ede856e Reviewed-on: https://chromium-review.googlesource.com/1227995Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#593164}
-
Christian Biesinger authored
(ListGrid::Cell takes 12.09% of total time when running the large-spanning-grid-item.html perf test with LayoutNG enabled; with this patch, that's down to 4.92%) R=rego@igalia.com Change-Id: Ibd0da807622824892227326844e5f4c19faa9bb0 Reviewed-on: https://chromium-review.googlesource.com/1237380Reviewed-by:
Sergio Villar <svillar@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#593163}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/05cf051f0252..217056c04885 git log 05cf051f0252..217056c04885 --date=short --no-merges --format='%ad %ae %s' 2018-09-21 kjlubick@google.com [CanvasKit] Implement some basic Canvas/Surface things. 2018-09-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 a977acc85769..ab5fb5edb186 (4 commits) Created with: gclient setdep -r src/third_party/skia@217056c04885 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I783462f5177e8eaf173e7ce03b8dbbb9fa694637 Reviewed-on: https://chromium-review.googlesource.com/1238319Reviewed-by:
-
Jan Krcal authored
This CL fixes an omission in integration tests for autofill wallet that different credit cards / addresses served by the server still had same ids in the specifics. This in particular fixes a test failure for CL 1236693. Bug: 853688 Change-Id: Iecb050ceb56f709004b16f6712196b71d0be56b0 Reviewed-on: https://chromium-review.googlesource.com/1238536 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#593161}
-
Olivier Robin authored
This CL does not add support to autofill in iFrames. Unittests may fail with the Autofill in iFrame flag enabled. This will be solve in a future CL. Bug: 881364 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I38cd09b7aec31d8e47eea8e756ef937bcdde7b1b Reviewed-on: https://chromium-review.googlesource.com/1230062 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#593160}
-
David Tseng authored
Change-Id: I76f06b801e6fdd71a89af55f7acca68c9d1bb4bd Reviewed-on: https://chromium-review.googlesource.com/1236508 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#593159}
-
Sylvain Defresne authored
As a followup to https://crrev.com/c/1233702, KeyedService takes the factory as a base::Callback instead of a function pointer. Convert BrowserStateKeyedServiceFactory to base::Callback, thus allowing binding some state to the factory. Bug: 809610 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ie563d9b76190b384660cd314fb0e6d8eede324e4 Reviewed-on: https://chromium-review.googlesource.com/1235718 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#593158}
-
Gauthier Ambard authored
This CL removes the button visibility of the legacy toolbar which has been removed in a previous CL. Bug: 800266 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I7d847599d4720fa6d5a920baa9b5ad468e6e4d32 Reviewed-on: https://chromium-review.googlesource.com/1236654Reviewed-by:
-
Boris Sazonov authored
This CL fixes a crash in ClearBrowsingDataPreferences that was introduced in https://crrev.com/c/1215202 by erroneously replacing getDialogOptions with getSelectedOptions. This CL also changes the return type of getDialogOptions to list to keep using removeAll. Bug: 887830 Change-Id: I22491ebd4a6b027dfaa61403e618df81f26a48a2 Reviewed-on: https://chromium-review.googlesource.com/1238218 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#593156}
-
Kush Sinha authored
|ChromeOSOAuth2TokenServiceDelegate| should not overload GAIA if we are receiving non-persistent errors from the server. Add a backoff policy. The backoff policy numbers have been taken from |MutableProfileOAuth2TokenServiceDelegate|. Bug: 820046 Test: unit_tests --gtest_filter="*CrOSOAuthDelegateTest*" Change-Id: Ic141638a476fca0f8f203411e352e0c2458568ad Reviewed-on: https://chromium-review.googlesource.com/1236553 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This CL changes the color of the steady view when it is highlighted to a darker color. Bug: 884171 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I39c9197b8f2172881d60b0f5cdb624d3d37722e3 Reviewed-on: https://chromium-review.googlesource.com/1228058Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#593154}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Id9f12eb713e8ba1477bb8286f2bea3351bfd3e21 Reviewed-on: https://chromium-review.googlesource.com/1238318Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593153}
-
Nico Weber authored
This reverts commit 71f80c9e. Reason for revert: Relanding with failing test (which tests more unused code) removed. Original change's description: > Revert "mac: Remove unused cocoa bookmarks code." > > This reverts commit fce6f1f0. > > Reason for revert: > Mac bots start failing after this on ZoomDecorationTest. > Logs are: > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/15388 > https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8934822664204431200/+/steps/browser_tests_on__none__GPU_on_Mac_on_Mac-10.12.6/0/logs/ZoomDecorationTest.BubbleAtDefaultZoom__x2f_1/0 > > Original change's description: > > mac: Remove unused cocoa bookmarks code. > > > > Bug: 832676 > > Change-Id: I7a307c33ad6daf44cc2c170829f03cfdc488da4b > > Reviewed-on: https://chromium-review.googlesource.com/1236177 > > Reviewed-by: Robert Sesek <rsesek@chromium.org> > > Commit-Queue: Nico Weber <thakis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#592940} > > TBR=ellyjones@chromium.org,thakis@chromium.org,rsesek@chromium.org > > Change-Id: I5cee6336950065ba9ba0053334892092d2ebe308 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 832676 > Reviewed-on: https://chromium-review.googlesource.com/1238033 > Reviewed-by: Taiju Tsuiki <tzik@chromium.org> > Commit-Queue: Taiju Tsuiki <tzik@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593079} TBR=ellyjones@chromium.org,thakis@chromium.org,rsesek@chromium.org,tzik@chromium.org Change-Id: Iefa37fb9c3c4aec4d885ace2fd2053f803e27d33 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 832676 Reviewed-on: https://chromium-review.googlesource.com/1238593 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#593152}
-
Fergal Daly authored
Bug: 882574 Change-Id: I7a5e3bba87410f4e5c41804d102e88e8426116d8 Reviewed-on: https://chromium-review.googlesource.com/1238194 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
-
Makoto Shimazu authored
This CL is to stop service workers when the network service crashes. This might drop inflight events, but given that the frequency is quite low, it's acceptable. When another event is dispatched to the service worker, it starts the worker again and it should work. Bug: 884007 Change-Id: I2da4bd05c6a89f70b623da8e29a89488fd5a9cf3 Reviewed-on: https://chromium-review.googlesource.com/1235593 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#593150}
-
Rayan Kanso authored
Pass a CompletionInfo to the OnDownloadFailed client observer, and populate the CompletionInfo with the URL chain and response in both cases. Bug: 881314 Change-Id: I4a3609aabd5c7a34429414c43fb0744ba678c070 Reviewed-on: https://chromium-review.googlesource.com/1228914Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#593149}
-
Boris Sazonov authored
This CL fixes an issue with Unified Consent rollback when 'Sync everything' wouldn't be enabled because unified_consent::RollbackHelper decides that some user selectable types are disabled. This was happening because syncer::UserSelectableTypes() returns some data types that aren't actually selectable on Android. To resolve the issue, this CL adds an Android-specific list of user selectable data types behind an ugly ifdef. This approach is used because of two reasons: 1. This CL should be merged back to M-70, so it's dangerous to change syncer::UserSelectableTypes implementation. 2. RollbackHelper will be removed after Unified Consent is rolled out. Bug: 885382 Change-Id: I70f09d09f8fb876681dde79b21e1a7338ba9e214 Reviewed-on: https://chromium-review.googlesource.com/1236694Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#593148}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/08b9e376..0664f0cf Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iefb9191f2ff461f786778bbbec30dbe39ad07f6e Reviewed-on: https://chromium-review.googlesource.com/1237822Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593147}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/97f63244f536..f5eacf83622c git log 97f63244f536..f5eacf83622c --date=short --no-merges --format='%ad %ae %s' 2018-09-21 primiano@google.com Merge "perfetto-ui: Parametrize track with data type" Created with: gclient setdep -r src/third_party/perfetto@f5eacf83622c The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Id391cd5655877b3cf3fbcd70abc870760914672d Reviewed-on: https://chromium-review.googlesource.com/1238316Reviewed-by:
-
Anders Hartvoll Ruud authored
When a var()-reference produces tokens that are incompatible with the current syntax, or the var()-reference refers to a variable that does not exist, we currently always substitute the initial value, even for inherited properties. This is incorrect, as the value should behave as 'unset', which means 'inherit' for inherited properties. Note that if syntax-incompatible tokens are specified directly (not via a var()-reference), we correctly behave as 'unset'. This is because the var()-less case is handled by a different code path (variable.cc). R=futhark@chromium.org Bug: 641877 Change-Id: Ifdd5435ee77f4b8cd3998967713cb6fcb7e8d5f4 Reviewed-on: https://chromium-review.googlesource.com/1235579 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#593145}
-
Marc Treib authored
This is mostly a revert of https://crrev.com/c/1189923. These DCHECKs were previously disabled because they triggered in some cases. That should be fixed as of https://crrev.com/c/1226634. Bug: 872360 Change-Id: I67424e6011693aa191014d8244f9ed2e63e2b68c Reviewed-on: https://chromium-review.googlesource.com/1226872Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#593144}
-
Daniel Bratell authored
content_shell wants to replicate a chome constant at several places which caused collisions in jumbo build experiments. This give the replicas unique names and fixes the documentation which was a bit outdated. Bug: 886902 Change-Id: Ibf65de50bb2f938392fcecc910d70a4c4182c87d Reviewed-on: https://chromium-review.googlesource.com/1233715 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
-
Colin Blundell authored
This CL streamlines IdentityManager's interaction with AccountTrackerService when firing updates for accounts with refresh tokens. Rather than caching state locally in response to PO2TS::DiagnosticsClient callbacks, IdentityManager simply obtains the AccountInfo from AccountTracker in the PO2TS observer callback itself. This CL eliminates the need for any cached state in IdentityManager related to accounts with refresh tokens. The motivation is to enable conversion of the codebase to IdentityManager as smoothly and painlessly as possible, as explained in detail in crbug.com/883722. Bug: 883722 Change-Id: Ic13d5be5a5f17411c167d19da7f8444e6ec257bc Reviewed-on: https://chromium-review.googlesource.com/1228197 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#593142}
-
Anders Hartvoll Ruud authored
We currently have lots of different functions on ComputedStyle for setting registered properties in different states (resolved/unresolved, inherited/ non-inherited). This is not terribly useful, and mostly just makes the calling code much more complicated. Also, the current implementation of Variable::ApplyValue is hard to understand. This CL refactors that using the new setters on ComputedStyle. R=futhark@chromium.org Bug: 641877 Change-Id: I5fc6bed24ec5aadd469a81353dc3b4e221e0f9d1 Reviewed-on: https://chromium-review.googlesource.com/1236004 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:
-
Laís Minchillo authored
Fix trying to access the proxy_config_service that was moved to the url_request_context in InitializeURLRequestContext Bug: 851995 Change-Id: Icc31c661ff4bd0e6b92d899a9d427ed75db0a295 Reviewed-on: https://chromium-review.googlesource.com/1234154Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Laís Minchillo <laisminchillo@chromium.org> Cr-Commit-Position: refs/heads/master@{#593140}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/036176db7c24..381f401bc444 Created with: gclient setdep -r src-internal@381f401bc444 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I5934306ca108be62c13c560930c751c9e0a1e5cf Reviewed-on: https://chromium-review.googlesource.com/1238313Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593139}
-
Mihai Sardarescu authored
IDC_SHOW_SYNC_SETUP and IDC_SHOW_SIGNIN have the same integer value. This CL removes IDC_SHOW_SYNC_SETUP to avoid confusion. It also cleans up the code in browser_command_controller that was setting both IDC_SHOW_SYNC_SETUP and IDC_SHOW_SIGNIN without knowing that they are in fact the same thing. Bug: 870239 Change-Id: I3b1ac005d3230fc581e6163a53ad20a84d124402 Reviewed-on: https://chromium-review.googlesource.com/1236263 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#593138}
-
Andreas Haas authored
R=haraken@chromium.org Bug: v8:7295 v8:8015 Change-Id: Ie4d7a011d3c20c2997fc9ee309dcc2aa83174d1a Reviewed-on: https://chromium-review.googlesource.com/1238158Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#593137}
-
Anders Hartvoll Ruud authored
This does not currently cause a crash, entirely because of luck. A value of nullptr is passed to SetVariable whenever an invalid var()-reference is used (for example), but it just so happens that needs_resolution_ is always true in this case, so it short circuits before attempting to de- reference 'value'. R=futhark@chromium.org Bug: 641877 Change-Id: I8b3776a58efb82b5deef74b50561d2ebfd57b817 Reviewed-on: https://chromium-review.googlesource.com/1235725 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:
-
Anders Hartvoll Ruud authored
Currently, StyleInheritedVariables::RemoveVariable removes variable data properly (i.e. it sets the value to nullptr locally), but only nullifies the registered value if we already have an entry for that variable locally. This means that if we inherit a variable via the root bucket, calling ::RemoveVariable will not actually remove the variable. Fix by setting registered value to nullptr if a non-nullptr value would have been returned from the root. R=futhark@chromium.org Bug: 641877 Change-Id: I78f0442bd0a8eba26e74a8a152b5bee048fbc23c Reviewed-on: https://chromium-review.googlesource.com/1235724 Commit-Queue: Anders Ruud <andruud@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e25b8006115b..ab5fb5edb186 git log e25b8006115b..ab5fb5edb186 --date=short --no-merges --format='%ad %ae %s' 2018-09-21 oetuaho@nvidia.com Reland "Support EXT_blend_func_extended in the GLES2 context" 2018-09-21 jmadill@chromium.org Remove secondary Texture rendering loop check. 2018-09-21 oetuaho@nvidia.com Fix using a large vertex attrib divisor on D3D11 Created with: gclient setdep -r src/third_party/angle@ab5fb5edb186 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:763695 TBR=jmadill@chromium.org Change-Id: I8f4813a39e32e17129ba3231ee14f49a9e0870a8 Reviewed-on: https://chromium-review.googlesource.com/1238314Reviewed-by:
-
Kouhei Ueno authored
This CL introduces OriginsList, which can be used to keep track of a {allow,deny} list of domains. The OriginsList will be used in the subsequent CLs to keep track of the origins who opt-in to "Accept: application/signed-exchange" header. Bug: 887201 Change-Id: Ie926587a016dab76a585088be76a70e0b62e51dc Reviewed-on: https://chromium-review.googlesource.com/1235362Reviewed-by:Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#593133}
-
Yoshifumi Inoue authored
Revert "If the caret is at the boundary of a misspelling, getting suggestions via context menu should work" This reverts commit 8698aaf7. Reason for revert: Causes lots of crashes on canary http://crbug.com/886589 Original change's description: > If the caret is at the boundary of a misspelling, getting suggestions via context menu should work > > If a screen reader user tries to get spelling suggestions for a misspelled word, they usually first move to the beginning of the word using Ctrl+Left/Right and then invoke the context menu. > On Windows, Ctrl+Left/Right always moves to the start of the word. On other platforms, Ctrl or Cmd + Left moves to the start whilst Ctrl / Cmd + Right moves to the end of the word. > When any of the above keystrokes are pressed, the user hears the whole word. > It is not reasonable to expect the user to first press Ctrl+Left/Right to navigate through the line until they find the spelling mistake and then have to additionally press cursor right, (or cursor left when using Cmd-Right on Mac), so that the caret is within the word before invoking the context menu. > The result is that many screen reader users might have the mistaken believe that our spell checker is broken. > > R=dmazzoni@chromium.org, yosin@chromium.org > > Bug: 790828 > Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng > Change-Id: Icdfc24eb85afe3217320d648183083133418fd58 > Reviewed-on: https://chromium-review.googlesource.com/1033430 > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > Commit-Queue: Nektarios Paisios <nektar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592270} TBR=dmazzoni@chromium.org,yosin@chromium.org,yoichio@chromium.org,nektar@chromium.org,xiaochengh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 790828 Change-Id: Icbe0c3e14eb08cfbd167ba86f1dc0dd3a2ce0819 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/1237836Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#593132}
-
Boris Sazonov authored
This CL revises SigninPromoUtil.launchSigninPromoIfNeeded to defer the moment when account list is acquired. This makes sense because launchSigninPromoIfNeeded is invoked early during startup, when the cache in AccountManagerFacade isn't populated yet, so getting the list of accounts may block until it is populated. Bug: 837374 Change-Id: Ie018c8e06f0be0df4ec742475035eb3175dc27a2 Reviewed-on: https://chromium-review.googlesource.com/1234233Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#593131}
-
