- 10 Sep, 2018 40 commits
-
-
Mason Freed authored
Previous to this CL, the RenderWidgetHostViewAura::CopyFromSurface function would capture only the main window contents. It would ignore any secondary child popup screens that were generated as a result of many popup operations, for example calendar pickers, selection popups, suggestion pickers, etc. With this CL, those popup screens are detected, captured, and overlaid on top of the main window capture. Note that in the process of implementing this, I fixed a bug in RenderWidgetHostViewAura::GetBoundsInRootWindow(), for the Windows case. Previous to this CL, for Windows, when legacy HWNDs are not in use (UsesNativeWindowFrame() returns false), the function would return locations in units of DIPs divided by scale factor. It should be returning DIPs. I moved the conversion up into the if{} block. It seems that no current test catches this issue, but once --enable-display-compositor-pixel-dumps becomes a default flag, the existing layout tests, under virtual/scalefactorXyz, should serve to monitor this code for regressions. Bug: 875962, 667551 Change-Id: Iefc9bfd7798b3dfabb3a28eb46009fa703c0fca0 Reviewed-on: https://chromium-review.googlesource.com/1192330 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#589975}
-
Leonard Ge authored
In this CL, I've extended the functionality of the `generate_perf_sharding` script to generate the shard_map only for the given benchmark. The user needs to provide the `benchmark_name` and `builder_name`, and the script will generate the shard map. Users can also set the number of shards to use as well as the output file path. I've also fixed some minor style issues. Bug: catapult:# Change-Id: I956ebea0a8d044b1725de4a94eb17f60260a1424 Reviewed-on: https://chromium-review.googlesource.com/1216064Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Leonard Ge <wangge@google.com> Cr-Commit-Position: refs/heads/master@{#589974}
-
Lei Zhang authored
Change-Id: If3b12f9ef36d20c43283fba936bdf4f9be7c1889 Reviewed-on: https://chromium-review.googlesource.com/1214742Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#589973}
-
Tatiana Buldina authored
Bug:chromedriver:2574 Change-Id: I4818d3765f02998a3d317476e0b80d37483c5b52 Reviewed-on: https://chromium-review.googlesource.com/1214683Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tatiana Buldina <buldina@chromium.org> Cr-Commit-Position: refs/heads/master@{#589972}
-
Xianzhu Wang authored
Previously we adjusted local border box properties out of LayoutBlock::PaintObject(), while adjusted cull rect and paint offset inside of LayoutBlock::PaintObject(), making inconsistent relationship among paint chunk properties, cull rect and paint offset between the two adjustments. We should adjust them altogether to ensure consistence. Now rename PaintInfoWithOffset to ScopedPaintState (which will include more paint property adjustment in the future), and combine ScopedBoxClipper and the original code that adjusts cull rect and paint offset for ScrollTranslation into ScopedBoxContentsPaintState. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I70f1ad00f2508d80eaa387259a1a62f301016ee5 Reviewed-on: https://chromium-review.googlesource.com/1213824Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#589971}
-
Ryan Harrison authored
I introduced a second definition of ZWW in the PDF plugin code without realizing it in a previoud CL. This CL merges the two definitions together. BUG=chromium:743522 Change-Id: Id5389bffc9aca70458c4aa934eb3163bf6ad503a Reviewed-on: https://chromium-review.googlesource.com/1213543Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Ryan Harrison <rharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#589970}
-
liberato@chromium.org authored
When we detect that an underlay is unoccluded, we would previously consider removing its damage rect if it hadn't moved. However, this can cause problems if the underlay was occluded on the previous frame, since we still need to erase whatever disappeared above it from the framebuffer. This CL requires that an underlay is unoccluded for one frame before removing its damage rect. Bug: 875879 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I00394c6d6f61c4381a97a6c753c8840485163845 Reviewed-on: https://chromium-review.googlesource.com/1211202Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#589969}
-
Quan Nguyen authored
This CL adds a button to the login-dev-overlay to pop up a fake kiosk error message. We also update the ToastManager to allow showing toasts on the Login screen (which also uses LockSystemModalContainer). This involves consolidating the toast requeueing logic into OnSessionStateChanged. Bug: 879117 Change-Id: I557f0444a2368d1bf460d5db0a41f893ce0e69ea Reviewed-on: https://chromium-review.googlesource.com/1211969Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#589968}
-
Nicolas Ouellet-Payeur authored
Bug: 881859 Change-Id: Ic6d6945726d1dfd4fda5b59031c785d321730a09 Reviewed-on: https://chromium-review.googlesource.com/1214243Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#589967}
-
Min Qin authored
TBR=bashi@chromium.org Bug: 882477 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Id894ba9de59d1936591f78fed39fefe66658ba70 Reviewed-on: https://chromium-review.googlesource.com/1217062 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#589966}
-
Zhenyao Mo authored
So we can easily take advantage of devtools integration in tests. For example, the ability to automatically turn into fullscreen video playing mode. BUG=867155 TEST=manual R=kbr@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I2ed4d91ea82c3fc1308663c5d70e0f37bd50cd78 Reviewed-on: https://chromium-review.googlesource.com/1159690Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#589965}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/abd4273e43da..b2d711673390 git log abd4273e43da..b2d711673390 --date=short --no-merges --format='%ad %ae %s' 2018-09-10 peah@webrtc.org AEC3: Correction of the suppressor behavior at delay changes 2018-09-10 danilchap@webrtc.org Allow different header extensions in 1st packet of a video frame Created with: gclient setdep -r src/third_party/webrtc@b2d711673390 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:882396 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I19018fd072ff9c12a936a165fe5e1df5f6d8be64 Reviewed-on: https://chromium-review.googlesource.com/1216803Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589964}
-
tzik authored
The usage of `has_value` in remote_suggestions_fetcher_impl_unittest.cc works for base::Optional, but does not work for std::optional. To keep base::Optional be replaceable with std::optional, this CL updates RemoteSuggestionsFetcherImplTest to avoid using the method pointer to `has_value`. Change-Id: Iac3bfd47680b7678fcabdfaaa3ad8cc440e43408 Reviewed-on: https://chromium-review.googlesource.com/1215433Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#589963}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/43b882bceda7..cd9d074578e0 git log 43b882bceda7..cd9d074578e0 --date=short --no-merges --format='%ad %ae %s' 2018-09-10 fmalita@chromium.org [skottie] More efficient group sizing 2018-09-10 reed@google.com remove legacy google3 flag Created with: gclient setdep -r src/third_party/skia@cd9d074578e0 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I9f51452870dfdc39abb5ab4094a596ed0db14cfd Reviewed-on: https://chromium-review.googlesource.com/1216542Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589962}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/77e18bee2225..ba11264e0971 Created with: gclient setdep -r src-internal@ba11264e0971 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:877957 TBR=mmoss@chromium.org Change-Id: I081be2dc6a956982f5c229f96377a0fb5cb344e9 Reviewed-on: https://chromium-review.googlesource.com/1216104Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589961}
-
Morten Stenshorne authored
LayoutNG block fragmentation doesn't cope with pagination of out-of-flow positioned objects, but in this case we shouldn't even be there, because block fragmentation should trigger fall-back to legacy layout. One check was too strict to make that happen. Bug: 879467 Change-Id: I97ef4435ef5dc4a4122c97b58c22c3adf88fd17f Reviewed-on: https://chromium-review.googlesource.com/1215026 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#589960}
-
James Cook authored
This reverts commit b7eae9f9. Reason for revert: May be causing crashes in desktopui_MashLogin autotest in the Chrome OS lab. See crbug.com/882073 0 libminigbm.so.1.0.0!gbm_bo_destroy [gbm.c : 153 + 0x0] 1 chrome!gbm_wrapper::Buffer::~Buffer() [gbm_wrapper.cc : 121 + 0x5] 2 chrome!ui::GbmPixmap::~GbmPixmap() [memory : 2321 + 0x5] 3 chrome!gl::GLImageNativePixmap::~GLImageNativePixmap() 4 chrome!std::__1::__vector_base<gpu::gles2::Texture::LevelInfo, std::__1::allocator<gpu::gles2::Texture::LevelInfo> >::~__vector_base() [ref_counted.h : 352 + 0x3] 5 chrome!gpu::gles2::Texture::~Texture() [texture_manager.cc : 652 + 0x9] 6 chrome!gpu::gles2::Texture::RemoveTextureRef(gpu::gles2::TextureRef*, bool) [texture_manager.cc : 602 + 0x8] Original change's description: > ozone/drm: Use minigbm mmap for modeset buffers > > FillModesetBuffer assumed all the buffers could be mmaped as dumb > buffers. > This doesn't work on some platforms. > > This CL mmaps the modeset buffer using gbm_map instead, that should > work with tiled formats too. > > Bug: b/78892556 > Change-Id: I20ff9e54ea12e9866360021d8d9c5f7940f5b551 > Reviewed-on: https://chromium-review.googlesource.com/1198451 > Commit-Queue: Daniele Castagna <dcastagna@chromium.org> > Reviewed-by: Michael Spang <spang@chromium.org> > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589556} TBR=spang@chromium.org,dnicoara@chromium.org,dcastagna@chromium.org,ddavenport@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b/78892556 Change-Id: I7ceefac024f76d8f7b945ead19a36fb4a6a2e34a Reviewed-on: https://chromium-review.googlesource.com/1217022Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#589959}
-
Aldo Culquicondor authored
Instead, UiInterface defines getters for each interface. This change will allow easier implementations of unittests that use UiInterface. Additionally, remove BrowserUiInterface::SetIsExiting, as it is no longer used. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I70ebe7960e27083d8ac67b000a4c032878974968 Reviewed-on: https://chromium-review.googlesource.com/1211543 Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#589958}
-
Alexandros Frantzis authored
minigbm doesn't support passing an empty usage flag to gbm_device_is_format_supported(), which could happen with the previous code if the format isn't scanout-able. GBM_BO_USE_TEXTURING is an enum value and thus its existence cannot be checked with the preprocessor. Bug: 882429 Change-Id: I824dca82be65fdb6ffb8ab1e729af424e8969200 Reviewed-on: https://chromium-review.googlesource.com/1215947Reviewed-by:
Maksim Sisov <msisov@igalia.com> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#589957}
-
Mason Freed authored
Useful for multi-thread or multi-process stack trace printing, when competing threads step on each other's stack traces. For example: base: :debug::StackTrace(50).Print(" [" + std::toString(getpid()) + "] "); Change-Id: I6d1e686b22769de4a58c7232f93d3a9ca0a1ff0f Reviewed-on: https://chromium-review.googlesource.com/1199698 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#589956}
-
Boris Sazonov authored
This CL disables "Activity and interactions" entry in "Sync and Google services" preference screen when custom passphrase is set. Bug: 882463 Change-Id: I1c882e6d6ecafc2f17d8e43801851002155974df Reviewed-on: https://chromium-review.googlesource.com/1216822Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#589955}
-
Christopher Cameron authored
Update NativeWidgetMacNSWindow to use the mojo BridgeNativeWidgetHost interface instead of directly dereferencing views structures. Make similar changes to ViewsNSWindowDelegate. Update the mojo interfaces to include these functions. Remove the nativeWidgetMac property from ViewsNSWindowDelegate. Replace it with an "id" uint64_t on NativeWidgetMacNSWindow, which can be used to look up a corresponding - BridgedNativeWidgetImpl (in the app/viewer process) - BridgedNativeWidgetHostImpl (in the browser process) - a follow-on patch will add a "shadow" NativeWidgetMacNSWindow in the browser process which will use this id - that window will not be visible, but will be used for state tracking and bounds computations This is a re-land of crrev.com/589415, reverted at crrev.com/589415 because it introduced static initializers. TBR=ellyjones,rsesek (reviewers of crrev.com/589415) Bug: 859152 Change-Id: I00d4c91d09a9d281f372a2a452837e4537c30b35 Reviewed-on: https://chromium-review.googlesource.com/1214604Reviewed-by:ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#589954}
-
John Abd-El-Malek authored
Bug: 845559 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ibcaa434f5ffb1c43363190d4030ddb70f9449bf9 Reviewed-on: https://chromium-review.googlesource.com/1213275 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#589953}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5313adfefcab..580b5f861834 git log 5313adfefcab..580b5f861834 --date=short --no-merges --format='%ad %ae %s' 2018-09-10 dproy@google.com Merge "Disable autodraw and implement our own router" Created with: gclient setdep -r src/third_party/perfetto@580b5f861834 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I93011dbcdcb22728eda71ca153a29b972addf747 Reviewed-on: https://chromium-review.googlesource.com/1216106Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589952}
-
Joanmarie Diggs authored
* Add an event notifier in AXPlatformNodeAuraLinux for browser chrome. * Check to see if focus should follow selection. If it should, also emit state-changed:focused events. * Ensure that the correct states (focusable and selectable) wind up in the state set of elements where focus should follow selection. * Forward events from Blink content to AXPlatformNodeAuraLinux. * Create an event listener so that DumpAccessibilityEventsTest tests can be run. Add expectations for tests for which events are now emitted. At the present time, that is only focus and selected. R=dmazzoni@google.com Bug: 866340 Change-Id: I0d3334c39b064afc75ac5e051969fb43a79a0d8a Reviewed-on: https://chromium-review.googlesource.com/1163724Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Joanmarie Diggs <joanmarie.diggs@gmail.com> Cr-Commit-Position: refs/heads/master@{#589951}
-
Eric Roman authored
Previously methods on ProxyResolutionService took an optional ProxyDelegate pointer. This was problematic as not all callers were providing the correct value, and plumbing it down was inconvenient. Now the ProxyDelegate is instead an internal detail of the ProxyResolutionService. Bug: 793071 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I2eed185bc42cdc0bfcb945ad037fe2df52416198 Reviewed-on: https://chromium-review.googlesource.com/1208465Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#589950}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a735ee2f6df8..480edb8c1d7d git log a735ee2f6df8..480edb8c1d7d --date=short --no-merges --format='%ad %ae %s' 2018-09-10 oetuaho@nvidia.com Clean up TextureStorage11_2DMultisample Created with: gclient setdep -r src/third_party/angle@480edb8c1d7d The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Id29d74fb20de86bb2e5b1bddd892bc415b153fdc Reviewed-on: https://chromium-review.googlesource.com/1216543Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589949}
-
Mason Freed authored
With this change, there are now two color-profile related switches: --force-color-profile - forces the DISPLAY color profile to the desired setting. Note that the name of the flag didn't change, for backwards-compatibility. But it now refers to the display surface only. --force-raster-color-profile - forces the rasterization to happen in the provided color space. The exotic-color-space virtual test suite now sets the raster color profile to the ColorSpin profile, and the display color profile to sRGB. All other tests (by default) set both color profiles to sRGB. Bug: 875942, 667551 Change-Id: I66445cea5ed8dcc259a8f0bda2141350bcf66458 Reviewed-on: https://chromium-review.googlesource.com/1205713 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#589948}
-
Greg Thompson authored
This removes the last use of BrowserDistribution in ShellUtil. BUG=879568 Change-Id: Ib6ec1ab03913f16f17495ce67f603c7f1eb7ba1a Reviewed-on: https://chromium-review.googlesource.com/1215282Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#589947}
-
Vadym Doroshenko authored
It's basically the same as in PasswordFormManager. Bug: 831123 Change-Id: Iee8fda80eb46e3be1245e2f28d5a9b08980f527e Reviewed-on: https://chromium-review.googlesource.com/1213156 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#589946}
-
Xida Chen authored
In the TouchActionFilter, we maintain a num_of_active_touches_ and increment it at TouchSequenceStart and decrement it at TouchSequenceEnd. From the collected data, we have seen num_of_active_touches_ goes larger than 1, while it never goes smaller than 0. This CL removes the DumpWithoutCrash so that it won't generate a crash report as we have enough data. TBR=dtapuska@chromium.org Bug: 880021 Change-Id: I0d097a4721f3f613f2d373eca408636f761ced17 Reviewed-on: https://chromium-review.googlesource.com/1216027Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#589945}
-
Erik Luo authored
- Adds ShouldServeMimeTypeAsContentTypeHeader() on URLRequestFileJob - With debug_devtools, our interceptor now serves files with ContentType header, allowing DevTools to importScripts() on locally-served bundled files. - Without this CL, strict MIME-type checks prevent importScripts() in FormatterWorker, required for pretty-print and autocomplete. Bug: 882013 Change-Id: Ib61284cfccd430dd9a4ddae769a416147c504e05 Reviewed-on: https://chromium-review.googlesource.com/1214365Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#589944}
-
Javier Ernesto Flores Robles authored
Creates a password coordinator to manage the mediator and view controller of passwords manual fallback. Bug: 878388 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I7be155f687707cf6cc5ff6082ce6548c1d1fa74e Reviewed-on: https://chromium-review.googlesource.com/1202145 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#589943}
-
Marc Treib authored
While we're here, also get rid of some "default:" cases in switches. Bug: 468320 Change-Id: I8695af13f946c1f374bdf0402f93ec9dd491977f Reviewed-on: https://chromium-review.googlesource.com/1215762Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#589942}
-
Paul Meyer authored
This patch implements crash reporting, as detailed in the reporting spec: https://w3c.github.io/reporting/#crash-report Change-Id: I209880150193910a0947608e6b08a6eeea29206c Reviewed-on: https://chromium-review.googlesource.com/1174965 Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#589941}
-
Ivan Sandrk authored
Continuation of work from crrev.com/c/1202147, fixing up how delegates are set and persisted (using the base::NoDestructor pattern). Bug: 865947 Change-Id: Ib8768fe71e91c5f1bad400ec047b2c941a939608 Reviewed-on: https://chromium-review.googlesource.com/1210502Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#589940}
-
David Tseng authored
This reverts commit b9c37a4d. Reason for revert: <INSERT REASONING HERE> Likey change that causes many tests to flake (in chromevox_tests target). Bug: 881845 Original change's description: > Defer AX events to avoid problems with transient focus events. > > Some dialog boxes, like the accelerator confirmation dialog that appears > when you press Search+Control+M, focus the dialog and then immediately > after focus one of the buttons. This was causing ChromeVox to suppress > information about the context of the dialog. > > Fix this by using PostTask to defer all events from Views. This doesn't > even add any delay, it just pushes the event firing to after the current > call stack so that transient changes get suppressed. > > Manually confirmed that the experience with this particular dialog is > improved, other dialogs and views seem to continue to work fine. > > Bug: 729449 > Change-Id: I278c0c0b1dbdd26a654799fb5b314341942c1373 > Reviewed-on: https://chromium-review.googlesource.com/1176207 > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589201} TBR=jamescook@chromium.org,dmazzoni@chromium.org,sky@chromium.org,dtseng@chromium.org,yawano@chromium.org,sarakato@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 729449 Change-Id: I3275d959e96d05fdcfeac3c6b7839f7f36f75735 Reviewed-on: https://chromium-review.googlesource.com/1216664Reviewed-by:
-
Etienne Pierre-doray authored
Fix compile error with -Wshorten-64-to-32. Image size is new stored as an offset_t to avoid implicit conversion. Bug: 881008 Change-Id: I82b12ce17d8368f05d6a5537fd1734ee32b37dbe Reviewed-on: https://chromium-review.googlesource.com/1213549Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#589938}
-
Christian Dullweber authored
MediaLicenses are deleted together with Cookies in Clear Browsing Data (basic tab) now. We should also delete them from SiteDetails. Bug: 877999 Change-Id: Id4c751ca797ef6b3d123870cceb9eb1eef62e5f8 Reviewed-on: https://chromium-review.googlesource.com/1213242Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#589937}
-
Bailey Berro authored
This change updates the remount flow so that hosts on the network are rediscovered, so if the hostname is the same but the ip has changed since the share was originally mounted, the share will be able to be mounted. Bug: chromium:757625 Change-Id: I5038882fa44be15b725e1ccc0b377b244b62f787 Reviewed-on: https://chromium-review.googlesource.com/1199939 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#589936}
-
