GitLab

This reverts commit 1eeaf562.

Reason for revert: The culprit CL is this one here: crrev.com/c/1282517 which is already reverted: crrev.com/c/1287729.


Original change's description:
> Revert "ES6 styles to onVolumeInfoListUpdated_ and setupCurrentDirectory_"
> 
> This reverts commit 0ad9fe79.
> 
> Reason for revert: speculative revert, will revert the revert if not a root cause.
> 
> Bunch of Video/file-manager related tests started to fail:
> OpenVideoFiles/FilesAppBrowserTest.Test/videoOpenDrive_DriveFs
> OpenVideoFiles/FilesAppBrowserTest.Test/videoOpenDownloads
> VideoPlayerBrowserTest.OpenSingleVideoOnDrive
> VideoPlayerBrowserTest.OpenSingleVideoOnDownloads
> VideoPlayerBrowserTest.ClickControlButtons
> OpenVideoFiles/FilesAppBrowserTest.Test/videoOpenDownloads_GuestMode
> VideoPlayerBrowserTestInGuestMode.OpenSingleVideoOnDownloads
> VideoPlayerBrowserTest.CheckInitialElements
> OpenVideoFiles/FilesAppBrowserTest.Test/videoOpenDrive
> 
> Failures:
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/9115
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/9116
> 
> Original change's description:
> > ES6 styles to onVolumeInfoListUpdated_ and setupCurrentDirectory_
> > 
> > Appliy ES6 features to the DirectoryModel.onVolumeInfoListUpdated_ and
> > FileManager.setupCurrentDirectory_.
> > 
> > ES6 styles:
> > - Change var to const or let.
> > - Change anonymous functions+bind(this) to arrow functions.
> > 
> > Remove a TODO that linked to a closed bug.
> > 
> > Move comment to be before queue.run() to match the style of the
> > previous lines.
> > 
> > Apply the formatting from git cl format, which is slightly uglier, but
> > at least automatic. :-)
> > 
> > Test: No change in behaviour.
> > Change-Id: I5564263d44f8639d97fc86d7add5a59e8938be6d
> > Reviewed-on: https://chromium-review.googlesource.com/c/1286239
> > Reviewed-by: Joel Hockey <joelhockey@chromium.org>
> > Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#600312}
> 
> TBR=joelhockey@chromium.org,lucmult@chromium.org
> 
> Change-Id: I5f4aa388d2b88c5914c705c71b0fcc70904a42fe
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/1288169
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600640}

TBR=kinuko@chromium.org,joelhockey@chromium.org,lucmult@chromium.org

Change-Id: I7ce79f80a47367a2e5547e1bb3d5b227c40e77dd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1288091Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600646}

This CL adds 2dip padding between tray icons & fix WiFi icon padding.
WiFi icon is also used in network detailed view, so we have to set the
custom padding by checking IconType.

TEST=manual
BUG=885233

Change-Id: I5848007a1c71af54bba29105bcef7e063f7b6cf0
Reviewed-on: https://chromium-review.googlesource.com/c/1286237
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600645}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/451dc721b571..324e0418e810


git log 451dc721b571..324e0418e810 --date=short --no-merges --format='%ad %ae %s'
2018-10-18 ihf@chromium.org chromeos_config: run test on eve-arcnext PFQ.
2018-10-17 bhthompson@google.com Add bvt-inline HW tests to nocturne-paladin


Created with:
  gclient setdep -r src/third_party/chromite@324e0418e810

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I819c58c3eb55d9c1d4c4bc94ff2640b6f193431f
Reviewed-on: https://chromium-review.googlesource.com/c/1288010Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600644}

PWA windows are intended to appear stand alone from the main
browser so they should not adopt the main browser's theme colors.
This CL provides a default theme getter to be used by hosted app
(and PWA) windows.

This CL also removes the quick fix for this issue done by
https://chromium-review.googlesource.com/c/chromium/src/+/1275466.

Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=363145&signed_aid=TMzuMVlMKC2dm6ppdYp9PQ==&inline=1
After: https://bugs.chromium.org/p/chromium/issues/attachment?aid=363146&signed_aid=Og46P66KeV7iP-mnBHO3cA==&inline=1

Bug: 891560
Change-Id: I2d94bff9f72bfca59fcf7d6cb940f42e4a25cc70
Reviewed-on: https://chromium-review.googlesource.com/c/1272896
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600643}

This reverts commit c4d25f5b.

Reason for revert: This made some tests for Video and Audio players flaky crbug.com/896529

Original change's description:
> Unify JSErrorCounter for Files, Audio, Video and Gallery apps.
>
> Bug: 893430
> Change-Id: I4cb8149eaec9c9ab22700905dae804ac893fdb6c
> Reviewed-on: https://chromium-review.googlesource.com/c/1282517
> Reviewed-by: Noel Gordon <noel@chromium.org>
> Reviewed-by: Trent Apted <tapted@chromium.org>
> Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600308}

TBR=tapted@chromium.org,noel@chromium.org,lucmult@chromium.org

Change-Id: I676ef1e26b98ff842158501ebf1221520db18bc9
Bug: 896529
Reviewed-on: https://chromium-review.googlesource.com/c/1287729
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600642}

This is similar to https://crrev.com/c/1256384 but for subresource
loading.

Design doc:
https://docs.google.com/document/d/16K2X5k6hUq7lZSee-KXR9FUeSTEEypDXCjYbu_CvkT0/edit?usp=sharing

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Bug: 877972
Change-Id: Iba9c82b4de08862699eb1ba318f5710fe0264d86
Reviewed-on: https://chromium-review.googlesource.com/c/1264335
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600641}

This reverts commit 0ad9fe79.

Reason for revert: speculative revert, will revert the revert if not a root cause.

Bunch of Video/file-manager related tests started to fail:
OpenVideoFiles/FilesAppBrowserTest.Test/videoOpenDrive_DriveFs
OpenVideoFiles/FilesAppBrowserTest.Test/videoOpenDownloads
VideoPlayerBrowserTest.OpenSingleVideoOnDrive
VideoPlayerBrowserTest.OpenSingleVideoOnDownloads
VideoPlayerBrowserTest.ClickControlButtons
OpenVideoFiles/FilesAppBrowserTest.Test/videoOpenDownloads_GuestMode
VideoPlayerBrowserTestInGuestMode.OpenSingleVideoOnDownloads
VideoPlayerBrowserTest.CheckInitialElements
OpenVideoFiles/FilesAppBrowserTest.Test/videoOpenDrive

Failures:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/9115
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/9116

Original change's description:
> ES6 styles to onVolumeInfoListUpdated_ and setupCurrentDirectory_
> 
> Appliy ES6 features to the DirectoryModel.onVolumeInfoListUpdated_ and
> FileManager.setupCurrentDirectory_.
> 
> ES6 styles:
> - Change var to const or let.
> - Change anonymous functions+bind(this) to arrow functions.
> 
> Remove a TODO that linked to a closed bug.
> 
> Move comment to be before queue.run() to match the style of the
> previous lines.
> 
> Apply the formatting from git cl format, which is slightly uglier, but
> at least automatic. :-)
> 
> Test: No change in behaviour.
> Change-Id: I5564263d44f8639d97fc86d7add5a59e8938be6d
> Reviewed-on: https://chromium-review.googlesource.com/c/1286239
> Reviewed-by: Joel Hockey <joelhockey@chromium.org>
> Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600312}

TBR=joelhockey@chromium.org,lucmult@chromium.org

Change-Id: I5f4aa388d2b88c5914c705c71b0fcc70904a42fe
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1288169Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600640}

This CL adds sliding out animation to NewMessageListView when
notifications are removed. Animation on removal consists of two stages:
SLIDE_OUT and MOVE_DOWN. Previously, MOVE_DOWN was implemented in
https://crrev.com/c/1280087 .

Video: http://shortn/_HiEcuNpheU

UnifiedMessageListView will replace MessageListView. It's behind a flag:
--enable-features=NewMessageListView

Design doc: go/chrome-popup-refactoring

TEST=UnifiedMessageListViewTest
BUG=769219

Change-Id: I8abe9eedeeb7bd1bcef09e5cb5a072a0ab88fee2
Reviewed-on: https://chromium-review.googlesource.com/c/1282628
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600639}

This CL updates the EME requestMediaKeySystemAccess() stack to support
AV1. For library CDMs, it needs to be signaled during CDM registration.

In the next CL, ClearKeyCdm will be updated to actually support AV1
playback.

TBR=sorin@chromium.org
Windows.

Bug: 884898
Test: Added new test cases. Also manually tested component installer on
Change-Id: I0222136c76682db51bcf021c6bd5db3c467c271e
Reviewed-on: https://chromium-review.googlesource.com/c/1241569
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600638}

The new release changes how ALTER TABLE RENAME is implemented, and
requires an update to WebSQL's SQLite authorizer. This CL includes the
update, and extends the LayoutTest for the authorizer to cover the
newly implemented column renaming functionality.

Bug: 892852
Change-Id: I58fdc2927cacb6ccc84a741d7fc519fb2e5b8721
Reviewed-on: https://chromium-review.googlesource.com/c/1266881Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600637}

`gn gen` failed due to missing pdb files.

This is follwup of
https://chromium-review.googlesource.com/c/1279380

TBR: wfh@chromium.org thestig@chromium.org
Change-Id: I513d10d61a3868953c4afc025adf840e0f3c70c2
Reviewed-on: https://chromium-review.googlesource.com/c/1286108
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600636}

Bug: 895733
Change-Id: Iee9b0deb1016d28c8d6b4c870cdd452c52feda71
Reviewed-on: https://chromium-review.googlesource.com/c/1285116Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600635}

Bug: 893618
Change-Id: Idbfa57949f173847d2985e528fe05bdf1a2e93a2
Reviewed-on: https://chromium-review.googlesource.com/c/1287033
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600634}

Bug: 893618
Change-Id: I56f6c0ccf0c7cecfa419d557ed9fc444f500cd2d
Reviewed-on: https://chromium-review.googlesource.com/c/1287039Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#600633}

This Cl changes layout of PIN setup input/keyboard to match new specs.
This changes behavior both in First Run and in Settings UI.

Bug: 884667,890685
Change-Id: Ie0f94dfaa3ea22cdf99f478eb21ec1631de41bd5
Reviewed-on: https://chromium-review.googlesource.com/c/1286199Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600632}

The implementation just forwards the call to BlueZ. Future iterations
will support saving the new state into a user pref and concurrent calls.

Bug: 870192
Change-Id: I1dc1ebec9a58378ed8a4b87f31027c76a2a03323
Reviewed-on: https://chromium-review.googlesource.com/c/1280066Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Doug Turner <dougt@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600631}

This CL fixes
1 - Paused downloads showing up as failed after browser restart
2 - Pending for network downloads showing up as failed

Bug: 894159
Change-Id: Id4879c7e7a8e66413943c2a7732a72c558e11a49
Reviewed-on: https://chromium-review.googlesource.com/c/1284889
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600630}

Bug: none
Change-Id: I9d5b73409d25cf667a5b1ac580a7c5d6ddd3ea1a
Reviewed-on: https://chromium-review.googlesource.com/c/1286878Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600629}

swiftshader now supports arm64

Bug: 881334
Change-Id: I370fb7bdc361588ff69e47ac81af991ee2c02af1
Reviewed-on: https://chromium-review.googlesource.com/c/1287206Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600628}

This reverts commit f24f12dd.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 600509 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZjI0ZjEyZGRhYzc2ZmRlZDRiYmJkMmI0NjMxOTUyYjlhY2QyOWNjMQw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/14827

Sample Failed Step: viz_content_browsertests

Sample Flaky Test: BrowserSideFlingBrowserTest.TouchscreenFlingBubblesFromOOPIF

Original change's description:
> Added Fling Bubbling browsertests.
> 
> The tests were initially landed in the following cl:
> https://chromium-review.googlesource.com/c/chromium/src/+/1278963
> 
> The logic of the cl is re-landed in a separate cl(r599781) to give it
> more time to bake. This cl re-lands the browser tests after applying
> the following changes:
> 
> 1- Addressed renaming nit.
> 2- Used MainThreadFrameObserver to make sure that compositor is synced
> after scrolling on main thread.
> 
> Bug: 894703
> Change-Id: I25d6dbf7f216bbedecb6673d6c2819dcd1d82d55
> Reviewed-on: https://chromium-review.googlesource.com/c/1286875
> Reviewed-by: Charlie Reis <creis@chromium.org>
> Reviewed-by: Kevin McNee <mcnee@chromium.org>
> Commit-Queue: Sahel Sharify <sahel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600509}

Change-Id: Ie617c2ccc9b0048d24804ab59cdb5753f99a3e32
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 894703, 894703
Reviewed-on: https://chromium-review.googlesource.com/c/1287077
Cr-Commit-Position: refs/heads/master@{#600627}

https://chromium.googlesource.com/angle/angle.git/+log/3a482179dedb..25843dd65181


git log 3a482179dedb..25843dd65181 --date=short --no-merges --format='%ad %ae %s'
2018-10-18 ynovikov@chromium.org Align memory access in Copy32FixedTo32FVertexData
2018-10-17 jmadill@chromium.org perftests: Record trace events to JSON file.


Created with:
  gclient setdep -r src/third_party/angle@25843dd65181

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: I2013d8790c16cd8e11b2b34d9ff5c6973d32ec0a
Reviewed-on: https://chromium-review.googlesource.com/c/1287412Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600626}

Re-encoded for spec compliance. Previous versions omitted the
Codec Private.

BUG=879263
R=dalecurtis

Change-Id: I466e15886bba2b975b4b8b93a15cefb604f93057
Reviewed-on: https://chromium-review.googlesource.com/c/1287091Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Tom Finegan <tomfinegan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600625}

Bug: 896468
Change-Id: I17754946715d84c0db9b8d1bda237553d171c4ac
Reviewed-on: https://chromium-review.googlesource.com/c/1287292Reviewed-by: Patrick Noland <pnoland@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600624}

Bug: 546191
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I870931443b05f0ea8767864346703ba954df63f0
Reviewed-on: https://chromium-review.googlesource.com/c/1287291Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600623}

The test was failing because it was asserting on a DOM subtree that was behind a
<dom-if> that is false. In Polymer 2, a new optimization prevents those parts of
the DOM to receive any updates.

Bug: 896208
Change-Id: I268b6732ccf75f5544b3ce3011a73fbc8d11f55b
Reviewed-on: https://chromium-review.googlesource.com/c/1287199Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600622}

TBR=edwardjung@chromium.org

Bug: 852872
Change-Id: I6a48dca2ccb00fcac5f4ad2420694478d93639b7
Reviewed-on: https://chromium-review.googlesource.com/c/1285693Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600621}

When a WKWebView is displaying a PDF, the first responder is not in the view hierarchy (but a class adhering to UIResponder).

Bug: 882470
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I6f9e993e740541b7cf009b1d11e16183b409fdae
Reviewed-on: https://chromium-review.googlesource.com/c/1284438
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600620}

When localizing an extension, prioritize the user's preferred language
over the application locale.

Normally, these are the same. In some cases, they differ. For example,
the user may choose to display Chrome in "en-CA" (the intl.app_locale
pref), but because we don't have translations for that, the actual
UI locale is "en-GB".

This CL makes extensions try to use the user's preferred locale for i18n
("en_CA"), falling back to the UI locale ("en_GB") if no locale
directory is found for the preferred locale.

This change also updates the "current_locale" manifest key to reflect
the user's preferred locale, or the UI locale if intl.app_locale is
unset.

Note: Like the application locale, the preferred locale is only set at
startup (and in certain situations in CrOS). If the user changes their
intl.app_locale pref, they have to restart Chrome before extensions are
re-localized, just like before.

Bug: 874225
Change-Id: I1aabe3c3680b77d6522193e764aec15a3d618d2d
Reviewed-on: https://chromium-review.googlesource.com/c/1244666
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600619}

Add a new PSD to Feedback reports specifying the account type of the primary
user logged in.

R=afakhry@chromium.org

Bug: 891113
Change-Id: I6b46d65b0fb32fec0ef651d89dd06afcc3c58b25
Reviewed-on: https://chromium-review.googlesource.com/c/1277990
Commit-Queue: Rahul Chaturvedi <rkc@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600618}

This change applies clang-tidy's modernize-use-auto [1] in /media/cast.
This change does not rewrite new and cast expressions.

Reproduction steps:
- run clang-tidy's modernize-use-auto
- run git cl format
- manually remove unused typedefs due to -Wunused-local-typedef error

[1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html

This CL was uploaded by git cl split.

R=miu@chromium.org

Bug: 890902
Change-Id: I1f11e8871d5dab6298edd8829b852cd1907ee2b3
Reviewed-on: https://chromium-review.googlesource.com/c/1257904Reviewed-by: Yuri Wiitala <miu@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600617}

This disables Welcome App on selected devices.

Bug: 894095
Change-Id: I3a96e271f669eb2ac6d63d817d49be2838231170
Reviewed-on: https://chromium-review.googlesource.com/c/1287184
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600616}

Once a download becomes active, it should be shown on shelf.

BUG=895597

Change-Id: I307c64d2111a903ce0bc22b2bd0ae6ff1776c658
Reviewed-on: https://chromium-review.googlesource.com/c/1282023Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600615}

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I0651ad924a0cf050850cc5298b247c44abd355a4
Reviewed-on: https://chromium-review.googlesource.com/c/1287298Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600614}

See the retries on something like:
https://luci-milo.appspot.com/p/chromium/builders/luci.chromium.try/chromeos-amd64-generic-rel/110795

Failing due to the unknown args. This will just ignore them.

Bug: 876587
Change-Id: Ibfe012d74af2dff8ee9b35c3dc921ba53c671b83
Reviewed-on: https://chromium-review.googlesource.com/c/1284443Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600613}

- Touch event comes with coordinate where its origin is its root window
  host.

  Hardware. Confirm that ChromeVox works well on it, e.g. you can
  activate an element on the screen, etc.

Bug: 887222
Test: Enable spoken feedback on touch controller of Hangout Meet
Change-Id: I6bd6b50f13405c493659ad91f24d35974d5c72ce
Reviewed-on: https://chromium-review.googlesource.com/c/1282688Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Yuki Awano <yawano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600612}

These events were being sent up to AppListView, then back to
AppsGridView. In reality, these events can all be handled before
letting them pass through, just based on the nearest tile.

Bug: 893216
Change-Id: I9fee2bd9be03efb54a90b07d87bcf9f1a772d6f8
Reviewed-on: https://chromium-review.googlesource.com/c/1286129
Commit-Queue: Kevin Strohbehn <ginko@google.com>
Reviewed-by: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600611}

I accidentally modify cmd (which is unused, but passed in due to inherited function definition),
instead of recipe_cmd (which is used, and generated by this function). This is not caught by tests
as we mock subprocess.

Bug: 892381
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I8960fce63b98f68d2cf65792d4bd6e8bc971dcd0
Reviewed-on: https://chromium-review.googlesource.com/c/1287196Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: ericale <ericale@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600610}

This reverts commit ac77d3be.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 600408 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYWM3N2QzYmU5ZGIyYWJhMWMxZWUxNGI3Y2VmYTQwMGI2YmZkYzBlMAw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/29624

Sample Failed Step: viz_browser_tests

Sample Flaky Test: TopControlsSlideControllerTest.TestToggleChromeVox

Original change's description:
> top-chrome-slide: Disable the behavior when Chromevox is enabled.
> 
> Users of Chromevox may need to touch explore the webpage, and for
> things to remain consistent, we should disable hiding top-chrome
> with gesture scrolls as long as Chromevox is enabled.
> 
> BUG=857331
> TEST=Added a new browser test.
> 
> Change-Id: Ic70ebcad475ea7885ea3b6bd826b9b1f08f03e1b
> Reviewed-on: https://chromium-review.googlesource.com/c/1284289
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600408}

No-Presubmit: true
No-Tree-Checks: true
No-Try: true
BUG=857331, 896514

Change-Id: If1640bcc475ecbf869dd26dc11b35e6f9bc4fc75
Reviewed-on: https://chromium-review.googlesource.com/c/1287429
Cr-Commit-Position: refs/heads/master@{#600609}

R=abdulsyed@chromium.org

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I68f34a70ebe0e044092cc1abd25d48e9cfb28bd4
Reviewed-on: https://chromium-review.googlesource.com/c/1286863Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600608}

Avoids a pointless virtual call

R=eae@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ie3048af3bc77c1f2dfea7293d823dd2fa5bbdde5
Reviewed-on: https://chromium-review.googlesource.com/c/1287203
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600607}