- 09 Sep, 2018 10 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dd27ece0..abc91d41 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9d9acafcd0f81a1c626693962ab542aa2daa7633 Reviewed-on: https://chromium-review.googlesource.com/1214804Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589799}
-
Thomas Tangl authored
Screenshot before: https://drive.google.com/file/d/1gxhx2eGVfqwOi6GQFmyMTPaJkVtWIZXL/view?usp=sharing Screenshot after: https://drive.google.com/file/d/1bvwkIfvfCu0Jo3H04HRISWSp0xNmotO1/view?usp=sharing Bug: 872807 Change-Id: Ic0f6edee667e86661245105fd8f8a159f5674773 Reviewed-on: https://chromium-review.googlesource.com/1213176Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#589798}
-
Ned Nguyen authored
Note: the old Telemetry decorators no longer work on benchmarks TBR=pasko@chromium.org NOTRY=true # flake Bug: 760498 Change-Id: I514ebefb488db9934adcdde77c2f307a571183d6 Reviewed-on: https://chromium-review.googlesource.com/1215244 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#589797}
-
Jeremy Roman authored
Chromium is presently the only major vendor not to support it. Bug: 689891 Change-Id: Ibc7b0f1bf0da06f77d16cd9aeace44c2674807cc Reviewed-on: https://chromium-review.googlesource.com/1215242 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#589796}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I4d393c774db0c54782f315ef46404857c245fcdb Reviewed-on: https://chromium-review.googlesource.com/1214926Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#589795}
-
Alexei Filippov authored
Followup to fix test failure after r589730. BUG=878604 TBR=erikchen@chromium.org,thestig@chromium.org Change-Id: I55ae973e2d3b2204549ce67be24dfdd929b6f374 Reviewed-on: https://chromium-review.googlesource.com/1215054Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#589794}
-
Justin Donnelly authored
This reverts commit f3334641. Reason for revert: Reason for revert: Introduces static initializers according to https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/mac-rel/549. Original change's description: > RemoteMacViews: Remove browser deps from NativeWidgetMacNSWindow > > Update NativeWidgetMacNSWindow to use the mojo BridgeNativeWidgetHost > interface instead of directly dereferencing views structures. Make > similar changes to ViewsNSWindowDelegate. Update the mojo interfaces > to include these functions. > > Remove the nativeWidgetMac property from ViewsNSWindowDelegate. > Replace it with an "id" uint64_t on NativeWidgetMacNSWindow, which > can be used to look up a corresponding > - BridgedNativeWidgetImpl (in the app/viewer process) > - BridgedNativeWidgetHostImpl (in the browser process) > - a follow-on patch will add a "shadow" NativeWidgetMacNSWindow > in the browser process which will use this id > - that window will not be visible, but will be used for state > tracking and bounds computations > > Bug: 859152 > Change-Id: I9f62aefa1d4eba9961f691b5bd9247871e121355 > Reviewed-on: https://chromium-review.googlesource.com/1205477 > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Commit-Queue: ccameron <ccameron@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589415} TBR=ellyjones@chromium.org,ccameron@chromium.org,rsesek@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 859152 Change-Id: I597859c3dc3c11f231d21de73799c99481d28f36 Reviewed-on: https://chromium-review.googlesource.com/1214759Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#589793}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a3dc329d1db1..40c7c64572bc git log a3dc329d1db1..40c7c64572bc --date=short --no-merges --format='%ad %ae %s' 2018-09-09 fmalita@chromium.org [skottie] Skip group nodes for single-draw shapes Created with: gclient setdep -r src/third_party/skia@40c7c64572bc The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: Ib667dca8116d5e09de07c16b822c5912a929f11a Reviewed-on: https://chromium-review.googlesource.com/1215085Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589792}
-
Bin Wu authored
Initially QuicInlinedVector will be a absl::InlinedVector in Google3, and a std::vector in Chromium. Once Chromium can use absl, we can switch it to absl::InlinedVector as well. Merge internal change: 208999480 R=rch@chromium.org Change-Id: If341f868ca911439ae3ed36256d46138787456d5 Reviewed-on: https://chromium-review.googlesource.com/1177917Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bin Wu <wub@chromium.org> Cr-Commit-Position: refs/heads/master@{#589791}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 63a7666b. With Chromium commits locally applied on WPT: 488a36e8 "[IntersectionObserver] Fix the concept of "tracking document"" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24344 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I0be4af53a909667ba29bd0565a29aca5f219825e Reviewed-on: https://chromium-review.googlesource.com/1215057 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#589790}
-
- 08 Sep, 2018 30 commits
-
-
Koji Ishii authored
Following bot results are included. 9492 9497 9498 9499 9500 9502 9503 9508 9514 9515 9516 9517 9518 2 lines were removed and 3 lines were deflaked by consecutive results since 9497. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I62b7d6aee9f94364de2a09fec17448ed470eec34 Reviewed-on: https://chromium-review.googlesource.com/1212242 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#589789}
-
Steven Valdez authored
Bug: 630147 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Iea23b013ad1a2119e964ab5f60d8c9866f23e2c1 Reviewed-on: https://chromium-review.googlesource.com/1213929Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#589788}
-
Ryan Daum authored
* Some applications (such as maps) seem to disable gesture recognition, leading to a situation where onGestureEvent is never being called with ET_GESTURE_TAP_DOWN. * This led to applications timing out and returning to the home screen despite the user performing activity on the screen. * This CL treats a touch press event as a 'tap down', without requiring a GestureEvent. Bug: internal b/113205924 Test: manual on device Change-Id: I0bfa1bc8c2bd8685ae41de527f2b79477b176a3e Reviewed-on: https://chromium-review.googlesource.com/1214329Reviewed-by:Alex Sakhartchouk <alexst@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#589787}
-
Ulan Degenbaev authored
This is needed to implement a new metric that measures health of Web Page Replay archives. Bug: 880432 Change-Id: I8d3e7d83c9dc7b59ddc9953b5d4f0e1c5a707fcb Reviewed-on: https://chromium-review.googlesource.com/1203957Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#589786}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 67b6d035. With Chromium commits locally applied on WPT: 488a36e8 "[IntersectionObserver] Fix the concept of "tracking document"" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24320 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts NOAUTOREVERT=true TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I377c62d0f3655e720a9ad96ef92c2ad12fdbb6a1 Reviewed-on: https://chromium-review.googlesource.com/1215053 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#589785}
-
Eric Karl authored
This change adds more backpressure to Canvas/WebGL rendering in GPU bound situations. Before, the renderer could have three or four frames of drawing commands queued and waiting for execution by the GPU process. The GPU process does not know which drawing commands are associated with which display frame. Sometimes it would run multiple frames of queued drawing commands in one display frame, causing frame rate hiccups. Now when the TextureLayer has more than one buffer in flight, it calls DeferCommits to block the next requestAnimationFrame callback from running until one of the buffers is returned, indicating that the GPU process has executed the commands for that frame. The shorter pipeline reduces latency and prevents the GPU process from trying to execute multiple Canvas/WebGL frames in one display frame. Bug: 835353, 879658 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I7e5484add5fbd79757b205b1124ed7c2c5836dbb Reviewed-on: https://chromium-review.googlesource.com/1199699 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#589784}
-
Rakina Zata Amni authored
This CL removes usage of WebFindOptions in browser process, in favor of FindOptions, defined in find_in_page.mojom Bug: 819919 Change-Id: Iee85e1a277a225765dc5bb9f990b5bb5854efa04 Reviewed-on: https://chromium-review.googlesource.com/1184594Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#589783}
-
Eric Karl authored
We should have checked for |host_| before calling DeferCommits in the last CL. Adding this to match previous behavior. TBR=khushalsagar@chromium.org Bug: 881706, 835353, 879656 Change-Id: I27a1e6fc67478b2e50c33ae48339adb58749b980 Reviewed-on: https://chromium-review.googlesource.com/1215084 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#589782}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ead23c2a266c..c869f29dcef0 git log ead23c2a266c..c869f29dcef0 --date=short --no-merges --format='%ad %ae %s' 2018-09-08 nednguyen@google.com Wrap all websocket exception within InspectorWebsocket._SendRequest with exception.Error Created with: gclient setdep -r src/third_party/catapult@c869f29dcef0 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:882113 TBR=sullivan@chromium.org Change-Id: I29c31e0abcedc92dfa3514aa6444c4255279512f Reviewed-on: https://chromium-review.googlesource.com/1215083Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589781}
-
Robert Ma authored
There was a short period of time after we rolled in the new version of WPT tools (r588057) when these two tests were missing baselines (likely due to race between test changes and the roll). Now that the baselinse have been created by the importer, the two tests should no longer fail. Bug: 879728 Change-Id: Ide735b5dcf3538642187b0646c5459bb0442b03b Reviewed-on: https://chromium-review.googlesource.com/1214106 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#589780}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cbaaa59c..dd27ece0 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5e9255b2c0e86c2b75d3bf2c04a871e5facc9234 Reviewed-on: https://chromium-review.googlesource.com/1215050Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589779}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/fccfbbc4aee7..6c8c214ab77e git log fccfbbc4aee7..6c8c214ab77e --date=short --no-merges --format='%ad %ae %s' 2018-09-08 sapzape@gmail.com Add syntax error exception for empty values 2018-09-08 vapier@chromium.org binhost_test: overhaul AssertChromePrebuilts output 2018-09-08 hobexd@google.com Adjust tester for arc-camera user belonging to debugfs-access group. Created with: gclient setdep -r src/third_party/chromite@6c8c214ab77e The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I5819c48c9822a5d8e89a46321c2a2fdc48531ca3 Reviewed-on: https://chromium-review.googlesource.com/1215082Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589778}
-
Michael Lippautz authored
Fixes a regression where the exact timestamp was checked after processing a single object. Bug: chromium:878784 Change-Id: Id011b875ae56029bb415125d15b3701ac3dc375b Reviewed-on: https://chromium-review.googlesource.com/1213249Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#589777}
-
Ned Nguyen authored
** PERF SHERIFF: this CL may cause perf graphs to regress but it's expected ** Note that this CL also fixes a bug in sharding algorithm which makes the sharding map generation not very deterministic (see changes to tools/perf/core/sharding_map_generator.py). Step to generate the json files: remove 'startup.mobile' from UNSCHEDULED_TELEMETRY_BENCHMARKS, then run: $ ./tools/perf/generate_perf_sharding -r $ ./tools/perf/generate_perf_data TBR=jbudorick@chromium.org, perezju@chromium.org Bug: 880091,863768 Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I71a2622f979d451eba53ed89f567b82d6ce549e7 Reviewed-on: https://chromium-review.googlesource.com/1214758 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#589776}
-
Yao Xiao authored
This CL adds a new ActivationList for ad filtering on abusive sites. It also adds a base::Feature which triggers ad filtering on sites on the new ActivationList. This allows us to provide a stricter enforcement of abusive experiences, to go along with our current stronger popup blocker. Change-Id: I3b956f9b4cbee35e27aa0d30cdffd37bca41e533 Reviewed-on: https://chromium-review.googlesource.com/1197732 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#589775}
-
Chris Palmer authored
Bug: 864462 TBR: ajwong,haraken Change-Id: Ia32bd6ec4aad86c0581a0512cabeb658546d6327 Reviewed-on: https://chromium-review.googlesource.com/1214692 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#589774}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9ad92ef93e71..fccfbbc4aee7 git log 9ad92ef93e71..fccfbbc4aee7 --date=short --no-merges --format='%ad %ae %s' 2018-09-08 ayatane@chromium.org sysmon: Remove host metrics Created with: gclient setdep -r src/third_party/chromite@fccfbbc4aee7 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ibe8698fa995e6efcc59f27107f5171da1733dc33 Reviewed-on: https://chromium-review.googlesource.com/1214823Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589773}
-
BUG=762641 TBR=achuith@google.com Change-Id: Iedb514c2927c9ada785a594199f745057a56dfc7 Reviewed-on: https://chromium-review.googlesource.com/1212447Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#589772}
-
Vladislav Kaznacheev authored
- Update chrome_app manifest to support 32 and 192px icons. - Use 192px icon as window icon for Chrome browser. - Move all resource handing related to chrome_app under OS_CHROMEOS ifdef. Bug: 879618 Test: manual Change-Id: If3e9fb396424159ea0bf7f2cf61febfd89838b62 Reviewed-on: https://chromium-review.googlesource.com/1210943 Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#589771}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4d2b901804e0..f022f91453f7 git log 4d2b901804e0..f022f91453f7 --date=short --no-merges --format='%ad %ae %s' 2018-09-08 nodir@chromium.org Revert "[bot_update] Stop using repository properties" Created with: gclient setdep -r src/third_party/depot_tools@f022f91453f7 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:877161,chromium:694348 TBR=agable@chromium.org Change-Id: I26f83aba6c0a3e1adb3db8e4769af40c306023b5 Reviewed-on: https://chromium-review.googlesource.com/1214822Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589770}
-
Eric Willigers authored
CSS keywords serialize in lower case. https://drafts.csswg.org/cssom/#serializing-css-values "To serialize a CSS component value depends on the component, as follows: keyword The keyword converted to ASCII lowercase." BUG=882014 Change-Id: Ibdfb7f3bf64f26bc4841bbf012668d9071d4473c Reviewed-on: https://chromium-review.googlesource.com/1213563 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#589769}
-
Timothy Gu authored
R=foolip@chromium.org, robertma@chromium.org Bug: 715718 Change-Id: I7aca0973747d8bf1143fa4811e0432cc5a4fe369 Reviewed-on: https://chromium-review.googlesource.com/1214688 Commit-Queue: Timothy Gu <timothygu@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#589768}
-
Will Harris authored
../../chrome_elf/chrome_elf_test_stubs.cc(91,18): warning: implicit conversion loses integer precision: 'long long' to 'uint32_t' (aka 'unsigned int') [-Wshorten-64-to-32] return tracker - buffer; ~~~~~~ ~~~~~~~~^~~~~~~~ BUG=879657 Change-Id: Ie9044aae8fffebd05fa45c26ee5a63649ea228f5 Reviewed-on: https://chromium-review.googlesource.com/1214743Reviewed-by:
Robert Shield <robertshield@chromium.org> Commit-Queue: Robert Shield <robertshield@chromium.org> Cr-Commit-Position: refs/heads/master@{#589767}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/0a162b0cd376..9ad92ef93e71 git log 0a162b0cd376..9ad92ef93e71 --date=short --no-merges --format='%ad %ae %s' 2018-09-08 lannm@chromium.org Remove incorrect 'storage' arg from TempDir docstring 2018-09-08 vapier@chromium.org image_test: stop whitelisting 30-cups.sh 2018-09-08 lannm@chromium.org cbuildbot: Preserve chromite/ in CleanUp stage Created with: gclient setdep -r src/third_party/chromite@9ad92ef93e71 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I81b6eeccd324d365bbec69f834e585bdca29ae99 Reviewed-on: https://chromium-review.googlesource.com/1214763Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589766}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I4fd571965605c84d724ffdfbccbd2137bbb9bbd8 Reviewed-on: https://chromium-review.googlesource.com/1214922Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#589765}
-
dpapad authored
Currently if Escape is used to close a cr-dialog, the 'open' property is not getting set to false, which causes dialogs to not be re-opened in some cases. Slight modification of original fix by stevenjb@. Bug: 877122 Change-Id: Ib39a0e20bbf2318045844b39794335e49829faf4 Reviewed-on: https://chromium-review.googlesource.com/1213954 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#589764}
-
Eunseok Oh authored
This patch replaces the erase(std::remove()) and erase(std::remove_if()) used in the net folder with base::Erase() and base::EraseIf(). Bug: 875665 Change-Id: I3143eccb4da2f53e600c0a75f798e41af78e08dd Reviewed-on: https://chromium-review.googlesource.com/1203514Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#589763}
-
Weiyong Yao authored
This cl is to add a new getMediaStreamId method to tabCapture API. The object is to offer easy access to the content of current tab for sharing/recording together with mic/cam by web apps, by returning an encrypted device id from extension to web app. See design doc: https://docs.google.com/document/d/1YWFmFJaN-bbAxh01JP5qczERW9vda62vLInO32WvCM8/edit?ts=5ac7ebd8 TEST = autotests and a modified tab_capture example. Bug: 867533 Change-Id: I03283b2c6ce5187224e45370f8ca9b27881d570a Reviewed-on: https://chromium-review.googlesource.com/1167659 Commit-Queue: Weiyong Yao <braveyao@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#589762}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2810c856dfa2..a3dc329d1db1 git log 2810c856dfa2..a3dc329d1db1 --date=short --no-merges --format='%ad %ae %s' 2018-09-08 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 d84b6737fa10..3b9680534909 (4 commits) Created with: gclient setdep -r src/third_party/skia@a3dc329d1db1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I294232d51fe204072833621ddcf7bb8334a20303 Reviewed-on: https://chromium-review.googlesource.com/1214762Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589761}
-
Jdragon authored
There is no case of remaining id in new-shortcuts dictionary. Because all of them are deleted by above code. Change-Id: I0e9c971e58d811617fee957bf9864ce091ebab5b Reviewed-on: https://chromium-review.googlesource.com/1186921 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#589760}
-