GitLab

BUG=b/27447486

Change-Id: Ie08130329f12f34b6af4538aba56eb4e942abf3c
Reviewed-on: https://chromium-review.googlesource.com/530766Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478713}

Currently Update call will create a new unique pointer and destroy the
existing one. This will cause crash if we get the same object, change
the states and call Update again.

This CL also removes the cache in model, since we should support pass
the same object into Model::Update call.

Bug: 731994
Change-Id: I35ea73bf8b32f7f2a08d2e212dc738cfc4d155d9
Reviewed-on: https://chromium-review.googlesource.com/530484
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478712}

Remove LineBoxListPainter::InvalidateLineBoxPaintOffsets
Deadcode from https://crrev.com/9200103f3f0c21d9bd88c669159a43097ba185ed

Remove InlineTextBoxPainter::PaintCompositionBackgrounds
Deadcode from https://crrev.com/81808f5a2947e0a2c6d895fe59438ac7e3af04c8

Remove BoxPainter::IsFillLayerOpaque
Deadcode from https://crrev.com/e3ab046fcbe969bd1b38a0361f7d583998365c2c

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Icfa5df530d09bbb13aed0946f6bb2c114027ada7
Reviewed-on: https://chromium-review.googlesource.com/530038Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478711}

Bug: 732241
Change-Id: Ie525bd9ca1811581a1d8fbe4a9c02be768032ed9
Reviewed-on: https://chromium-review.googlesource.com/531066Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Yipeng Wang <yipengw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478710}

Up until now, there has been little help in debugging the
feature_engagement_tracker component other than seeing how the UI
behaves.

This has meant that some things are harder to evaluate and debug,
and developers typically have to add manual logging, particularly for
the check for whether in-product help should trigger.

This CL adds support for writing the ConditionValidator::Result struct
to an std::ostream using the operator<<. In addition, it makes use of
that in DVLOG(2) statements.

It also adds some extra debugging information related to startup
initialization and tracking of events.

By adding the following to the chrome command line, the extra logging
would appear in debug builds:
--vmodule=feature_engagement_tracker_impl*=2,model_impl*=2,availability_store*=2

BUG=None

Change-Id: Ifc4194d19fdec9230ad372b1d6296ffca45d5ee0
Reviewed-on: https://chromium-review.googlesource.com/526013Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478709}

Adding 4 strings that will be used for incognito mode on ARC's intent
picker.

Bug: 678141
Test: Build
Review-Url: https://codereview.chromium.org/2912133002
Cr-Commit-Position: refs/heads/master@{#478708}

This patch:
1. Changes kLtr to be 0. In most CPU architectures, 0 is faster and
   smaller code to set to and to compare with.
   This also matches to the assignments in ICU UBiDiDirection[1].
2. Adds comments.
3. Removes type name from function name since it's not needed when it
   was changed to "enum class", and looks redundant.
4. Prefers LTR/RTL than full spell, since they are common enough
   acronyms used in many specs and is more intuitive than full spell.
   Note the style guide[2] prefers to capitalize acronyms.
5. Adds "IsRtl()" for better readability than "!IsLtr()".

[1] https://cs.chromium.org/chromium/src/third_party/icu/source/common/unicode/ubidi.h?type=cs&q=UBiDiDirection&l=419
[2] https://google.github.io/styleguide/cppguide.html#Function_Names

Review-Url: https://codereview.chromium.org/2925293003
Cr-Commit-Position: refs/heads/master@{#478707}

It provides a concise syntax for using CreateDataProperty to create
data objects without invoking any setters that may exist on the
prototype chain. Most call sites were doing this already via
SafeSetV8Property, but DataObjectBuilder is clearer.

gin::DataObjectBuilder is extended to accept indices in addition to
string keys.

Bug: 689396
Change-Id: I0ef4119a73a0d6a6739b8f9e871bcc665c7543f2
Reviewed-on: https://chromium-review.googlesource.com/524243Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478706}

During refactoring, the wrong value was recorded.  Record the correct value.

BUG=725740

Review-Url: https://codereview.chromium.org/2925113004
Cr-Commit-Position: refs/heads/master@{#478705}

SpdySessionPool::OnNewSpdySessionReady() calls
HttpStreamFactoryImpl::Request::Complete() repeatedly while there are
any Requests in the map.  This relies on
HttpStreamRequest::Delegate::OnStreamReady() destroying the Request,
which in its destructor calls
HttpStreamFactoryImpl::JobController::OnRequestComplete(), which calls
HttpStreamFactoryImpl::JobController::CancelJobs(), which calls
HttpStreamFactoryImpl::JobController::RemoveRequestFromSpdySessionRequestMap(),
which calls SpdySessionPool::RemoveRequestFromSpdySessionRequestMap().
However, if HttpStreamRequest::Delegate::OnStreamReady() does not
destroy the Request, that results in DCHECK(!completed_) triggering in
HttpStreamFactoryImpl::Request::Complete() in a debug build, and an
infinite loop in production build.

This CL fixes this by explicitly calling
RemoveRequestFromSpdySessionRequestMap() in
SpdySessionPool::OnNewSpdySessionReady().

This revives https://crrev.com/2784143003, which was abandoned to do all
the necessary cleanup first.  Kudos to xunjieli@ for paving the way.

BUG=706974

Review-Url: https://codereview.chromium.org/2930323002
Cr-Commit-Position: refs/heads/master@{#478704}

https://chromium.googlesource.com/android_tools.git/+log/cb6bc2110..023e2f654

023e2f6 Roll NDK to pick std::deque patch.

BUG=674287

Review-Url: https://codereview.chromium.org/2904813005
Cr-Commit-Position: refs/heads/master@{#478703}

BUG= 672257

Review-Url: https://codereview.chromium.org/2932373002
Cr-Commit-Position: refs/heads/master@{#478702}

This moves the tearing down of VR UI into onStop instead of onPause.
However, this means we have to handle cases where Chrome pauses without
stopping while in VR. The only case I'm aware of where this is possible
is when the user enters multi-window mode while in VR.

(Even if there are other unhandled cases, the only problem is we keep
showing VR UI where we would prefer not to, and the user would have to
more explicitly exit VR)

Bug: 673528
Change-Id: Ia890875e1cf813b47443c4bb0883401506e6e55d
Reviewed-on: https://chromium-review.googlesource.com/527379
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Yash Malik <ymalik@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478701}

We decided that it is possible to have answer cards in Launcher even
before full-screen launcher is implemented.

As answer cards dictate the design of the whole search result page, new
search result page design will be applied when answer-card flag is on,
even without the full-screen flag.

The full-screen launcher comes with a total redesign of everything,
including search results page, so the new design for search results page
will be applied if full-screen flag is on, even without answer-card
flag.

This means that old design of search results page will be preserved only
when both flags are off.

Also, removing some unnecessary code.

Bug=712331

Review-Url: https://codereview.chromium.org/2933673002
Cr-Commit-Position: refs/heads/master@{#478700}

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2932913003
Cr-Commit-Position: refs/heads/master@{#478699}

BUG=729164

Review-Url: https://codereview.chromium.org/2930113002
Cr-Commit-Position: refs/heads/master@{#478698}

BUG=583440

Review-Url: https://codereview.chromium.org/2930353002
Cr-Commit-Position: refs/heads/master@{#478697}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f1ec7517..de09009b

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2932383002
Cr-Commit-Position: refs/heads/master@{#478696}

Context: I was recently updating this test for http://crrev.com/c/528297,
(and this test was also updated recently for --new-flag-specific-baseline).

The purpose of this is to improve this unit test's coverage and improve
readability.

Change-Id: I2f431ac4e1ab56ee3010ee8bf0a451ad1948222f
Reviewed-on: https://chromium-review.googlesource.com/529709
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478695}

On certain android versions, content URI from the DownloadManager can not be read by other apps
This CL works around the problem by using the file uri.

BUG=722383

Change-Id: I30ee7ab0ad16f9e13a5d43a1b1f50fe7425078ad
Reviewed-on: https://chromium-review.googlesource.com/530047
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478694}

instance and should have been const. Making this change also allowed
for several other methods to pass const SymmetricKey pointers where
previously they were non-const.

SymmetricKey: :GetRawKey() and SymmetricKey::key() did not modify the
Change-Id: I937e477f91870a1026c2c0aaf767a2e7d5e0ed42
Reviewed-on: https://chromium-review.googlesource.com/529746Reviewed-by: Adam Langley <agl@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Chris Mumford <cmumford@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478693}

https://skia.googlesource.com/skia.git/+log/fc3341632fc0..ffaa47e0fe5f

$ git log fc3341632..ffaa47e0f --date=short --no-merges --format='%ad %ae %s'
2017-06-12 robertphillips Roll ANGLE
2017-06-12 robertphillips Re-enable deferred proxies in Chrome
2017-06-12 robertphillips Remove GrTGpuResourceRef specializations
2017-06-12 mtklein append(from_srgb) -> append_from_srgb(kUnpremul)
2017-06-12 bsalomon Modify Adreno 3xx workaround to toggle face culling rather than call glFlush.
2017-06-11 reed remove unneeded proc fields

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=rmistry@chromium.org

Change-Id: If06f8578dc07b69a86917ae2d349a91609aed03a
Reviewed-on: https://chromium-review.googlesource.com/531484Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478692}

Bug: None
Change-Id: Iaffa31a55019b3bf25cac048eb81cc9bb05cc950
Reviewed-on: https://chromium-review.googlesource.com/530105
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478691}

8-bit WTF::String and LChar are expected to be used for Latin-1 data, rather
than UTF-8. Using CString and char is more idiomatic, and as a bonus, avoids
a copy (since String::Utf8 returns a CString already).

Change-Id: I5a4f726d4980a143793cd88cc80f79fb7375ea72
Reviewed-on: https://chromium-review.googlesource.com/521965
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478690}

If any of the failure conditions are reached it's a serious problem
which crashes ash. Switch DVLOG(1) to LOG(ERROR).

Bug: 732436
Change-Id: Ibac4991a6b5f7bae8763e191eb73de9684318e75
Reviewed-on: https://chromium-review.googlesource.com/531564Reviewed-by: Elliot Glaysher <erg@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478689}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/a5ece949fa04..7ba431f75da5

$ git log a5ece949f..7ba431f75 --date=short --no-merges --format='%ad %ae %s'
2017-06-12 nednguyen Remove generate_telemetry_harness script

Created with:
  roll-dep src/third_party/catapult
BUG=728177


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ibf94dfa26bace6a6e9f8fd3fae0237cc08e74ebe
Reviewed-on: https://chromium-review.googlesource.com/531445
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478688}

Matchers should not wait, so this is a replacement. This replaces
most uses of chrome_test_util::WebViewContainingText. There are
a few left over that are dependent upon having a method that
waits for the absence of a test.

BUG=707009

Review-Url: https://codereview.chromium.org/2798773002
Cr-Commit-Position: refs/heads/master@{#478687}

Before this CL, the unit test method test_build_check was
still passing even though the check_build behavior wasn't quite
as intended, I think -- run_webkit_tests.main was still exiting
with an error code, but not because the build check failed.

This CL fixes the test and Port.check_build, and simplifies the logic
in Port.check_build.

Bug: 726781
Change-Id: I03ff816245e244ea05e75e34fe8fabc649f41865
Reviewed-on: https://chromium-review.googlesource.com/528394
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478686}

Before this patch, hitting the software keyboard's "submit" button in
the CVC unmask dialog would hide the software keyboard and recenter the
dialog vertically. This would cause the user to hunt for the "Confirm"
button on the dialog at a new location. The user would be even more
frustrated if they instead accidentally tapped outside of the CVC
dialog, which cancels the CVC unmask.

This patch adds an editor action listener for the CVC number field in
the CVC unmask dialog. Whenever the user hits "submit" button on their
software keyboard in the CVC dialog, the listener checks if the dialog's
"confirm" button is enabled and, if so, clicks it. This patch also
changes the default software keyboard action on expiration date from
"submit" to "next field".

After this patch, hitting the software keyboard's "submit" button in the
CVC unmask dialog will perform the CVC unmask.

Bug: 730771, 687438
Change-Id: Ie8d93e1df214c7fd5494dd0da64a3b94fb1861b9
Reviewed-on: https://chromium-review.googlesource.com/527500Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478685}

The main change is to move most of the v4_* unit_test targets out of
the runners for mobile since v4_* is specifically targeting desktop
platforms.

Bug: 621647
Change-Id: I8a8b1c28231b424c116b87c23659f18b1e5873c6
Reviewed-on: https://chromium-review.googlesource.com/524988
Commit-Queue: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Luke Z <lpz@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478684}

There's no need to go to LocalFrameClientImpl to determine how to load
a plugin element, that was a purely pre-blink necessity.

Simplify a bunch of logic around HTMLPlugInElement to assume that url_
and service_type_ are always set and correct by the time the
ObjectContentType is being determined.

BUG=

Review-Url: https://codereview.chromium.org/2927703003
Cr-Commit-Position: refs/heads/master@{#478683}

Revert of Fix timestamp issue in RTCVideoEncoder for native frames (patchset #1 id:20001 of https://codereview.chromium.org/2934793002/ )

Reason for revert:
The CL did not fix the problem.

Original issue's description:
> Fix timestamp issue in RTCVideoEncoder for native frames
>
> Speculative fix for WebRTC test failures. See issue for more information.
>
> BUG=732345
> TBR=emircan
>
> Review-Url: https://codereview.chromium.org/2934793002
> Cr-Commit-Position: refs/heads/master@{#478627}
> Committed: https://chromium.googlesource.com/chromium/src/+/25b7a7a6350e64c24953b43594ed2b73afe33246

TBR=emircan@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=732345

Review-Url: https://codereview.chromium.org/2936583003
Cr-Commit-Position: refs/heads/master@{#478682}

Exclusively for extension app windows spawned using showInShelf = true,
make the tooltip text for the shelf item (icon) match the current value
of document.title from the corresponding window.

BUG=chromium:687359
TEST=Verify that the shelf item tooltip for extension app windows
     matches the document.title once the content is loaded.
TEST=From an extension app window with showInShelf=true, change the
     document.title dynamically and confirm that the shelf item tooltip
     changes to match.

Change-Id: I4620052821c19d91ea803151dc2cd4e538be121d
Reviewed-on: https://chromium-review.googlesource.com/526276
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478681}

This is part 2 of the conversion of ash system tray IME support to mojo.
The next CL will introduce a mojo interface that needs this type. The
struct is simple, so use it natively everywhere.

Rename IMEProperty to ImeMenuItem because it's a menu item, not a
generic property.

Bug: 724305
Test: ash_unittests, unit_tests
Change-Id: I8a8bb21ce99158ce45d4a6d889254ab311eef877
Reviewed-on: https://chromium-review.googlesource.com/528345
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Zachary Kuznia <zork@chromium.org>
Reviewed-by: Hadi Moshayedi <moshayedi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478680}

Following r478084, the main thread may contend with the audio thread
on accessing AudioBufferSourceNodeHandler's mutable state. Coordinate
such access by introducing a Mutex over |min_playback_rate_|.

Using atomic ops would be the natural choice for handling this, but
steering clear of those over doubles (cf. https://crrev.com/1256053006)
until std::atomic<> is allowed.

R=haraken,hongchan
BUG=731568

Review-Url: https://codereview.chromium.org/2929283002
Cr-Commit-Position: refs/heads/master@{#478679}

Compiling locally, resources.pak goes from 16744913 bytes to 14952341
(nearly 1.8MiB savings).

Review-Url: https://codereview.chromium.org/2933483005
Cr-Commit-Position: refs/heads/master@{#478678}

- Disable contextual search before we go through the search engine promo
check
- On a WebSearch from selection, first show the search engine promo and
only after that send the search intent.

BUG=728891

Review-Url: https://codereview.chromium.org/2926413002
Cr-Commit-Position: refs/heads/master@{#478677}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2935713002
Cr-Commit-Position: refs/heads/master@{#478676}

Revert of Remove find_dependencies script (patchset #1 id:1 of https://codereview.chromium.org/2932213002/ )

Reason for revert:
find_dependencies is still used.

Original issue's description:
> Remove find_dependencies script
>
> BUG=chromium:728177
>
> Review-Url: https://codereview.chromium.org/2932213002
> Cr-Commit-Position: refs/heads/master@{#478658}
> Committed: https://chromium.googlesource.com/chromium/src/+/e5ee4f9d1a7815c320dadb315675449a710c19aa

TBR=charliea@chromium.org,stevenjb@chromium.org,achuith@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:728177

Review-Url: https://codereview.chromium.org/2933163002
Cr-Commit-Position: refs/heads/master@{#478675}

These tests were never ran as they were stashed to a folder named
resources.

Bug: 
Change-Id: I8b8c7bd426ce3b25b3a4a623ad5a1fed4800e1c9
Reviewed-on: https://chromium-review.googlesource.com/529904
Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478674}