- 03 May, 2018 40 commits
-
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6a74bf33..fc1a04fd Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I4f3185d713c3808869fdfccb7ff6b8879875f02f Reviewed-on: https://chromium-review.googlesource.com/1041551Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#555689}
-
Mounir Lamouri authored
Bug: 839332 Change-Id: I07e98cae8763a0b6075eb59f6bf559aa0c244b85 Reviewed-on: https://chromium-review.googlesource.com/1041930Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#555688}
-
Guido Urdaneta authored
This is a better match for the spec, which says that group IDs are browsing-session unique, not frame-unique. This CL also reorganizes code in preparation for better support for the groupId constrainable property. Drive-by: Some minor fixes in WebRtcGetMediaDevicesBrowserTest. Bug: 833333 Change-Id: I4b7309fafc1f2c336bbe0d61f736992aa5d7f36e Reviewed-on: https://chromium-review.googlesource.com/1015560 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#555687}
-
Jérôme Lebel authored
Moving all files related to unified consent into: ios/chrome/browser/ui/authentication/unified_consent/ Original patch: crrev.com/c/1039187 Fix in Patchset 4 Reverted with: crrev.com/c/1039745 Bug: 827072 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I053db355aee79630eb4d97812c14ffede1241972 Reviewed-on: https://chromium-review.googlesource.com/1041926Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#555686}
-
Xiaohan Wang authored
This will prevent decoding error caused by destroyed MediaService during page navigation. See Bug for more details. Bug: 821171 Change-Id: I515fe3731ced2c38c6ccbb364d05a6122c9a4461 Reviewed-on: https://chromium-review.googlesource.com/1018821 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#555685}
-
Michael Lippautz authored
Bug: chromium:839114, chromium:757440 Change-Id: I9784179f8af19739a8c4398e3deea04611e12b09 Reviewed-on: https://chromium-review.googlesource.com/1041825Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#555684}
-
Bruce Dawson authored
New versions of C++ make aggregate initalization with truncation a hard error. VC++ gives warnings if old initialization syntaxes are used, for backwards compatibility, but gives a hard error for C++ 11 syntax. This change adds the casts needed to make this one spot build, which is sufficient since it is currently the only troublesome spot by the VC++ rules. Change-Id: I3b597cc8ce628135cfdbb3b91a8b2f9d54562d34 Reviewed-on: https://chromium-review.googlesource.com/1039195 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#555683}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/23d4f20c..6a74bf33 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Iee09cc2a1eb57ab8b0a05f9b0000d06e76c14b71 Reviewed-on: https://chromium-review.googlesource.com/1041548Reviewed-by:
-
Darren Shen authored
This reverts commit 09e09d32. Reason for revert: borked crbug.com/838803 Original change's description: > [VK] Add a way to reload IME without destroying KeyboardController. > > This patch introduces a new ash::Shell::ReloadKeyboard() method that > reloads the IME without recreating a KeyboardController. It destroys the > keyboard UI window instead and replaces it with a new one. > > We use this for accessibility prefs. The accessibility VK and normal VK > are different, so when we switch between the two, we have to reload IME. > > Bug: 731537 > Change-Id: I2388839206a48d81873f4bc6e7cf1ad2d0ed30f6 > Reviewed-on: https://chromium-review.googlesource.com/1025532 > Commit-Queue: Darren Shen <shend@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Yuichiro Hanada <yhanada@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553920} TBR=jamescook@chromium.org,yhanada@chromium.org,dvallet@chromium.org,shend@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 731537 Change-Id: Ia8a9996e0c82db4506c587ec8ab937d5c81849ef Reviewed-on: https://chromium-review.googlesource.com/1041445 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#555681}
-
Mahesh Machavolu authored
selection_popup_controller_ object is swapped to new_rwhva when new render process gets created and this pointer is set to null for the old_rwhva. Refer to API SelectionPopupController::UpdateRenderProcessConnection(). When stylus button event is given to this old_rwhva before the browser loads the new page, then it will cause a crash as OnStylusSelectBegin() will try to access selection_popup_controller_ which is already null. So, don't handle any selection events when selection_popup_controller_ is null. BUG: 834158 Change-Id: I2f55f9109183fe93a7fa7964cf4a67dfb9175e21 Reviewed-on: https://chromium-review.googlesource.com/1016180Reviewed-by:
AJITH KUMAR V <ajith.v@samsung.com> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: AJITH KUMAR V <ajith.v@samsung.com> Cr-Commit-Position: refs/heads/master@{#555680}
-
Rune Lillesveen authored
Gets rid of mutable style access from layout. Bug: 813068 Change-Id: Ie6af46ed9a0be75b692a8443929fe3de1db774df Reviewed-on: https://chromium-review.googlesource.com/1039571Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#555679}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ib761eda386538bb55864b1778c2edf0af07e9f32 Reviewed-on: https://chromium-review.googlesource.com/1041663 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555678}
-
Jani Hautakangas authored
HOST_NAME_MAX usage is guarded by #if defined(OS_LINUX) && !defined(OS_CHROMEOS) and include header for it <limits.h> should be also guarded by same ifdefs because limits.h is not required in other configs Change-Id: I1d70125b1101176cb08f317affbc760e65a726e5 Reviewed-on: https://chromium-review.googlesource.com/995419Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@chromium.org> Cr-Commit-Position: refs/heads/master@{#555677}
-
Khushal authored
We were not initializing the position buffer for a text run. TBR=enne@chromium.org Bug: 829622 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie64d63b18431198d12abc70a091ce2e24ea0d4d0 Reviewed-on: https://chromium-review.googlesource.com/1041656 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#555676}
-
Morten Stenshorne authored
When we resolve the BFC offset, all pending floats should always be committed, so keeping them as two separate operations doesn't really serve any purpose. Resolving the BFC offset also requires us to update the previous inflow position, so always do that as well. Change from MaybeUpdateFragmentBfcOffset() to ResolveBfcOffset(). The latter also positions floats and updates the previous inflow position. Rather than returning true when the offset got updated, it will return true if we're allowed to continue layout (even if the BFC offset was already resolved, in which case it will do nothing apart from returning true). If it returns false, we need to abort, because there was preceding content that needed a BFC offset. This required some changes in NGBlockLayoutAlgorithm::Layout() and also allowed for some clean-up there. No behavior change is intended with this CL. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I2a2318238aba3e6b10b3f69368761b832832822f Reviewed-on: https://chromium-review.googlesource.com/1039589Reviewed-by:
-
Maksim Sisov authored
This patch makes it possible to use system wayland libraries when building Chromium with Wayland support. By default, the wayland libraries in the //third_party are used. Change-Id: I34809fe643fb4967b9ac146af17f7845697fd394 Reviewed-on: https://chromium-review.googlesource.com/1033746Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#555674}
-
Xiaocheng Hu authored
This reverts commit 85d8d125. Reason for revert: causing crbug.com/838075 Original change's description: > Stop using RenderedPosition in VisibleUnitsLine > > VisibleUnitsLine uses RenderedPosition instances without using > the bidi-related functionalities. > > Since RenderedPosition is a wrapper of InlineBoxPosition with bidi > utility functions added, this patch changes VisibleUnitsLine to > use InlineBoxPosition directly for simplicity. > > Bug: 822575 > Change-Id: I158ddfb3dec1ead3f8b66e1255f3465f3f0353a2 > Reviewed-on: https://chromium-review.googlesource.com/1024645 > Reviewed-by: Yoichi Osato <yoichio@chromium.org> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553008} TBR=yosin@chromium.org,yoichio@chromium.org,xiaochengh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 822575, 838075 Change-Id: Ifa8429f7749d5c6bdb6dda3f2ed3471c523756ce Reviewed-on: https://chromium-review.googlesource.com/1040611Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#555673}
-
Luke Halliwell authored
Prevents teardown race conditions (other components may attempt to record metrics during shutdown, e.g. media pipeline tries to record end of playback). Bug: None Test: None Change-Id: I53cdbbecdfa23aca6d97dbb453f64f4ccf1abd73 Reviewed-on: https://chromium-review.googlesource.com/1028629Reviewed-by:
Stephen Lanham <slan@chromium.org> Commit-Queue: Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#555672}
-
Nate Fischer authored
The other CL in this series: http://crrev/i/616309 This adds the entries in histograms.xml and enums.xml for the SafeBrowsing.WebView.UserConsentVsUrlCheckRace histogram, which will be logged downstream, for the first Safe Browsing check. Bug: 836064 Test: check that metric is logged under chrome://histograms/SafeBrowsing Change-Id: Ief746b6c03044edc7becbcbf1664bfd08e2a2843 Reviewed-on: https://chromium-review.googlesource.com/1032255Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
Use horizontal-tb on UA stylesheet to make sure the controls look the same in all writing modes. Bug: 839142 Change-Id: I7c84afb4f1eef2cf741196b6a8639845aa72066c Reviewed-on: https://chromium-review.googlesource.com/1041025Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#555670}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f93c127f..23d4f20c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I5d3119284742cb0b7e5430d97ff9a1d992a6444e Reviewed-on: https://chromium-review.googlesource.com/1041387Reviewed-by:
-
Devlin Cronin authored
The dev mode extension bubble does not have a close button ('x') on cocoa, but does on views. This means that it should not have a cancel button on views (since it would be redundant with the 'x'), but it should on cocoa (since otherwise there's no way to close it, short of hitting the escape key). It looks like there was logic to try and ensure that the cocoa bubble always had a cancel button, but it was insufficient, since it uses MAC_VIEWS_BROWSER to check. However, MAC_VIEWS_BROWSER may be true, while Cocoa UI is still shown. This means that the Cocoa bubble may be shown without a cancel button, which is very bad (since it is exceedingly hard to close). Add the dismiss button back in for non-views-enabled mac builds. Bug: 838768 Change-Id: I61cf06bb3612607462fff28b72e4bfdd156a017b Reviewed-on: https://chromium-review.googlesource.com/1038231 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#555668}
-
Joe Downing authored
This CL changes the data type used in platform independent code from a NativeKeyCode to a DomCode. This is a follow-up from a previous CL in which I received feedback that DomCode is the preferred mechanism for storing keyboard keys above the native API level. For this CL, I updated every interface which previously took a NativeKeyCode (or a set of them) to use DomCode. It updates some callsites which previously did a conversion to/from NativeKeyCode and simplified them to use DomCode. It also updates the KeyboardHook impl to use Domcode (platform impls will receive a NativeKeyCode from the OS which is now translated to a DomCode first before checking if it needs to be forwarded). BUG=680809 Change-Id: I0126a8ce65e317316bd0c85e35f7d80d89c63704 Reviewed-on: https://chromium-review.googlesource.com/1037927 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kevin Schoedel <kpschoedel@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#555667}
-
Ramin Halavati authored
Network traffic annotation tests on trybots are triggered only if Chrome or remoting targets are modified. In cases that a file out of this scope, like in components, is modified, the test is not triggered and annotation changes miss tests. The test scope is expanded to all targets. It is expected that this does not have any negative speed effect as traffic annotation tests prefilter files that do not include any annotations. Bug: 690323 Change-Id: Iaa771443a40285c4b547b5e3c15f26f6cb61457e Reviewed-on: https://chromium-review.googlesource.com/1030270Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#555666}
-
Ehsan Karamad authored
Currently if a DomWindow in the page has a touch handler, the whole region for local frame root is added as touch region. This is incorrect as only the window for corresponding to the document/frame should be considered -- which is the same treatment that is given to |document|. Bug: 830626 Change-Id: Ieebd4116e9753f800fe2534cb0c89da812d22c56 Reviewed-on: https://chromium-review.googlesource.com/1005368Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#555665}
-
Max Moroz authored
That single-line change would be very helpful for hosting reports at GCS, as it provides a multi-platform dir structure for free. Bug: 836663 Change-Id: Ic9a984360cb352a23ace780d4aa600084be98a36 Reviewed-on: https://chromium-review.googlesource.com/1041282Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#555664}
-
John Abd-El-Malek authored
AKA LoadImageBrowserTest.LoadImageW on Windows. Also remove 2 tests from the filter file that don't exist. Bug: 776589 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ic4e0171723a52ff1cbf403af5df1510a26c868e6 Reviewed-on: https://chromium-review.googlesource.com/1040741 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#555663}
-
Johannes Henkel authored
I think it's better to do this directly on the field decl in the header than with every single constructor since it's easy to forget it there: at the moment it's missing from the third constructor in the .cc. It's possible that this makes no difference thus far but it's better to initialize it to avoid undefined behavior. R=caseq Change-Id: Ifd3e6b320bae593f9400f30ca7dc4769c391afb5 Reviewed-on: https://chromium-review.googlesource.com/1038820Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#555662}
-
Kenneth Russell authored
Worked with zmo@ to develop this documentation along with the example CLs. Also added top-level links to the GPU docs and cleaned up some other now-incorrect documentation. More cleanups are still needed. Bug: 838970 Tbr: zmo@chromium.org Change-Id: I40e07adf864974a645490627f5a055ce686237a3 Reviewed-on: https://chromium-review.googlesource.com/1041273 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#555661}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=anantha@chromium.org Change-Id: Ia029f0b839985c95a263b3b9259a11068875bc66 Reviewed-on: https://chromium-review.googlesource.com/1041408Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#555660}
-
Daniel Cheng authored
There's a weird crash right now in RequestBeginMainFrameNotExpected. The current theory is that somehow, Blink can't lookup the LocalFrame's corresponding WebLocalFrame. Add some tracing info to try to figure out how this is happening. Bug: 838348 Change-Id: Icbc357fcbb278e309d8b99a03cc652f9b9ccd771 Reviewed-on: https://chromium-review.googlesource.com/1041150Reviewed-by:
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/456cff40ed21..25309ca66e03 $ git log 456cff40e..25309ca66 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal BUG=chromium:835714 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie410b60509ad2bb2e98ec7ac600eec9428161c16 Reviewed-on: https://chromium-review.googlesource.com/1041220 Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555658}
-
Alexander Alekseev authored
This CL creates new component components/account_id/ by moving existing files out of components/signin/. Basically it moves: components/{signin/core => }/account_id/ components/{signin/public => account_id}/interfaces/BUILD.gn Most of the changes are purely mechanical: git-gs 'include .components/signin/core/account_id/account_id.h' | sed 's/:.*$//' | xargs sed -i 's#components/signin/core/account_id/account_id.h#components/account_id/account_id.h#' find . -mount -name DEPS | xargs sed -i 's#components/signin/core/account_id#components/account_id#' find . -mount -name '*mojom' | xargs sed -i 's#components/signin/public/#components/account_id#' find . -mount -name '*.gn' -type f | xargs sed -i 's#components/signin/core/account_id#components/account_id#' components/account_id/DEPS was created manually be stripping all the extra deps it had in components/signin/DEPS . Bug: 727549,462823 Change-Id: I9c0752a0503affef87c032453b6b5023b41e8e77 Reviewed-on: https://chromium-review.googlesource.com/1036504 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#555657}
-
https://chromium.googlesource.com/catapult.git/+log/02bb4b7da4db..978be7439d1e $ git log 02bb4b7da..978be7439 --date=short --no-merges --format='%ad %ae %s' 2018-05-02 simonhatch Dashboard - Remove internal_only from row. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I4237e7ae839cf987bc4446330f48483e98ba51ba Reviewed-on: https://chromium-review.googlesource.com/1041014Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555656}
-
Patti authored
Update the "Site Settings" page in chrome://settings with new strings and add headings. This change is gated behind the #site-settings flag. Bug: 835712 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I944e14d1009a96f6728a9dbd0917136c27894fe5 Reviewed-on: https://chromium-review.googlesource.com/1036707 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#555655}
-
John Budorick authored
Bug: 838767 Change-Id: I0e589d218161e2cd45e1023093dbe7341c9899aa Reviewed-on: https://chromium-review.googlesource.com/1039149 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#555654}
-
Jun Cai authored
Network Service: Fix some LoginPromptBrowserTest by adding |do_not_prompt_for_login_| flag for URLLoader This CL fixes some LoginPromptBrowserTest by adding a |do_not_prompt_for_login_| flag for URLLoader. It is similar to what ResourceLoader::OnAuthRequired() does. Bug: 783990 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I86d72fcf64429a3d78231ce55fc1bb07359c7caa Reviewed-on: https://chromium-review.googlesource.com/1015742 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#555653}
-
Ryan Hamilton authored
Merge internal change: 195142837 Change-Id: I39fd91432d12d60aea4299654dac48cc7dfd5b98 Reviewed-on: https://chromium-review.googlesource.com/1040660Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#555652}
-
Nasko Oskov authored
Currently this test navigates to a file that is not copied over to the device, which causes it to fail on the bots inconsistently. This CL makes sure the file is present in the location copied to the device and updates the path in the test. Bug: 838161 Change-Id: Icc8f7aa4537ba89575cda19fe1fd00b84e375323 Reviewed-on: https://chromium-review.googlesource.com/1040873Reviewed-by:
-
https://webrtc.googlesource.com/src.git/+log/219958059034..6f7e6d6ff353 $ git log 219958059..6f7e6d6ff --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic73ab77163de035ecdd8bb59faed90b2db587573 Reviewed-on: https://chromium-review.googlesource.com/1041148Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555650}
-
