GitLab

registerLoadRequest must take a URL as it is comparing it with a URL.

BUG=671964

Review-Url: https://codereview.chromium.org/2582373002
Cr-Commit-Position: refs/heads/master@{#439756}

FileBrowser.Load.BackgroundScript:
  Time to initialize backend script to wait for events.
FileBrowser.Load.BackgroundLaunch:
  Time from onLaunched event is called to the window is created.
FileBrowser.Load.BackgroundRestart:
  Time to create a window on restart.

BUG=675536
TEST=manually confirmed on Linux that sane values are exported in
chrome://histograms

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2585193002
Cr-Commit-Position: refs/heads/master@{#439755}

EGTests don't have the application group entitlement.
Disable the Receiver in that case.

BUG=675412

Review-Url: https://codereview.chromium.org/2588683002
Cr-Commit-Position: refs/heads/master@{#439754}

Previously, form-not-secure was enabled as its own value of the
--mark-non-secure-as flag. That value also enabled the "Not secure" omnibox
warning. Also, the autofill code that checked for the command-line flag
didn't allow us to enable it via Finch.

This CL moves the form-not-secure warning into its own Finch feature and
corresponding chrome://flags flag. This lets us turn it on and off via Finch,
independently from the "Not secure" omnibox warning that is controlled by
--mark-non-secure-as.

BUG=674320

Review-Url: https://codereview.chromium.org/2588133002
Cr-Commit-Position: refs/heads/master@{#439753}

Specification: https://webaudio.github.io/web-audio-api/#widl-AudioContext-getOutputTimestamp-AudioTimestamp

BUG=619533

Review-Url: https://codereview.chromium.org/2587223002
Cr-Commit-Position: refs/heads/master@{#439752}

Reland of load: "Request desktop site" feature should ask reposting (patchset #1 id:1 of https://codereview.chromium.org/2593533002/ )

Reason for revert:
This is not culprit

Original issue's description:
> Revert of Reload: "Request desktop site" feature should ask reposting (patchset #1 id:1 of https://codereview.chromium.org/2587923002/ )
>
> Reason for revert:
> Caused browser_test failure:
> https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/36770
> https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/34179
> https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/25740
> https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests/builds/36090
>
> Original issue's description:
> > Reload: "Request desktop site" feature should ask reposting
> >
> > Now Android Chrome does not confirm if it is expected to repost a form
> > on selecting "Request desktop site".
> >
> > This change modifies to ask it as we do in other cases.
> >
> > If a user reject reposting, the navigation switches to use desktop user
> > agent strings as usuals, but only for the next navigation and
> > following ones.
> >
> > BUG=675522
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> >
> > Committed: https://crrev.com/cb996c3d933656df61f80e1afc05742f9697b704
> > Cr-Commit-Position: refs/heads/master@{#439727}
>
> TBR=tedchoc@chromium.org,kinuko@chromium.org,toyoshim@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=675522
>
> Committed: https://crrev.com/28ed9ea575ab0cfb7db84ab0132863b3fa22cb4d
> Cr-Commit-Position: refs/heads/master@{#439749}

TBR=tedchoc@chromium.org,kinuko@chromium.org,toyoshim@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=675522

Review-Url: https://codereview.chromium.org/2587343002
Cr-Commit-Position: refs/heads/master@{#439751}

See bug for context. This patch begins the implementation of
more limited accessibility modes by only fetching a subset of
accessibility attributes from Blink unless more are explicitly
needed.

Only Windows is affected initially. By default now when
accessibility support is enabled on Windows, only a few
key accessibility attributes are fetched, like role, state, name,
value, and location. As individual APIs are accessed that go
beyond these, Chrome's accessibility mode is automatically
changed to start fetching more.

Screen readers are unaffected by this change. I manually
tested JAWS and NVDA.

Password managers and single-sign-on software should
continue to work fine, but users should experience a
performance boost.

BUG=672205

Review-Url: https://codereview.chromium.org/2581483002
Cr-Commit-Position: refs/heads/master@{#439750}

Revert of Reload: "Request desktop site" feature should ask reposting (patchset #1 id:1 of https://codereview.chromium.org/2587923002/ )

Reason for revert:
Caused browser_test failure:
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/36770
https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/34179
https://uberchromegw.corp.google.com/i/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/25740
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests/builds/36090

Original issue's description:
> Reload: "Request desktop site" feature should ask reposting
>
> Now Android Chrome does not confirm if it is expected to repost a form
> on selecting "Request desktop site".
>
> This change modifies to ask it as we do in other cases.
>
> If a user reject reposting, the navigation switches to use desktop user
> agent strings as usuals, but only for the next navigation and
> following ones.
>
> BUG=675522
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
>
> Committed: https://crrev.com/cb996c3d933656df61f80e1afc05742f9697b704
> Cr-Commit-Position: refs/heads/master@{#439727}

TBR=tedchoc@chromium.org,kinuko@chromium.org,toyoshim@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=675522

Review-Url: https://codereview.chromium.org/2593533002
Cr-Commit-Position: refs/heads/master@{#439749}

The HeapListHashSet<> iterators keep a pair of heap references, which
really should be traced like any other such reference during GCs. This
isn't unsafe for the stack allocated uses of these iterators, but one
Blink object (CSSSegmentedFontFace) keeps an iterator as a field on the
heap, we really have to trace these on-heap part object iterators.

Add the needed infrastructure and use it for CSSSegmentedFontFace.

R=haraken
BUG=672030

Review-Url: https://codereview.chromium.org/2583363002
Cr-Commit-Position: refs/heads/master@{#439748}

This changes the left and right arrow symbols into text (e.g. "left arrow"),
reducing ambiguity.  It also promotes cmd-[ over cmd-left on Mac.

BUG=637547
TEST=On a new profile, have a page in your "back" session history, then hit backspace twice while outside a textfield to trigger the "Use alt-left to go back" UI.  It should say "Left arrow" instead of "<-".

Review-Url: https://codereview.chromium.org/2540523003
Cr-Commit-Position: refs/heads/master@{#439747}

BUG=663601
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
NOTRY=true
TBR=zmo@chromium.org

Review-Url: https://codereview.chromium.org/2594583002
Cr-Commit-Position: refs/heads/master@{#439746}

This reverts commit 063b9902.

Original comment:
Remove Finch support for PasswordBranding

PasswordBranding has launched in the form of 100% being SAVE_PROMPT_ONLY.

This CL removes the code to obtain the Finch group for the experiment, related
tests, and also the functionality only executed for the unused FULL variant of
the experiment (mainly the SmartLock warm welcome).

BUG=486739
Committed: https://crrev.com/063b99026eca67b274692d0879bfdbcd0c9b5008
Cr-Commit-Position: refs/heads/master@{#439740}

TBR=mathp@chromium.org,vasilii@chromium.org,stanisc@chromium.org,stevenjb@chromium.org,dfalcantara@chromium.org,
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Review-Url: https://codereview.chromium.org/2588323002
Cr-Commit-Position: refs/heads/master@{#439745}

Some of them have already been marked as flaky, but others look also flaky.

BUG=610300
TBR=drott@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2590793002
Cr-Commit-Position: refs/heads/master@{#439744}

joined by ','.
Now, FetchHeaderList::get() is iterating all header list and
append strings to a result joined by ','.

BUG=645497

Review-Url: https://codereview.chromium.org/2587463002
Cr-Commit-Position: refs/heads/master@{#439743}

DataUse.AppTabState UMA is recorded with the following dimensions.
  Upstream.AppBackground
  Upstream.AppForeground.TabBackground
  Upstream.AppForeground.TabForeground
  Downstream.AppBackground
  Downstream.AppForeground.TabBackground
  Downstream.AppForeground.TabForeground

BUG=673820

Review-Url: https://codereview.chromium.org/2583703002
Cr-Commit-Position: refs/heads/master@{#439742}

Using GL_DEPTH_STENCIL_ATTACHMENT in GL_EXT_discard_framebuffer results
in a INVALID_ENUM gl error. Hence, we must prevent InvalidateFramebufferImpl
to generate such an attachment in this case.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2583183002
Cr-Commit-Position: refs/heads/master@{#439741}

PasswordBranding has launched in the form of 100% being SAVE_PROMPT_ONLY.

This CL removes the code to obtain the Finch group for the experiment, related
tests, and also the functionality only executed for the unused FULL variant of
the experiment (mainly the SmartLock warm welcome).

BUG=486739

Review-Url: https://codereview.chromium.org/2579823003
Cr-Commit-Position: refs/heads/master@{#439740}

This CL converts push event IPCs into mojo interface:
  ServiceWorkerMsg_PushEvent
  ServiceWorkerHostMsg_PushEventFinished

BUG=629701
TEST=content_unittests

Review-Url: https://codereview.chromium.org/2569993002
Cr-Commit-Position: refs/heads/master@{#439739}

[CrOS Tether] Create ble_constants.h/cc, which include common constants to be shared among multiple BLE-related classes.

BUG=672263

Review-Url: https://codereview.chromium.org/2590553003
Cr-Commit-Position: refs/heads/master@{#439738}

This UI was experimental and is not going to be released.

BUG=562280

Review-Url: https://codereview.chromium.org/2552903003
Cr-Commit-Position: refs/heads/master@{#439737}

As we're deprecating implicit conversions for WebString <-> string16
replace them with explicit methods. (See crbug.com/667131 for more
details)

BUG=667131

Review-Url: https://codereview.chromium.org/2584893002
Cr-Commit-Position: refs/heads/master@{#439736}

Adds the ability for property-suite to test string values that are represented the same as something else in Typed OM.

Converts the remaining inlinestyle/transform-rotate.html tests to use property-suite.

BUG=545318

Review-Url: https://codereview.chromium.org/2546343002
Cr-Commit-Position: refs/heads/master@{#439735}

This CL changes the type of MemoryCoordinatorImpl::ChildInfo::memory_state
from mojom::MemoryState to base::MemoryState. The reason of this change
is to avoid unnecessary type conversion. We are planning to add public
interface of memory coordinator so that chrome/ can access memory state
of each process. Since mojom::MemoryState is only accessible from
content/ we have to convert mojom::MemoryState to base::MemoryState when
we expose memory state outside content/. By storing states as
base::MemoryState we can eliminate type conversion.

BUG=673216

Review-Url: https://codereview.chromium.org/2586873002
Cr-Commit-Position: refs/heads/master@{#439734}

Many css1/ tests compare the image output with the expected one. They expected
that tests finish when the layout result becomes stable.

But the test runner may finish tests before loading some resources. Even worse,
the document load event may be dispatched before loading some resources. They're
working by chance, and changing the loading timing a bit will break them.

This CL makes those tests wait for css1/resources/basebg.gif to be loaded.

BUG=603396, 675870

Review-Url: https://codereview.chromium.org/2588283002
Cr-Commit-Position: refs/heads/master@{#439733}

Revert of Temporarily enable PlzNavigate to see perf bot results. (patchset #1 id:1 of https://codereview.chromium.org/2584093003/ )

Reason for revert:
Change cycled to perf bots.

Original issue's description:
> Temporarily enable PlzNavigate to see perf bot results.
>
> BUG=368813
> TBR=clamy@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://chromium.googlesource.com/chromium/src/+/3d001c287618b8298e5b95bd98556a5beffc0316
> Committed: https://crrev.com/722be6f390eba4c47669ad4307d2580dc09762dc
> Cr-Commit-Position: refs/heads/master@{#439731}

TBR=clamy@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=368813

Review-Url: https://codereview.chromium.org/2587333002
Cr-Commit-Position: refs/heads/master@{#439732}

BUG=368813
TBR=clamy@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Committed: https://chromium.googlesource.com/chromium/src/+/3d001c287618b8298e5b95bd98556a5beffc0316
Review-Url: https://codereview.chromium.org/2584093003
Cr-Commit-Position: refs/heads/master@{#439731}

BUG=672263

Review-Url: https://codereview.chromium.org/2590713002
Cr-Commit-Position: refs/heads/master@{#439730}

TBR=OWNER
BUG=675851

Review-Url: https://codereview.chromium.org/2589103002 .
Cr-Commit-Position: refs/heads/master@{#439729}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/580ee66c..a011eb0a

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2592513003
Cr-Commit-Position: refs/heads/master@{#439728}

Now Android Chrome does not confirm if it is expected to repost a form
on selecting "Request desktop site".

This change modifies to ask it as we do in other cases.

If a user reject reposting, the navigation switches to use desktop user
agent strings as usuals, but only for the next navigation and
following ones.

BUG=675522
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2587923002
Cr-Commit-Position: refs/heads/master@{#439727}

This CL generalises the EngagementLevel concept in site engagement,
moving it to a Mojo enum in Blink's public/platform. Prior to each
navigation commit, and when the engagement level for an origin changes
between buckets, the browser process sends the new level to all renderers
which are navigated to that origin. Using the discrete levels rather
than the continuous score minimises the IPC overhead to one additional
IPC per navigation commit per frame, and one IPC per engagement level
change.

The engagement level is stored on Document within the renderer, with
a temporary stop on RenderFrameImpl if sent prior to navigation commit.
This is a first step to enabling the collection of UseCounter data for
JavaScript API usage against engagement buckets.

BUG=655415

Review-Url: https://codereview.chromium.org/2535483002
Cr-Commit-Position: refs/heads/master@{#439726}

This patch adds a new method setSpellCheckResolvedCallback to test
runner, so that layout tests can run script when a spell check request
is resolved, which can be used to inspect spelling markers in a
better manner. It also adds removeSpellCheckResolvedCallback for clearing
a previously set callback.

Currently layout tests can only set a timeout to wait for markers to appear.
Follow-up patches will utilize this new method in layout tests.

BUG=674819

Review-Url: https://codereview.chromium.org/2587823003
Cr-Commit-Position: refs/heads/master@{#439725}

The font size was too small in DSF>1.0 because pointsToPixels() unnecessarily
multiplied the value by device scale factor.  Font sizes in this code should be
treated as DIP size.

BUG=674663

Review-Url: https://codereview.chromium.org/2587283002
Cr-Commit-Position: refs/heads/master@{#439724}

R=rjkroege@chromium.org
BUG=675055

Review-Url: https://codereview.chromium.org/2586393002
Cr-Commit-Position: refs/heads/master@{#439723}

Revert of Optimize KURL protocols (patchset #9 id:160001 of https://codereview.chromium.org/2463703002/ )

Reason for revert:
Causing DCHECK flakes. crbug.com/674388

Original issue's description:
> Optimize KURL protocols
>
> This patch optimizes KURL::protocol and KURL::protocolIs by keeping
> an AtomicString m_protocol on KURL. This reduces string allocations
> throughout the code using KURL::protocol().
>
> This also fixes an inconsistency with KURL::protocolIs that will return
> true for invalid URLs.
>
> BUG=348655
>
> Committed: https://crrev.com/775abc2d7c903f191f7b24f8b299ebabbea3f624
> Cr-Commit-Position: refs/heads/master@{#438197}

TBR=esprehn@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=348655,674388

Review-Url: https://codereview.chromium.org/2586253004
Cr-Commit-Position: refs/heads/master@{#439722}

This patch adds RELEASE_CHECK of offset and length to
InlineTextBox::constructTextRun(). StringView constructor only does
SECURITY_DCHECK intentionally, see http://crrev.com/2587863002.

BUG=671328

Review-Url: https://codereview.chromium.org/2588193003
Cr-Commit-Position: refs/heads/master@{#439721}

BUG=672719, 675819
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2590103002
Cr-Commit-Position: refs/heads/master@{#439720}

The lifetimes of RenderWidgetHostViewGuest and BrowserPluginGuest are not tied together and
it is possible for BrowserPluginGuest to be destroyed sooner than RenderWidgetHostViewGuest.

This CL will check for |guest_| null-ness before getting owner's RenderWidgetHostView from
it.

BUG=674417
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2588233002
Cr-Commit-Position: refs/heads/master@{#439719}

Remove ui::ContextProvider and ui::GLES2Context, since they are incomplete.
Instead use ui::ContextProviderCommandBuffer, which is used by chrome browser
and renderers.

BUG=643746
TBR=jam@ for content/renderer for code update for API change

Review-Url: https://codereview.chromium.org/2586323002
Cr-Commit-Position: refs/heads/master@{#439718}

to remove the term "sample" when no sampling is being done.

BUG=

Review-Url: https://codereview.chromium.org/2592493002
Cr-Commit-Position: refs/heads/master@{#439717}