- 30 Jul, 2018 40 commits
-
-
Parastoo Geranmayeh authored
Problem: When we Autofill, to decide if we should fill a field or leave it as is, we check if the last edit was user's edit. If so, we would not autofill (clear, etc). But sometimes, the website writes on the top of the autofilled value (exp: formatting a phone number). So, if the user adds a value on the field, the JS would edit it, and it would be overwritten by autofill. Solution: Instead of looking at the last edit, look if the user has ever edited that field. Bug: 860542, 867556 Change-Id: I59ec9c1efab98a9a07f23a47a0354e04ba9b87aa Reviewed-on: https://chromium-review.googlesource.com/1150683Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#579038}
-
Mythri Alle authored
We want to decouple the code cache from the HttpCache and recently added a separate code cache [1]. This cl is a follow up that actually writes the generated code into the code cache. There will be a followup cl that also fetches from the code cache. [1] chromium-review.googlesource.com/c/chromium/src/+/1120179 Bug: chromium:812168 Change-Id: I2866f8689b83ccba13ea8e0bcf7c60558997380d Reviewed-on: https://chromium-review.googlesource.com/1150237 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#579037}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ba191605..74c725b6 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6816c9581b3caad59990787750c3483693b6fe94 Reviewed-on: https://chromium-review.googlesource.com/1154889Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579036}
-
Ebrahim Byagowi authored
After several tries it seems it is stable now so lets remove this bit. Bug: 792131 Change-Id: I54df2450ff46477473d0e68b3ab9448bfa599ff3 Reviewed-on: https://chromium-review.googlesource.com/1076808Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#579035}
-
Thomas Tangl authored
When the unified consent toggle is switched off, the sync section and the non-personalized services section are expanded. Bug: 811517 Change-Id: I25e288e498c9397660f214ce61a1bed744c2cbf3 Reviewed-on: https://chromium-review.googlesource.com/1152986 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#579034}
-
Kevin Schoedel authored
TouchExplorationController provides audio feedback for certain actions. This provides an interface for a platform-specific implementation of these sounds. Bug: b/73383411 Test: manual and touch_exploration_controller_unittest Change-Id: Ic6a6e4163ee651bf2446b6ebb3121f4372c32b17 Reviewed-on: https://chromium-review.googlesource.com/1153505Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Kevin Schoedel <kpschoedel@chromium.org> Cr-Commit-Position: refs/heads/master@{#579033}
-
Elly Fong-Jones authored
This UI was only reachable in !mac_views_browser (last shipped in M66) with !ShowAllDialogsUsingToolkitViews (last shipped in M65). Bug: 832676 Change-Id: I3097f0de0b09c28e72c5e3a4c0977739cb0da2cc Reviewed-on: https://chromium-review.googlesource.com/1151655Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#579032}
-
Dominik Röttsches authored
Bug: 867866 Change-Id: If25d954db330ee2dfa32779fb1e8e7f40b2152f4 Reviewed-on: https://chromium-review.googlesource.com/1151203 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#579031}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e05f902a6929..dd9e5b9c8c10 git log e05f902a6929..dd9e5b9c8c10 --date=short --no-merges --format='%ad %ae %s' 2018-07-30 anthonyalridge@google.com Finish api change in preparation for integration. Created with: gclient setdep -r src/third_party/catapult@dd9e5b9c8c10 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866423 TBR=sullivan@chromium.org Change-Id: Ia08daf0c7c0191d8f38740e3e7f602341dc0a7ad Reviewed-on: https://chromium-review.googlesource.com/1154468Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579030}
-
Denis Kuznetsov authored
Change-Id: Ib3dc4a3b6bfd52250ee5a97d5bc5833117aec952 Reviewed-on: https://chromium-review.googlesource.com/1151633 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#579029}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/da846e65f8a2..c06b8a4e0ca3 git log da846e65f8a2..c06b8a4e0ca3 --date=short --no-merges --format='%ad %ae %s' 2018-07-30 borenet@google.com [infra] Fix expectations 2018-07-30 benjaminwagner@google.com Upgrade Test/Perf Mac bots to 10.13.6. 2018-07-30 benjaminwagner@google.com Add a TSAN GPU job running in Skolo. Created with: gclient setdep -r src/third_party/skia@c06b8a4e0ca3 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:862292 TBR=scroggo@chromium.org Change-Id: Ic70c37cd91a1ba2968d23db37aefc1d22375bceb Reviewed-on: https://chromium-review.googlesource.com/1154927Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#579028}
-
Koji Ishii authored
From a review of build 8466. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ib51559660e234a8dedb345b0072d6bd2ece49e4d Reviewed-on: https://chromium-review.googlesource.com/1154860 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#579027}
-
Guido Urdaneta authored
A result was unnecessarily moved and possibly used after move in content::MediaDevicesManager::OnDevicesEnumerated. Existing unit tests cover the affected code path, although it does not result in a crash, perhaps because the move is unnecessary and might be optimized away. No crashes have been observed in the wild either, except on a clusterfuzz build that performs IPC directly instead of going through the getCapabilities() JavaScript API. Bug: 868241 Change-Id: I2a3d9704a789c67b9eb763e1257504187201f941 Reviewed-on: https://chromium-review.googlesource.com/1154911Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#579026}
-
Yuki Shiino authored
As blink::Range::extractContents uses EventQueueScope that runs arbitrary author code internally, we cannot apply a auto-generated test for [NewObject], so this patch stops generating it by specifying [DoNotTestNewObject]. Ideally, it's better to have an alternative test, but we need a v8::Isolate to do it, and using [CallWith=ScriptState] looks a bit overkilling. So, this patch doesn't add an alternative so far. Bug: 865279 Change-Id: Ief434a2c7a4df9c75f5c0d3f4cdc198fa880c702 Reviewed-on: https://chromium-review.googlesource.com/1154746Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#579025}
-
Haruka Matsumura authored
This CL changes the system of slots registration in HeapCompaction. As preparing for HeapCompaction with IncrementalMarking, we change a timing of the registration on HashMap that related to slots, from during tracing to during atomic pause. So, we add HashSet that registeres traced slots. Previous commit caused a crash in heap_compact.cc:Add(slot), because it didn't check whether the reference is nullptr. So, we fixed it and we modified null check of backing_store from TraceBackingStoreStrongly() to VisiBackingStoreStorngly. Bug: 864425 Change-Id: I5e7edec41918b4058b9763b7ce60eadf50d43311 Reviewed-on: https://chromium-review.googlesource.com/1151043Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
This is just for command line flag clean up. Bug: 619640 Change-Id: Ie0611e6ff15db10721a55c29e0665be1c4295561 Reviewed-on: https://chromium-review.googlesource.com/1154227 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Rakina Zata Amni authored
The imports for script_promise.h, script_value.h and css_style_sheet_init.h can be replaced with forward declarations instead. Bug: 807560 Change-Id: I6fccced908fb9b75d51a50fbbe2a59d3f20f22b6 Reviewed-on: https://chromium-review.googlesource.com/1154858 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
-
Bence Béky authored
This is a follow-up to https://crrev.com/c/1146878. Bug: 779589 Change-Id: I44a2ba9106d247843e846815f410719a1a59a1c7 Reviewed-on: https://chromium-review.googlesource.com/1149112Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#579021}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/69747f20..ba191605 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie0a77319e8c1b344b5a9cdb65a8e70f01c44a4fa Reviewed-on: https://chromium-review.googlesource.com/1154641Reviewed-by:
-
Peter Beverloo authored
We have a strict dependency, so the base::Feature entry should be disabled. In addition, set the network start-up delay to zero, as there is no need to throttle network activity in testing scenarios. Bug: 866116 Change-Id: I5d2d22f20601824d09c7fd22233406dca7774268 Reviewed-on: https://chromium-review.googlesource.com/1153048 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#579019}
-
Henrique Ferreiro authored
The documentation had a typo in the variable mapping the hashes. Bug: 852347 Change-Id: If69581b2bec94698208f7cf9f3d91b63e8048733 Reviewed-on: https://chromium-review.googlesource.com/1152908Reviewed-by:
-
stkhapugin@chromium.org authored
Adds stkhapugin as ios/chrome/browser/ui/omnibox OWNER. Bug: None Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I1743135f6fa395a240fe63bd528b46d5480ff280 Reviewed-on: https://chromium-review.googlesource.com/1154533Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#579017}
-
Tanja Gornak authored
The service to substitute TiclInvalidationService. Bug: 801985 Change-Id: I675954b439b14ee8ccd2360fe042f31d8526bd1d Reviewed-on: https://chromium-review.googlesource.com/1145301 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#579016}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 15d5f5e9. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22108 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=robertma No-Export: true Change-Id: Ia4d403cde30e13e8461969d3dc81dbeb04d03d76 Reviewed-on: https://chromium-review.googlesource.com/1154644 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#579015}
-
Manuel Rego Casasnovas authored
We're planning to update the behavior of percentage row tracks and gutters when the grid container has an indefinite size to match the last changes on the spec. In the intent to implement and ship thread [1] it was agreed to first add a deprecation message to notify web developers about the upcoming change. BUG=846187 [1] https://groups.google.com/a/chromium.org/d/msg/blink-dev/CJgcT4hR7Rk/58WfZNbWBQAJ Change-Id: I5ca013615522d431c81bd96b6d12f61dd1846070 Reviewed-on: https://chromium-review.googlesource.com/1154531 Commit-Queue: Manuel Rego <rego@igalia.com> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#579014}
-
Takuto Ikuta authored
I did more than 50 commits under build directory, and I'd like to have ownership of build configs especially for goma and build performance related things. ~/chromium/src$ git log --author=tikuta --oneline build | wc -l 52 Change-Id: I3c0549ab4fc1426a37e5d6c0d7253c264da3ebc3 Reviewed-on: https://chromium-review.googlesource.com/1152707 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
-
Thomas Tangl authored
Metrics are recorded for the action the user takes when the consent bump is shown. Bug: 858870 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I6723ed814e22f8681edab3062648cc39a2731e3b Reviewed-on: https://chromium-review.googlesource.com/1143185 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Cr-Commit-Position: refs/heads/master@{#579012}
-
Kent Tamura authored
This reverts commit bb69db9e. Reason for revert: Found that both of tests still timed out. Original change's description: > html: Split semantics/tabular-data/processing-model-1/span-limits.html into two. > > The third test and the forth test are very slow. Split out the latter to > another file. > > Bug: https://github.com/web-platform-tests/wpt/issues/11187 > Change-Id: I3af14e712b6b06603140666f08005fb18d6a0541 > Reviewed-on: https://chromium-review.googlesource.com/1148163 > Reviewed-by: Takayoshi Kochi <kochi@chromium.org> > Commit-Queue: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#578991} TBR=kochi@chromium.org,tkent@chromium.org Change-Id: I1733918daad4fcc6ed83e015397b9830443b22aa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: https://github.com/web-platform-tests/wpt/issues/11187 Reviewed-on: https://chromium-review.googlesource.com/1154569Reviewed-by:
-
Olivier Robin authored
+ is an invalid character for include guard, so for a file named "foo+bar.h", include guard should be FOO_BAR_H_ Bug: 856548 Change-Id: I39a2d01e328b9352620d0d0e9548e40f1b57150a Reviewed-on: https://chromium-review.googlesource.com/1152971 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
-
Mikel Astiz authored
Recent changes in crbug.com/851905 cause tab IDs to be stable across restarts on Android. This means there's only one remaining field that we update for placeholder tabs: the window ID. Nodoby really cares about the window ID field in tab entities, because the window/tab hierarchy is constructed using the header entity, where tab IDs are used as foreign keys to refer to tabs (independently of window IDs). Hence, let's avoid wasting data use and traffic to sync servers by simply letting the window IDs become stale in tab entities. Bug: 854493 Change-Id: I65b054d564fd47b4664d6376fda0f7ff799d259d Reviewed-on: https://chromium-review.googlesource.com/1107989 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#579009}
-
Dan Elphick authored
Uses Int32Value(Local<Context>) instead of deprecated Value::Int32Value. Adds const modifiier to gin::arguments::GetHolderCreationContext. Change-Id: I90b06eaedb6684c91e349bc4801f02f5a3fe5654 Reviewed-on: https://chromium-review.googlesource.com/1152973Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#579008}
-
Jan Wilken Doerrie authored
This change implements ReadRemoteCharacteristic(), WriteRemoteCharacteristic() and WriteWithoutResponse() for WinRT's BluetoothRemoteGattCharacteristic. Furthermore, appropriate tests are enabled. Bug: 821766 Change-Id: I7bb11038ad88beda8103b723f9a69ad91106d30a Reviewed-on: https://chromium-review.googlesource.com/1151325 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#579007}
-
Tetsui Ohkubo authored
This reverts commit 704db340. Reason for revert: Crash https://crbug.com/868059 Original change's description: > Unified: Get default focus on detailed view. > > In UnifiedSystemTray, detailed view did not get focus when it is > transitioned by keyboard. > > TEST=manual > BUG=862504 > > Change-Id: I9f39359d3fa72be4bff5d42e5a9f98144b1a1bad > Reviewed-on: https://chromium-review.googlesource.com/1132899 > Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> > Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574461} TBR=yoshiki@chromium.org,tetsui@chromium.org,sammiequon@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 862504,868059 Change-Id: Iaf2f70f3b22a21a3e18863ad1911fca7772c3b63 Reviewed-on: https://chromium-review.googlesource.com/1154568Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#579006}
-
Tobias Sargeant authored
AwRenderProcess holds a child process identity, obtained via AwContents, which can be used to shut down the associated renderer service. The AwContents getter and the AwRenderProcess terminate method are exposed via the webview support library glue. Bug: 865062 Change-Id: Icdf59beb53e4b9afb1a213dc861bd158f3a41af8 Reviewed-on: https://chromium-review.googlesource.com/1143900Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#579005}
-
Matt Falkenhagen authored
This reverts commit bdff024c. Reason for revert: It turns out the crash was still happening up to 70.0.3501.2, before this was committed. The crash went away since 70.0.3502.0, but it's unclear whether that was because the instrumentation was removed or the "quick fix" was removed at the same time (r577435). I'm removing the instrumentation to see if the crashes will return. Original change's description: > service worker: Remove instrumentation for ServiceWorkerObjectHost crash. > > Remove the instrumentation from issue 854993 (and duped issue 838410) as > it is now fixed. > > This is mostly a straight revert of the CLs, but it retains some > checks as DCHECKs and other improvements like adding constness. > > Bug: 866769, 854993 > Change-Id: Id617e06e85e2b947258ba5f80c1d7aa0396888af > Reviewed-on: https://chromium-review.googlesource.com/1147888 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Matt Falkenhagen <falken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#577430} TBR=falken@chromium.org,kinuko@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 866769, 854993 Change-Id: I169f6c894d862008f4cfb0b778cd6f657b8351c0 Reviewed-on: https://chromium-review.googlesource.com/1154740Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Boris Sazonov authored
This CL changes the way an account is bundled into an intent that opens the settings page for this account: instead of bundling just the name of the account, the whole account object is bundled now. This is necessary because Settings app expects the whole account object in the bundle. Bug: 863370 Change-Id: I95a5ae901183c3cdd96bffd38906cb767a3afef3 Reviewed-on: https://chromium-review.googlesource.com/1152924Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#579003}
-
Yoshifumi Inoue authored
This patch changes |SetSelectionToDragCaret()| to take |SelectionInDOMTree| instead of |VisibleSelection&| since it uses |SelectionInDOMTree| and output parameter isn't used in caller for improving code health. This is 1/3 of series of patches: 1. This patch 2. http://crrev.com/c/1153070 3. http://crrev.com/c/1153071 Bug: 657237 Change-Id: If01c9f465cbf5e5a940d1e9c30af8080a5496527 Reviewed-on: https://chromium-review.googlesource.com/1153069Reviewed-by:
-
Arthur Sonzogni authored
The test http/tests/misc/adopt-iframe-src-attr-after-remove.html as always been a bit flaky: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fmisc%2Fadopt-iframe-src-attr-after-remove.html&testType=webkit_layout_tests The reason is that navigations triggered by a script before the onload handler don't generate back/forward entries. See third_party/blink/public/web/web_history_commit_type.h Sometimes, this test was fast enough so that no history entry was created. Then history.back() failed and it ended with a timeout. This is the same for: http/tests/misc/resource-timing-iframe-restored-from-history.html Bug: 862580, 831155 Change-Id: I3b8243c5f43c5043de8e23acfbe561a648c0f115 Reviewed-on: https://chromium-review.googlesource.com/1133170Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#579001}
-
Yoshifumi Inoue authored
This patch changes call site of |ChildrenChanged()| in |ContanerNode:: RemoveChild()| out side of |SlotAssignmentRecalcForbiddenScope| to allow |ChildrenChanged()| to use flat tree. Background: |HTMLElement::ChildrenChanged()| adjust directionality of element, e.g. "dir" attirbute, <bdi>, <bdo>, etc, by traversing flat tree. Bug: 867355 Change-Id: I8e1211f1a43afc27ba0e582030f2f2e8a6a74731 Reviewed-on: https://chromium-review.googlesource.com/1152754Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#579000}
-
Kunihiko Sakamoto authored
gen-certurl's -sct option is deprecated in https://github.com/WICG/webpackage/pull/259. Bug: 803774 Change-Id: I4fbc575366aba978b262418d2cf415121e840099 Reviewed-on: https://chromium-review.googlesource.com/1154745 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#578999}
-
