- 14 Sep, 2020 40 commits
-
-
Raphael Kubo da Costa authored
The class is called PlatformSensor, not Sensor. No functional changes. TBR=reillyg Change-Id: I6cffc3b41190a34aab8fa0b56d79d101851f0c8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409281Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#806610}
-
arthursonzogni authored
The test causes webview to crash. It has to be disable until the cause off the crash is found. TBR=timvolodine@chromium.org Bug: 1073077 Change-Id: I66fb484ad23d33754b5ab841abd4826d3a289b07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409977 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#806609}
-
Josh Nohle authored
This is a reland of 45e983ef Original change's description: > [Nearby] Use common default device name creation for Windows > > We previously handled default device name creation for Windows > differently than we did for other non-Chrome OS platforms. The > underlying reason appears to be that the Nearby Share service unit tests > were using base::RunLoop().RunUntilIdle() instead of > task_environment_.RunUntilIdle(). Because the hardware info fetch takes > longer on Windows than other platforms, I suspect that was the reason > only Windows was having issues. The correct run loop behavior was fixed > in a previous CL. > > Fixed: 1127603 > Change-Id: I1f10027696fb47d30ccfe0aa7b2ceb7c85de1393 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407856 > Auto-Submit: Josh Nohle <nohle@chromium.org> > Commit-Queue: James Vecore <vecore@google.com> > Reviewed-by: James Vecore <vecore@google.com> > Cr-Commit-Position: refs/heads/master@{#806466} Change-Id: I67038737e9d80c557e12fde6dbc567b06c6abe20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408214 Auto-Submit: Josh Nohle <nohle@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#806608}
-
arthursonzogni authored
The test was failing with the following error: ``` ../../content/browser/back_forward_cache_browsertest.cc:5429: Failure Expected: (0.01) > (duration2 - duration1), actual: 0.01 vs 0.011018 ``` TBR=altimin@chromium.org,hajimehoshi@chromium.org BUG=1127833 Fixed: 1127833 Change-Id: Ic0a5c531ab1b9aaa6e9ddac0b009b9add5c72966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409898Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#806607}
-
Titouan Rigoudy authored
This currently asserts the erroneous behavior documented in crbug.com/1124346. It will serve as proof that the bug is indeed fixed once the code under test is amended. Bug: chromium:1124346 Change-Id: Ic8cf6d0ac81e8ae1732981c5a020a6499ad5da47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395779Reviewed-by:
-
Tanmoy Mollik authored
SignInPreference class shows the signin promo when there is no primary syncing account present in chrome. Because the user can now be in signed in state this can show sync promos and signin promos at the same time. SigninInPreference class should instead check for if there is signed in account in chrome. Bug: 1126008 Change-Id: I45cd4a80b1206171d1634346865502fc1c94c1cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398542 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#806605}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1600019602-32c2a84e23bf8e92bb08ca2c2b541f0b03d0321b.profdata to chrome-win32-master-1600062449-2fe327552dcb0c48f221a41ff1f1e25d4acb9926.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I233bcc6044b31c1a97eb5fc7c9132b13923403b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409377Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806604}
-
Gauthier Ambard authored
This CL adds a cell in the settings to open Settings.app to set the default browser. Launch bug: crbug.com/1126436 Bug: 1127225 Change-Id: I9dea25330f999c0ed76bad6b6635dce1029bee28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400480 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#806603}
-
Eliot Courtney authored
In particular, the RGBX8 format doesn't seem to be supported. RGBA ordering support also seems to vary depending on device. Bug: 1127558 Test: can launch lacros Change-Id: Iff175b455444b6cfc3cc5c487080b5d42a4b2bc1 Fixed: 2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409532 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#806602}
-
Pavol Marko authored
According to MSAN, SurfaceAggregator::has_cached_render_passes_ is sometimes read without having been initialized. Default-initialize it (and another bool member) to false, as that seems to be the expectation. TBR=kylechar@chromium.org Bug: 1127818 Change-Id: I34d0a9399fab9b3af70feab14257b82fdb2476d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409697Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#806601}
-
Victor Hugo Vianna Silva authored
Score of 563 on the flakiness dashboard. The CL disables the test on every platform except Windows. https://findit-for-me.appspot.com/p/chromium/flake-portal/flakes?flake_filter=test_type%3A%3Async_integration_tests Bug: 1126404 Change-Id: I1cffbf8beb44f678c8d60eaecc8936e4ceb77816 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409695 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#806600}
-
Mark Cogan authored
Adds the icon for the "New Window" menu item. Bug: 1119332 Change-Id: I4ef194f49ced3526aa1489c64d6891473ad0b376 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409434 Commit-Queue: Mark Cogan <marq@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: Mark Cogan <marq@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#806599}
-
Pavol Marko authored
This reverts commit 71f44efe. Reason for revert: Assuming that it causes failures described in https://crbug.com/1127804 Original change's description: > Add test configs for URL display experiments > > This CL adds test configs for the URL display experiment group that > launches all three URL display experiments and SafeBrowsing Delayed > Warnings. > > SafeBrowsingDelayedWarnings was launched standalone for M85. In M86 and > above, it's launched with the other URL display experiments. It's also > no longer launched on Android as the URL display experiments aren't > implemented on Android. > > The CL also removes a couple of obsolete configs so that the bots > don't hit the command line length limit. > > Bug: 1111429 > Change-Id: I037fb3a456a31d7617516eb7ad554ec1a02f4d6d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399563 > Reviewed-by: Tommy Li <tommycli@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Commit-Queue: Emily Stark <estark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806380} TBR=mpearson@chromium.org,meacer@chromium.org,tommycli@chromium.org,estark@chromium.org,mahmadi@chromium.org,tiborg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1111429, 1127804 Change-Id: I92d5ecfcc4b8176fa91f31e4e491508d272bb357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408655Reviewed-by:
-
Benoit Lize authored
Changes: disabled the thread cache on Windows. Original change's description: > base/allocator: Add a thread cache to PartitionAlloc. > > This CL adds a thread cache to PartitionAlloc. It is optional, only > applies to thread-safe partitions, and uses the same freelist encoding > and bucketing as the main allocator. > > The thread cache is added "in the middle" of the main allocator, that is: > - After all the cookie/tag management > - Before the "raw" allocator. > > That is, the general allocation flow is: > 1. Adjustment of requested size to make room for tags / cookies > 2. Allocation: > a. Call to the thread cache, if it succeeds, return. > b. Otherwise, call the "raw" allocator <-- Locking > 3. Handle cookies/tags, zero allocation if required > > On the deallocation side, the process is reversed: > 1. Check cookies / tags, adjust the pointer > 2. Deallocation > a. Return to the thread cache of possible. If it succeeds, return. > b. Otherwise, call the "raw" allocator <-- Locking > > The thread cache maintains an array of buckets, the same as the parent > allocator. A single thread cache instance is only used by a single > partition. Each bucket is a linked list of allocations, capped to a set > maximum size. Elements in this "freelist" are encoded the same way they > are for the main allocator. > Only the smallest buckets are eligible for caching, to reduce the > memory impact. > > There are several limitations: > - Only a single partition is allowed to have a thread cache > - No periodic purging of thread caches is done > - No statistics are collected > > The last two limitations will be addressed in subsequent CLs. Regarding > the first one, it is not possible to use Chrome's native thread local > storage support, as it allocates. It is also desirable to use > thread_local to improve performance. > > Bug: 998048 > Change-Id: Ia771f507d9dd1c2c26a4668c76da220fb0c65dd4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375206 > Commit-Queue: Benoit L <lizeb@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805697} Bug: 998048 Change-Id: I23b70f6964bb297502921d1a08bf128d9093d577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404849Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#806597}
-
Robbie Gibson authored
Discussions on the bug show that OverscrollActionsController's high memory usage is coming from a large number of small allocations. The method in question is the initializer, so this implies that a large number of OverscrollActionsControllers are being initialized. This CL adds some histograms to verify if this is the case. Bug: 1102494 Change-Id: Id38c61781a8293a033a77df37227717e2ce7fe56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391232Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#806596}
-
Patrick Brosset authored
In order to achieve the right UX in the grid debugging tools in devtools we need to be able to fill the background of the grid overlay with a customizable color. This change adds a new parameter for this in the protocol file. Bug: 1047356 Change-Id: I4b9cec0017f1cde5f54da95f6f0aa9274375c5b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405997Reviewed-by:
Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Cr-Commit-Position: refs/heads/master@{#806595}
-
Anatoliy Potapchuk authored
After refactoring of AccessibilityControllerImpl, we can finally leverage that modularity by removing tons of identical calls. Bug: 2390184 Change-Id: I1c42bff577a844af80584ba6acd8da81e7b9b704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398687 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#806594}
-
Camillo Bruni authored
- Enable tests with TLA enabled - Fix top-level error reporting with TLA Based on the discussions on the spec, we fire error events on rejection of the result promise: https://github.com/whatwg/html/pull/4352#discussion_r435178136 Bug: 1022182, 1096455c, 1127215, v8:9344 Change-Id: I16e83cb4e279c1e44be7fa70a51a103ee94aacc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228881 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/master@{#806593}
-
Tsuyoshi Horo authored
Currently the subresource requests which are served from the subresource Web Bundles can't be interceptable by Chrome extensions. This is because the requests are handled only inside the renderer process. This CL introduces UrlLoaderFactoryProxy Mojo interface which can proxy the URLLoaderFactory for subresource Web Bundles to make the requests interceptable by Chrome extensions. This change checks the ENABLE_EXTENSIONS build flag not to increase the cost of calling IPC for Android where we don't support extensions. Bug: 1082020 Change-Id: I35efaf5cbb5de4522abd6e5739f265fcfb78dbc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379333 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#806592}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/01a6665d9a38..02fad13e1950 2020-09-14 alexrudenko@chromium.org Disable flaky test 2020-09-14 changhaohan@chromium.org Fix background color stuck issue for Computed pane box model If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1124613,chromium:1127785 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7c8b4c44962d324a2c8da983fc21657e53d64220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409375Reviewed-by:
-
arthursonzogni authored
Disable this test on Marshmallow, because it it consistently failing since it was added. TBR=jds@google.com,dtrainor@chromium.org Bug: 1127786 Change-Id: Id30d2503395b6e03c9bd42fc2dba9a7fde994f27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408755 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
-
Rohit Agarwal authored
This CL adds a check to resolve CustomTabIncognitoManager's dagger dependency only when the CustomTabActivity is incognito. Bug: 1127801 Change-Id: Idff4539cface4f76924310eb09d052768b15e610 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408314Reviewed-by:
Peter Conn <peconn@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#806589}
-
arthursonzogni authored
This test has been added recently by: https://chromium-review.googlesource.com/c/chromium/src/+/2393526 TBR=donnd@chromium.org Bug: 1127796 Change-Id: I13cac24be28b33467f7abbd2e605ae1596e03c23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409299Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/759ae5aec02b..f8a5602c5560 2020-09-14 john@johnkgo.com Fix #2385: guard against constant_id on non-const. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,jmadill@google.com Change-Id: Ib3a973cb7aee5f62266dab025a9c353dc62e47d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409376Reviewed-by:
-
Jan Wilken Dörrie authored
Bug: 1120688 Change-Id: I11080aa3c7a258c124193940e8897be4ff780491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396124Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#806586}
-
Omer Katz authored
CL [1] was submitted on August 24th as an attempt to address foreground marking time regression caused by migrating to the jobs api. That CL made it such that if there aren't many objects left in the marking worklist, a concurrent marker might die without reporting its marked bytes count. As a result, the marked bytes used to compute object size in the heap statistics would be lower than it should be. If collection backing stores are also promptly freed, the overall alllocated bytes since previous gc statistic could be negative and bigger in absolute value than the marked bytes of the previous GC. Drive-by: check if should yield before popping from the worklist. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2368498 Bug: 1124159 Change-Id: Ifa0c74ffc9f521679a21fc0109f2e2f3796700e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404856 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#806585}
-
Victor Hugo Vianna Silva authored
Score of 336 in the flakiness dashboard. https://findit-for-me.appspot.com/p/chromium/flake-portal/flakes?flake_filter=test_type%3A%3Async_integration_tests Bug: 1111227 Change-Id: Ie1ab0b8a3c7c87218941ce06fadc8dde2e657533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408014 Commit-Queue: Victor Vianna <victorvianna@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Victor Vianna <victorvianna@google.com> Reviewed-by:
-
Matt Menke authored
Rename URLRequestJobFactory::ProtocolHandler::MaybeCreateJob() to CreateJob(), since it can't fail, and make it return a unique_ptr, which is plubmed up through URLRequestJobFactory to URLRequest. Also remove the unused URLRequestTestJob::CreateProtocolHandler() method and the implementation of ProtocolHandler it returned. Bug: 354158 Change-Id: I277b1e367a39b8d0d345f78d9196fe9db6430f05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401328 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#806583}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1960f3b2. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I091899197285fea96c70ff1fc8edb2121760b2c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407380Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806582}
-
Jan Wilken Dörrie authored
This change adds a CHECK(str) into BasicStringPiece's constructor from `const value_type* str`. This prepares the code base for switching to std::string_view, since std::string_view(nullptr) would invoke undefined behavior. Bug: 1049498 Change-Id: Id5d832bc0586dc16a5e1045ba67602e4dc57317d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407712 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#806581}
-
Pavol Marko authored
It has been flaky on Chrome OS for a while. TBR=afakhry@chromium.org Bug: 1127805 Change-Id: I16d3b25015a6785ccef0edd6db45e7c910dfd4b8 sheriff: Only call GetPreviousURL on committed/error navigations Speculative fix for https://crbug.com/1127797 TBR=estark@chromium.org Bug: 1127797 Test: CQ Change-Id: I0ebc142960a4f9bea3df626123210367df6f8d35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409433Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/183a454b9d54..75d257686e00 2020-09-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from fe51fcb5 to 1960f3b2 (467 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jmadill@google.com Change-Id: I00f0e4258e167e7e36919813b6e533071088a92d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409373Reviewed-by:
-
Frédéric Wang authored
This CL aligns with a recent resolution from the CSSWG: https://github.com/w3c/csswg-drafts/issues/5385#issuecomment-690462275 This also ensures that LayoutObjectFactory::CreateMath always receives a MathML element. The new test fails when MathML Core (in particular LayoutNG) is disabled because math display values are not supported. Subtests fail when MathML Core is enabled because multiple display values are not supported. Bug: 1127222, 6606 Change-Id: Ica5558f221960d0f80609dfe0e56c029de7e9c3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404789Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Frédéric Wang <fwang@igalia.com> Cr-Commit-Position: refs/heads/master@{#806578}
-
Richard Knoll authored
This makes it clear which device will have to have the NearbyShare UI open in order to be visible. Bug: b/167692425 Change-Id: Iaef8a0bdba3a00c40249787972feec06ec13a53c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400979Reviewed-by:
-
Ye Kuang authored
https://chromium.googlesource.com/infra/infra/+/18502e6a01811b0c2dd2a0250e81bd82e47d2c2d Bug: 1127205 Change-Id: Ia58d7727f1b877bd4c48b62fa4c0872bd449be50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409393 Commit-Queue: Ye Kuang <yekuang@google.com> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#806576}
-
Yoshisato Yanagisawa authored
All builders using lib/try.star will use the task service account by default. All the task service accounts used for accessing Goma have already been granted. Bug: crbug.com/1105814 Change-Id: Ib0bfd2feb6d04453f87801a56c276eae13bfb6a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408882Reviewed-by:
Fumitoshi Ukai <ukai@google.com> Reviewed-by:
-
Nohemi Fernandez authored
Currently we use default initialization for creating ManageAccountParams in SigninHeaderHelper, which causes the uninitialized variables to be undefined and crash on a physical device. https://ci.chromium.org/p/chrome/builders/ci/ipad-device/12249 Bug: 1126746c Change-Id: I04e10d69925ad1887d3cf144d45fc5465680d63d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404794 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#806574}
-
Roberto Moura authored
As specified in the "Thumb Strip Layout" subsection of the Thumb Strip design doc (go/bling-thumb-strip-design): - Create a new Horizontal Layout class. - Create a Tab Switcher Layout class that will contain the intersection of the new Horizontal Layout and the existing Grid Layout. - Make the Grid Layout and Horizontal Layout subclasses of the Tab Switcher Layout. Bug: 1127604 Change-Id: I8da3e43563e6a18abb3bf0234db26aeccefc8e06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367092 Commit-Queue: Roberto Moura <mouraroberto@google.com> Reviewed-by:
-
Matthias Körber authored
This CL adds a structured component tree for addresses and regular expressions to parse address lines into their components are introduced. Additionally, for most structured address component types the zero-argument constructors are removed, since they are not supposed to be used as root nodes and should always be constructed with a supplied parent-node pointer. Change-Id: Ie7e2548d9f52a61c003cb263111bce2ab9d97602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388460 Auto-Submit: Matthias Körber <koerber@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#806572}
-
Maria Kazinova authored
This histogram was initially introduced to verify an assumption and now it's done. Change-Id: Iaef07a9977d13379c7d41f267a88d8f52ef8ca44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405577Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#806571}
-
