- 24 May, 2018 40 commits
-
-
Kyle Horimoto authored
Additionally, add the ability for FakeMultiplexedChannel to run a callback in its destructor. Bug: 824568, 752273 Change-Id: I1dd571d79c3e73228481efb2b68b210dbeb041f1 Reviewed-on: https://chromium-review.googlesource.com/1072164Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#561577}
-
Adam Langley authored
This was requested as a follow-up in a previous review: https://chromium-review.googlesource.com/c/chromium/src/+/1033336/3/content/browser/webauth/authenticator_impl.cc#836 Change-Id: I672fa5ac74bed7c70c680a8cd1b88b4d0f059277 Reviewed-on: https://chromium-review.googlesource.com/1069707 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#561576}
-
spqchan authored
When BubbleDialogDelegateView::SizeToContents() is called, it doesn't take into account that the bounds from GetBubbleBounds() doesn't include the NSWindow's style. This causes the SizeToContents() to potentially set the bubble window's bounds to an incorrect value. Bug: 839709 Change-Id: I6e27ff4f30673b5f7c26b68459be1e1cdac51587 Reviewed-on: https://chromium-review.googlesource.com/1069541 Commit-Queue: Sarah Chan <spqchan@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#561575}
-
Pavel Feldman authored
Change-Id: Ibec20968f901353dd96b0273e06723a3fcbbda9e Reviewed-on: https://chromium-review.googlesource.com/1070712 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#561574}
-
Fernando Serboncini authored
Bug: 563816 Change-Id: I22d22fcd06d6bbb9de94dc891fb4b4f327720881 Reviewed-on: https://chromium-review.googlesource.com/1070210 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#561573}
-
Gabriel Charette authored
This reverts commit 27f8891c. Reason for revert: suspect for crbug.com/846417 Original change's description: > Migrate ContentHashFetcher to SimpleURLLoader > > This CL migrates ContentHashFetcher away from URLRequestFetcher to > SimpleURLLoader. > > In order to accomplish this, a few other related changes are also performed: > > 1) The regular flow of the code is ContentVerifier -> ContentHash -> > ContentHashFetcher. In ContentVerifier, for instance, UI, IO and > "File tasks" threads take place. > Previously, the URLRequestFetcher logic residing in ContentHashFetcher > executed in the "file tasks" thread. > > As part of the migration from URLRequestFetcher to SimpleURLLoader > machinery, this CL also changes the ContentHashFetcher logic to > execute to the IO thread. > Note that it could be possible to keep the new SimpleURLLoader logic > in the "file tasks" thread. However, this would impose a way bigger change, > and require unittests to be considerably rewritten as well (see for > patchsets 7, 8 and 9. > The issue is that mojo objects are not thread safe. We could create a new > URLLoaderFactory for the extensions thread, but then we'd need to create a > new one when the network service crashes (Something this SharedURLLoaderFactory > one, already bound to the IOThread, magically handles), but that would be > significantly more complicated. > > 2) content_verifier_hash_fetch_behavior_browsertest.cc was changed > to support running with the network service feature both enabled > and disabled. This is a pattern that is also present in various other > unittests. > > In summary, the migration to use SimpleURLLoader performed here includes > also a change in the thread that ContentHashFetcher runs on, but no > functionality change is expected from this CL. > > BUG=773295,844926 > > Change-Id: If570f69d01ff75ac59d8d043f8687621336dddcf > Reviewed-on: https://chromium-review.googlesource.com/1056587 > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561480} TBR=lazyboy@chromium.org,rdevlin.cronin@chromium.org,mmenke@chromium.org,tonikitoo@igalia.com Change-Id: I31235cf26cfff34aac0ff1e4047575ed2881722b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 773295, 844926, 846417 Reviewed-on: https://chromium-review.googlesource.com/1072110Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#561572}
-
Jimmy Hastings authored
Change-Id: I143904a7dec28ffbe506f29b88ef3ac83ce5e980 Reviewed-on: https://chromium-review.googlesource.com/1071112Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Jimmy Hastings <jhastings@chromium.org> Cr-Commit-Position: refs/heads/master@{#561571}
-
Qiang Xu authored
changes: - Add #enable-app-shortcut-search flag and develop behind it. - Chrome side framework to support searching app shortcuts. - Reuse GetAppShortcutItems mojo API. When specified |package_name| is empty, it is aimed on global query. Video demo: https://drive.google.com/file/d/14y70Bn0gFrZqmqJtsCS8xPLUEC0twFwh/view?usp=sharing https://drive.google.com/file/d/1LUyzoX0dLpy3rkAx420oqznZEO9Lyyww/view?usp=sharing Bug: 842947 Test: manual test with Android change Change-Id: I8d6f62f12d215d464815dd4ff6c31c1e6af9e2c5 Reviewed-on: https://chromium-review.googlesource.com/1058681 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#561570}
-
Fabrice de Gans-Riberi authored
Some Posix-only instances were missed when disabling the OS_POSIX macro for the Fuchsia build. Bug: 836416 Change-Id: I291465a50813e984bdca223b1e533c2ad624062c Reviewed-on: https://chromium-review.googlesource.com/1070625Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#561569}
-
Chris Hamilton authored
This is the first in a multi-part cleanup, detailed in the bug. BUG=846374 Change-Id: I76331ceb7469f1262a2c934a956fdd96410c1a19 Reviewed-on: https://chromium-review.googlesource.com/1071884Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#561568}
-
Calder Kitagawa authored
This is an attempted fix for ToTWinCFI. Looks like sys.executable logic isn't working well on some Python configurations so directly using sys.executable. If this doesn't fix ToTCFI I'll revert the previous change until I can determine what is happening: https://chromium.googlesource.com/chromium/src/+/8e7c08d3d11c61d08ad05d3ebc283aa2d6bf7c91 Thanks to thakis@ for solution suggestion. Bug: 844826 Change-Id: Ie1cb36fe19401e954cb84bc905cd95c9eefa1622 Reviewed-on: https://chromium-review.googlesource.com/1072159 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#561567}
-
Aaron Leventhal authored
Extra events occur in unpredictable order, with the following text: EVENT_OBJECT_LOCATIONCHANGE on role=ROLE_SYSTEM_CLIENT name="Edit" Filter out these events in the output. Bug: 791268 Change-Id: If9096af8bd625a08b0cb7583d523c7cc93811947 Reviewed-on: https://chromium-review.googlesource.com/1071728 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#561566}
-
Krishna Govind authored
R=cmasso@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic14dc4769b0bdeff4eead0ab6aafbbda4e66744b Reviewed-on: https://chromium-review.googlesource.com/1072203Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#561565}
-
Andre Goddard Rosa authored
- Makes implementation symmetric to program manager - DecUseCount() was not only doing what's named after - Also decreases binary size: text data bss dec hex filename before 6883184 193376 2012 7078572 6c02ac out/Release/libgles2.so after 6882668 193360 2012 7078040 6c0098 out/Release/libgles2.so R=piman@chromium.org Bug: 846385 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I51fc0b37ab1f59e4fc54fb11b43cc480209a0479 Reviewed-on: https://chromium-review.googlesource.com/1071009Reviewed-by:Zhenyao Mo <zmo@chromium.org> Commit-Queue: Andre Goddard Rosa <andre.rosa@lge.com> Cr-Commit-Position: refs/heads/master@{#561564}
-
Dmitry Skiba authored
LibraryLoader is a singleton, but to get its instance one has to pass LibraryProcessType value. However out of all LibraryLoader methods only two (initialize() and ensureInitialized()) actually use the process type value. Also, LibraryLoader.get(LibraryProcessType) stores process type on the first call (which creates the instance), and throws an exception if subsequent calls don't use the same value. This puts additional burden on callers, which have to handle ProcessInitException from get() even when they are calling non-initialization methods (e.g. preloadNow()). This CL moves LibraryProcessType argument from get() to initialization methods (initialize() and ensureInitialized()), and also renames get() to getInstance(). Bug: 841403 Change-Id: I74b311316f10831c23915a7f2189f38c660c4982 Reviewed-on: https://chromium-review.googlesource.com/1067847Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Dmitry Skiba <dskiba@chromium.org> Cr-Commit-Position: refs/heads/master@{#561563}
-
glevin authored
As per crbug.com/788019 Comments 1,5,7: - Width = 448px - Remove X (Close) button from upper right - Update title and body strings - Code cleanup - NOTE: Dialog has no buttons, is dismissed by any user action Bug: 788019 Test: Sit idle in Public Session (?), see if the Great Harmony will come and find you Change-Id: I160e93eb0fc9a788ef1c627b5459ca1e1d6c04de Reviewed-on: https://chromium-review.googlesource.com/1070713Reviewed-by:
-
Kevin Marshall authored
PipelineIntegrationTest.TrackStatusChangesWhileSuspended times out frequently on the FYI bots, so filter it out for now. Bug: 836785 Change-Id: Id209d83a72e16a52cd7cc8b9281bf167a63cf636 Reviewed-on: https://chromium-review.googlesource.com/1068617Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#561561}
-
glevin authored
As per crbug.com/788025 and various other discussions: - Replace "Learn more" link with (?) button - Button has a11y text and is Tab stop - Update text to match crbug.com/721969 - Width = 448px - At present, NOT removing X (Close) button - Clean up code Bug: 788025 Test: Try to play HD content that requires device id / verification. Verify Harmoniousness of resultant dialog. Change-Id: Ibcc300a97b6f2edd49d822171467162500d9e859 Reviewed-on: https://chromium-review.googlesource.com/946907Reviewed-by:
-
Sahel Sharifymoghaddam authored
This reverts commit 63049f46. Reason for revert: I missed the nit comments on the test, I will reland the issue after addressing them. Original change's description: > Touchpad fling bubbling doesn't generate extra GSB. > > With browser side touchpad fling, the fling controller processes a GFS > and schedules fling progress. On flingProgress the controller generates > wheel events which get queued in the mouse wheel event queue(MWEQ). > > When we start wheel scrolling on an out of process iframe while it is > already at its extent the wheel events get processed in the MWEQ of the > child view but the generated gesture scroll events including the GFS get > bubbled to the parent view. When the GFS gets processed by the parent > view, the generated wheel events get queued in the MWEQ of the parent. > The MWEQ will generate a GSB for the first wheel event generated from > processing the fling since it is not aware of the GSB that is bubbled to > this view and it causes hitting this DCHECK: > https://cs.chromium.org/chromium/src/content/browser/renderer_host/render_widget_host_impl.cc?q=render_widget_host_impl&dr=C&l=1256 > > This cl changes the MWEQ to ask for the state of wheel scrolling from > RWHI rather than keeping its own state, this change will be also useful > for enabling touchpad fling boosting. > > Bug: 249063 > Test: SitePerProcessBrowserTest.TouchpadGestureFlingStart > Change-Id: I0c6faa81faa7f009517393440d6e37c7e7e6a053 > Reviewed-on: https://chromium-review.googlesource.com/1064792 > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561550} TBR=kenrb@chromium.org,tdresser@chromium.org,nzolghadr@chromium.org,sahel@chromium.org Change-Id: I485b5a1dee759ba0760acc4a5210fedd34346f10 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 249063 Reviewed-on: https://chromium-review.googlesource.com/1072108Reviewed-by:
Sahel Sharifymoghaddam <sahel@chromium.org> Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#561559}
-
John Chen authored
Fixes two race conditions in ChromeDriver's websocket code (for connecting to DevTools): * If a connection is made after SyncWebSocketImpl::Core::Connect has timedout and returned, lower level code can access stack variables that have already gone out of scope. * If a connection is closed right after it was opened, ChromeDriver might try to read from a closed socket. Bug: chromedriver:2431 Change-Id: I6895856256f610615f63220bc33c34bacab2eeda Reviewed-on: https://chromium-review.googlesource.com/1070571 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Jonathon Kereliuk <kereliuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#561558}
-
Pavel Feldman authored
Change-Id: I1411429de9f3bb92eae22c6911a4caeb4a2932f7 TBR: eseckler Reviewed-on: https://chromium-review.googlesource.com/1071874 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
-
Oystein Eftevaag authored
Chrome has seven #ifdefs that decide whether Perfetto tracing is available or not. This change consolidates those into two and then enables Perfetto on Windows. This change also updates two .gn files to enable Perfetto. This change makes no difference unless the command-line option --enable-features=TracingPerfettoBackend is specified. Note that this change will fail to run unless the Assert in Angle's AddTraceEvent function in event_tracer.cpp is removed. This is being investigated. Bug: 844421 Change-Id: Ia978eb69bed77bda68202fdbec7a306fdb9886bc Reviewed-on: https://chromium-review.googlesource.com/1064371 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#561556}
-
Hiroshige Hayashizaki authored
No behavior changes. Bug: 842349 Change-Id: Iebd91d4d0f98441fd613d7bc98e26e06767915cf Reviewed-on: https://chromium-review.googlesource.com/1056415 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#561555}
-
John Chen authored
Cleaning up navigation tracker code intended to support old browsers. Change-Id: Ifd1f317574866c9c1a37b7be199e77fad7a06627 Reviewed-on: https://chromium-review.googlesource.com/1066785Reviewed-by:
-
Greg Thompson authored
Instrumentation added in r556859 revealed that some deletes are failing because the thing-to-be-deleted isn't there. This here CL attempts to plug all holes in the delete logic so that this is treated as a condition for success. BUG=599084 R=gab@chromium.org Change-Id: I04e2c22ac49bc0bd7b7850b2d17abc72f3e05e7b Reviewed-on: https://chromium-review.googlesource.com/1071656 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
David Trainor authored
Add support for a BatchedListObservable. This is an implementation of ListObservable that incorporates the Android support library's BatchListUpdateCallback. This class has the following behavior: - It batches up all calls to insert, remove, or change based on whether or not the changes occur to adjacent elements. - It automatically flushes the updates when a non-adjacent or different type of operation occurs. - It supports manual flushing for when the batch operation is done by the caller. BUG=842345 Change-Id: I87dcd03ad31952582308a690fb3a3dab3a4fc26b Reviewed-on: https://chromium-review.googlesource.com/1070885 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#561552}
-
Raymond Toy authored
The trybots can now run AudioContext with a fake audio device if no audio HW is available. Change the MediaElementAudioSource tests to use an AudioContext instead of an OfflineAudioContext. This is the first step in moving the factory methods from BaseAudioContext to AudioContext. Bug: 845913 Change-Id: Id4fe3d7d1b943db25cf023940c541dfab2a01aed Reviewed-on: https://chromium-review.googlesource.com/1070217Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#561551}
-
Sahel Sharify authored
With browser side touchpad fling, the fling controller processes a GFS and schedules fling progress. On flingProgress the controller generates wheel events which get queued in the mouse wheel event queue(MWEQ). When we start wheel scrolling on an out of process iframe while it is already at its extent the wheel events get processed in the MWEQ of the child view but the generated gesture scroll events including the GFS get bubbled to the parent view. When the GFS gets processed by the parent view, the generated wheel events get queued in the MWEQ of the parent. The MWEQ will generate a GSB for the first wheel event generated from processing the fling since it is not aware of the GSB that is bubbled to this view and it causes hitting this DCHECK: https://cs.chromium.org/chromium/src/content/browser/renderer_host/render_widget_host_impl.cc?q=render_widget_host_impl&dr=C&l=1256 This cl changes the MWEQ to ask for the state of wheel scrolling from RWHI rather than keeping its own state, this change will be also useful for enabling touchpad fling boosting. Bug: 249063 Test: SitePerProcessBrowserTest.TouchpadGestureFlingStart Change-Id: I0c6faa81faa7f009517393440d6e37c7e7e6a053 Reviewed-on: https://chromium-review.googlesource.com/1064792Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#561550}
-
rbpotter authored
Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9b12f216b10de1c4479fb44f25d3e3450b903169 Reviewed-on: https://chromium-review.googlesource.com/1071767Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#561549}
-
Kyle Horimoto authored
This class encapsulates the parameters passed by clients of SecureChannel which are meant to be tightly coupled to an individual connection request. Encapulsulating these within a class makes clients of the relevant classes much less complex and allows PendingConnectionRequest and SingleClientMessageProxy to use the ID associated with the parameters. Bug: 824568, 752273 Change-Id: I9da3824fef3ede7727b5cdccb879ee2b49140807 Reviewed-on: https://chromium-review.googlesource.com/1070990 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
jonross authored
RenderWidgetHostViewGuestSurfaceTest.TestGuestSurface is obsolete once Viz has been enabled by default. This disables it in that state, with a note for me to delete it later. TEST=RenderWidgetHostViewGuestSurfaceTest.TestGuestSurface Bug: 762521 Change-Id: I647b1abe0d88d3b65aef5965dddada1d95b5de42 Reviewed-on: https://chromium-review.googlesource.com/1070215 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#561547}
-
John Abd-El-Malek authored
This reverts commit 9fedcd68. Reason for revert: fixed after r560938 Original change's description: > Disabling flaky test TestSBUpdateCookies > > Full test name: > SafeBrowsingDatabaseManagerCookieTest.TestSBUpdateCookies > > Link to failure: > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-xenial-rel/54 > > Bug: 842195 > Change-Id: I807a6815fc65e75b3023095d8abd875ad2cf3e14 > > TBR=jialiul@chromium.org > > Change-Id: I807a6815fc65e75b3023095d8abd875ad2cf3e14 > Reviewed-on: https://chromium-review.googlesource.com/1055618 > Reviewed-by: Tommy Martino <tmartino@chromium.org> > Commit-Queue: Tommy Martino <tmartino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557905} TBR=tmartino@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 842195 Change-Id: I1dfc6104223cc0ae27fb912d20befb98d77aa616 Reviewed-on: https://chromium-review.googlesource.com/1071848Reviewed-by:
-
Fernando Serboncini authored
Implemented with a Mojo sync API. Note that an alternate approach with WaitableEvent was attemped for this, but the fact that we need to wait on two IPCs, added a lot of complexity for thread hops for Mojo, and ends up being much more complicated. Bug: 838133 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id512c86b0df0ecba3ee9965801be916165d4c0cf Reviewed-on: https://chromium-review.googlesource.com/1043008 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#561545}
-
Krishna Govind authored
R=amineer@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I535a12727501c4a723ef1c0f2754bfcee64b6348 Reviewed-on: https://chromium-review.googlesource.com/1072043Reviewed-by:
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2a12b3d585a8..22a5f5f01f70 $ git log 2a12b3d58..22a5f5f01 --date=short --no-merges --format='%ad %ae %s' 2018-05-23 geofflang Make sure to destroy all resources in DisplayWGL if initialization fails. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=lucferron@chromium.org Change-Id: I2b4def80be7a23e4163a8806c118dab9c88c6634 Reviewed-on: https://chromium-review.googlesource.com/1071717 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561543}
-
Minh X. Nguyen authored
This would allow the template function to be used in other modules without depending on chrome\browser\. This is a reupload of reverted cl 1070669, which had a compiler error in Linux. Change-Id: I0904635d9ec71e91053962d1bfcc16489a68be43 Reviewed-on: https://chromium-review.googlesource.com/1071007Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Minh Nguyen <mxnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#561542}
-
Edward Jung authored
Change-Id: I3f76e2ec46f199c1ce905f5a52de66ea67a23459 Reviewed-on: https://chromium-review.googlesource.com/1071516Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Edward Jung <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#561541}
-
Dmitry Gozman authored
- Provide WebMenuItemInfo directly from ContextMenuProvider. - Combine most methods in ContextMenuController to a single ShowContextMenu. - Do not store ContextMenu instance in ContextMenuController. - Remove ContextMenu and ContextMenuItem classes. Change-Id: Ibb395d304a0a4dfa86087b1d062141f788a00091 Reviewed-on: https://chromium-review.googlesource.com/1068246 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#561540}
-
Elly Fong-Jones authored
This test is broken because of the issues with MacViews keyboard event dispatch, as tracked in the linked bug. TBR=rockot@chromium.org Bug: 845503 Change-Id: Ia5aba0918fb16cb5d2271bcbbd7bcc8bab1b015b Reviewed-on: https://chromium-review.googlesource.com/1071693 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
David Trainor authored
Add an OfflineItemList to wrap an OfflineItemFilterSource. This list will (1) sort the items and (2) add date headers for each day items are seen. BUG=842345 Change-Id: Ib1b0ee15b7431416934ee8e037f58ed055d090b5 Reviewed-on: https://chromium-review.googlesource.com/1069677Reviewed-by:
-
