- 20 Sep, 2018 40 commits
-
-
Ben Kelly authored
R=jsbell@chromium.org, rkaplow@chromium.org Bug: 886898 Change-Id: I7519c327419c81b5eeb9dd83ac17850114a3795f Reviewed-on: https://chromium-review.googlesource.com/1234636 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#592962}
-
Dave Gash authored
Update declarative_content.json docs for minor language and formatting Bug: none Change-Id: I254f52f83b42844559da1277070e53ba060153c0 Reviewed-on: https://chromium-review.googlesource.com/1225859Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Meggin Kearney <mkearney@chromium.org> Cr-Commit-Position: refs/heads/master@{#592961}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7b11354810a9..268707284dcd git log 7b11354810a9..268707284dcd --date=short --no-merges --format='%ad %ae %s' 2018-09-20 fmalita@chromium.org [skottie] GM exercising external font loading 2018-09-20 mtklein@google.com send SkPMColor::toPMColor() through Sk4f_toL32() 2018-09-20 robertphillips@google.com Disable LCD text when drawing SkPictureImageFilter content 2018-09-20 brianosman@google.com Always use portable fonts in image filter test 2018-09-20 mtklein@google.com add interp-in-premul case to GM 2018-09-20 jvanverth@google.com Add new PolyUtils benches 2018-09-20 halcanary@google.com SkDocument: Factories now located in SkPDFDocument.h and SkXPSDocument.h 2018-09-20 halcanary@google.com SkPDF: draw persepctive rectangles 2018-09-20 brianosman@google.com Some SkPM4f cleanup 2018-09-20 bungeman@google.com Remove SkAutoTCallIProc. 2018-09-20 mtklein@google.com have SkConvertPixels use SkColorSpaceXformSteps 2018-09-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 d511948b9f82..52ea49706fd7 (1 commits) 2018-09-20 brianosman@google.com Fix/simplify equal_pixels 2018-09-20 halcanary@google.com Document headers: IWYU 2018-09-20 jcgregorio@google.com Use new build targets in continuous build of skottie and debugger. 2018-09-20 brianosman@google.com Remove (unused) GrBlend.cpp, and some GrColor helpers Created with: gclient setdep -r src/third_party/skia@268707284dcd The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:878874,chromium:884150 TBR=reed@chromium.org Change-Id: Ic7fa8bc7070238dfbb1d7c014446989ed87ecfaa Reviewed-on: https://chromium-review.googlesource.com/1236881Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592960}
-
Alex Oldemeier authored
Add a user policy for Crostini usage logging which is disabled by default. If this policy is active, log a time window for the last app launch and the used Termina version in prefs. Report these in DeviceStatusCollector. Bug: 844468, 883634 Test: Run unit and browser tests. Change-Id: I90ba296c9284b987829f8907283873c8213fad9f Reviewed-on: https://chromium-review.googlesource.com/1221947 Commit-Queue: Alex Oldemeier <aoldemeier@chromium.org> Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#592959}
-
mrefaat authored
The problem is we discard the last committed item, if the request was blocked, instead we should only discard that when the last item was not native view. Bug: 881690 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I3de1649da8a4d1c198c7f5386cfeb2ef3608033a Reviewed-on: https://chromium-review.googlesource.com/1234953 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#592958}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d8dcf93795bb..b20563f5defb Created with: gclient setdep -r src-internal@b20563f5defb The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id355f77748012995e160a11e54d4a93a10657a4c Reviewed-on: https://chromium-review.googlesource.com/1236484Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592957}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3d81f7cc222b..b0768af22643 git log 3d81f7cc222b..b0768af22643 --date=short --no-merges --format='%ad %ae %s' 2018-09-20 benjhayden@chromium.org Fix /api/report/template 2018-09-20 bsheedy@chromium.org Add force commit to SharedPrefs 2018-09-20 wangge@google.com Add function to run benchmark both locally and on swarming. Created with: gclient setdep -r src/third_party/catapult@b0768af22643 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:887579,chromium:863390 TBR=sullivan@chromium.org Change-Id: I0052555ff9d1cd652448e2b3af79e37681de72e0 Reviewed-on: https://chromium-review.googlesource.com/1236883Reviewed-by:
-
Gina Ko authored
Bug: internal b/115749837 Change-Id: I4f0b21097081415956f1b386f68916b50fd8de82 Reviewed-on: https://chromium-review.googlesource.com/1235289 Commit-Queue: Yi-Chun Gina Ko <yichunko@google.com> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#592955}
-
John Budorick authored
Bug: 794372 Change-Id: I6b6d81ab0c72fd1b781d03e242f78ddef24fef95 Reviewed-on: https://chromium-review.googlesource.com/1235015Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#592954}
-
Jun Mukai authored
LoginCursorTest.CursorHidden and OobeTest.Accelerator are still crashing even after the refactoring of UIControls and aura::Env. Actually, these tests do not require browser windows therefore UIControlsOzone is created with nullptr WindowTreeHost which is not expected. Thinking about that, such test cases actually do controls for the UI within Ash -- therefore AshUIControls should be used. Test: interactive_ui_tests with --enable-features=SingleProcessMash Bug: 883523 Change-Id: I3d6e1ecb569551a7eacfce979c4b543771f19fc6 Reviewed-on: https://chromium-review.googlesource.com/1236842Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#592953}
-
Christian Biesinger authored
Now that constraint spaces are stack allocated, there's no point in having the builder be separate from the constructor. We can avoid some duplication and just directly initialize the members from the builder. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I5470a1be7e0f6e82f93af3fa263cc642e1d8cfbe Reviewed-on: https://chromium-review.googlesource.com/1235216 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#592952}
-
Mark Pearson authored
I think this codifies the results of our discussion. Is this the right place to put this content? Do I need reminders of it elsewhere (i.e., in the status or owners sections)? Change-Id: Icfeb6551515727f02d0cb83450008ad77ed0275d Reviewed-on: https://chromium-review.googlesource.com/1232523Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#592951}
-
Gang Wu authored
Enable content and journal storage in FeedProcessScopeFactory.java. Also fix type mismatch issue in Journal bridge, and handle empty content mutation case. Bug: 887116 Change-Id: I9333beb9141aab7a96e87d90baa8bef788b0b5e4 Reviewed-on: https://chromium-review.googlesource.com/1234263Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#592950}
-
Lan Wei authored
Add NoHoverAfterLayoutChange to base::Feature, so that we can run finch experiment on this feature to see if there is any performance improvement. Bug: 877132 Change-Id: Id1048757f7f48bc1be68787347d5594644b9ac38 Reviewed-on: https://chromium-review.googlesource.com/1234036Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#592949}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/713f53360e2e..6dd0074561b7 git log 713f53360e2e..6dd0074561b7 --date=short --no-merges --format='%ad %ae %s' 2018-09-20 dgarrett@google.com manifest_version: Commit new buildspecs. 2018-09-20 achuith@chromium.org metadata_lib: Pretty print metadata.json 2018-09-20 dgarrett@google.com CIDB: Update readme docs. 2018-09-20 dgarrett@google.com CIDB: Add branch column to buildtable. 2018-09-20 chingcodes@google.com signing: Add Mock Signer commands for Firmware signers Created with: gclient setdep -r src/third_party/chromite@6dd0074561b7 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I11cbc35a8669774dfc8e435c11a130e04becf0c7 Reviewed-on: https://chromium-review.googlesource.com/1236483Reviewed-by:
-
Robert Liao authored
Material refresh is now on by default. BUG=876090 Change-Id: I308da4d0ed5a4df6dc7104a573ed9063151caab0 Reviewed-on: https://chromium-review.googlesource.com/1229175 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#592947}
-
Robbie McElrath authored
This migrates DomainReliabilityMonitor from NetworkChangeManager to NetworkConnectionTracker, which works with the network service enabled. Bug: 887027 Change-Id: Icc22466c2272bdc45978218d1443c77810e7f663 Reviewed-on: https://chromium-review.googlesource.com/1234855Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#592946}
-
Karan Bhatia authored
r591131 unified code to close the overflow menu from the ui/layer, deleting MediaRouterActionPlatformDelegate::CloseOverflowMenuIfOpen, removing the need for a delegate. This CL removes the delegate interface and its implementations. It should have no behavior change. BUG=None Change-Id: I54bba038673c6fbba2b84aa17ad63f4c9ed7e229 Reviewed-on: https://chromium-review.googlesource.com/1229776Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#592945}
-
yiyix authored
Change-Id: Ie83fb3f96f0d914a002fdcb9461066a2a29f5abe Reviewed-on: https://chromium-review.googlesource.com/1231376Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#592944}
-
Evan Stade authored
Bug: 883072 Change-Id: I24380dc595a7446e463422848916b73845945861 Reviewed-on: https://chromium-review.googlesource.com/1227357Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/52ea49706fd7..4ce287e04201 git log 52ea49706fd7..4ce287e04201 --date=short --no-merges --format='%ad %ae %s' 2018-09-20 ianelliott@google.com Change the name of the opt'ed-in app from maps to cubey. Created with: gclient setdep -r src/third_party/angle@4ce287e04201 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I17c7fff9689dbdccf4e92a0e8b1baa24f65d03c1 Reviewed-on: https://chromium-review.googlesource.com/1236882Reviewed-by:
-
mark a. foltz authored
You can't run Views browsertests on Mac when views browser windows are disabled. TBR=imcheng@chromium.org Bug: 883976 Change-Id: I4d318db3f58743f543e278f744e3926d6e9076e4 Reviewed-on: https://chromium-review.googlesource.com/1237151Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#592941}
-
Nico Weber authored
Bug: 832676 Change-Id: I7a307c33ad6daf44cc2c170829f03cfdc488da4b Reviewed-on: https://chromium-review.googlesource.com/1236177Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#592940}
-
Sarah Hu authored
Bug: 882588 Change-Id: I4f12426d6e2027640a6645cac9bd6b62b1a34fc5 Reviewed-on: https://chromium-review.googlesource.com/1232478Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Cr-Commit-Position: refs/heads/master@{#592939}
-
Richard Townsend authored
Fixes an uninitialised variable caught by MSAN. This reverts commit 66a74d2f. Change-Id: I1e896476fe201fb05072970220bab5c3b20588a2 Reviewed-on: https://chromium-review.googlesource.com/1233746 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#592938}
-
Justin Cohen authored
This reverts commit fbe67a95. Reason for revert: Breaks TabSwitcherTransitionTestCase\testRotationsWhileSwitcherIsNotActive Original change's description: > [ios] Fix VoiceOver Issues in Tabgrid > > - Updates _currentPage properly in response to 3-finger accessibility swipe. This will now properly read out the currently visible page if a user swipes to a different page. > - Ensures that only the currently visible page's elements can be selected in the scroll view. This resolves an issue VoiceOver was having with what page to readout and to focus on. Oftentimes the visible page was not readout or selectable. > > Video: https://drive.google.com/open?id=1Q62MUlrVcNlqnFIQOfw_YiGHinTKb_45 > > Bug: 880079 > Change-Id: I0696786292bec375af9d5326a790700000114559 > Reviewed-on: https://chromium-review.googlesource.com/1221474 > Commit-Queue: Chris Lu <thegreenfrog@chromium.org> > Reviewed-by: Mark Cogan <marq@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592818} TBR=marq@chromium.org,thegreenfrog@chromium.org Change-Id: Idb378ca1c1a1405275975e47956ac94d09865ab1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 880079 Reviewed-on: https://chromium-review.googlesource.com/1237174Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#592937}
-
Sunny Sachanandani authored
Send an early DidNotProduceFrame if the scheduler uses a late deadline, and no new frame is expected. The DisplayScheduler uses this as a signal to draw if other producers have submitted frames. This is intended as a short-term fix to solve smoothness issues with surface for video with 30fps videos. Ideally the DisplayCompositor will have some followups as well so that one client that is slow to respond will not cause smoothness issues with another client. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Icf2f067dd08836de24ea5d0cdc896dc433062d5c Bug: 874676 Reviewed-on: https://chromium-review.googlesource.com/1211917 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#592936}
-
Tommy C. Li authored
Bug: NONE Change-Id: Ibb8098e156f63a43b82b25d4ba84f43002d27911 Reviewed-on: https://chromium-review.googlesource.com/1236927 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#592935}
-
Paul Miller authored
Chrome uses IsFetchingEnabled() to enable getting the seed under any of these conditions: • is_chrome_branded • --variations-server-url • g_should_fetch_for_testing Chrome also enables the test config if none of these conditions are met: • fieldtrial_testing_like_official_build • is_chrome_branded • --disable-field-trial-config • --force-fieldtrials • --variations-server-url (See VariationsFieldTrialCreator::SetupFieldTrials().) So by default (is_chrome_branded=false), the seed will be disabled and the test config will be enabled. In the released builds (is_chrome_branded=true), the seed will be enabled and the test config will be disabled. But depending on flags and build args, it's possible to enable both. The same experiment in both places will then be added twice, hitting a DCHECK in FeatureList::RegisterFieldTrialOverride(). WebView shares the same conditions for enabling the test config, but before this change, would always use the seed as well, since WebView doesn't call IsFetchingEnabled(). BUG=884827 Change-Id: I3b8281a3a44ebbae894e744fc0a84d6d1f94a0d4 Reviewed-on: https://chromium-review.googlesource.com/1228913 Commit-Queue: Paul Miller <paulmiller@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#592934}
-
Matthew Jones authored
This patch fixes some ambiguous wording for light/dark mode icons in favor of incognito/normal and flips the incorrect accessibility text labels. This patch also makes buttons with no drawable invisible so accessibility does not try to focus them. Bug: 887001, 887010 Change-Id: Ie7ae4461035064d3aeac5c929fc9f3eb1296bbcd Reviewed-on: https://chromium-review.googlesource.com/1235203 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#592933}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a7a0a5198543..d8dcf93795bb Created with: gclient setdep -r src-internal@d8dcf93795bb The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I0b32a37c27b13416ab8e6dc6e70d5086f3e69258 Reviewed-on: https://chromium-review.googlesource.com/1236481Reviewed-by:
-
Josh Karlin authored
Removes a metric that showed the resources loaded in non-ad frames. This was never referenced so it's time to remove it. Bug: 884233 Change-Id: Icc3522b515d757f4b58c30edcf7373da98453423 Reviewed-on: https://chromium-review.googlesource.com/1233937 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
-
Mike Klein authored
We noticed recently on the Skia tree that if we build Chromium's zlib with GCC, -O3, -m32, and -msse2, deflateInit2_() crashes. Might also need -fPIC... not sure. I tracked this down to a `movaps` (16-byte aligned store) to an address that was only 8-byte aligned. This address was somewhere in the middle of the deflate_state struct that deflateInit2_()'s job is to initialize. That deflate_state struct `s` is allocated using ZALLOC, which calls any user supplied zalloc if set, or the default if not. Neither one of these has any special alignment contract, so generally they'll tend to be 2*sizeof(void*) aligned. On 32-bit builds, that's 8-byte aligned. But because we've annotated crc0 as zalign(16), the natural alignment of the whole struct is 16-byte, and a compiler like GCC can feel free to use 16-byte aligned stores to parts of the struct that are 16-byte aligned, like the beginning, crc0, or any other part before or after crc0 that happens to fall on a 16-byte boundary. With -O3 and -msse2, GCC does exactly that, writing a few of the fields with one 16-byte store. The fix is simply to remove zalign(16). All the code that manipulates this field was actually already using unaligned loads and stores. You can see it all right at the top of crc_folding.c, CRC_LOAD and CRC_SAVE. This bug comes from the Intel performance patches we landed a few years ago, and isn't present in upstream zlib, Android's zlib, or Google's internal zlib. It doesn't seem to be tickled by Clang, and won't happen on 64-bit GCC builds: zalloc is likely 16-byte aligned there. I _think_ it's possible for it to trigger on non-x86 32-bit builds with GCC, but haven't tested that. I also have not tested MSVC. The moved comment is entirely to appease git cl format. Change-Id: Ie2d8eb9ddefa1e35e6d21ee4b29797f6949b0687 Reviewed-on: https://chromium-review.googlesource.com/1236613Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#592930}
-
Xiaohui Chen authored
Bug: b:115397214 Test: locally build and test Change-Id: Ia7ccdd15906bb195e766f5a93db9e0ed2c0039ca Reviewed-on: https://chromium-review.googlesource.com/1220812Reviewed-by:
Muyuan Li <muyuanli@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#592929}
-
Michael Thiessen authored
A downstream project wants to exclude hdpi and higher density resources, so I figured I'd land support here to reduce rebase burden. Change-Id: I780b09703f822f455912ac9a119acb3dd56112bb Reviewed-on: https://chromium-review.googlesource.com/1234221Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
-
mrefaat authored
Create a field trail entry before experimenting with 50% Beta Bug: 850760 Change-Id: Ie2796f43a0443ac8bc8a77ac2db8057b32d989d2 Reviewed-on: https://chromium-review.googlesource.com/1234356Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#592927}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e6dfe41ffa6e..7397af8da50b git log e6dfe41ffa6e..7397af8da50b --date=short --no-merges --format='%ad %ae %s' 2018-09-20 primiano@google.com Merge "Add performance debug mode" Created with: gclient setdep -r src/third_party/perfetto@7397af8da50b The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ib7a81bba65f5872420a79431273549ac288d1889 Reviewed-on: https://chromium-review.googlesource.com/1236482Reviewed-by:
-
Madeleine Barowsky authored
Bug: no bug Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If0f518894dd1264931e224f5103f2d6f75e343cd Reviewed-on: https://chromium-review.googlesource.com/1236674Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org> Cr-Commit-Position: refs/heads/master@{#592925}
-
Joshua Peraza authored
9ae453628f50 android: handle RELRO sharing by the Chromium linker 688dcfa22ee9 android: handle modules loaded from zipfiles Change-Id: Ib295fb1e0f0571c38f9bf5603eda349b9f8e15da Reviewed-on: https://chromium-review.googlesource.com/1236467Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#592924}
-
Zhenyao Mo authored
We still see a bit of hang at buffer_manager() destruction, which is the beginning of ContextGroup destruction. So we add a few pokes in context destruction before the ContextGroup destruction. BUG=749046 TEST=crash reports go down R=piman@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4726e63f2cf4fa5c1471a25ef65f8d8ac9411c09 Reviewed-on: https://chromium-review.googlesource.com/1237114Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#592923}
-
