- 18 Sep, 2018 40 commits
-
-
Takashi Toyoshima authored
Current KeywordOrderingAndDescriptions test does not use TestURLLoaderFactory and it results in making actual network requests. This causes a DCHECK failure that says network code runs not on the IO thread. This does not actually happen on TOT, but when OOR-CORS feature is enabled, it happens. This patch makes the test use TestAutocompleteProviderClient instead of ChromeAutocompleteProviderClient so to use TestURLLoaderFactory that avoid making actual requests. Bug: 870173 Change-Id: Ifb02d36b3c9be35c99037350e9676a671f948f6f Reviewed-on: https://chromium-review.googlesource.com/1226672Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#591952}
-
Ulan Degenbaev authored
Bug: 878390 Change-Id: I3acc35c0639859e958247b9510b8cfbe1a71f680 Reviewed-on: https://chromium-review.googlesource.com/1217038 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#591951}
-
Findit authored
This reverts commit 052bac3d. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 591916 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzA1MmJhYzNkNWEzMDM0NTg2M2IwMTJhOTc4YTc4YWQ3N2JmY2RjNmQM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/29026 Sample Failed Step: browser_tests Original change's description: > CrOS FilesApp: Fix error messages in integration tests > > Mounted volume without a request: crostini:Crostini: > * This is basically what happens when you pull out a USB without > clicking unmount. This message is harmless, but the code is changed > to stop it anyway. > * Message fixed to state 'Unmounted ...' since the error happens at unmount. > * Changed test to call FMP.unmount and added logic into private_api_mount.cc > to remove crostini mount. > * Removed unmountCrostini test function which is no longer needed. > > Error in event handler: TypeError: Cannot read property 'volumeType' of null: > * This error happens when crostini is unmounted and the directory changes > back to Downloads. banners.js fixed to guard for the case where the > volume is now removed and VolumeManager.getLocationInfo returns null. > > Bug: 883571 > Change-Id: I13c0bee7f514dfc318eaa12f4c1ef1c2186e7a70 > Reviewed-on: https://chromium-review.googlesource.com/1227864 > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > Reviewed-by: Noel Gordon <noel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#591916} Change-Id: I419e792b050f4a991bfe435907e7fc5b2d45311e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 883571 Reviewed-on: https://chromium-review.googlesource.com/1229619 Cr-Commit-Position: refs/heads/master@{#591950}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/89652a35ebc4..95277a300f52 git log 89652a35ebc4..95277a300f52 --date=short --no-merges --format='%ad %ae %s' 2018-09-18 jie.a.chen@intel.com ES31: Add DispatchComputeIndirect support for D3D11 Created with: gclient setdep -r src/third_party/angle@95277a300f52 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I2d1e1c7889ba0f534f86559da76e698e10026d80 Reviewed-on: https://chromium-review.googlesource.com/1229511Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#591949}
-
Ben Wagner authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/9789c75b1a6f..dfddc2d97596 $ git log 9789c75b1..dfddc2d97 --date=short --no-merges --format='%ad %ae %s' 2018-09-17 wl [pshinter] Handle numeric overflow. 2018-09-16 wl freetype.h: Add warning w.r.t. B/W hinting and rendering (#54589). 2018-09-15 wl [sfnt] Comment fix. 2018-09-13 wl [truetype] Some fixes for VF checks. 2018-09-13 wl * src/sfnt/sfdriver.c (sfnt_get_var_ps_name): Fix last commit. 2018-09-13 wl * src/sfnt/sfdriver.c (sfnt_get_var_ps_name): Check `result'. 2018-09-12 John.Tytgat [sfnt] Better PS name handling (#54629). 2018-09-12 wl [truetype] Improve VF check. 2018-09-12 wl * src/truetype/ttgxvar.c (ft_var_load_gvar): Check `glyphoffsets'. 2018-09-10 prince.cherusker * src/pshinter/pshrec.c (t2_hints_stems): Mask numeric overflow. 2018-09-09 wl [sfnt] Comment improvement. 2018-09-09 bungeman * builds/freetype.mk (refdoc-venv): Ensure python version (#54631). 2018-09-07 wl Typo. 2018-09-07 wl [truetype] Fix assertion failure. 2018-09-05 wl Synchronize `ftdebug.c' files. 2018-09-05 wl Synchronize `ftconfig' files. 2018-09-05 ramakrishnan.nikhil * docs/DOCGUIDE: Minor. 2018-09-05 ramakrishnan.nikhil Add documentation guidelines file. 2018-09-04 wl * devel/ftoption.h: Synchronize with master `ftoption.h'. 2018-09-04 wl Typo (#54618). Created with: roll-dep src/third_party/freetype/src R=bungeman@chromium.org,drott@chromium.org CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng PDFium-Issue: pdfium:1153 Change-Id: I7414d61999f20047d32949812511b1fc840e262e Reviewed-on: https://chromium-review.googlesource.com/1228613Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#591948}
-
Peter Wen authored
Use stability.gpu_crash_count in the system_profile proto to track gpu crash metrics rather than a variety of changing gpu histograms. This new proto value is only used on Android starting in M71 and tracks the same value as the histogram: "Stability.Android.ProcessedCrashCounts.All GPU process crashes" Thus this unifies our gpu metrics across stability proto, UMA histogram, and crash reports, since these all count the number of crashes with a valid crash dump (note that crash reports only include the number that are successfully processed and uploaded, so should be slightly reduced). Bug: 839017 Change-Id: If836b4fc8c8390ce008b7089a773af0b26ea6c10 Reviewed-on: https://chromium-review.googlesource.com/1228546 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#591947}
-
Rijubrata Bhaumik authored
This CL adds exposureTime to ImageCapture API. Spec discussion: https://github.com/w3c/mediacapture-image/issues/199 This was added to the spec in https://github.com/w3c/mediacapture-image/pull/200 Layout tests and mock tests are updated to support the same. Support for Android is added. TEST= run the demo in https://codepen.io/rijuB/pen/eKwLXB use slider to change exposureTime. BUG=823316 Intent to Implement and Ship discussions: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/ls3wQSoHOUY Change-Id: Ic3a546d734c02df31cd8ca08ece01f006ae8d906 Reviewed-on: https://chromium-review.googlesource.com/1136439Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#591946}
-
Darren Shen authored
There are some existing keyboard "end to end" tests, where a web page is loaded along with the open source keyboard extension. We refactor the tests a bit so that different web pages can be used for different tests and split/added a few more tests. Bug: 849995 Change-Id: I87e41b8df3b2210a95e233a9bc9f789c9181b5b3 Reviewed-on: https://chromium-review.googlesource.com/1214971Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#591945}
-
Shao-Chuan Lee authored
Bug: 866326 Change-Id: I8b9b65b4aee737707426ae3b103bd1ea8a866e27 Reviewed-on: https://chromium-review.googlesource.com/1223594 Commit-Queue: Shao-Chuan Lee <shaochuan@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Maajid <maajid@chromium.org> Cr-Commit-Position: refs/heads/master@{#591944}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/460fd889fcdb..934a29ea903e git log 460fd889fcdb..934a29ea903e --date=short --no-merges --format='%ad %ae %s' 2018-09-18 benjhayden@chromium.org Add expand-button for v2spa Created with: gclient setdep -r src/third_party/catapult@934a29ea903e The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ibdf83e3e91c43eb00ed8212abddb4aac073ff1f1 Reviewed-on: https://chromium-review.googlesource.com/1229775Reviewed-by:
-
Kunihiko Sakamoto authored
Bug: 863305 Change-Id: Ifd46182aa91c9006b5881b3df8348fe47a1fa057 Reviewed-on: https://chromium-review.googlesource.com/1226757Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
-
Xiaohan Wang authored
These are not used after deprecating PPAPI CDM support. Bug: 772160 Change-Id: I95370a698773a7c27cc38ad331670263877c77e7 Reviewed-on: https://chromium-review.googlesource.com/1228509Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#591941}
-
Xiaohan Wang authored
Conversion code is added to support multiple CDM interfaces that use different version of cdm::VideoDecoderConfig and cdm::VideoFrame. Bug: 854943 Change-Id: I235c12805aea3191f8a5153c9a124f6fe3b26a31 Reviewed-on: https://chromium-review.googlesource.com/1227489 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#591940}
-
Hayato Ito authored
Chromestatus entry is here: https://www.chromestatus.com/feature/5636327009681408 Per the discussion of https://github.com/whatwg/dom/issues/685, Blink will try to align the event dispatch behavior with other browsers; Call capture event listeners in capturing phase at shadow hosts. So far, Blink and WebKit call capture event listeners in *bubbling* phase, instead of *capturing* phase, at shadow hosts. Other browsers: - Safari: Will try to change the behavior in the next Safari Technical Preview. - Firefox: Already implemented the new behavior - Edge: Strong public support for the new behavior. This change is guard by CallCaptureListenersAtCapturePhaseAtShadowHosts flag, which is disabled at this moment, to confirm that this CL doesn't cause any behavior change when the flag is disabled. This CL adds a wpt for new behavior, which is now marked as [Failure] in Blink. After this CL lands, I will flip the flag in a follow-up CL, with rebasing a very few existing tests. BUG=883650 Change-Id: I29938840aed4f3430d8b749cd4843176b8668b5d Reviewed-on: https://chromium-review.googlesource.com/1212255 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#591939}
-
Tatsuhisa Yamaguchi authored
Bug: 870409 Test: manual test on device w/ enterprise enrollment Change-Id: I70e667c1ab4f6761a4cb32b73081b6c7fe2a50af Reviewed-on: https://chromium-review.googlesource.com/1215483 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#591938}
-
Krishna Govind authored
R=kariah@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ideaccacb4a2ab5db2ef9c6d2c212826c5a25d0b6 Reviewed-on: https://chromium-review.googlesource.com/1228996Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#591937}
-
David Tseng authored
Likely a typo. We don't want to just replace one occurance, but all occurances. Test: type inside of a Gmail content editable. At some point, type several spaces in succession. Observe nbsps being inserted by Gmail. Start arrowing around and verify characters are read. Change-Id: Ibd0629b5f99f5b7ba07f068ea6965fefc4f4b426 Reviewed-on: https://chromium-review.googlesource.com/1228992Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#591936}
-
Noel Gordon authored
DOMContentLoaded can fire before the addEventListener is installed, so setup the listener per convention: test "document.readyState" and then install the event listener if needed. Per the HTML DOM spec, DOMContentLoaded fires on document, not window, so install the event listener on document. Test: browser_tests --gtest_filter="AudioPlayerBrowserTest*" Bug: 884963 Change-Id: I0c8168dd4869d16ccfdf7dd01513d3921fe45c9b Reviewed-on: https://chromium-review.googlesource.com/1229713Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#591935}
-
Shao-Chuan Lee authored
Bug: 866326 Change-Id: I4832e39d9bd4e82ae70e47f24dc62c5d8d3aafa6 Reviewed-on: https://chromium-review.googlesource.com/1223553 Commit-Queue: Shao-Chuan Lee <shaochuan@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#591934}
-
Kunihiko Sakamoto authored
This will be used for UMA reporting. Design doc: https://docs.google.com/document/d/1kzQRLybaUk12UgG8YTyACwNZ7tpcXwdjzPXU3CV25J8/edit Bug: 863305 Change-Id: I5a302d833cb3f308ed9617819f65c6dd3f98ab70 Reviewed-on: https://chromium-review.googlesource.com/1226756Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/4c3b4aa6d1df..debba6d2124e git log 4c3b4aa6d1df..debba6d2124e --date=short --no-merges --format='%ad %ae %s' 2018-09-18 thestig@chromium.org Roll third_party/freetype/src/ f8af8fba7..dfddc2d97 (14 commits) 2018-09-17 tsepez@chromium.org Make fxcrt::Retainable non-copyable. 2018-09-17 thestig@chromium.org Check for empty streams earlier in CPDF_StreamAcc::LoadAllData(). 2018-09-17 tsepez@chromium.org Replace CJS_GlobalVariableArray::Copy() with operator=(). Created with: gclient setdep -r src/third_party/pdfium@debba6d2124e The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I79b1fc3fb7f8924c019172d294d8f6c00eac0fc6 Reviewed-on: https://chromium-review.googlesource.com/1229505Reviewed-by:
-
Anand K. Mistry authored
storage::ShareableFileReference is a non-threadsafe ref-counted object, and therefore all refcounts must be done on the IO thread. This change splits all file reference tracking into a helper class that lives on the IO thread, to ensure non-racy refcounting. BUG=None Change-Id: Icd3dad5ee6518a6476f5644ed8df222750cca562 Reviewed-on: https://chromium-review.googlesource.com/1220850Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#591931}
-
Sungguk Lim authored
As color strings used by themes renamed(kColorTable->kOverwritableColorTable), the corresponding theme doc should be updated. Bug: None Change-Id: I67684c050b92b52cf7914c6731b0fad593a0106f Reviewed-on: https://chromium-review.googlesource.com/1226719Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Sungguk Lim <limasdf@gmail.com> Cr-Commit-Position: refs/heads/master@{#591930}
-
Siddhartha authored
Bug: 859260 Change-Id: I808dd3fe090aa9ba346906160bcd2468841d07ff Reviewed-on: https://chromium-review.googlesource.com/1229195 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#591929}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ea4301e5c5d2..f9b4845975ff git log ea4301e5c5d2..f9b4845975ff --date=short --no-merges --format='%ad %ae %s' 2018-09-18 vadimsh@chromium.org [cipd] Bump CIPD client version to 2.2.8, add presubmit check for *.digests. Created with: gclient setdep -r src/third_party/depot_tools@f9b4845975ff The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:821194,chromium:870166 TBR=agable@chromium.org Change-Id: I87d0b91a9894ec790a266a0ff346538b7a0dbc65 Reviewed-on: https://chromium-review.googlesource.com/1229503Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromiue.org Change-Id: I0b1618faed05d2adc8df81dc2d05cd120065296a Reviewed-on: https://chromium-review.googlesource.com/1229246Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#591927}
-
Brian Salomon authored
Bug: 883507 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0918e4b87265acc7367f07e3f7b95c4d8d67851c Reviewed-on: https://chromium-review.googlesource.com/1224676Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#591926}
-
Khushal authored
ServiceFontManager currently assumes that it should only be used from the same thread. While this is true in the case where there is a GPU process, and skia font cache usage is limited to the GPU main thread, this is not true for in process gpu. Update ServiceFontManager to allow use from multiple threads. R=ericrk@chromium.org Bug: 882549 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I58d4200f08c5ac92150129ead8ad1a09efc6d8a9 Reviewed-on: https://chromium-review.googlesource.com/1227593 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
-
Jeffrey Kardatzke authored
This modifies the private autotest API so that when it sets Crostini to be enabled that it also notifies the CrostiniRestarter that it should skip its restart phases. This will enable testing of features that integrate into the Chrome launcher without having to invoke the slower Crostini startup process that Chrome uses. BUG=chromium:849438 TEST=Verified on eve that launcher apps can start after this Change-Id: Ieaf9f8d41b8e077fc0ae44bae5ec12da9dcfcf92 Reviewed-on: https://chromium-review.googlesource.com/1227185Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#591924}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9f7d7304ef4c..460fd889fcdb git log 9f7d7304ef4c..460fd889fcdb --date=short --no-merges --format='%ad %ae %s' 2018-09-18 simonhatch@chromium.org Dashboard - Add new linux perf fyi name to Pinpoint approved list. Created with: gclient setdep -r src/third_party/catapult@460fd889fcdb The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:884388 TBR=sullivan@chromium.org Change-Id: Ia29a7ddba3fbaeba848978495ca1814e00f77b71 Reviewed-on: https://chromium-review.googlesource.com/1229507Reviewed-by:
-
Brian Salomon authored
Bug: 883507 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I76f00baa70afd29585f2d4f3a71aa2a05126a4a9 Reviewed-on: https://chromium-review.googlesource.com/1224674 Commit-Queue: Brian Salomon <bsalomon@google.com> Reviewed-by:
-
Erik Luo authored
- Console Sidebar's icons are now masks, use the same background color as other navigator icons. - Inactive selections used to have the exact same color as toolbar backgrounds, which made them invisible. Now inactive selections in dark theme are brighter. Light (l in hsl) values in dark theme for: ElementsTreeOutline > Navigators/Sidebars > Inactive tree selections Before: 14% > 20% > 20% After: 14% > 20% > 29% Screenshot: https://imgur.com/a/Dn4e1Hv Bug: none Change-Id: I1caf8e53a58352a92d3efc143c55b274246253b6 Reviewed-on: https://chromium-review.googlesource.com/1229196Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#591921}
-
Christopher Cameron authored
Create a views_bridge_mac::mojom::BridgedFactory interface to create remote views_bridge_mac::mojom::BridgedNativeWidget instances. The chrome::mojom::AppShim interface will be updated in a follow-on patch to have a method to provide a BridgedFactory instance. Create a views_bridge_mac::mojom::BridgeFactoryImpl to instantiate in the app shim process, to own the bridges. Add a CreateWindow method to views_bridge_mac::mojom::BridgedFactory to create a window in the app shim process. This function is not yet expressive enough to encompass all window types needed, but is sufficient for testing. Add a BridgedNativeWidgetHostImpl::CreateRemoteBridge function to create a remote bridge. Bug: 859152 Change-Id: Iea81da4af7f3787f70474f49ba45c1c831d2fcc3 Reviewed-on: https://chromium-review.googlesource.com/1226251 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#591920}
-
Jordy Greenblatt authored
Changes in this CL: -Unindent 'forget device' line -Get rid of coloration of 'Better together is on' -When waiting for verification/server, show text for that instead of 'better together is on/off' -When waiting for verification/server, show and verify button instead of suite toggle Bug: 884390 870103 Change-Id: I0c8fb9519d52c8a016f90eba32b26dda97bd449b Reviewed-on: https://chromium-review.googlesource.com/1228935 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#591919}
-
Jonathan Metzman authored
Ship the libFuzzer runtime on Windows as is currently done for libFuzzer on other platforms. Bug: 884707 Change-Id: I543d8c2a310d58f61a0f0fb966420d6b4879ec21 Reviewed-on: https://chromium-review.googlesource.com/1229078Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#591918}
-
Charles Zhao authored
(1) Add SerializedMrfuAppLaunchPredictor with unit test. SerializedMrfuAppLaunchPredictor is basically MrfuAppLaunchPredictor with extra serialization and deserialization logic. Bug: 871674 Change-Id: I95bcb2599557ef9f7a860b74814dc4307da109a2 Reviewed-on: https://chromium-review.googlesource.com/1223716 Commit-Queue: Charles . <charleszhao@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#591917}
-
Joel Hockey authored
Mounted volume without a request: crostini:Crostini: * This is basically what happens when you pull out a USB without clicking unmount. This message is harmless, but the code is changed to stop it anyway. * Message fixed to state 'Unmounted ...' since the error happens at unmount. * Changed test to call FMP.unmount and added logic into private_api_mount.cc to remove crostini mount. * Removed unmountCrostini test function which is no longer needed. Error in event handler: TypeError: Cannot read property 'volumeType' of null: * This error happens when crostini is unmounted and the directory changes back to Downloads. banners.js fixed to guard for the case where the volume is now removed and VolumeManager.getLocationInfo returns null. Bug: 883571 Change-Id: I13c0bee7f514dfc318eaa12f4c1ef1c2186e7a70 Reviewed-on: https://chromium-review.googlesource.com/1227864 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#591916}
-
Joel Hockey authored
Make VolumeManagerWrapper inherit from VolumeManager and use the VolumeManager interface as much as possible within FilesApp. A new class VolumeInfoListWrapper is defined in volume_manager_wrapper.js which implements the minimal VolumeInfoList interface required in foreground. Now that VolumeManagerWrapper implments VolumeManager, we have some type safety for VolumeManagerWrapper.volumeInfoList property which must implement the VolumeInfoList interface. MockVolumeManager no longer requires to implement VolumeManagerWrapper and a lot of code can be deleted, fixing a TODO left by tomascz. VolumeInfoListImpl no longer requires to sort volumes, since this is done in NavigationListModel code. The directory_tree_unittest required modification to stop inserting volumes in an illegal manner which would not happen in prod, and cannot happen now that the correct VolumeInfoList interface is being used. Bug: 884107 Change-Id: I03078d0423b1ad85ae8909d633c58786135cd4b6 Reviewed-on: https://chromium-review.googlesource.com/1226755 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
Ben Kelly authored
Currently the ServiceWorkerSubresourceLoader sequentially reads the blob side data and then starts reading the main blob data. This delays when the disk I/O can start to filling the DataPipe buffer which in turn increases time to first byte for the resource seen by the page. Performing the reads in parallel allows the DataPipe to begin buffering data immediately. This CL changes the default behavior to load the main blob data and the side data in parallel. The ServiceWorkerParallelSideDataReading feature is also added to support a future holdback study. In addition, two new histograms measure the delays within the loader for starting to read the main blob data and for notifying the loader client that the body has started loading. R=kinuko@chromium.org, rkaplow@chromium.org Bug: 883052 Change-Id: If34dbf05074bea8f3067934269099a88f2782bc0 Reviewed-on: https://chromium-review.googlesource.com/1220563 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#591914}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/16dc632a7201..151945a7459c git log 16dc632a7201..151945a7459c --date=short --no-merges --format='%ad %ae %s' 2018-09-17 chrome-bot@chromium.org Update config settings by config-updater. 2018-09-17 bhthompson@google.com Remove zoombini and rainier builder configurations 2018-09-17 dgarrett@google.com firmware_stages: Move "production" artifacts. Created with: gclient setdep -r src/third_party/chromite@151945a7459c The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I853ac668a2c75af2cebd4a7ff0e806214a8076b0 Reviewed-on: https://chromium-review.googlesource.com/1229494Reviewed-by:
-
