GitLab

Canvas.getContext() method is idempotent, i.e. successive calls return
the same context over and over. When the context is lowLatency, however,
we think it's an OffscreenCanvas context and fail. This CL fixes
that and adds a LayoutTest to verify the new functionality.

Bug: 895551
Change-Id: I1ae140080915a277eb45ac01486e6c7c1464aefa
Reviewed-on: https://chromium-review.googlesource.com/c/1294090Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601652}

Change-Id: I213af3504a7383f1c0130b1345b436216010c204
Reviewed-on: https://chromium-review.googlesource.com/c/1286637Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601651}

This CL is part of
https://chromium-review.googlesource.com/c/chromium/src/+/1286017

This CL was uploaded by git cl split.

R=aleventhal@chromium.org

Bug: 681136
Change-Id: I7961ce74b47e41b4818e4fed007df38e1060539d
Reviewed-on: https://chromium-review.googlesource.com/c/1288338
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601650}

It's flaky.

BUG=897801
TEST=test only change
TBR=thestig@chromium.org

Change-Id: Ieba62e4047a3fc240ac6b09b6e526ff87a0e29d3
Reviewed-on: https://chromium-review.googlesource.com/c/1294197Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601649}

Based on [1], it would seem that we should treat the case where we have
no image candidate as representing nothing - this apparently also
matches what other UAs do.

Simplify the NoImageSourceSpecified helper function a bit. (IsNull
implies IsEmpty and !hasAttribute.)

[1] https://html.spec.whatwg.org/multipage/embedded-content.html#the-img-element:the-img-element-5

Bug: 897033
Change-Id: I37ecad8faea2b929e8cf35ce7c746313b2d3b915
Reviewed-on: https://chromium-review.googlesource.com/c/1293574Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#601648}

No change to production logic.

This enables 2 tests which were previously disabled due to flakiness.
The flakiness was fixed in http://crrev/c/1286031, and these appear safe
to enable:

 * testFullscreenForNonVideoElementIsSupportedInSoftwareMode
 * testPowerSaveBlockerIsTransferredToFullscreen

This also cleans up annotations on other disabled tests. It's sufficient
to mark disabled tests as "@DisabledTest" without commenting out other
annotations. It's helpful to actually leave these annotations
uncommented, because it makes enabling the test a one-line change.

Bug: 789306
Test: run_webview_instrumentation_test_apk \
Test: --gtest_filter=AwContentsClientFullScreenTest#* \
Test: --repeat=1000
Change-Id: I497718177d086c46e1553e1f365b23b27de760e4
Reviewed-on: https://chromium-review.googlesource.com/c/1290142Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601647}

BUG=chromium:894375
TEST=None

Change-Id: I905b4dd02a40e515fdd7f47f3b3efb845953841e
Reviewed-on: https://chromium-review.googlesource.com/c/1292650Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Shuhei Takahashi <nya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601646}

This test often flakes on its first run in a batch, with each call
expectation satisfied more than once.

Bug: 897550, 879806
Change-Id: I2b7b130e5fd2fc8abf6aa15fbfd417041da0420f
Reviewed-on: https://chromium-review.googlesource.com/c/1293178Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601645}

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

Remove the RecentModelFactory::SetForProfileAndUseForTest
method as it pass a std::unique_ptr<> object to return from
the factory which is difficult to adapt to the new API that
requires a base::RepeatingCallback<>.

Instead inline the implementation in the sole unit test that
called this method and modify it to pass a factory returning
a std::vector<std::unique_ptr<RecentModel>>.

This converts uses in src//chrome/browser/chromeos/fileapi.

This CL was uploaded by git cl split.

R=slangley@chromium.org

Bug: 809610
Change-Id: Idb8bae335e3defca5b2c6736d302586faf97d929
Reviewed-on: https://chromium-review.googlesource.com/c/1259014Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601644}

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/browsing_data.

This CL was uploaded by git cl split.

R=markusheintz@chromium.org

Bug: 809610
Change-Id: Ie7a9a867b2214dd56e7c54fcf8328dc02cc0b4ea
Reviewed-on: https://chromium-review.googlesource.com/c/1258361
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601643}

Allows us to add an arm to the Holdback experiment where secure proxies
are disabled for DRP.

Bug: 768597
Change-Id: I66ecfa86f985de262e8f260a5a2d47c863beb0f8
Reviewed-on: https://chromium-review.googlesource.com/c/1292598
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601642}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/333c890004ba..a7f9ec980c66


Created with:
  gclient setdep -r src-internal@a7f9ec980c66

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ic5f468853e561485f1bb843738651b7e61b286b4
Reviewed-on: https://chromium-review.googlesource.com/c/1293716Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601641}

This test leaks process-global state, causing potentially causing later
tests (e.g. WebGPUInProcessCommandBufferTest.Dummy) run in the same
batch process to unexpectedly fail.

Bug: 897456, 879806
Change-Id: Ied7facc983f7f62e6954e3d3ad28572010b09ae5
Reviewed-on: https://chromium-review.googlesource.com/c/1293030Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601640}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/e696a0e1..7bc77bb4

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I1260f6aaa37641e63b44b56fcaea3f3b92864707
Reviewed-on: https://chromium-review.googlesource.com/c/1294009Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601639}

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//extensions/browser/api/display_source.

This CL was uploaded by git cl split.

R=alexander.shalamov@intel.com

Bug: 809610
Change-Id: I0296a88846eed33c92d7baa74217e845218f3bf5
Reviewed-on: https://chromium-review.googlesource.com/c/1257937Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601638}

BUG=897592,814528

Change-Id: I2c9adf2ff533446c10be19d12ec3c83a8b1e0323
Reviewed-on: https://chromium-review.googlesource.com/c/1294131Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601637}

Bug: 897190
Change-Id: I1c2d24bc3db26d5c27a582a6fd5049a16cabd927
Reviewed-on: https://chromium-review.googlesource.com/c/1291769Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601636}

TestingFactoryFunction is a simple function pointer. It is
deprecated in favor of TestingFactory which is a Callback<>.
Convert indirect uses by using base::BindRepeating() in all
invocation of SetTestingFactory/AddTestingFactory.

This converts uses in src//chrome/browser/themes.

This CL was uploaded by git cl split.

R=pkotwicz@chromium.org

Bug: 809610
Change-Id: I66ee3e218e4333f6d704e64b58003f100f1364e9
Reviewed-on: https://chromium-review.googlesource.com/c/1258352Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601635}

There's a bunch of custom measure, draw and tint  code that appears to be no
longer needed. I suspect it was left over from our non-Modern design and
from when Android support library didn't have tinting support built in.

Also remove unused btn_new_tab_white* assets.

BUG=897345

Change-Id: Ie3b67573371b58ecbef9f9f47518f704435e4180
Reviewed-on: https://chromium-review.googlesource.com/c/1292553
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601634}

https://webrtc.googlesource.com/src.git/+log/ff292f30d9a4..67b011d22c1b


git log ff292f30d9a4..67b011d22c1b --date=short --no-merges --format='%ad %ae %s'
2018-10-22 nisse@webrtc.org Use BitrateAllocatorInterface in AudioSendStream and VideoSendStream


Created with:
  gclient setdep -r src/third_party/webrtc@67b011d22c1b

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I4a7455ec6ae0cd3250334288640c3ecb62b89d02
Reviewed-on: https://chromium-review.googlesource.com/c/1293710Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601633}

Change-Id: Ib31144ffc4d0e18e9d583ee6fbdea2551ebf5b6a
Reviewed-on: https://chromium-review.googlesource.com/c/1294195
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Reviewed-by: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601632}

We changed IsInArcAppWindow() to use the window property,
aura::client::kAppType, but it's not set for ARC++ Kiosk apps' window.
It makes text input on ARC++ Kiosk apps stop working.
This CL adds a temporary workaround for this situation. Ideally,
IsArcAppWindow() in arc_util.cc should handle windows of ARC++ Kiosk app
correctly.

Bug: 891825
Test: Can type text on Wikipedia kiosk app.
Change-Id: I594aa5c0730704b9ad922441187297bd707de20a
Reviewed-on: https://chromium-review.googlesource.com/c/1291289
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601631}

Since surface resurrection doens't work anymore, make sure the renderer
allocates a new id every time it's visible, as the old surface might
have been evicted.

Bug: 893731
Change-Id: I44d715949f2ccc76a270feac9e6fb899a472cbbc
Reviewed-on: https://chromium-review.googlesource.com/c/1293765Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601630}

Bug: 893850
Change-Id: Iee754cefbd083d0a21a2b672fb8e837eaab81c43
Reviewed-on: https://chromium-review.googlesource.com/c/1293712Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601629}

V8 currently writes the raw values for embedder fields always,
so don't put pointers (which differ even between runs of the same
binary, due to ASLR) in there until that's fixed. Instead, put
a magic integer there and transform that to a pointer at
deserialization time.

(Also remove a redundant call from CreatePlainWrapper() --
the caller of CreatePlainWrapper() already sets the embedder
field, no need to do that twice. This part is behavior-preserving.)

Bug: 870584
Change-Id: I6b29286ec8c7a68a662d51c36b5642b968f2e343
Reviewed-on: https://chromium-review.googlesource.com/c/1293791
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601628}

Bug: 891310
Change-Id: Ie467f737e76cc0125b03723e16c3c12bdaf41187
Reviewed-on: https://chromium-review.googlesource.com/c/1271380Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601627}

The logic allowing us to switch the active pref at runtime is no longer
necessary since there is now only a single Extended Reporting pref in the
system.

Bug: 662944
Change-Id: I8ae0efa90ad488d7a93652268fad24f86ded70c2
Reviewed-on: https://chromium-review.googlesource.com/c/1286988
Commit-Queue: Luke Z <lpz@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601626}

This patch changes tests in the following directories to use
Element.innerText for text dump:

fast/css*

Most of this patch is mechanical rebaseline, except that:
- Some LayoutNG-specific baselines become redundant and are removed
- One test is changed to fail in LayoutNG due to a known innerText bug

Bug: 887148
Change-Id: I3cb1f410eb4544630498d451bf2e260d4be6bbec
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Reviewed-on: https://chromium-review.googlesource.com/c/1282305Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601625}

This reverts commit 3d1759c9.

Reason for revert: Due to crbug.com/897772, tests were not run.

Original change's description:
> [BlinkGenPropertyTrees] Promote BGPT to experimental
>
> BlinkGenPropertyTrees (BGPT) is an incremental step towards making
> compositing decisions after the paint lifecycle phase. The primary
> changes are to build property trees in blink and send a layer list to
> the compositor, rather than building property trees in cc from a layer
> tree. This patch marks the project as experimental which will give us
> test and perf coverage on the bots.
>
> Sheriffs: This shifts time (e.g., we now run PaintArtifactCompositor
> and no longer run the cc property tree builder) and will likely change
> performance benchmarks. Because this is an initial trial, feel free to
> roll this patch out.
>
> Bug: 836884
> Change-Id: Ia1073bdd0922503925c17161f052bdfcd94196b7
> Reviewed-on: https://chromium-review.googlesource.com/c/1292555
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Commit-Queue: Philip Rogers <pdr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#601429}

TBR=pdr@chromium.org,chrishtr@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 836884, 897772
Change-Id: Iee4fb4fc15e2400c85c9855f904bc4f4225eed71
Reviewed-on: https://chromium-review.googlesource.com/c/1293992
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601624}

Bug: 855767
Change-Id: I6dfefc7aa5a8934ee41ae1ca07e15eabe5685377
Reviewed-on: https://chromium-review.googlesource.com/c/1292724
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601623}

https://android.googlesource.com/platform/external/perfetto.git/+log/8c0d048e784b..ea46bbbe607b


git log 8c0d048e784b..ea46bbbe607b --date=short --no-merges --format='%ad %ae %s'
2018-10-22 treehugger-gerrit@google.com Merge "trace_to_text: Remove redundant code"


Created with:
  gclient setdep -r src/third_party/perfetto@ea46bbbe607b

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I5734f4517ed6f2668f4f824418a431617c55aec0
Reviewed-on: https://chromium-review.googlesource.com/c/1293713Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#601622}

Change-Id: Ibdd326e93f3d00b7212e3ae30fc1f4210802a28f
Reviewed-on: https://chromium-review.googlesource.com/c/1293751Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601621}

Bug: 817798
Change-Id: Ib8ede24df41747fbf72050b17d045f920c8c33af
Reviewed-on: https://chromium-review.googlesource.com/c/1184048
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601620}

The "Restore default shortcuts" menu option is not updated unless an
onMostVisitedChanged event is sent. This only occurs when a URL/title
of the new tile set is different from the current tiles. As such (after
adding then removing a link), the restore default option will not be
disabled after clicking since the tiles are considered unchanged.

Now consider tiles with different sources to be unequal.
Screencast: https://screencast.googleplex.com/cast/NTQ0MDY0MTk2MjA4MjMwNHw0MTY5NmRmYi1mNg

Bug: 896566
Change-Id: I8c1474d2a567889fc5296c3a58228a92c3a67b71
Reviewed-on: https://chromium-review.googlesource.com/c/1292149
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601619}

Bug: 893592
Change-Id: I619bb47295302ba74301c327372206269c12bf23
Reviewed-on: https://chromium-review.googlesource.com/c/1293729
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Commit-Queue: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601618}

Suspecting patch crrev.com/c/1290916 causes test failures. As the patch
was landed several hours ago, I'd like to disable the tests and assign
the owner for review.

TBR=skyostil@chromium.org
NOTRY=true

Bug: 897775
Change-Id: I416121366cae0d4503b1b02db075722be43db6a9
Reviewed-on: https://chromium-review.googlesource.com/c/1294129Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601617}

Bug: 893850
Change-Id: Icb5d59ac7dd6a6cf1dfd6e17f913966d6d546c29
Reviewed-on: https://chromium-review.googlesource.com/c/1294012Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601616}

TaskScheduler: Delegate reinsertion of Sequences in SchedulerWorkerPool priority queue to TaskScheduler

Bug: 889029
Change-Id: I424024245e74c0c08d76a94263c94fad7a3631cc
Reviewed-on: https://chromium-review.googlesource.com/c/1271794
Commit-Queue: Jesse McKenna <jessemckenna@google.com>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601615}

It's now to be resolved against the inline-size of the content area of
the block itself [1]. Already fixed for legacy layout here:
https://chromium-review.googlesource.com/c/chromium/src/+/1285109

We no longer need PercentageResolutionInlineSize().

[1] https://github.com/w3c/csswg-drafts/issues/2394#issuecomment-380429078

Bug: 884588
Change-Id: I7526bbdbab4cfc31cdfb4c8e1d83450e9d1eee1a
Reviewed-on: https://chromium-review.googlesource.com/c/1292874Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601614}

This patch changes AbsoluteCaretBoundsOf() to take PositionWithAffinity
instead of VisiblePosition to decrease the usage of VisiblePosition.

It is also a preparation for bidi caret affinity.

Bug: 657237, 894651
Change-Id: Ic55c037c058c1fe666ba89cbee502f7d0a74754b
Reviewed-on: https://chromium-review.googlesource.com/c/1292726Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#601613}