GitLab

No-Try: true
Tbr: mlamouri@chromium.org
Bug: 947126
Change-Id: I1e27b93a4c23b6cb2ad524ff1b48c844d802905d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544194Reviewed-by: Ella Ge <eirage@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#645405}

Bug: 844118
Change-Id: I55855b12622509836d921861a12bced9f3f9fbd9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539859
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#645404}

Bug: 947090
Change-Id: I4c9976175e5eba39996a942c2281e0c590dcb7a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531009
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#645403}

Bug: 942107
Change-Id: Ic675a55bf775d8531585cf7d2b62ce3a8ca35755
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543262
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#645402}

Added some std::flushes and initialized max_size_ variable.

Bug: 946367
Change-Id: I1675344ba975ef58286ae4913a7612393d9a5f02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542837
Auto-Submit: Matthew Denton <mpdenton@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Matthew Denton <mpdenton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#645401}

Prior to this it was up to consumers of View to know when the right
time to call Layout() was. This is error prone, and easy to get wrong.
This patch makes it so a call to InvalidateLayout() results in a later
call to Layout() (starting from the root). The call to Layout()
happens right before the damage rects are sent to the compositor.

This only cleans up views side. No doubt other cleanup can happen in
other places. Additionally, there are future changes that should happen:
. add/remove should really InvalidateLayout().
. It isn't always necessary to start the Layout from the root. Some
views size *never* changes (such as the BookmarkBar), in which case
layout need not start from the root. This is a future optimization.

BUG=627663
TEST=covered by tests

Change-Id: I883d09eb3329a159aecf799b39bb61aab3b2a0f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498720
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#645400}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4f260ee2..97e48306

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I4c15bf8c12b159478d4d0c083d5d8bfe039d2d0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543459Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#645399}

Changed the callbacks of CookieManager::GetCookieList and
CookieManager::SetCanonicalCookie to include the list of blocked cookies
And the cookie status, respectively. This puts them in line with the
callbacks for CookieMonster::GetCookieListWithOptions and
CookieMonster::SetCanonicalCookie. This is controlled by the
|return_excluded_cookies| in the CookieOptions object sent with the
request, and is disabled by default (setting the lists to empty).

Bug: 856777
Change-Id: Ice601c89b1136b49e4f0f273401a9774c7e36252
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1523528Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Aaron Tagliaboschi <aarontag@chromium.org>
Cr-Commit-Position: refs/heads/master@{#645398}

Context: https://crbug.com/926940#c2

Chrome OS Account Manager's proto was modified to have an email field.
We wanted to guarantee that this field can never be empty and some
migration code was written in
|ProfileOAuth2TokenServiceDelegateChromeOS| to backfill email ids into
old, unmigrated accounts in Account Manager.

Cleanup the migration code and replace it with a DCHECK.

Do NOT back-merge this patch to any release prior to M75.

Bug: 933307
Change-Id: I946e0d4aef322aaf270cba8e2480f51bdee14085
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539842
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#645397}

Note, this migration is done in order to keep the API of the video capture
service in services/video_capture free from native enums. Native enums prevent
the API from being used by non-Chromium clients.

This CL does not remove the legacy IPC logic for ui::gfx::ColorSpace, because it
is still being used in various places, e.g. in legacy IPC logic for structs
containing a ColorSpace field.

Bug: 893203
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ic7ee31748662ceaf064b1a2a2490100cca5fbe00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1249092
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#645396}

Bug: 942107, 942001
Change-Id: Ibff3489ecdfbde92f368ffea94897e1abf5992fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534175Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#645395}

This gives a clue that the control has a drop-down list.
The arrow looks the same as the regular Combobox one. Screenshot
uploaded to corresponding bug. Tested in RTL UIs as well.

This requires modifying Textfield to add extra insets so the RenderText
doesn't write over the arrow. The mouse has its default look when
hovering over the arrow. Whether we click in the text or on the arrow
the effect is the same: The control is focused and the menu comes up.
We can start typing right away (even if we clicked on the arrow).
If the menu is already open, then clicking on the arrow will close it,
but clicking in the text will not.

Bug: 923660
Change-Id: I3cf1b8aa6ac9a85ce278fd83f5b493cbfa0e9af6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534177Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Edin Kadric <edinkadric@google.com>
Cr-Commit-Position: refs/heads/master@{#645394}

Tbr: caseq@chromium.org
Bug: 848799
Change-Id: Ifda052f25cfb33847a79b590c38e85b072c9cfc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543810
Commit-Queue: Ella Ge <eirage@chromium.org>
Reviewed-by: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#645393}

No-Try: true
TBR: kyleju@chromium.org
Bug: 856601
Change-Id: I3a716e35d538983e3a4ffc5fc1213fd00f8a9031
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544192Reviewed-by: Ella Ge <eirage@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#645392}

This CL adds a utility function to retrieve the time stamp of certain
hour in yesterday.

Bug: 930968
Change-Id: Ifb38b24bfcb5fa560738884f930a1d1a6bb78ffc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542303Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#645391}

This is a reland of 3d8e2c2a

Original change's description:
> [AudioOutputDevices] Check frame before checking device authorization.
> 
> This attempts to address an unusual crash involving WebLocalFrame and
> SetSinkIdResolver.
> This CL also removes a timer to fire an asynchronous task and uses
> a per-frame task runner instead.
> 
> Bug: 941380
> Change-Id: I9acf17ca3fd7d3dd8253b4e278adf583f4205f85
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524267
> Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
> Commit-Queue: Guido Urdaneta <guidou@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#641563}

Bug: 941380
Change-Id: I6e61eb632e22fa81230b2420eed0b1c40c5ba992
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543632Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#645390}

Now EXPECT_EQ and other test macros will dump the contents of an OfflinePageItem
when a test condition fails, as opposed to the raw bytes.

I went ahead and cleaned up OfflinePageItem a bit:
* One constructor was only used in tests, and removing it led to easier to read
  code anyway.
* I moved member default values to header.
* Move ctor/operator= were implicitly disabled for no reason, so I declared them

Change-Id: Iba0f98817a967245df0319c80cc62a159ae3a98f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1539919Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Dan H <harringtond@google.com>
Commit-Queue: Dan H <harringtond@google.com>
Cr-Commit-Position: refs/heads/master@{#645389}

Change-Id: I95125c19756de04278ffa67e3bddf505cb341a53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530961Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/heads/master@{#645388}

This CL makes ar_module_tmpl use placeholders where appropriate,
and also refactors how upstream bundles uses "build switches"
  * android_64bit_target_cpu,
  * is_64_bit_browser,
  * build_apk_secondary_abi,
  * include_32_bit_webview,
to compute "module assignments"
  * loadable_modules,
  * secondary_abi_loadable_modules,
  * native_lib_placeholders,
  * secondary_native_lib_placeholders,
for native code inclusion.

Details:
* Outer template: Wrap non-global built switches above, i.e.,
  {is_64_bit_browser, include_32_bit_webview}, into scope
  native_switches, which is then passed to module templates that need to
  include native code.
* Module templates (currently only AR):
  * Specify {native_modules_if_32_bit, native_modules_if_64_bit}.
  * Forward native_switches to inner template.
* Inner template: Perform the computation:
  * Decision logic: Compute intermediate variables.
  * Realization logic: Compute "module assignments".
    * Behavior change: Specify names for dummy placeholders.
* Still need to support the old flow to support downstream templates.

Bug: 930874
Change-Id: I5576490c095a1e3d2337884051c9aff8e96ef2a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536079
Commit-Queue: Samuel Huang <huangs@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#645387}

In order to run the web-platform-tests automatically, we will use
testdriver Action API in all the wpt to simulate inputs. Here we are
changing some pointerevent touch input tests which are doing scrolling.

This is the second CL that changes part of the pointerevent touch input
tests.

Bug: 606367
Change-Id: I67cc6c401a22de59af298133021f380baa7d4b19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1473971
Commit-Queue: Lan Wei <lanwei@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#645386}

In Android WebView in order to intercept "data:" scheme urls and
invoke shouldInterceptRequest callback for them we need to be able to
receive the corresponding requests by the AwProxyingURLLoaderFactory
loaders.

Originally in chrome data scheme urls were not proxied for
navigations, however for subresources it appeared the data scheme urls
were actually sent through the proxy.

An approach where we would keep the same behavior for data scheme
navigations in chrome was attempted in:
https://chromium-review.googlesource.com/c/chromium/src/+/1495536
Using the relevant check in
ChromeContentBrowserClient::WillCreateURLLoaderFactory(), however that
approach appeared to break at least one test (see crbug.com/944124),
in particular ExtensionWebRequestApiTest.WebRequestTypes, because it
was assuming that data scheme urls (for subresources) would still go
through WillCreateURLLoaderFactory().

This patch solves the issue by allowing proxying data urls for
navigation as well (in addition to subresource requests).

This changes the logic in chrome, but there seemed to be no particular
reasons for disallowing it.

Fixes tests:
-AwContentsClientShouldInterceptRequestTest.testBaseUrlOfLoadDataSentInRefererHeader
-AwContentsClientShouldInterceptRequestTest.testLoadDataShouldTriggerShouldInterceptRequest
-AwContentsClientShouldInterceptRequestTest.testLoadDataUrlShouldTriggerShouldInterceptRequest
-AwContentsClientShouldInterceptRequestTest.testLoadDataWithBaseUrlTriggersShouldInterceptRequest

BUG=893566,841556,928728,944124

Cq-Include-Trybots: luci.chromium.try:android_mojo
Change-Id: If08a7dec7b99ee5f4b9f18e3909557e20cf1b8a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541086
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#645385}

Allow a few debug commands in KioskNext when --ash-debug-shortcuts is
on the command line.

Bug: 932054
Change-Id: Id27b9abe9ff6901355d512b6439785751399ec7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542782
Auto-Submit: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#645384}

This Cl removes unused "screen header" elements.

Bug: 926638
Change-Id: If43bd996bf6cce70e5a7f760edef6b5a138906dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542729Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#645383}

Add missing expectation for DidChangeBackForwardState callback.

Bug: 899827
Change-Id: I1977a31ea43ceb799ec155d6d35127613003f332
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542560
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#645382}

Instead, use InstallAttributes.
InstallAttributes is the better high-level interface to use and it
can easily be stubbed during a test.

Bug: 836857
Change-Id: I2910aaeb0c86dcab47bb74e42d46671afe92630c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541057
Commit-Queue: A Olsen <olsen@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#645381}

1. Add AXPlatformNodeWin::GetTextAttributeValue which is used to query the
   TEXTATTRIBUTEID

2. Implement AXPlatformNodeTextRangeProviderWin::GetAttributeValue
   a) Get all anchors in the range
   b) Query the TEXTATTRIBUTEID on each anchor
     b.1) If all the same value, return that value
     b.2) If there's multiple values, return a reserved mixed value
     b.3) If none support it, return a reserved not supported value

3. Implement UIA_IsHiddenAttributeId

Bug: 847971
Change-Id: I7e315ab8ec2c01de62aa8cce51a697464424fc7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542575Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Adam Ettenberger <adettenb@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#645380}

Now that we can use CIPD to install GN binaries, we can finally
roll GN and catch up w/ multiple months of changes :)

    https://gn.googlesource.com/gn.git/+log/0790d304..b85982b

    b85982b3 visual_studio_writer: Make OutDir equal to $(SolutionDir).
    9434c3d2 Make gen.py compatible with python3
    b199e54b [docs] : Split 'gn help' heading and usage summary when exceed 80 cols
    5bc90b63 stdout: use dim colors
    24411bec Make gn check faster
    3941394b [docs] regenerate docs/reference.md
    93ac4e04 Some documentation of gn check --check-generated
    fd1532f2 [docs] Fix Markdown format missing `
    74657a61 Add gn check --check-generated to check dependencies of generated files
    6b943827 Fixed typo (missing parenthesis) in get_path_info documentation
    d062e74f Improve config documentation.
    e15f243a gen.py: Pass -pthread, not -lpthread, in ldflags.
    013513c9 gn recipe: Do not pass libraries in LDFLAGS in the Linux recipe
    1152229e gen.py: Pass -pthread via ldflags, not libs
    01237e9c Remove references to ARM-optimized math implementation
    0ac93dd2 For proper order put -lpthreads as a 'library' not a 'linker flag'
    1ab6fa2c Attempt to unbreak build with MSVC 15.8.4
    082fbe39 Pass -lpthread when linking instead of -pthread
    d69a9c37 [help] Fixing help issues.
    04685d69 Add --dump-json-tree option for format subcommand.
    57586fdb Suppress warning on VS2017.
    4dcd2776 Port to FreeBSD.
    5519dc2f Reintroduce the ICF flag, turn it on for bots
    53107bfc [infra] Update XCode version
    377ad041 Enable LTO for release builds
    282a428c Disable ICF on Darwin, make it default for Release
    71b537ce [format] Extend `gn format` to take a list of files.
    b5a2ac6e Improve help output.
    d837047a format: Ensure that formatting always reaches a fixedpoint in one run
    8ed01d3b Docs: regenerate docs
    d84a862e More efficient Value implementation.
    bcfb6471 cleanup label_ptr.h
    88bd8a8d build/gen.py: Add --no-strip option.
    894143c3 format: Fix incorrect dewrap of `if`
    45314e29 [metadata] Return metadata in postorder.
    e49432fa [metadata] Actually collect the metadata
    c1780c21 [metadata] Allow specification of rebase dir
    5a9e0a2c [metadata] Adding metadata vars to write_data target
    d021d391 [metadata] Add generated_file target type
    27b66b57 Allow whitespace in include directives.
    c6841d31 Fix a crash on invalid on `not_needed(scope)` without a 2nd argument.
    54be6f11 Allow NOSORT to be the last line in a comment in addition to the first.
    a07831bb [metadata] Adding `meta` command
    0587778f [metadata] Walk function
    96c77296 [metadata] Add metadata walk to target
    a27e8dc0 [metadata] Adding basic metadata walking
    2000587b [metadata] Adding metadata output to gn desc
    0e1b8843 [metadata] Adding metadata variable to target
    ecc95221 Add links to the "Using GN build" presentation.
    13ac6ca4 Test that not_needed works with forward_variables_from

Change-Id: I8db493df2a27c9b8ffe066a11179ffedb2b0f47a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1522549
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#645379}

https://webrtc.googlesource.com/src.git/+log/e5cc85b5c53f..20393ee9b7ba


git log e5cc85b5c53f..20393ee9b7ba --date=short --no-merges --format='%ad %ae %s'
2019-03-28 nisse@webrtc.org Delete all stats-related logic from VCMJitterBuffer.
2019-03-28 kthelgason@webrtc.org Adds workaround for audio not restarting after interruption


Created with:
  gclient setdep -r src/third_party/webrtc@20393ee9b7ba

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I5acc50e8e9f99d5feabfe9fefccc798c6206b0a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543421Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#645378}

This allows the compiler to run a little faster. Clang will still
be running with assertions enabled on the Clang tip-of-tree waterfall
to catch regressions in Clang, or to catch existing asserts getting
triggered by code that's checked into Chromium.

Below are build times (each build was run twice to warm up the cache,
and the second build time was noted) of the 'chrome' target
configured with 'is_debug=false is_component_build=true'.

Linux
-----
asserts enabled:
real    43m51.506s
user    2304m36.334s
sys     93m34.650s

asserts disabled:
real    36m37.976s  (-16%)
user    1910m47.627s
sys     87m37.474s


Windows
-------
asserts enabled:
peak memory: 2341.99MB
real: 64m3.234s
qpc: 3843245179us

asserts disabled:
peak memory: 2343.40MB
real: 50m59.093s (-20%)
qpc: 3059111587us


Mac
---
asserts enabled:
real    175m19.768s
user    3960m35.641s
sys     168m42.376s

asserts disabled:
real    148m50.279s (-17%)
user    3336m16.310s
sys     171m51.878s


It also reduces the size of the Clang package:

59M        clang-356356-1-linux.tgz
33M        clang-356356-1-mac.tgz
57M        clang-356356-1-win.tgz
50M (-15%) clang-356356-2-linux.tgz
28M (-15%) clang-356356-2-mac.tgz
45M (-21%) clang-356356-2-win.tgz


Bug: 896306
Change-Id: I26068467119065a9d381f7f97f8dfac1defeb309
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532107Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#645377}

SchedulePaintType was used to only argument of a function.
and it has only two values. so it is possible change to bool arg.
the change will make more shorter code at overall.
and inlining all of BoundsChanged() into SetBoundsRect()
to make this code clearer.

Bug: 940736
Change-Id: I14bd47155aef0e71c9c17f9fd693901f1bd2bd0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530504Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#645376}

Bug: 941230
Change-Id: Ibd8e2cfec9d1859a192e82332453fabbbee67b4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531396
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#645375}

Bug: 946616
Change-Id: I5fa49fe568ab0aecbd2b270c32a714c463d92605
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542162Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#645374}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/68845f14d6d5..4dca0a0b7aaf


Created with:
  gclient setdep -r src-internal@4dca0a0b7aaf

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=robertocn@chromium.org,noel@chromium.org,eirage@chromium.org

Change-Id: Ieed2304f16e54ef736bed00694dad38df1b01bc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541747Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#645373}

Collecting them (after crrev.com/c/1512765) caused element id collision
between element ids of the scrollbar layer and the effect nodes of the
scrollbars.

We should probably skip setting element ids of scrollbar layers in
the future, but the element ids are still required even in layer list
mode in LayerTreeHost::ApplyScrollAndScale().

Not collecting them won't break animation because scrollbar animation
is controlled by cc::ScrollbarAnimationController instead of the
classes under cc/animations.

Bug: 946397
Change-Id: I8a713588e1ee3073b82ef5d8a95b296ff77747ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542460Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#645372}

To make the macOS V2 sandbox more robust, allow access to
CoreTypes.bundle.

Bug: 871280
Change-Id: I0de730ace30a18f3c3d8a3c12b13d2e968056ac8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540543
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#645371}

BUG=none

Change-Id: I62430a543623f957a7be1bc197b05978cc1bce76
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543457
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#645370}

This CL renames the files and classes:
s/{Vaapi,V4L2}JpegDecodeAccelerator/{...}MjpegDecodeAccelerator/

Also adapts the GpuJpegDecodeAccelerator factory file
and renames the file+class FakeJDA.

No new code intended, just semi-mechanical renames.

Bug: 932860
Change-Id: Ib1c87de9edec0172531f41bfa59b63c96d8c7283
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536008
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#645369}

After the 'linux-annotator-rel' buildbot successfully validates the
annotations, it will write annotation contents to a Google Sheets
document.

This is not modifying the original spreadsheet (just a copy of it),
so we can test that the script works.

Bug: 878759
Change-Id: Ia4c8096b200d9025d32ed869295e0c5620beb48f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521240Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#645368}

If a candidate content has not changed for 3 frames, do not promote it as
Single On Top overlay as it can be just be flattened, allowing other
strategies to kick in if possible.

Bug: 885180
Test: SingleOverlayOnTopTest.DoNotPromoteIfPreviouslyPromoted
Change-Id: I516dab628c129fe9fae09c713e2783a6ce889c56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1521591
Commit-Queue: Mark Yacoub <markyacoub@google.com>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#645367}

Welcome!

Bug: None
Change-Id: I239dcf3730387dbb8b6f6e29f0a1138069485c4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541170
Commit-Queue: Egor Pasko <pasko@chromium.org>
Auto-Submit: Egor Pasko <pasko@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#645366}