- 03 Sep, 2019 40 commits
-
-
Antonio Gomes authored
This is a reland of f8ab5df9 The original (reverted CL) https://crrev.com/c/1778671 had one mistake: it missed to remove the includes of the autogenerated file <out>/gen/content/public/common/buildflags.h in chrome/. ... that is now gone. Given that the bots do not do a full rebuild (remove <out>/), CQ did not catch it. This reland CL should fix it. Original change's description: > Move definition of kWebRtcH264WithOpenH264FFmpeg to Blink > > This is a precursor CL to Onion soup'ing > content::RtcVideoEncoderFactory (phase 2.3 in the design document [1]). > > [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ > > Basically, it merged the definition and declaration of > content/public/common/feature_h264_with_openh264_ffmpeg.cc|h > into Blink's features.h. More specifically, to > third_party/blink/public/common/features.h (declaration) and > third_party/blink/common/features.cc (definition). > > This allows rtc_video_encoder_factory.cc|h to move to Blink in a > follow up step. > > BUG=787254 > R=guidou@chromium.org, haraken@chromium.org, jam@chromium.org > > Change-Id: I4ba7c59da0f799e1d30053923fb1e692202223b6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778671 > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#692757} TBR=guidou@chromium.org Bug: 787254 Change-Id: I479b07d13802e3cad25b57e8c7dbeee048db0fd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782514 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#692861}
-
Cathy Li authored
Bug: 977713, 987301 Change-Id: I7e0be3b3f8367be2f5f1e3d42f7b46a7f6b79b66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775188 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#692860}
-
Joe DeBlasio authored
This CL drops the "Safety tip: " prefix from the safety tip bubble to get us closer to our new mocks. Bug: 996731 Change-Id: I1dfb629378e0becdeaf7222d78fb2e9616b42a5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782128Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#692859}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I417640eee3feba3ca2205b20376a6d8b808d6f48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781534 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#692858}
-
Ahmed Mehfooz authored
Mirror highlight path if a view has canvas flip for RTL enabled. Remove unneeded inkdrop highlight code in system tray. Bug: 997843 Change-Id: I4df02654d1fc25f5c8a93c59f36abe092fdf4f60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771041 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#692857}
-
Kyle Milka authored
These actions are no longer recorded. Bug: None Change-Id: I163d0ec558f57efd753cdd2d0f2cc3ff7906f14a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775361 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#692856}
-
Maksim Ivanov authored
Avoid letting the focus jump from the password/PIN input field to the "1" PIN keypad button when both fields are about to be hidden. This case occurs when entering a security token PIN at the login/lock screen into the user pod that uses challenge-response (a.k.a. smart card) authentication. Without this CL, this quick focus jump led to unexpected effect that the accessibility screen reader was saying "ONE". Fix this by swapping the visibility manipulation of the textfield and the keypad, so that the keypad is hidden before the textfield and therefore doesn't receive the focus during this UI update. Bug: 990391 Test: enable ChromeVox, click on the smart card user's pod on the login screen, enter valid PIN, check that ChromeVox didn't say "one" Change-Id: I2c3fa26580cb94f97b6f98290b2003b226929552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783138Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#692855}
-
Connor Clark authored
Bug: 1000409 Change-Id: I2917f7d8a63b14fc8f13e692ed12551f437e9c9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783245Reviewed-by:
Paul Irish <paulirish@chromium.org> Commit-Queue: Connor Clark <cjamcl@google.com> Cr-Commit-Position: refs/heads/master@{#692854}
-
arthursonzogni authored
It turns out the process used to load about:srcdoc was not always correct. For instance, when starting from A(B), if B navigates to about:srcdoc, it was sometimes loading in B's process instead of A's process. This is now fixed and enforced. This is not a regression. The previous code about srcdoc in RenderFrameHostManager::CanSubframeSwapProcess() isn't really effective when the about:srcdoc navigation happens AFTER a cross-process one. Bug: 996044, 996725 Change-Id: I670ee6dc917cfe4cb02721a58a79a1a415b45e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773264Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#692853}
-
Christian Biesinger authored
Always set the override size instead of checking whether we need to, no downside to doing that and code is a bit simpler, and move this setting to *before* calling CanAvoidLayoutForNGChild, so that it actually does the right thing. Also make the code in the condition not overwrite whether we need layout, just add to it. This may have been a bug but I don't have a broken testcase. R=dgrogan@chromium.org, eae@chromium.org Change-Id: If5b1d69a4307720c40f620d7a76b2e5222f1719c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779129 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#692852}
-
Jérôme Lebel authored
Adding accessibility identifier in the link in the user consent view. Updating ChromeSigninViewControllerTest to use this identifier. Bug: 1000357 Change-Id: I327a93f2da0e79ed7bd300bb943b323bf3ae21e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782804 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#692851}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/23c7a63c..e576e759 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I062ac15730aa5537291e1a25439f8c465fe05d1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782723Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692850}
-
Toni Barzic authored
The margin for small config is different than other (2 instead of 4), so it cannot be just hardcoded in folder_image. Updates how item image offset from the center of the folder icon is calculated to 1/2 (item icon size + item margin), which matches the new spec. It's little different from the existing logic, where the item icon is inset by 2 dip from the folder icon edge, but the numbers match for the current (kShared) config. BUG=996808 Change-Id: I4b5ffab257055d89ec612e60076af6cf6e24f841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779668Reviewed-by:
-
Aga Wronska authored
Bug: 999391 Change-Id: If2c808eaff4df58729f5fdb11d0a33b4aec25419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782675Reviewed-by:
-
James Cook authored
Record a pref when the user closes the banner so we don't show it every time. Screenshot: http://screen/McRQaMqm23c With secondary user banner: http://screen/tFGqMWtwCbm Secondary user banner only: http://screen/eARAncc5nHS Bug: 1000307 Change-Id: I1134301e1b8a84b71fa83a5994b6fa1aafbdd5ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783060Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#692847}
-
Xing Liu authored
Currently the notification entry is inserted into stl container after loading the icon, which causes the background task coordinator failed to find the notification and won't trigger any background task. This CL inserts the entry when all asynchronous opeartions are done, and reply the result in a callback. This behavior should be covered with end to end test. Bug: 998998 Change-Id: I00d9f3b8c3f6b93c37fa8d93dc319e0c1aa91f11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779567Reviewed-by:
Hesen Zhang <hesen@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#692846}
-
Sasha McIntosh authored
Similar to the work done for WebP YUV decoding, we would like to implement direct decoding of JPEG 4:2:0 images to YUV rather than RGB for non progressive JPEGs. BUG: 919627 Change-Id: Ie6522e51204a0013b1db7b0635bed5cdb847baa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768817 Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#692845}
-
Brian Salomon authored
Failure is expected when the GL context is lost and so we should not assert as Skia's default handler does. Bug: 999327 Bug: 1000384 Change-Id: Iab2bd55a674e5143ec006959889a462511cdeabf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783297Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#692844}
-
Aaron Leventhal authored
After updating aria-hidden to false on ancestor, the table row and cell roles need to be updated. Bug: 928384 Change-Id: I57cbda12b3f7de9170fc007eb1561f5ccf2eb93c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776400 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#692843}
-
Philip Rogers authored
This is never true, as LocalFrameView is no longer a ScrollableArea. Change-Id: Ic190ce31bf4f13baa6a0f6a7a439511551011a80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783220 Auto-Submit: Philip Rogers <pdr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#692842}
-
Stephen McGruer authored
This is essentially a hack to fix crbug.com/995806. The HTML spec says that the clock for animations is only updated once per rendering lifecycle, at the start. However the spec also assumes that the user agent runs rendering lifecycles constantly, back-to-back. In Blink we attempt to *not* run rendering as much as possible, to avoid unnecessary CPU usage. Unfortunately that then means that when we are outside of the lifecycle, e.g. in a setInterval, the AnimationClock time no longer updated after https://crrev.com/629180f ! This is a short-term fix for that problem, by re-introducing the old dynamic self-update behavior - but only when outside of rendering lifecycles. Note that it may still have an effect on the overall time, as the logic sometimes guesses too far and the next real frame may have an older time than we updated the clock to. In that case there would be a discrepancy between the animation clock time and things like the rAF timestamp, but it isn't the worst bug in the world. Bug: 995806 Change-Id: I66642c28026c9370c73b5ce4d7db2fa2981ec7e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778598Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#692841}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2bacc9ef457f..042f99bcb1d4 git log 2bacc9ef457f..042f99bcb1d4 --date=short --no-merges --format='%ad %ae %s' 2019-09-03 treehugger-gerrit@google.com Merge "Send proto instead of text when tracing an Android device with webUSB" Created with: gclient setdep -r src/third_party/perfetto@042f99bcb1d4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ie2d4c4469020297cdcdce6aa1f74a6bdad621a75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783248Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692840}
-
Vasiliy Telezhnikov authored
This CL modifies SkiaOutputDevice to support more than one swap operation in flight. It also enables triple buffering for SkiaOutputDeviceBufferQueue. Bug: none Change-Id: I25bd07caa4ae28fcfbb5b1502682763b5ee76bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779001 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#692839}
-
Xiaocheng Hu authored
This patch moves SVGLengthInterpolableType from the deprecated list-of-numbers model to the newly introduced InterpolableLength, to avoid handling details of length values directly. It also paves the way to supporting SVG length interpolation on values involving comparison functions min/max. Note: this patch has no behavior change in MaybeConvertSVGLength. The old code relies on AccumulateLengthArray(), which doesn't support unitless lengths in math expressions (e.g., calc(1px + 1)). This patch doesn't change it, but simply rewrites it and tracks it with a TODO. Bug: 991672 Change-Id: I50c0a6f2609daf477b5f7970c6c898e5531668bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775736Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
-
Yann Dago authored
chrome://flags http://screen/Lo55W5zX19F chrome://flags/enterprise http://screen/93FCOP69fGG Bug: 999089 Change-Id: Id6018d21283ef40b7e94e1e79eb74b9c104583f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779189 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#692837}
-
François Doray authored
Test fails on Windows. TBR=dalecurtis@chromium.org Bug: 1000396 Change-Id: If59d2db47148a203517ebe433662b9a738b9c619 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783398Reviewed-by:
-
Andrew Grieve authored
It can be used to spot check optimizations are working. Change-Id: I27445d674894869dc27264440ccf8aa84c4e66d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779007 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#692835}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/77743492418e..e9d9a3278fdf git log 77743492418e..e9d9a3278fdf --date=short --no-merges --format='%ad %ae %s' 2019-09-03 brianosman@google.com Remove GrGLProgram cache stats, remove spurious declarations/includes 2019-09-03 halcanary@google.com gn: move all skia_* declare_args to skia.gni 2019-09-03 egdaniel@google.com Track all sampled textures in GrOpsTask and pass them to GrOpsRenderPass. 2019-09-03 bungeman@google.com [pdf] Only compute needed advances. 2019-09-03 kjlubick@google.com [canvaskit] Add rrect support 2019-09-03 reed@google.com update test to allow dumping images Created with: gclient setdep -r src/third_party/skia@e9d9a3278fdf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jlavrova@google.com Bug: chromium:996185 Change-Id: If16273cf83c08501ef8d164287269e7f429c87f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783078Reviewed-by:
-
Misha Efimov authored
- Keep NSURLRequest.HTTPBodyStream in HttpProtocolHandlerCore::http_body_stream_ to work around system behavior of returning new NSStream object for each call if NSURLRequest.HTTPBody is set. - Initialize |http_body_stream_delegate_| to nullptr if request doesn't have a body. - Rename HttpProtocolHandlerCore::http_body_stream_[delegate_] member variables for consistency. TBR=dschinazi@chromium.org Bug: 979324 Change-Id: Ibc0b5d4226c3e517f314e66fa305a995b54cc008 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778407 Commit-Queue: Misha Efimov <mef@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#692833}
-
Sidney San Martín authored
The toolbar buttons were easy to hit by accident. Bug: 999545 Change-Id: I7922fc6a942190e1f53bc37b49fe9bda09c516ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783197Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#692832}
-
Steven Bennetts authored
internet-detail-dialog is a top level element that may be loaded before InternetDetailDialogUI::BindCrosNetworkConfig() is called, causing 'chromeos.networkConfig.mojom' to be undefined when the HTML is loaded. Because of this, defining 'const mojom = chromeos.networkConfig.mojom' at the top level triggers an error. To address this, avoid using the alias outside of individual JS methods. This also fixes an error where cr_network_listener_behavior.html was not being included. Bug: 1000207 Change-Id: Id1c87c08a1c019d4c4dafbbc668dcce63c1c9c4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783064 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#692831}
-
Mitsuru Oshima authored
Original CL: crrev.com/c/1767716 Bug: 989052 Change-Id: Id2e5e00c922e7e707afd0ad3312ad4b3d0aa9fa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781541Reviewed-by:
Wei Li <weili@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Reviewed-by:
-
Mikel Astiz authored
This experimental mode will allow plumbing the sync encryption keys by means other than the keystore keys in the sync protocol. Bug: 1000146 Change-Id: Ic78acb87036b4d1ba5158b260e4f383b08d550bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714585 Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#692829}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d9cbe7ad6916..1db68ea0ba17 git log d9cbe7ad6916..1db68ea0ba17 --date=short --no-merges --format='%ad %ae %s' 2019-09-03 jmadill@chromium.org Add ANGLE issue tracker to my_activity.py. Created with: gclient setdep -r src/third_party/depot_tools@1db68ea0ba17 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:None Change-Id: I9e0e88876a967729b617d6934222879d0eb51ff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783244Reviewed-by:
-
Sidney San Martín authored
Also unlist Cocoa owners; they don't need to be bugged about this flag. Change-Id: Id90a93c424c7b5b65f5863b4d9bccd712d76db37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782941 Auto-Submit: Sidney San Martín <sdy@chromium.org> Reviewed-by:
-
Alexander Hendrich authored
This CL implements focusing behavior when tabbing through elements in the login screen extension UI's window. When reaching the last element of the window, the next tab will focus the first element of the login tray. When reaching the last element in the login tray, the next tab will focus the first element in the window. The same procedure also works with backwards tabbing (shift+TAB). Bug: 957573 Change-Id: I0e08c8b2a58e9b7efe4497927044f25277afb56b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774448 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#692826}
-
Nikita Podguzov authored
After UX decide to remove placeholders from printing strings we should also remove it from the code. Current behavior causes crash of DCHECK() here: https://cs.chromium.org/chromium/src/ui/base/l10n/l10n_util.cc?l=742 Bug: 985020 Change-Id: Ib929037beb6b3cc5ad70c86f36d52480145daa47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778489Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Cr-Commit-Position: refs/heads/master@{#692825}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/437660031093..050b124d7838 git log 437660031093..050b124d7838 --date=short --no-merges --format='%ad %ae %s' 2019-09-03 syoussefi@chromium.org Reland "Vulkan: Debug overlay" 2019-09-03 mihu@microsoft.com ANGLE test fixture leaking. Created with: gclient setdep -r src/third_party/angle@050b124d7838 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@chromium.org,jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org,jmadill@google.com Bug: None Change-Id: Id65c1b414268947a5ddacafdd7612229cab6087e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782746Reviewed-by:
-
Dominic Battre authored
One challenge of fixing local heuristics is to understand why a certain field has been classified by the local heuristic. This CL introduces corresponding logging in chrome://autofill-internals. Bug: 928595 Change-Id: Ia6b31ced07c58e7b6c8ee330243e3ae577505847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781462 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#692823}
-
Yannic Bonenberger authored
*** Note: There is no behavior change from this patch. *** This CL replaces calls to base::{Bind,BindRepeating} with calls to base::BindOnce, and removes calls to base::AdaptCallbackForRepeating when the returned base::RepeatingCallback is immediately converted to a base::OnceCallback. This CL was uploaded by git cl split. R=nharper@chromium.org Bug: 714018 Change-Id: I097288f597b7287b3e6c0f512fe7d69ab374a315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778610 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
-
