GitLab

The In-Product Help demo mode currently only supports enabling demoing
all In-Product Help features, or none of them.

This leads to issues with testing some of them, since they might
happen at the same time, and it is confusing to test.

This CL fixes that issue by adding support for selecting only a single
In-Product Help feature to demo at a time, in addition to keeping the
old choice of enabling all or none of them.

BUG=728449

Change-Id: I78902c48117eb4e6602f768186579d08f4a83217
Reviewed-on: https://chromium-review.googlesource.com/520626
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476472}

This test causes HttpNetworkTransactionTests tests to crash on iOS.

BUG=728808
TBR=mef

Review-Url: https://codereview.chromium.org/2920733003
Cr-Commit-Position: refs/heads/master@{#476471}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/c294424b587e..817b8684be60

$ git log c294424b5..817b8684b --date=short --no-merges --format='%ad %ae %s'
2017-06-01 benjhayden In dashboard alerts-table, select ranges of alerts on shift+click.

Created with:
  roll-dep src/third_party/catapult


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I78ff3d2dd252da81164f34b79e474f84f49182f7
Reviewed-on: https://chromium-review.googlesource.com/521887
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476470}

This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL26

Pass a callback into ServiceLaunchedVideoCaptureDevice that gets invoked when
the connection to the video capture service is lost. The connection lost signal
is passed through the VideoCaptureController to the VideoCaptureManager.

Additional change:
Uninitialize VideoCaptureProvider when the last client disconnects. This is to
allow the service to shut down when it is no longer in use.

BUG=584797
TEST=
  content_unittests --gtest_filter="*Video*"
  content_browsertests --gtest_filter="VideoCaptureBrowserTest.*"

[1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing

Review-Url: https://codereview.chromium.org/2902203002
Cr-Commit-Position: refs/heads/master@{#476469}

https://pdfium.googlesource.com/pdfium.git/+log/5f34d479d06e..5171a27eaa74

$ git log 5f34d479d..5171a27ea --date=short --no-merges --format='%ad %ae %s'
2017-06-01 tsepez Use unique_ptrs for codec contexts in ccodec_progressivedecoder.

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I927f171f64bba1e6b989db6a09e4bb859bc036ce
Reviewed-on: https://chromium-review.googlesource.com/521766
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476468}

Previously, isolated origins subframes from unrelated tabs would
always get their own process.  This results in too many tabs for
scenarios like sign-in, where there's a sign-in subframe on every
Google tab.  To address this, set the process reuse policy to allow
isolated origin subframes to reuse existing processes for that origin.

BUG=713444
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2920473005
Cr-Commit-Position: refs/heads/master@{#476467}

This patch is in preporation to break target dependency in
NetworkRequest. This specific patch is because we will be adding more
conditions in canReplayRequest().

R=dgozman,pfeldman
BUG=None

Review-Url: https://codereview.chromium.org/2906843002
Cr-Commit-Position: refs/heads/master@{#476466}

This is a continuation of changes in http://crbug.com/616967; the purpose
is to make it so that in general there's one class per file, and files
aren't too large.

This CL also makes a couple of minor clean-up changes in the classes
that are moved, e.g. changing method order, but this CL doesn't
include any changes to behavior.

Bug: 616967
Change-Id: I4f6aade879d0f660d3f35668448028e8ef0651b0
Reviewed-on: https://chromium-review.googlesource.com/521787
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476465}

This is additional CL to support update over cellular.
- add a property in NetworkState indicating tethering state.
- show a warning message in about Chrome OS page on tethered networks.

BUG=691108

Review-Url: https://codereview.chromium.org/2919683002
Cr-Commit-Position: refs/heads/master@{#476464}

When clicking inside a button and dragging the mouse out of the button's
bounds, a button should update its appearance to show that its action
will not fire if the user releases the mouse. This cl fixes a problem
with the tab close button where it would always show the mouse down
state, even if you clicked and dragged outside of it.

This cl also does a little refactoring, moving common init-time code to
a commonInit method (like its HoverCloseButton subclass).

R=avi@chromium.org
BUG=647757

Review-Url: https://codereview.chromium.org/2898343002
Cr-Commit-Position: refs/heads/master@{#476463}

This method accesses audio/video_streams_ collections and must acquire
the |lock_| since those collections might be modified from a different
thread.

BUG=726526

Change-Id: Ibb9ab848612f9bace1321aed56a4d22706ab7bea
Reviewed-on: https://chromium-review.googlesource.com/517226Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Commit-Queue: Sergey Volk <servolk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476462}

https://skia.googlesource.com/skia.git/+log/c6912f712f34..1bfece8556cc

$ git log c6912f712..1bfece855 --date=short --no-merges --format='%ad %ae %s'
2017-06-01 robertphillips Rm int flavor of GrNextPow2 in favor of uint32_t flavor
2017-06-01 kjlubick Use ssh to trigger chromecast test
2017-06-01 lsalzman fix premultiplied color generation in linear gradients when using fApplyAlphaAfterInterp
2017-06-01 mtklein have shaders that need seed_shader call it themselves
2017-05-31 recipe-roller Roll recipe dependencies (nontrivial).
2017-06-01 mtklein plumb y through to SkJumper
2017-06-01 jcgregorio [fiddle] Report GL driver info.
2017-06-01 brianosman Revert "Expand texturability testing to cover mip-mapped textures, and fix iOS"
2017-06-01 brianosman Expand texturability testing to cover mip-mapped textures, and fix iOS
2017-06-01 mtklein update SkRasterPipeline::run() to also take y
2017-05-26 msarett Better image for copyTo4444 test
2017-06-01 brianosman Revert "Expand texturability testing to cover mip-mapped textures, and fix iOS"
2017-06-01 fmalita Add smartptr SkRWBuffer snapshot methods
2017-06-01 robertphillips Update copyOp to split-opList world
2017-06-01 brianosman Expand texturability testing to cover mip-mapped textures, and fix iOS
2017-06-01 robertphillips update GrOp printouts
2017-05-31 mtklein raster pipeline sprite blitter

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=herb@chromium.org

Change-Id: I190f25b47a967af5fb7466f0471616e2feba34e9
Reviewed-on: https://chromium-review.googlesource.com/521705Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476461}

This reverts commit b9cd452c.

Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=728792

Original change's description:
> Image Capture: Enable browser tests in Mac and Android
> 
> This CL enables Image Capture browser test in Mac and Android; this test
> needs a real-ish camera, so it's only part of the webrtc infra, which is
> run explicitly in "large bots" [1].
> 
> Also git cl format restyled the code a bit.
> 
> [1] https://build.chromium.org/p/chromium.webrtc/waterfall
> 
> 
> Bug: 656810
> Change-Id: Iadc2fa1b4b5b56c3e06288b73e452a40e15b3426
> Reviewed-on: https://chromium-review.googlesource.com/521263
> Reviewed-by: Vincent Scheib <scheib@chromium.org>
> Commit-Queue: Miguel Casas <mcasas@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#476350}

TBR=scheib@chromium.org,mcasas@chromium.org
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 656810

Change-Id: I094b9d51dbf46f9e1a96458d6fe7264aae18cff1
Reviewed-on: https://chromium-review.googlesource.com/521708Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476460}

If we support browsing in VR, when we leave a page that support presentation
on headset insertion, don't unregister the Daydream intent.

Bug: 728638
Change-Id: Ie9087e2a2a35a6e5d5839b6f1ef0672ba3b781aa
Reviewed-on: https://chromium-review.googlesource.com/521942Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476459}

Bug: 713222
Change-Id: Ice1cd5d0061aff3470aa61420de0244a6fd414a4
Reviewed-on: https://chromium-review.googlesource.com/521662
Commit-Queue: rnephew <rnephew@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476458}

This CL relands crrev.com/2899073006 with some fixes/tweaks:

- RWHI::DidProcessFrame is not currently called in the
SynchronousCompositor code path. RWHVAndroid::SynchronousFrameMetadata
should call into RWHI::DidProcessFrame.

- SynchronousCFS::SubmitCompositorFrame will not send the frame to
the browser after fallback tick fires. We should make sure
QueueMessageSwapPromise doesn't send the swap messages either.

- There is no reason to pass frame_swap_message_queue to RendererCFS.

BUG=726485

Review-Url: https://codereview.chromium.org/2921713002
Cr-Commit-Position: refs/heads/master@{#476457}

ScopedMockObject implementation depends on scoped_nsobject with is not
ARC-compatible. Scoped*MockObject class is only used in Cast unit and
EG tests. Now that they have been converted to ARC, these classes are
no longer necessary.

Change-Id: Ifb4746d6b302eb50427dce2e0cf8c1940eed2df5
Reviewed-on: https://chromium-review.googlesource.com/520565Reviewed-by: Mike Baxley <baxley@chromium.org>
Commit-Queue: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476456}

Previously when the user clicks on an offline host, the client will still
attempts to connect to it, then it crashes.

This CL prevents the client from attempting to connect to an offline host.
When the offline host is selected, the client will just show a snack bar
message and do nothing else.

Review-Url: https://codereview.chromium.org/2914233003
Cr-Commit-Position: refs/heads/master@{#476455}

https://chromium.googlesource.com/angle/angle.git/+log/cae72d6..b7d5e30

BUG=2016

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2915203002
Cr-Commit-Position: refs/heads/master@{#476454}

BUG=718187

Review-Url: https://codereview.chromium.org/2904293002
Cr-Commit-Position: refs/heads/master@{#476453}

BUG=727959

Review-Url: https://codereview.chromium.org/2921453003
Cr-Commit-Position: refs/heads/master@{#476452}

Remove _URLOnStartLoading from crw_web_controller as its not read anywhere.

BUG=

Review-Url: https://codereview.chromium.org/2919473004
Cr-Commit-Position: refs/heads/master@{#476451}

R=dpapad@chromium.org
BUG=727449

Review-Url: https://codereview.chromium.org/2919663002
Cr-Commit-Position: refs/heads/master@{#476450}

BUG=

Review-Url: https://codereview.chromium.org/2914923002
Cr-Commit-Position: refs/heads/master@{#476449}

In stacked tab mode, if the active tab's x-position
is maximal and there is a stacked tab to its left,
gesture-dragging the active tab to the left will
produce a gap in the tabstrip. Prevent this from
happening by invoking AdjustStackedTabs() rather than
ResetToIdealState(), as is done in the symmetric case
of gesture-dragging to the right.

BUG=454479
TEST=StackedTabStripLayoutTest.DragActiveTabExisting

Review-Url: https://codereview.chromium.org/2918653002
Cr-Commit-Position: refs/heads/master@{#476448}

Change-Id: Ice22726f0bfb7cda5c5b1e60dd844c415527fd1f
Reviewed-on: https://chromium-review.googlesource.com/513527Reviewed-by: Jeff Carpenter <jeffcarp@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476447}

- CSS Parser now is ThreadSpecific and not only static local.
- Multi threaded tests for all code that OffscreenCanvas filters
currently use:
  - CSSToLengthConversionData
  - CreateOffscreenFilterOperations

Bug: 724565
Change-Id: I7fdc7f2ff0246709211740d8f708f65513aa2a4f
Reviewed-on: https://chromium-review.googlesource.com/517969
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476446}

This allows developers to request a decode of an img element.
When the promise resolves, the compositor will keep the image
locked for two frames, ensuring that if appended into the DOM,
jank is minimized.

Intent to implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/LMV9dBG_1-I

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2769823002
Cr-Commit-Position: refs/heads/master@{#476445}

The GetUrlForPagewithTitle method on ChromeWebViewTest needed to be
implemented manually becuase the previous default handler which was
handling the echotitle url only looks for the value within the request
body which is not usable for CWVWebView tests as they must pass all data
within the url.

BUG=704038

Review-Url: https://codereview.chromium.org/2902403002
Cr-Commit-Position: refs/heads/master@{#476444}

In order to notify FrameFetchContext of frame detach event, this CL adds a
new function. FrameFetchContext::document_ has been a weak member due to a
reference cycle. This CL also makes the reference strong and break the cycle
explicitly on the event.

Bug: 695939
Change-Id: I0395c649c1da4797be3f9055ee38c86ff5e6e844
Reviewed-on: https://chromium-review.googlesource.com/516843Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476443}

Bug: 718063
Change-Id: I7c9769b3115c2de8dc07443117271d8b10782b87
Reviewed-on: https://chromium-review.googlesource.com/520284Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476442}

The workaround to confine ARC windows to the primary display is no
longer needed now that ARC supports multiple displays.

BUG=718627
TEST=Extended desktop mode works for ARC and other clients.

Review-Url: https://codereview.chromium.org/2862173004
Cr-Commit-Position: refs/heads/master@{#476441}

BUG=726553

Review-Url: https://codereview.chromium.org/2911583003
Cr-Commit-Position: refs/heads/master@{#476440}

This CL adds a lock indicator image as well as the corresponding "https://"
scheme to a host name if the connection is secure. The logic for determining
if the connection is secure (which should be in the Payment Request Manager
class) will not be implemented in this CL. As of now there is a bool created
in that manager class that is set to false denoting that the connection is not
secure. However I have attached images showing what the UI would look like
if this boolean was set to true. A later CL will implement the logic behind
determining if the web context is secure.

Screenshot #1: http://imgur.com/a/2HbUG
Screenshot #2: http://imgur.com/a/qWmpo

Bug: 602666
Change-Id: I959189bb8e06ace669d06df960360947c52d6638
Reviewed-on: https://chromium-review.googlesource.com/518247
Commit-Queue: Randall Raymond <rayraymond@google.com>
Reviewed-by: mahmadi <mahmadi@chromium.org>
Reviewed-by: Louis Romero <lpromero@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476439}

BUG=672263

Review-Url: https://codereview.chromium.org/2913363002
Cr-Commit-Position: refs/heads/master@{#476438}

https://pdfium.googlesource.com/pdfium.git/+log/f6ca07b3fda4..5f34d479d06e

$ git log f6ca07b3f..5f34d479d --date=short --no-merges --format='%ad %ae %s'
2017-06-01 tsepez Move CCodec_GifModule state to CGifContext
2017-06-01 thestig Simplify code in fpdfformfill.cpp.
2017-05-31 thestig Clarify IPWL_Filler_Notify::QueryWherePopup() parameters.

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I49adabc079052c90f0f69451156fda02009e9d0c
Reviewed-on: https://chromium-review.googlesource.com/521886
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476437}

Chrome creates QuirksManager, so that when mash tries to access
QuirksManager we get a crash.

BUG=728748,718860
TEST=none
R=kylechar@chromium.org

Change-Id: I13f33abde92cb13048542469440f5ab8cc562e00
Reviewed-on: https://chromium-review.googlesource.com/521922Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476436}

ResourceSettings holds the field that are used by LayerTreeHostImpl and
LayerTreeHostImpl no longer needs LayerTreeSettings::renderer_settings.

cc: :Display to create ResourceProviders. With ResourceSettings,
Bug: 711146
Change-Id: Ib3594b35cbf698913fde91a5ec72c6323aa561d6
Reviewed-on: https://chromium-review.googlesource.com/517748Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Xingyu Zhang <staraz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476435}

BUG=727825

Review-Url: https://codereview.chromium.org/2909283003
Cr-Commit-Position: refs/heads/master@{#476434}

Bluez recent changes corresponding to this CL:
https://chromium.googlesource.com/chromiumos/third_party/bluez/+/758dae03725ed7a1138d848aad940a73bbf5d659
https://chromium.googlesource.com/chromiumos/third_party/bluez/+/d356a6242be9a1aba2cca871b79618e3b28a5ec2

BUG=725349
TEST=Called chrome.bluetoothLowEnergy.registerAdvertisement with
advertisement data containing both manufacturerData and serviceData, the
operation succeeded.

Review-Url: https://codereview.chromium.org/2907913002
Cr-Commit-Position: refs/heads/master@{#476433}