GitLab

Implemented image list item for the new download home.

Bug: 850595
Change-Id: Ie82086b6b619a9a9b17a2fc4a6da9d5341fe74dd
Reviewed-on: https://chromium-review.googlesource.com/1123159
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575539}

This is used immediately for clearing up the logic around allowfullscreen
and allowpayment request, and can also be used for more complex
container policy logic in the future.

Change-Id: I9cc702e0344d86d56a91894dc7a5a25bcdc26424
Reviewed-on: https://chromium-review.googlesource.com/1136909
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575538}

Time::FromTimeVal() method will add the offset of UNIX epoch,
and breaks the timestamp check at video_encode_accelerator_unittest.
This CL change it to Time::FromMicroseconds().

BUG=chromium:853185
TEST=pass video_encode_accelerator_unittest at Kevin device

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ia13027141062015f904be74b9323a988697fea3a
Reviewed-on: https://chromium-review.googlesource.com/1133612
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575537}

UI.Toolbars give 'flex: none' to their shadow :host. In [1], an extra
element was placed in between the Toolbar and the flex container,
breaking the 'flex: none'.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1080036

Screenshot: https://imgur.com/a/wyacU7H

Bug: 860476
Change-Id: If12df76e2bf711c93acee8df5d7f0bbb0a5a868d
Reviewed-on: https://chromium-review.googlesource.com/1139049Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575536}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=amineer@chromium.org

Change-Id: Ia8c2213b2fad3834d7201b1b6b86aeffeb15f3ba
Reviewed-on: https://chromium-review.googlesource.com/1139815Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575535}

Bug: 862537
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie69f12655aae22a9c48452d86ef27bafafadae68
Reviewed-on: https://chromium-review.googlesource.com/1132912
Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575534}

Because of the way manifests were setup the browser was connecting
to ws2, but it wasn't configuring aura/views correctly.

BUG=none
TEST=none

Change-Id: I1e5f858d3b513d99f56d12fef6bfb137c7eaeabf
Reviewed-on: https://chromium-review.googlesource.com/1139181
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575533}

Using wpt-import in Chromium ce49be89.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21472

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
mkwst@chromium.org, andypaicu@chromium.org:
  external/wpt/content-security-policy

TBR=raphael.kubo.da.costa@intel.com

No-Export: true
Change-Id: I72d7b8eb15d0e21f732e4ba861d18a7b437ab2bb
Reviewed-on: https://chromium-review.googlesource.com/1139316
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575532}

https://skia.googlesource.com/skia.git/+log/c45a5c559365..0c64e52aea82


git log c45a5c559365..0c64e52aea82 --date=short --no-merges --format='%ad %ae %s'
2018-07-17 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-07-16 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 ddd8eaa8dca0..e076a2327f0d (7 commits)
2018-07-16 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-07-16 bungeman@google.com Remove SkRefDict.
2018-07-16 bsalomon@google.com Stop running gltestpersistentcache in PreAbandonContext mode
2018-07-16 herb@google.com Remove processText last vestige of drawText
2018-07-16 herb@google.com Remove drawText support from SkOverdrawCanvas
2018-07-16 bsalomon@google.com Blacklist dftext from gltestpersistentcache
2018-07-16 bsalomon@google.com Test GrContextOptions persistent cache on linux/quadrop400 bots.


Created with:
  gclient setdep -r src/third_party/skia@0c64e52aea82

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=bungeman@chromium.org

Change-Id: I1f23a3f20de8c9bf2997fa5f8910858df62c4d6b
Reviewed-on: https://chromium-review.googlesource.com/1139007Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575531}

This reverts commit d1fef2b1.

Reason for revert: Suspected culprit for crbug.com/863786

Original change's description:
> blink/wtf: Really move MovableStrings when DCHECK_IS_ON.
>
> When a MovableString is parked, actually park the content, and poison
> the previous allocation. This is intended to find cached raw pointer
> accesses, which are not allowed beyond the UI thread task per the
> contract of the class.
> Enabled only when DCHECK_IS_ON to prevent potential crashes.
>
> Changes with and without DCHECK()s:
> - Cache some String properties in MovableStringImpl
> - Add a parked_strings_ to MovableStringTable for accounting, and
>   update tests accordingly.
>
> Changes with DCHECK()s:
> - Add a parked_string_ member to MovableStringImpl
> - Copy the string to the parked version in Park(), and poison the
>   previous allocation.
> - Restore the string in Unpark().
>
> Bug: 837659
> Change-Id: Ib7631d5e12471826c9e71a424e30d26cf8f1f042
> Reviewed-on: https://chromium-review.googlesource.com/1133169
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Commit-Queue: Benoit L <lizeb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#574529}

TBR=haraken@chromium.org,lizeb@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 837659, 863786
Change-Id: I380210859a1eed42d869c1548d0d93b0e8606e58
Reviewed-on: https://chromium-review.googlesource.com/1138873
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575530}

Known issues
- Settings icon fades in/out. Will address in follow up.
- ActionView is just a wrapper now for a LogoView. Will do a follow up
  CL to further clean this up.

See bug for spec/demo.

Bug: b:111500701
Change-Id: Iee2902f0c34b33cce579a78fb91b4519a2dff8c7
Reviewed-on: https://chromium-review.googlesource.com/1137843
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575529}

Pressing Assistant UI when it is in mini state should cause it to
re-expand. We only do this when NOT using stylus input modality.

The implementation uses a delegate pattern analogously to what was
done previously with CaptionBar(Delegate).

Bug: b:110986383
Change-Id: I3dfdb85542b9ae591e3ec3f2f74eb4e7065a3859
Reviewed-on: https://chromium-review.googlesource.com/1137483
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575528}

In current Deferred Error Callback implementation, CallDeferredErrorCallbacks
will be invoked in every GPU_CLIENT_SINGLE_THREAD_CHECK().

Current implementation of CallDeferredErrorCallbacks will do extra deque created
and swap operation even there is no errors. This impact performance.

This patch fixed this by adding a flag and skip CallDeferredErrorCallbacks if there are no errors.

Bug: 862069
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ie64aca137ac20bd7a19895a9dafed2a1744348ae
Reviewed-on: https://chromium-review.googlesource.com/1131010Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Shaobo Yan <shaobo.yan@intel.com>
Cr-Commit-Position: refs/heads/master@{#575527}

Like legacy layout, in order to match other browsers when list-style-type
is none, pretend there's an invisible marker in <LI>.

Bug: 725277
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I35d3122f9a99a4262ee41236650ff41aa09ff53d
Reviewed-on: https://chromium-review.googlesource.com/1138044Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: cathie chen <cathiechen@tencent.com>
Cr-Commit-Position: refs/heads/master@{#575526}

https://pdfium.googlesource.com/pdfium.git/+log/481749905d44..ff402c2c4ce8


git log 481749905d44..ff402c2c4ce8 --date=short --no-merges --format='%ad %ae %s'
2018-07-17 tsepez@chromium.org Check for global flag on global proxy objects.
2018-07-16 tsepez@chromium.org Make JSGetObject<C>() return UnownedPtr<C>.
2018-07-16 tsepez@chromium.org Use UnownedPtr/Optional in cfxa_layoutcontext.cpp
2018-07-16 tsepez@chromium.org Use UnownedPtr<> to v8::Isolates.
2018-07-16 hnakashima@chromium.org Fix crash when typing letters into an XFA datetime field.
2018-07-16 rharrison@chromium.org Alert embedder when attempting to save XFA form
2018-07-16 thestig@chromium.org Fix some nits in CPDF_Document.
2018-07-16 vmiklos@collabora.co.uk Add FPDFFormObj_GetObject() API
2018-07-16 rharrison@chromium.org Process data changes regardless if they can be formatted
2018-07-16 tsepez@chromium.org Use UnownedPtr in CXFA_LocaleMgr
2018-07-16 tsepez@chromium.org Remove unused member from CPDF_DataAvail.


Created with:
  gclient setdep -r src/third_party/pdfium@ff402c2c4ce8

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:862059,chromium:857521
TBR=dsinclair@chromium.org

Change-Id: I34c5767262f39734719d87120febf1c2c8193a9a
Reviewed-on: https://chromium-review.googlesource.com/1139006Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575525}

Add iconName property on VolumeEntry and on crostini FakeItem.

Change FileType.getIcon to prefer iconName property if available.

Change CSS to add icon to file-type-icon which is used on file list and
file grid.

The changes above fix crostini (a FakeEntry), downloads and android
(VolumeEntry) to be displayed with proper icons on RHS.

Change directory tree (LHS) icon for shortcut, from "drive" to a new
dedicated icon for shortcuts.

Bug: 846587
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I44e08f9f6d711c45a4e698acbb203e9cb3a87d9d
Reviewed-on: https://chromium-review.googlesource.com/1132258
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575524}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/66a2db59..381ff28a

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I1545c2c73bfd4720ea398826a6844645f5297872
Reviewed-on: https://chromium-review.googlesource.com/1139096Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575523}

Only move code without modifying the implementation so that Barcode Detection
can reuse it.

BUG=848182

Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win10_chromium_x64_rel_ng
Change-Id: Ia04a56efbd2ace4eb05f0ebaa4e341ef7a032fa4
Reviewed-on: https://chromium-review.googlesource.com/1128625
Commit-Queue: Junwei Fu <junwei.fu@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575522}

Bug: 807724
Change-Id: I71ddcf48ef586baa4d784a76f3d281988e6c2fc4
Reviewed-on: https://chromium-review.googlesource.com/1128180Reviewed-by: Adam Rice <ricea@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575521}

Bug: 833380
Change-Id: Icebd24dbe4514239ae0a627dd97dd9276f18c40d
Tbr: kenrb@chromium.org
NoTry: True
Reviewed-on: https://chromium-review.googlesource.com/1139533Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575520}

Add additional details on the permission requirements for the
tabs.captureVisibleTab() method, including that activeTab is required
for sensitive sites that the extension wouldn't otherwise be allowed
access to.

Bug: 839857
Change-Id: I6fa1a68e8dc50bc7c3553fb32740b4c963276395
Reviewed-on: https://chromium-review.googlesource.com/1138634
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575519}

This CL removes the last remaining references to exe_and_shlib_deps (3 were
added since my first CL that removed them).

In addition, I also rename the group to something ridiculously long:
executable_and_loadable_module_and_shared_library_deps.  This is because we
cannot set visibility=["//build/config:executable", ...] because those are
templates.  Renaming ensures folks who were used to adding the dependency no
longer add it, and makes sure that no third party projects have any references
either (I checked and they don't, but this is just to make sure).  The long name
discourages adding the dep manually.

BUG=845700
TBR=dpranke

Change-Id: I1e8861b1045716f488fdbc90b4b8d0ec95abc0a6
Reviewed-on: https://chromium-review.googlesource.com/1132557
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575518}

TBR=bnc@chromium.org

Change-Id: Iaa2eebc6f4534212b7b9b6a9fc50f5408ce9b815
Reviewed-on: https://chromium-review.googlesource.com/1138860Reviewed-by: Nick Harper <nharper@chromium.org>
Reviewed-by: Bence Béky <bnc@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575517}

Change-Id: I17dfd6ca8e94db3b610cca28e0feca2b63bb3d01
Tbr: xiaochengh@chromium.org
NoTry: True
Bug: 860706
Reviewed-on: https://chromium-review.googlesource.com/1139435Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575516}

They are complex to compute, and the results are basically there isn't any:
1) There is usually only one read ongoing (>99% of the time, except I
broke this bucket in M63...)
2) For writes, basically 90+% of the time we have only a single write to
   an entry, too. Most of the rest it's a second write following an
   optimistic write, which can't be easily parallelized since HttpCache writes
   with truncate = true. This isn't entirely impossible, though.

Bug: 757682
Change-Id: I7c65988e14a6d413b95122e9c7c39c922f77524f
Reviewed-on: https://chromium-review.googlesource.com/1122706Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575515}

Adding a new flag for controlling whether homepage tile should be used
and inserted into Most Visited tiles on New Tab Page. This will be
checked along with NTPButton Enabled.

Default value is enabled.

Change-Id: I37ba92a2fe0b40c2c682adf1d34d6306242ece53
Bug: 864191
Reviewed-on: https://chromium-review.googlesource.com/1134587
Commit-Queue: Yafei Duan <romax@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575514}

The new monitor's real DPI would override the forced scale factor, causing
DCHECK failures.  Instead, use the forced scale factor if it exists.

Bug: none
Test: Start a debug build of chrome on a two-monitor system with --force-device-scale-factor=1.5 (or some other value that doesn't match your monitors), drag the window from one monitor to the other.  This shouldn't cause a DCHECK failure.
Change-Id: I5ef336add05840f7ec2d7277b54855ef05e17d28
Reviewed-on: https://chromium-review.googlesource.com/1137481Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575513}

The state change reason should be logged with every discard metric,
to allow proper interpretation.

Adding the state change reason to the observer interface is the first
step towards adding it to every metric.

Bug: 775644
Change-Id: I671ca55494a50bb99e89e8bdd1ec0b18dbe281cb
Reviewed-on: https://chromium-review.googlesource.com/1136949Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575512}

This Cl fixes Offline Gaia layout to match new OOBE style from
https://chromium-review.googlesource.com/c/chromium/src/+/1111025 .


BUG: 863266,  852034
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ibef139a3a685b1be7f8dea52fb9c5f6a5ab73b76
Reviewed-on: https://chromium-review.googlesource.com/1136380
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575511}

This CL changes the way answers reverse content and description
fields (the position/layout approach was incomplete). Font sizes
and colors are also applied to answers according to redline spec.

Bug: 855783
Change-Id: I39d619bbb729d2637f08d9c37fdfd5fb4938361a
Reviewed-on: https://chromium-review.googlesource.com/1137341Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575510}

The AudioDestinationNode is an object managed by Oilpan so the audio
thread should not access it.  However, the audio thread needs
information (currentTime, etc) from the destination node. So instead
of accessing the audio destination handler (a scoped_refptr) via the
destination node, add a new member to the base audio context that
holds onto the destination handler.

The destination handler is not an oilpan object and lives at least as
long as the base audio context.

Bug: 860626, 860522, 863951
Test: Test case from 860522 doesn't crash on asan build
Change-Id: I3add844d4eb8fdc7e05b89292938b843a0abbb99
Reviewed-on: https://chromium-review.googlesource.com/1138974
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575509}

Document a method for using more detailed stack traces to jump directly
to a crashing line of code in Sublime Text.

Change-Id: I14d49091377dd73230cc9e4583a5ebe108f5a575
Reviewed-on: https://chromium-review.googlesource.com/1137489Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575508}

Ensure |blob_data_| is always initialized on successful codepaths even
when OnDataAvailable() is never invoked.

Bug: 863788
Change-Id: I08d0d73fa2a99c3d0b229c05f1c23377eb72f0b3
Reviewed-on: https://chromium-review.googlesource.com/1137956Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575507}

Most callers in chrome/browser/ui need just one helper:
GenerateApplicationNameFromExtensionId

All callers in chrome/browser/ui need just 3 helper functions from
chrome/browser/web_applications/web_app.h.
(See the CL code)

So let's move out these helpers. (No changes in behavior)

This change will allow us to break chrome/browser/ui dependencies on
chrome/browser/web_applications root target.

Also: this CL removes circular dependency between shell_integration_win.cc and
web_app.h

Next steps:
1) Remove web_app.h dependency in create_application_shortcut_view.h
2) Remove web_app.h dependency in shell_integration_linux.cc

Bug: 862049
Change-Id: I53242317d73cc3df5aae0bb61d17aa288fd51821
Reviewed-on: https://chromium-review.googlesource.com/1137953Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575506}

This moves CheckUserVerificationCompatible() from GetAssertionTask into
GetAssertionRequestHandler, and
CheckIfAuthenticatorSelectionCriteriaSatisfied() from MakeCredentialTask
into MakeCredentialRequestHandler.

These preconditions are now checked before dispatching a request onto a
FidoAuthenticator. This means, precondition checks now cover all types
of authenticators, not just FidoDeviceAuthenticator subtypes. The
FidoAuthenticator interface gets a new Options() method to support the
preconditions check (and an implementation for Touch ID is added).

Corresponding unit tests are moved from the FidoTask test into the
matching FidoRequestHandler test.

Also, remove AuthenticatorSelectionCriteria from the FidoTask class and
from the FidoAuthenticator::MakeCredential() signature, where it has
become superfluous due to this change.

Bug: 678128

Change-Id: I75259e63a8ef4fda4ecb0d8c9f8ff25f10c077a6
Reviewed-on: https://chromium-review.googlesource.com/1135601
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Jun Choi <hongjunchoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575505}

R=ericrk@chromium.org

Bug: 859635
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I0afc80a877b5fdae5a4459bb5fa6f767ad842a7d
Reviewed-on: https://chromium-review.googlesource.com/1138750Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575504}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/ee72342a5342..9a962fc1e6e5


git log ee72342a5342..9a962fc1e6e5 --date=short --no-merges --format='%ad %ae %s'
2018-07-16 dgarrett@google.com chrome_committer: Hardcode GCE service account.
2018-07-16 vapier@chromium.org lint: do not use yoda boolean statements
2018-07-16 tbrindus@chromium.org paygen: Clean up arguments in calls to delta_generator
2018-07-16 tbrindus@chromium.org paygen: Remove dependency on brillo_update_payload hashing
2018-07-16 tbrindus@chromium.org paygen: Remove usage of deprecated check_update_payload args


Created with:
  gclient setdep -r src/third_party/chromite@9a962fc1e6e5

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Ifbf720f1ea1b067163a3c8c7925a6bad175c5ee1
Reviewed-on: https://chromium-review.googlesource.com/1139004Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575503}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8d3925b16482..fb734036f4b5


git log 8d3925b16482..fb734036f4b5 --date=short --no-merges --format='%ad %ae %s'
2018-07-16 vadimsh@chromium.org [cipd] Update CIPD client to 2.1.0 (b9c4670197 -> 521b9b6477).


Created with:
  gclient setdep -r src/third_party/depot_tools@fb734036f4b5

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:794764
TBR=agable@chromium.org

Change-Id: I7f7b32f6845b0f30c32d1fe411c8c8e70a0ac705
Reviewed-on: https://chromium-review.googlesource.com/1138995Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575502}

This is a reland of [1] with a fix for animations not starting. This
patch adds a CompositorAnimationHost to LinkHighlights, similar to how
ScrollingCoordinator works, so that the link highlight timeline is
connected to an animation host. A basic test has been added.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1123315

Link highlights are currently owned by the WebViewImpl so their updates
(creation, deletion, layout, paint) happen entirely outside the main
LocalFrameView update lifecycle. In BlinkGenPropertyTrees we will need
to create foreign layers for link highlights which needs to happen after
the link highlight update (LinkHighlightImpl::UpdateGeometry) but before
blink does the cc update (PaintArtifactCompositor::Update). This patch
moves link highlights from WebViewImpl to Page which will let us manage
their lifecycle from the main blink lifecycle update.

This patch does not fix the issue of link highlights getting painted via
a cc paint callback, which will need to be fixed for SPV2, but this does
move us closer towards that goal.

Bug: 857501
Change-Id: I921594484f7b41844b3e2b49c6ef79458f0e7c5b
Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Reviewed-on: https://chromium-review.googlesource.com/1134413Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575501}

Bug: b:80186902
Change-Id: I64ff4ee52144ec15cfeedeeb1ab091aee18ea9e5
Reviewed-on: https://chromium-review.googlesource.com/1115512Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575500}