GitLab

mtune was set to cortex-a8, which is a Nexus S-generation CPU.
Removing it allows for small speed improvements (~1%) for
warm page load times on top10 mobile sites on more recent devices.
Data: https://docs.google.com/spreadsheet/ccc?key=0Ao-xIDuezqMNdDc5OWpxbkk4NFJ0SF9Iemt0Tlg3RFE&usp=sharing
And it has virtually no effect on binary size.
BUG=334271

Review URL: https://codereview.chromium.org/145663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247882 0039d316-1c4b-4281-b951-d872f2087c98

BUG=335900
R=ben@chromium.org

Review URL: https://codereview.chromium.org/150073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247881 0039d316-1c4b-4281-b951-d872f2087c98

R=mpcomplete@chromium.org

Review URL: https://codereview.chromium.org/149703003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247880 0039d316-1c4b-4281-b951-d872f2087c98

BUG=n/a
R=nhiroki@chromium.org

Review URL: https://codereview.chromium.org/147143005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247879 0039d316-1c4b-4281-b951-d872f2087c98

https://codereview.chromium.org/26753005/ might have introduced crashes that
trace to SetContentViewCore.  That previous patch assumed that ContentViewCore
(CVC) always outlives its associated RenderWidgetHostView.  In this patch, we
are trying to ensure that the RWHVA pointer to CVC is nulled when CVC is
destroyed.

Note the following:
- WebContents owns ContentViewCore and WebContentsView.
- CVC and WebContentsView are implicitly destroyed (no direct call to clean-up
code).  So ContentViewCore cannot refer to WebContents or WebContentsView in
its destructor.

Therefore, we use the observer of when WebContents is destroyed to start the
clean up on CVC.


BUG=335165, 324341

Review URL: https://codereview.chromium.org/133073012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247878 0039d316-1c4b-4281-b951-d872f2087c98

BUG=339327
R=kinuko@chromium.org, nhiroki@chromium.org

Review URL: https://codereview.chromium.org/149683008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247877 0039d316-1c4b-4281-b951-d872f2087c98

BUG=333499
TEST=none
R=jamesr@chromium.org

Review URL: https://codereview.chromium.org/149513010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247876 0039d316-1c4b-4281-b951-d872f2087c98

The small icon is a 16x16 image in the bottom right of all notification
templates.  Currently it is not exposed to the JS API, but instead is used
only by internal API systems (starting with synced notifications.)

BUG=284592

Review URL: https://codereview.chromium.org/149433005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247875 0039d316-1c4b-4281-b951-d872f2087c98

This adds traces to entry points in SingleThreadProxy that have
analogous trace events in the ThreadProxy. Also add trace points
along the critical CompositeImmediately -> CommitAndComposite ->
DoCommit/DoComposite code path.

R=enne
BUG=339248

Review URL: https://codereview.chromium.org/149053006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247874 0039d316-1c4b-4281-b951-d872f2087c98

This issue was found by a linter.

R=skuhne@chromium.org

BUG=

Review URL: https://codereview.chromium.org/141133006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247873 0039d316-1c4b-4281-b951-d872f2087c98

BUG=284553

Review URL: https://codereview.chromium.org/146703006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247872 0039d316-1c4b-4281-b951-d872f2087c98

* Make StartMonitoringPowerAsync() synchronous in terms of starting the powermetrics process by waiting for output file to be created before returning.
* Handle parse errors in powermetrics output - empirically while I was able to quite easily get powermetrics into a state where it exited in the middle of writing a sample, I was completely unable to get it not write out at least one sample completely.
* Modify unit test to start/stop powermetrics faster than it's refresh rate to try to trigger malformed output - test fails without rest of this patch, passes with this patch.

BUG=338808

Review URL: https://codereview.chromium.org/145353012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247871 0039d316-1c4b-4281-b951-d872f2087c98

Many of the members from WebApplicationInfo were in place to support
crx-less hosted apps. Since crx-less apps have been removed, we can
clean up references to them and repurpose convert_web_app.cc to be
solely for generating bookmark apps.

Review URL: https://codereview.chromium.org/142993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247870 0039d316-1c4b-4281-b951-d872f2087c98

This is mostly a cosmetic patch to change a boolean into an enum.

BUG=335289

Review URL: https://codereview.chromium.org/131683005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247869 0039d316-1c4b-4281-b951-d872f2087c98

Crash would occur in resetting selection model. It was possible to
attempt to reset the selection model with an active index of -1, which
TabStripModel does not like.

BUG=338285
TEST=see bug
R=ben@chromium.org

Review URL: https://codereview.chromium.org/149393009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247868 0039d316-1c4b-4281-b951-d872f2087c98

BUG=339271
TBR=dglazkov@chromium.org

Review URL: https://codereview.chromium.org/131003014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247867 0039d316-1c4b-4281-b951-d872f2087c98

The remaining pieces in ui/test/ are used only by a unittest in ui/gfx/,
so in this patch we move these files into ui/gfx. This fixes the TODO in
ui/gfx/DEPS that was assigned to Ben.

BUG=None
TEST=ui_unittests
R=tony@chromium.org,ben@chromium.org

Review URL: https://codereview.chromium.org/147803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247866 0039d316-1c4b-4281-b951-d872f2087c98

This cl is pure style-targeted refactoring. 
No functional changes were made. 

BUG=339176

Review URL: https://codereview.chromium.org/148663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247865 0039d316-1c4b-4281-b951-d872f2087c98

Remoting host on windows contains latest revision number so parts
of remoting are rebuilt every time revision number changes. Removed
dependency on LASTCHANGE to prevent ninja from rebuilding remoting
every time. The file is still used.

BUG=332679

Review URL: https://codereview.chromium.org/142713006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247864 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/130803011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247863 0039d316-1c4b-4281-b951-d872f2087c98

Perform /ListAccounts check before session merge to see if there is a need for session merge at all.

BUG=338543
TEST=manual, added OAuth2Test.PRE_PRE_MergeSession to test existing user with fresh cookies, modified OAuth2Test.PRE_MergeSession to test existing user with stale GAIA cookies

Review URL: https://codereview.chromium.org/148463004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247862 0039d316-1c4b-4281-b951-d872f2087c98

BUG=161119

Review URL: https://codereview.chromium.org/148093011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247861 0039d316-1c4b-4281-b951-d872f2087c98

BUG=329384

Review URL: https://codereview.chromium.org/149213004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247860 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/149073004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247859 0039d316-1c4b-4281-b951-d872f2087c98

Since we are only testing correctness and not performance in Debug, we
can use much smaller images and still get decent coverage.

This reduces the runtime in Debug from 17092ms to 191ms.

BUG=338133

Review URL: https://codereview.chromium.org/149063009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247858 0039d316-1c4b-4281-b951-d872f2087c98

Add method to ServiceDiscoveryClient that will allow it to actively refresh
stale services when their TTL runs out.

BUG=336883

Review URL: https://codereview.chromium.org/141583010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247857 0039d316-1c4b-4281-b951-d872f2087c98

BUG=339117

Review URL: https://codereview.chromium.org/137383007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247856 0039d316-1c4b-4281-b951-d872f2087c98

This patch replaces currentDirectoryPath with currentDirectoryURL, and same for the selectionPath. As a result, the entire appState does not depend on paths anymore.

TEST=browser_tests, also tested manually.
BUG=333168

Review URL: https://codereview.chromium.org/132453007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247855 0039d316-1c4b-4281-b951-d872f2087c98

It's a bit ugly--I wish I could get the text and the dropdown indented a bit (the width of one checkbox) so it lines up with the other text. But it's not a big deal and not worth my time figuring out.

BUG=265675

Review URL: https://codereview.chromium.org/149683005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247854 0039d316-1c4b-4281-b951-d872f2087c98

This registers accelerator table entries for VKEY_BROWSER_(BACK|FORWARD)
to IDC_(BACK|FORWARD) for linux platforms (linux desktop and ChromeOS) so
that hardward back/forward keys navigate the browser.

BUG=338945

Review URL: https://codereview.chromium.org/149273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247853 0039d316-1c4b-4281-b951-d872f2087c98

Previous implementation of GrantFullAccessToExtension() granted permissions
only for paths that are mounted at that moment, and required hack for
one dynamically mounted path, namely, Google Drive directory.

It's not what is meant for GrantFullAccessToExtension(). Rather, it
should just simply allow access for the extension any time.
In multi-profile settings, more directories, i.e., Downloads/Drive
directories from other profiles are going to be dynamically added.

BUG=337705

Review URL: https://codereview.chromium.org/148233008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247852 0039d316-1c4b-4281-b951-d872f2087c98

In particular:

 - Switch to 1-based indexing.
 - Use 0 instead of -1 as the "invalid index" value.
 - Add "host" header to the static table.
 - Add HpackEncodingContext::GetMutableEntryCount() function.

This lands server change 60493594 by akalin.

Review URL: https://codereview.chromium.org/145353017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247851 0039d316-1c4b-4281-b951-d872f2087c98

When we run content_shell in the single process mode with tests using the clipboard, the renderer thread passes WebString to the browser thread. It causes leak.
To avoid this, change the member WebString to NullableString16.

BUG=328158
TEST=content_shell --dump-render-tree --single-process ../../third_party/WebKit/LayoutTests/editing/pasteboard/createMarkup-assert.xml

Review URL: https://codereview.chromium.org/135853010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247850 0039d316-1c4b-4281-b951-d872f2087c98

Credential slot field has been removed from SYN_STREAM frame.

This lands server change 59587408 by mlavan.

Also update affected Chromium portions of QUIC & SPDY.

Review URL: https://codereview.chromium.org/141953004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247849 0039d316-1c4b-4281-b951-d872f2087c98

BUG=339204

Review URL: https://codereview.chromium.org/141713004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247848 0039d316-1c4b-4281-b951-d872f2087c98

BUG=313530

Review URL: https://codereview.chromium.org/147593006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247845 0039d316-1c4b-4281-b951-d872f2087c98

TBR=oshima@chromium.org,stevenjb@chromium.org,bajones@chromium.org,rch@chromium.org

Review URL: https://codereview.chromium.org/149573004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247844 0039d316-1c4b-4281-b951-d872f2087c98

Pinch zoom should not affect native-looking UI. This patch disabled zoom
in all cases except for the browser view.

BUG=232098

Review URL: https://codereview.chromium.org/134683004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247843 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/150053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247842 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247840 0039d316-1c4b-4281-b951-d872f2087c98