GitLab

Test: build and run locally, stop assistant do not show animation
Bug: b:112229074
Change-Id: I7a669f9a6bf2d11d84a6c3a364c7c4f729068eb1
Reviewed-on: https://chromium-review.googlesource.com/1163841Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580971}

https://chromium.googlesource.com/angle/angle.git/+log/a6d34af67286..6ba9754f4a56


git log a6d34af67286..6ba9754f4a56 --date=short --no-merges --format='%ad %ae %s'
2018-08-06 geofflang@chromium.org Refactor index range calculation in DrawCallParams.


Created with:
  gclient setdep -r src/third_party/angle@6ba9754f4a56

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: Ie123b90795a1951821e966b7606dbd763bc34300
Reviewed-on: https://chromium-review.googlesource.com/1162723Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#580970}

This adds a --deploy option to the vm test runner and binds it to true
every time we build the cros_vm_launcher. This assumes that everything
that uses that target also builds chrome and also wants it deployed to
the VM (which is true atm).

Also rebalance telemetry unit test shard count on the FYI bot.

Bug: 836447
Change-Id: I012932edac7bf40c369f69378e3ad365dd9e1ab6
Reviewed-on: https://chromium-review.googlesource.com/1155833
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580969}

UrlBar#setAllowFocus was not updating the widget if it had
not drawn a single time.  This internally was done because
tabbed mode wanted to prevent he UrlBar from gaining focus
on initial inflation, but tabbed mode never calls setAllowFocus
except when manipulating the tab switcher and thus would
never happen before drawn a single time.  This just updates
setAllowFocus to immediately take action and the lazy setting
of focus for Tabbed mode still happens in the first draw
callback (this method can just be set before that has happened,
which is OK for both SearchWidget and Custom Tabs as they both
want to set that state as early as possible).

BUG=871121

Change-Id: I74ef57890e223a10583ecbb67179705fb2f11caa
Reviewed-on: https://chromium-review.googlesource.com/1163754Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580968}

Many similar stories are already disabled on A1.

NOTRY=true
TBR=panicker@chromium.org

Bug: 764868
Change-Id: Iaccf98bdaf53bedbedfbe24169a5d577789ac1ab
Reviewed-on: https://chromium-review.googlesource.com/1164028Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580967}

Previously, code in LayoutBox::StyleDidChange which
tried to detect change of border for clips did not
take into account changes of border style to hidden
or none.

Bug: 814439

Change-Id: Ic59985c1b7b877cbbee678930328444d7700274e
Reviewed-on: https://chromium-review.googlesource.com/1163220Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580966}

Shelf height is changed unintendedly in
https://chromium-review.googlesource.com/c/chromium/src/+/1142441, so
change it back.

Bug: 865139
Change-Id: Iec2de46cf6e48ed9bde0e5cd736e5d7154c6d9c4
Reviewed-on: https://chromium-review.googlesource.com/1163986Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580965}

This test is disabled due to a regression on Mac FYI Retina Debug (NVIDIA)
bot since build 2964

NOTRY=true

Bug: 871352
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ida3ec7f78ee39c2578f0ee802101559de11c92d9
Reviewed-on: https://chromium-review.googlesource.com/1163993
Commit-Queue: Maggie Chen <magchen@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580964}

This CL includes:
- Add new base::Feature: kDeleteUndecryptableLogins.
- Expand metric enum PasswordSyncState with failed decryption & cleanup states.
- Call LoginDatabase::DeleteUndecryptableLogins when merging sync data.
- Add tests for new feature.

Bug: 791541
Change-Id: I5a5f9cea618efdc4b467eee4bb54674be8574b84
Reviewed-on: https://chromium-review.googlesource.com/1160486
Commit-Queue: Tonko Sabolčec <tsabolcec@google.com>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580963}

testActivityServiceControllerPrintAfterRedirectionToUnprintablePage is
only valid for native error pages, because web-based error pages are
not printable. Updated comments, disabling condition and added DCHECK to
BVC.

testActivityServiceControllerCantPrintUnprintablePages can be rewritten
to use Offline Version from Reading List. Updated comments.

Bug: 864597
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I6f9ff464abed30024eb10ad9a187b424ccaa2663
Reviewed-on: https://chromium-review.googlesource.com/1163747Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580962}

https://skia.googlesource.com/skia.git/+log/439da2812f74..97d0970c25e9


git log 439da2812f74..97d0970c25e9 --date=short --no-merges --format='%ad %ae %s'
2018-08-06 brianosman@google.com Fix SkColor4Shader
2018-08-06 benjaminwagner@google.com [infra] Shuffle Mac CPU and xSAN jobs to MacBookPro11.5.
2018-08-06 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 a6d34af67286..6ba9754f4a56 (1 commits)
2018-08-06 fmalita@chromium.org [Skottie] Add raw data factory
2018-08-06 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/skia@97d0970c25e9

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=djsollen@chromium.org

Change-Id: If5269a0f0ba01ef602ba9ccdd88ad0141c733cf1
Reviewed-on: https://chromium-review.googlesource.com/1163842Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#580961}

BUG=871354
TEST=none
TBR=tsunghung

Change-Id: I8134ea1476c7a25f9dc8d00dc1e62a4cd951ee93
Reviewed-on: https://chromium-review.googlesource.com/1163988Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580960}

https://pdfium.googlesource.com/pdfium.git/+log/a7a957f7cec2..f3a3393a2f96


git log a7a957f7cec2..f3a3393a2f96 --date=short --no-merges --format='%ad %ae %s'
2018-08-06 thestig@chromium.org Avoid invalid object numbers in CPDF_Parser::LoadCrossRefV5().
2018-08-06 tsepez@chromium.org Small optimization in CJBig2_Image::SubImage()
2018-08-06 thestig@chromium.org Check for null object type in CPDF_Parser::LoadCrossRefV5().
2018-08-06 thestig@chromium.org Do more CPDF_Parser::LoadCrossRefV5() cleanup.
2018-08-06 rharrison@chromium.org Clean up a nit that was identified after CQing an earlier CL


Created with:
  gclient setdep -r src/third_party/pdfium@f3a3393a2f96

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:865272,chromium:871042,chromium:863098
TBR=dsinclair@chromium.org

Change-Id: I244334140b9abd5f018f052799d278320c51e5fc
Reviewed-on: https://chromium-review.googlesource.com/1163845Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#580959}

This reverts commit 030c9cd1.

We have fixed the issue in the latest Widevine CDM and this test
should pass now.

Original change's description:
> Revert "media: Reenable TestPolicyCheck() on Windows for Widevine"
> 
> This reverts commit 3a127077.
> 
> Reason for revert: The test is still failing on Win64 trunk and Win trunk on official continuous desktop builder.
> 
> Original change's description:
> > media: Reenable TestPolicyCheck() on Windows for Widevine
> > 
> > The original problem has been fixed in the latest Widevine CDM.
> > 
> > Bug: 851027
> > Change-Id: I9aced3ea2152e33fcc8a5bcddc8a587c45dee6cc
> > Reviewed-on: https://chromium-review.googlesource.com/1154087
> > Reviewed-by: Frank Liberato <liberato@chromium.org>
> > Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#579615}
> 
> TBR=xhwang@chromium.org,liberato@chromium.org
> 
> Change-Id: I1446eb5919ac014420fe7095d7916ee92cbb3d57
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 851027
> Reviewed-on: https://chromium-review.googlesource.com/1158767
> Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
> Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#579823}

TBR=xhwang@chromium.org,liberato@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 851027
Change-Id: I3ad5c9f79aeab0ed7bfa68ded3a49664c0c295d2
Reviewed-on: https://chromium-review.googlesource.com/1162213
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580958}

Make sure to damage the previous underlay area
when switching underlays so that it is repainted.

BUG=854790
TEST=UnderlayTest.UpdateDamageWhenChangingUnderlays

Change-Id: Idec0e30e0cf65e4937f85dfd3bdfd9ba4120d5fe
Reviewed-on: https://chromium-review.googlesource.com/1161393
Commit-Queue: Fritz Koenig <frkoenig@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580957}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/82bb756217cd..2ebf9fdade33


git log 82bb756217cd..2ebf9fdade33 --date=short --no-merges --format='%ad %ae %s'
2018-08-06 dgarrett@google.com my_activity: Don't crash if email unset.


Created with:
  gclient setdep -r src/third_party/depot_tools@2ebf9fdade33

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:None
TBR=agable@chromium.org

Change-Id: I98d7b857515ed74324520306b76d8e79425126be
Reviewed-on: https://chromium-review.googlesource.com/1163116Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#580956}

This CL renames these classes:
- MessageCenterNotificationManager -> NotificationUIManagerImpl
- MessageCenterNotificationManagerTest -> NotificationUIManagerTest
- MessageCenterNotificationsTest -> NotificationUIManagerBrowserTest
- MessageCenterNotificationManagerBrowserTest
    -> NotificationUIManagerInteractiveUITest

MessageCenterNotificationManager was confusing, because this class is
not for CrOS (which has message center) but for Win/Mac/Linux (popup only).

This CL renames this class into NotificationUIManagerImpl, because this is
an implementation of NotificationUIManager. And this also renames the
related test classes accordingly.

Bug: 869278
Test: trybots pass

Change-Id: I296f46d0b8634c95081167d6585f6f42798661f6
Reviewed-on: https://chromium-review.googlesource.com/1158669
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580955}

https://webrtc.googlesource.com/src.git/+log/15f0a12b8309..0047bce0a943


git log 15f0a12b8309..0047bce0a943 --date=short --no-merges --format='%ad %ae %s'
2018-08-06 mbonadei@webrtc.org Remove linux_internal_compile_lite from CQ.
2018-08-06 sakal@webrtc.org Remove unnecessary //base:base_java dependencies.


Created with:
  gclient setdep -r src/third_party/webrtc@0047bce0a943

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I20d263d85234b992d94cb53e411415501eb85c69
Reviewed-on: https://chromium-review.googlesource.com/1162118Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#580954}

Calling `acorn.parse()` in FormattedWorker may throw an error. If we
do not catch it, the error may appear in layout test results, making
tests flaky, such as
http/tests/devtools/console/console-correct-suggestions.js

This CL always catches errors from acorn.parse().

Bug: none
Change-Id: Ief452572c04ea45ae9a930999441e799e8f73f7d
Reviewed-on: https://chromium-review.googlesource.com/1159231Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580953}

Users of MediaLog have to be careful about the lifetime of the
object, since it's passed around as a raw ptr.  For things like
VdaVideoDecoder, which operate on multiple threads, it requires
special care that the log isn't used after VdaVideoDecoder is
no longer allowed to use it.

ChildMediaLog wraps a MediaLog, and provides an atomic way to
prevent access to the underlying MediaLog.  For example,
VdaVideoDecoder can do this when it's Destroy()ed, which is when it
must stop using the MediaLog that it was given.  Additional calls
to ChildMediaLog will do nothing.

The ChildMediaLog itself can be kept around until the other thread
is definitely done using it.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: If350b2b78da96bf7ba844f582a96661fd0b15ef0
Reviewed-on: https://chromium-review.googlesource.com/1139219
Commit-Queue: Frank Liberato <liberato@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580952}

This allows the experiment name to line up with the finch trial
experiment name, fixing a presubmit warning.

BUG=602688

Change-Id: I98da2aa87f58395aecf258a6f8cfb57586d096ee
Reviewed-on: https://chromium-review.googlesource.com/1163744Reviewed-by: Robert Kaplow (slow) <rkaplow@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580951}

Not only are leading +'s not allowed in the Content-Length according to
spec, our normal Content-Length parsing code doesn't allow them either.
This CL switches to using the HttpResponseHeaders Content-Length parser,
to match HttpStreamParser's behavior.

Unclear if this makes any sense for H2/QUIC, or if we should be doing
something else entirely.

Bug: 596582
Change-Id: I0520ade19f7eaa50cb9f4aab60338a19e97a1bd4
Reviewed-on: https://chromium-review.googlesource.com/1161250
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580950}

- Remove outline on click for:
  - Speech microphone icon
  - Shortcut
  - Edit link icon
  - Edit link dialog buttons
- Fix icon for restore default:
  - https://screenshot.googleplex.com/iVG7ohvNcXUp.png
- Prevent keyboard navigation to disabled "Restore default..." options.
- Keyboard navigation will start at edit dialog after it opens.
- Show add shortcut title for adding instead of edit shortcut.
- Can tab to add shortcut button.
- Keyboard navigation will remain within the edit shortcut dialog when
  open.
- Remove dark gray on click for the edit icon when dark theme/custom
  background.
- Clicking "Done" without modifying anything closes the dialog.
- Allow screen reader to move left/right through the links and edit link
  icons. (User must first use ctrl+shift+opt+down to enter the iframe).
- Prefill URL field with "https://". Text will turn dark gray on text
  input.
  - https://screenshot.googleplex.com/oBJNX4KHxeq.png
  - https://screenshot.googleplex.com/YpbDqiz0hkM.png
- Added labels to all buttons for screen readers ("name" attribute).
  - Edit = "Edit shortcut <title>"
  - Delete = "Remove <title>"
  - Cancel = "Cancel"
  - Edit icon = "Edit shortcut <title>"

Bug: 864357
Change-Id: Ie33248a0f633180e81e7a55373b06fb564f5596a
Reviewed-on: https://chromium-review.googlesource.com/1161096
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580949}

This feature flag gates the use of USBGuard on Chrome OS for blocking
new USB devices from being used by the linux kernel at the lockscreen.

CQ-DEPEND=CL:1154326
BUG=None
TEST=verify that dbus-send works for CrOS.
Signed-off-by: Allen Webb <allenwebb@google.com>
Change-Id: Iba101f04b1882c3dbad539bf418457129d2cdf17
Reviewed-on: https://chromium-review.googlesource.com/1161011Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580948}

This CL adds a histogram to record directory type when download is
completed.

Also splits the previous directory type histogram into two
separate histograms.

Bug:868115

Change-Id: I68efe49c5d954ab4476675bc739d1bc29f2676eb
Reviewed-on: https://chromium-review.googlesource.com/1152173Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580947}

The usbguard-daemon prints serial numbers of USB devices to
/var/log/messages. This change adds a pattern to anonymize those
serial numbers to prevent leaking PII.

BUG=None
TEST=Generate a report with logs and verify usbguard-daemon log
lines are properly anonymized.
Signed-off-by: Allen Webb <allenwebb@google.com>
Change-Id: Ifd41c8208b4d14bb3fafbf38198b04da6a8babd6
Reviewed-on: https://chromium-review.googlesource.com/1160935Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580946}

In addition to adding a content_browsertest, I've also manually tested
the changes using steps from https://crbug.com/810633#c14.

Note that after this CL a "hang renderer dialog" will appear if a
navigation cannot commit because it tries to reuse a hung renderer.
This is definitely an improvement.  But also note that after using the
dialog to kill the renderer, the navigation spinner will keep spinning -
there is additional work needed to fix this.

Bug: 848821
Change-Id: I9d6801dbd8b2532f2427509c938db5556a4fb133
Reviewed-on: https://chromium-review.googlesource.com/1089797
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580945}

There are a few more in TestExpectations which use video-throttled-load.cgi
with a low thorttle value and could probably be updated. However, they've
been disabled for some time, while these were just disabled, so to avoid
churn just re-enable these as slow for now.

BUG=869829, 870259
TBR=hubbe

Change-Id: I03a814e58e5ffb6a7f3d1040e636f16cded2c0f5
Reviewed-on: https://chromium-review.googlesource.com/1161196Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580944}

On Android, this test was flaky and was disabled on Android over 2 years ago.
This change speculatively re-enables the test on Android.

BUG=607841

Change-Id: I21acef884055bfb321dce17f4ca83803becd8ced
Reviewed-on: https://chromium-review.googlesource.com/1162915Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580943}

Multiple rcodes are mapped to DNS_SERVER_FAILED, so it'd be useful to also have a histogram of the
actual rcodes, in case that reveals something interesting. I'm currently attempting to find clues
as to why we see an increased proportion of DNS_SERVER_FAILED errors when performing CT-over-DNS
queries (these are TXT record lookups).

Bug: 142918, 506227
Change-Id: I6216f6aba1e668501da8087d24106ae5c5758169
Reviewed-on: https://chromium-review.googlesource.com/1152967
Commit-Queue: Rob Percival <robpercival@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580942}

Swarming does not support triggering tasks across instances (ie prod -> dev)

chromium.swarm exists only to drive traffic in the chromium-swarm-dev instance.
Move everything into cr-buildbucket-dev.

Bug: 868525
Change-Id: Ice37edd7c8d668e1ec52962811b10fd8883ce659
Reviewed-on: https://chromium-review.googlesource.com/1155740Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580941}

Editor::ReplaceSelection() was modified so that |smart_replace| is
false. No callers currently existed that used the version of
ReplaceSelection() with |smart_replace| = true.

Smart Replace may add whitespace before and/or after an inserted
piece of text. The only current call to Editor::ReplaceSelection()
needs |smart_replace| to be false because no extra whitespace is
desired.

A comment was added in editor.h to explain that Smart Replace is not
used in Editor::ReplaceSelection().

A test was added, EditorTest.ReplaceSelection, which passes when
|smart_replace| = false and fails when |smart_replace| = true.

Bug: 717553
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I1424e200780cd32900dac5b6f824f8d50c3f8dd5
Reviewed-on: https://chromium-review.googlesource.com/1150448
Commit-Queue: Tessa Nijssen <tnijssen@google.com>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Sarah Chan <spqchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580940}

There were no flag updates.

Rename MockEpollServer, which isn't a mock, to FakeEpollServer.

n/a, test-only name change

Merge internal change: 206334361

Deprecate FLAGS_quic_reloadable_flag_quic_no_irtt.

Merge internal change: 205975056

Deprecate FLAGS_quic_reloadable_flag_quic_fast_ack_after_quiescence.

Merge internal change: 205913948

Deprecate FLAGS_quic_reloadable_flag_quic_one_rto.

Merge internal change: 205880360

In QUIC, reset no_stop_waiting_frames_ after version is negotiated. Not protected.

Merge internal change: 205836440

Deprecate FLAGS_quic_reloadable_flag_quic_validate_ack_largest_observed.

Merge internal change: 205821526

In QUIC, add a public static method GetRetransmittableControlFrameSize in QuicFramer. No functional change expected, not protected.

This method can be used to calculate retransmittable control frame size in tracegraf.

Merge internal change: 205821194

Add a QUIC trace converter class, used to convert stream offset (and control frame ID) to TCP-like connection offset.

Merge internal change: 205668840

R=rch@chromium.org

Change-Id: I4eead190214cc868774d010a5a0aa72cb65e07d3
Reviewed-on: https://chromium-review.googlesource.com/1163124
Commit-Queue: Ian Swett <ianswett@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580939}

Bug: 834001
Change-Id: I4f21239a17fa91d824f143a8043a1114e6853e2f
Reviewed-on: https://chromium-review.googlesource.com/1159000
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580938}

demo mode setup flow.

* Change DemoSetupController delegate into callback passed to Enroll()
* Pass info about enrollment type separately from Enroll() request
* Store DemoSetupController instance in WizardController instead of
  DemoSetupScreen for easier storage and access to demo setup flow status

Change-Id: I43f2f28dfc2daea519849d222ea5a73561522516
Bug: 862445
Test: Run DemoSetupTest, DemoSetupControllerTest and wizard_controller_browsertest.
Reviewed-on: https://chromium-review.googlesource.com/1155152
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580937}

A future CL will rename this to FakeClock.

Change-Id: I105d1d0278eb15eb0601fd40b45f738cd9cad7ff
Reviewed-on: https://chromium-review.googlesource.com/1163832
Commit-Queue: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580936}

Advanced Protection (Titanium) service flag is included in client ID
token if user is in this program. This CL parses client ID token to
determine if Advanced Protection serice flag is available. Very similar
to how we get the child account bit for unicorn.

Service side of work is tracked in b/109872750.

Change-Id: Iaf9490fb2bd16b61480bbf1c875ba451d25f853d
Bug: 866620
Reviewed-on: https://chromium-review.googlesource.com/1155813Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580935}

This reverts commit b3a65a61.

Reason for revert: Need to write a service to demux and decode.

Original change's description:
> Add assistant audio decoder
> 
> This cl creates a mojo service for assistant audio decoder. The decoder
> is running in utility process. This is a temporary solution until
> MediaService for Chrome OS is implemented.
> 
> Bug: b/80315134
> Test: manual tested can create the audio decoder for assistant.
> Change-Id: Ib4d1a8d3e6d38b0cbb436e20e6d12033d74ed7cf
> Reviewed-on: https://chromium-review.googlesource.com/1137020
> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Dan Sanders <sandersd@chromium.org>
> Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
> Commit-Queue: Tao Wu <wutao@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#577713}

TBR=dcheng@chromium.org,dalecurtis@chromium.org,kinuko@chromium.org,xhwang@chromium.org,sandersd@chromium.org,xiaohuic@chromium.org,tguilbert@chromium.org,wutao@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: b/80315134
Change-Id: I9e7636a9f1e809bc35cbefda5d4183718a5ef240
Reviewed-on: https://chromium-review.googlesource.com/1162546Reviewed-by: Tao Wu <wutao@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580934}

... It's not going to keep much cached if the process gets OOM killed,
after all.

Bug: 845639
Change-Id: Ic3e8ac616e2b511f995410a5aa54c1342cef0b63
Reviewed-on: https://chromium-review.googlesource.com/1110155
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580933}

The class is reference counted, and makes a mojo call, with a callback,
on the UI thread. The callback was passed a raw pointer to the class,
but when it was invoked, it grabbed a reference to the class. When the
class's last reference is released, it posts a delete task to the UI
thread.

So if the class's last reference was released, and then it received a
a Mojo callback, there would be a pending delete task, we'd grab a
new ref (Increasing the refcount from 0 to 1), the delete task would
run, and then a new delete task would be posted when the reference went
to 0 again, resulting in a double-delete.

This CL fixes that by making the class keep a reference to itself
whebever there's a pending mojo callback. MessageFilters are designed
to be able to call Send() after the class they want to send messages
to has been deleted, so the increased lifetime is completely safe.

Bug: 870675
Change-Id: I64f6656e61dc9222a67cd40555d3dd73fb48e208
Reviewed-on: https://chromium-review.googlesource.com/1161967
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580932}