GitLab

Previously VulkanImplementation defined functions for semaphore
import/export from/to file descriptors. This approach doesn't work on
platforms that don't support FDs for semaphores, specifically on
Fuchsia and Windows.

This CL:
1. Adds cross-platform gpu::SemaphoreHandle that allows to
represent semaphore handle on any platforms.
2. Replaces ImportSemaphoreFdKHR() with ImportSemaphoreHandle().
3. Replaces GetSemaphoreFdKHR() with GetSemaphoreHandle()

This allows to remove dependency on ScopedFD in
gpu::ExternalVkImageFactory, which will make it easier to reuse that
class on Fuchsia and Windows.

Bug: 934526
Change-Id: I16b1a9f3a606683b76a73c4e68a33b3294f25a90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540724
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646424}

It's a big method that can easily be broken up into smaller
methods. This will make it easier to review downstream changes.

Also, rather than create a TextWrapper every time it's needed, I
instantiated one for the class. That winds up saving about .3 seconds
when running histograms pretty_print.py.

Bug: 1538783
Change-Id: I4bb697c74472e8729060828e29a2f67766fa4f43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1543248
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646423}

Ignore network interfaces with just link-local addresses when
computing a computer's network connection type. Mac assigns
link local addresses to several different types of interfaces
even when they are not connected. Internal bug b/128444384.

Change-Id: Iee6f3143903c5f2f7e4c3b3942221ab4251854d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546877
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646422}

https://pdfium.googlesource.com/pdfium.git/+log/21d000094ade..010a4da72d17


git log 21d000094ade..010a4da72d17 --date=short --no-merges --format='%ad %ae %s'
2019-04-01 tsepez@chromium.org Limit input size in pdf_fx_date_helpers_fuzzer.
2019-04-01 thestig@chromium.org Avoid premature decoding completion in CJBig2_ArithDecoder.


Created with:
  gclient setdep -r src/third_party/pdfium@010a4da72d17

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:947780,chromium:947622
TBR=dsinclair@chromium.org

Change-Id: I42f2ec103277a13cfb9dbae2cd0cb0a200375a0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547300Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#646421}

This CL deletes some comments that shouldn't be there.

Change-Id: I8cb2bc8838be3b265028dd99e75c88b7dd2c0a9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546726Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646420}

Bug: 899318
Change-Id: Idc40408aa27a8c67f923343d50975f7099567999
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548030Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646419}

This sort of worked before since the logic to detect if any part of the list
was focused was broken, but that didn't work in the VRB so. This CL fixes that
logic and makes the menu close in a more direct way.

Bug: 865010
Change-Id: Ie6974404947380bb45c48c597b0b4a7830c68228
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546725Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Will Cassella <cassew@google.com>
Cr-Commit-Position: refs/heads/master@{#646418}

This patch adds a series of checks to allow us to cache layout results
which floats are present within the BFC.

We perform these additional checks when:
 - The BFC offset isn't equal.
 - The ExclusionSpace isn't equal.

The cases when we can't reuse a layout result are:
 - The layout result was pushed by floats. This is due to complexities
   with margin collapsing. I believe that if we wanted to cache this
   case we'd need to either return the BFC-offset if it wasn't affected
   by clearance, or add a bit telling us if the margin-strut *when the
   BFC offset was resolved* was empty.
   This seems too complex to get right at the moment.
   NOTE: we'll still may cache things with clear:both, etc. (if they
   weren't pushed by floats.
 - If we *may* have a descendant above the block-start edge. E.g. an
   arbitrary descendant may have a negative top margin, and any content
   within it would be affected by floats. We just add a "May" check
   for this (child_offset.block_offset < LayoutUnit()) as this should
   be relatively rare.
 - If there were overhanging floats initially.
 - If there may be overhanging floats once moved.

This adds a new test file as the ng_block_layout_algorithm_test.cc
was getting long.

Bug: 635619
Change-Id: Iaac7ec58099e2d4c3359aee61e6454bec84c0888
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496955
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646417}

There are already files called download_service_factory.(cc|h) in
//src/chrome/browser/download, which use the components files.
Therefore, calling the components files
download_service_factory_helper.(cc|h)

Change-Id: Id34daa36a975321b6b0e1c99e2b7608e7d75b798
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546421Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Auto-Submit: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646416}

If a layout result had exclusions inside it we previously didn't
move them relative to the given new bfc offset.

This introduces NGExclusionSpace::MergeExclusionSpaces which looks
at the:
 - old input exclusion space
 - old output exclusion space
 - new input exclusion space
 - bfc movement offset

and produces a "new output exclusion space".

Bug: 635619
Change-Id: I436dd97f88b1a75287703a8f3692d0a56342c7b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546494
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646415}

If we do not have any artwork we should not shift the
media notification contents to the right.

BUG=897836

Change-Id: Ia1b333e5c80e2065fda9ad2c1eea90dfdd86742d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545728
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646414}

Failed when run locally on iOS 12 iPhone.

Bug: 947536
Change-Id: Ic4c6cd02afb0289658f7658794df93cc212fffa7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545997
Auto-Submit: Eugene But <eugenebut@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646413}

Previously if a NGConstraintSpace had a rare-data object, and the
comparison NGConstraintSpace did not, we said we couldn't skip layout.

However there are cases where we may allocate a rare-data object and
still be able to skip layout.

I don't believe this case is particularly common, so this is just a
cleanup patch.

Bug: 635619
Change-Id: Iba91c9028b614fcce0c3bf48b14fe38030709ab0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546309
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646412}

This CL adds support to detect when the encoded data for an image has
been received in its entirety prior to creating the first
DecodingImageGenerator for it. This is to support the use case of
sending the encoded data to a hardware decoder. The motivation is as
follows: hardware decoding requires that all the data has been received.
If the image is received incrementally and we software-decode the
partial data as it comes, there is no point in sending the complete
image to the hardware decoder once it's received because the software
decoder has already done a lot of the work, so it's better to finish the
decoding in software.

A DeferredImageDecoder is shared across the process of incrementally
receiving the image. However, at each step, a new DecodingImageGenerator
is created (which is what cc uses ultimately to decode the image).
Therefore, we keep enough state in DeferredImageDecoder to detect when
we create the first DecodingImageGenerator. If at that point, all the
encoded data has been received, then it's okay to send the image to
hardware decoder. We store this decision in the DecodingImageGenerator.
That way a PaintImage can have an IsEligibleForAcceleratedDecoding()
method which asks the underlying PaintImageGenerator if it's okay to
hardware-decode.

Additionally, a small clean-up is done: the
DecodingImageGenerator::SetCanYUVDecode() method is removed in favor of
passing the YUV decoding decision at construction.

Test: unit tests are added for the new behavior.
Bug: 868400
Change-Id: I396cf08ab007fd98b6fd65d60704ae8d26673aa4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546327Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Madeleine Barowsky <mbarowsky@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646411}

Previously to answer questions about clearance offsets, we'd need to
potentially build the derived-geometry data-structure.

This has a very large overhead for something that looks relatively
cheap.

This moves those tracking members into NGExclusionSpaceInternal instead.

Bug: 635619
Change-Id: I01b57014c479133e9eeaa95e65ecfa05ca954e3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544882
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646410}

Specifically:
 - directory_model.js
 - filtered_volume_manager.js

Also had to declare more member variables in the constructor of
directory_model.js, to address newly discovered compiler erros, as a result of
ES6 classes being @struct by default.

This is in preparation of removing the custom cr.EventTarget implementation in
favor of native EventTarget, which requires all subclasses to be ES6 classes,
otherwise a runtime "Illegal invocation" error is thrown.

Bug: 854268,778674
Change-Id: I7e2944c0112b8676fd1dbfb5717d722da62e0c8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546856Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646409}

No change to logic, this just renames a test.

This renames "redirectFromThirdToFirst" to
"redirectFromThirdPartyToFirst," for consistency with the
"...FirstPartyToThird" test case. The original name was a typo.

R=changwan@chromium.org

Bug: 941337
Test: N/A
Change-Id: I8c0bc3daa4fa24c854e5cc2dc2c473827037d5ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546759
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646408}

SetUpOnMainThread is too late to mutate the command-line. By then, other
threads have started and may be reading from it. Instead, use
SetUpCommandLine.

This should fix the following TSan flake:
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8917832371169415328/+/steps/content_browsertests/0/logs/Flaky_failure:_WebRtcInternalsBrowserTest.UpdateAllPeerConnections__status_FAILURE_ON_EXIT_SUCCESS_/0

Change-Id: Ibf819a3247b290b9d583d25dc0111881868c4a74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541497
Auto-Submit: David Benjamin <davidben@chromium.org>
Reviewed-by: Alexander Potapenko <glider@chromium.org>
Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646407}

Servicification is enabled by default on tests. For the tests that use
request_headers, only main frame request headers will be available. So they
are changed accordingly.

Bug: 947736
Change-Id: I16e0b915f8667fa2a75bfece58395c4262e02681
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546197Reviewed-by: Robert Ogden <robertogden@chromium.org>
Commit-Queue: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646406}

This is a reland of e73ae865

In this version, the issue causing flakiness has been fixed. Namely,
FaviconCache powers two sync datatypes so WaitUntilReadyToSync() must
support overlapping calls.

Original change's description:
> Make sure HistoryService is ready before favicon sync
>
> This is achieved with SyncableService::WaitUntilReadyToSync(), which
> holds sync interactions back until the SyncableService is ready to
> start.
>
> This CL was uploaded by git cl split.
>
> R=treib@chromium.org
>
> Change-Id: Icdfb17cc36132488cb30600f894e5118e9ac01a1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545054
> Reviewed-by: Marc Treib <treib@chromium.org>
> Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> Auto-Submit: Mikel Astiz <mastiz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#645741}

Change-Id: Ie2b765479c6a7352ebc10e1f9ecc21f71679c5a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1545408
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646405}

Backend still sends this since it's a required field. We cannot yet
remove it completely since it's non-optional and sent over public
protocol API.

Bug: 744601
Change-Id: Iee1ea175ba1fa9cf8ce596e218f98109836e5b70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546498Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646404}

This fixes a TODO item I added for myself back in commit dd9b04ee ("sensors:
Remove bogus DCHECK from SensorReader::Create()").

Commit 9d8348e5 ("sensors: Clean up sequence, task and thread handling in
the Linux implementation") got rid of PlatformSensorProviderLinux's polling
thread altogether, so we can finally make |disallow_blocking_| a regular
member variable that is used for the entirety of
PlatformSensorAndProviderLinuxTest's lifetime.

Change-Id: Ic78bc2d4d2ad64ea4be7a2e2cf39315a87d96e9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546102
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646403}

Change-Id: If6e543d8319f2e2160d8c8d8e3b6b42a9b3f5f18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1530005
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: weiliangc <weiliangc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646402}

Bug: 879657
Change-Id: I753af2ee72b695d8cecc24e15795235823e4306d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1396383
Commit-Queue: Raul Tambre <raul@tambre.ee>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646401}

BEFORE:
https://photos.app.goo.gl/WJgfDni6K83tZ2NA9

AFTER:
https://photos.app.goo.gl/mynmp7i3t8F53qJu6

Test: manual
Bug: 946601
Change-Id: I9a9f952048f9f819e7751bf726ac19fc9cdf7fbe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1541839
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646400}

Setting the flag enables the data saver feature. This is
necessary for testing data saver features on CrOS.
The flag has been added to bad flags prompt since enabling the flag
causes user's traffic to be proxied in unexpected ways.

Bug: 940943
Change-Id: I4070055234b02cc9d4be0d3644ffbe0d450273fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546328Reviewed-by: Tommy Martino <tmartino@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646399}

BUG=947314

Change-Id: I671483b4d28934303bb4d55294b25dc0a5851f86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546492
Commit-Queue: Robert Liao <robliao@chromium.org>
Auto-Submit: Robert Liao <robliao@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646398}

This was causing missing debug info on the pillar boxed window.

Bug: None
Test: manual
Change-Id: I1b7d8f2c0f40a9cc72853490de670a22e3f76d09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1542243Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Eliot Courtney <edcourtney@chromium.org>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646397}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/507bf397d15c..f6cbd3926d95


git log 507bf397d15c..f6cbd3926d95 --date=short --no-merges --format='%ad %ae %s'
2019-04-01 pprabhu@chromium.org config: Migrate {mistral,whirlwind}-paladin to Skylab


Created with:
  gclient setdep -r src/third_party/chromite@f6cbd3926d95

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@chromium.org

Change-Id: I75a9e492812e864d5036c34d4332ac4847d00397
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547407Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#646396}

As per //base/containers/README.md, we prefer base::circular_deque<>,
which has well-defined & consistent performance across platforms, unlike
std::deque<>.

Change-Id: Id77b9cdc9009d257181e1b30e9cc0951ca912f8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546196
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Reviewed-by: Fabrice de Gans-Riberi <fdegans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646395}

I noticed in debugging that the scroll tree never had an outer viewport.
Some investigation shows that we never hooked up the bit to the root
scroller.

Sure enough, before this CL, we don't perform the URL bar adjustment
correctly. This CL sets the bit based on the root scroller and fixes the
issue. Also added the scrolls_inner|outer_viewport bits to the debugging
output to make this easier to see.

Bug: 947879
Change-Id: I5a450aa2642a64f8db004c97c0e744d196e91009
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546540Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646394}

Bug: None
Change-Id: I2457657ea1e3c957e0b582465e0246187a6993b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547930Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646393}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8b6d15b049c2..096bd921bbab


Created with:
  gclient setdep -r src-internal@096bd921bbab

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=shimazu@chromium.org,dgozman@chromium.org,hbos@chromium.org

Change-Id: I04d278b94680ea6b4ffceda17f508d5cf94ab82a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547405Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#646392}

Patchset 1 is the original patch. There are two additional fixes here
. ChromeNativeAppWindowViewsAuraAshBrowserTest was expecting a sync
layout. It already had logic to wait for view to be in position, so I
just enabled that path always.
. HostedAppBrowserController::GetAppShortName() may be called when the
extension is null. See 947391 for the exact stack. This is likely
necessitated by layout being called at a different time then it was
before.

Prior to this it was up to consumers of View to know when the right
time to call Layout() was. This is error prone, and easy to get wrong.
This patch makes it so a call to InvalidateLayout() results in a later
call to Layout() (starting from the root). The call to Layout()
happens right before the damage rects are sent to the compositor.

This only cleans up views side. No doubt other cleanup can happen in
other places. Additionally, there are future changes that should happen:
. add/remove should really InvalidateLayout().
. It isn't always necessary to start the Layout from the root. Some
views size *never* changes (such as the BookmarkBar), in which case
layout need not start from the root. This is a future optimization.

BUG=627663, 947391
TEST=covered by tests

Change-Id: I84c057b3df078659734d8a73bae06cd76cd60575
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547051Reviewed-by: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646391}

TBRing these comment-only changes.
TBR=treib

Bug: none
Change-Id: I457ec0eda2c472c6f001329a1d9752fcba5673d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547704
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646390}

Bug: 947044
Change-Id: I83fa2110d3d74ccbdf1675c5fe9278957754cade
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1547795Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646389}

Performing shard retries means that long-running shards with failing
tests consume their execution time multiple times so additional
headroom is needed to prevent timeouts.

Bug: 948115
Change-Id: Ibefb296e2e67eaa558463d2d6a9af1b810c37dd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546525
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646388}

Allow multiple targetText= fields in the text fragment anchor, where
they are all highlighted and the first is scrolled to.

Bug: 938650
Change-Id: I4ec5b2f1f23af04d39838ca28b0dec7ea232f02d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1532680
Commit-Queue: Nick Burris <nburris@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646387}

Bug: 948173
Change-Id: I4aa253eb57cce870b19c9f42f7e937f24c0d69ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1544191
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#646386}

Bug: None
Change-Id: Ib69e1b67bf76a4cba028a4faac014c1d5f5465ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536311Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Anastasia Helfinstein <anastasi@google.com>
Cr-Commit-Position: refs/heads/master@{#646385}