- 17 Apr, 2018 40 commits
-
-
Jungshik Shin authored
U+04CF (ӏ) has the confusability skeleton of 'i' (lowercase I), but it can be confused for 'l' (lowercase L) or '1' (digit) if rendered in some fonts. If a host name contains it, calculate the confusability skeleton twice, once with the default mapping to 'i' (lowercase I) and the 2nd time with an alternative mapping to 'l'. Mapping them to 'l' (lowercase L) also gets it treated as similar to digit 1 because the confusability skeleton of digit 1 is 'l'. Bug: 817247 Test: components_unittests --gtest_filter=*IDN* Change-Id: I7442b950c9457eea285e17f01d1f43c9acc5d79c Reviewed-on: https://chromium-review.googlesource.com/974165 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#551263}
-
Luciano Pacheco authored
This fixes a memory leak and renderer crash as described below. Change Cache Storage "open" method callback to have a WeakPersistent reference to CacheStorage to avoid a circular reference between them. Remove Persistent<CacheStorage> from callback for "delete" since it wasn't used. WebServiceWorkerCacheStorageImpl keeps the callback while waiting for mojo response from browser process which keeps CacheStorage alive, CacheStorage also has a reference to WebServiceWQorkerCacheStorage, which is implemented by WebServiceCacheStorageImpl, creating the circular reference, this situation leads to memory leak because those can't be garbage collected properly on some termination conditions, this leak in turn would cause renderer to crash when starting a new worker and trying to reuse pointer to address cleaned by Oilpan heap. When a worker is terminated with pending WithCacheCallback objects, the termination GC callback will access the Persistent handle. However, it will point to an object in a dead Oilpan heap and cause a segfault. Using a WeakPersistent is a workaround to prevent this crash, since the termination GC callback won't try to access it. In the future, Oilpan might be updated to handle this more gracefully see https://crbug.com/831117. The added test catches two conditions where renderer process was crashing: 1. When initializing Cache Storage after "close()". 2. Initializing Cache Storage before "close()" and issuing new calls, that trigger mojo after "close()". Bug: 831054 Change-Id: I6620d8107c00aed1c386c869dc1a793bc51d97fa Reviewed-on: https://chromium-review.googlesource.com/1011467 Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#551262}
-
Andrey Lushnikov authored
Browser doesn't commit navigation if server responds HTTP 204 / HTTP 205 for the main resource or if navigation triggers a download. In these cases, navigation is considered aborted. This patch teaches page.navigate to return "ERR:ABORTED" when either of the usecases happens. R=dgozman, pfeldman Change-Id: I0017e458c2f905429c7234bc8f9be20a4201bbfd Reviewed-on: https://chromium-review.googlesource.com/1009487Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#551261}
-
Matt Menke authored
Bug: 824715 Change-Id: I71d7f38a2dbe9de6515b8e9d284ab622c2311276 Reviewed-on: https://chromium-review.googlesource.com/1014367 Commit-Queue: Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#551260}
-
Christopher Lam authored
See go/closure-compile-gn for details. This CL converts the Closure Compilation from GYP to GN for the following: - cryptotoken - download_internals - md_downloads - md_extensions - md_history - md_user_manager - offline_pages - signin - webapks - welcome A local closure compile can be run by setting closure_compile = true in args.gn, and then running ninja -C out/Default webui_closure_compile. Individual projects can be compiled via, for example, ninja -C out/Default chrome/browser/resources/md_extensions:closure_compile Relanding with a fix for android builds. TBR=calamity@chromium.org,dpapad@chromium.org,ntfschr@chromium.org Bug: 632206, 833550 Change-Id: I197201fe9cd06153cce18a8e6243d6fd189f1087 Reviewed-on: https://chromium-review.googlesource.com/1013801 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#551259}
-
Tsuyoshi Horo authored
This reverts commit c4334bc5. Reason for revert: Caused crashes when storing javascript modules in cache storage. https://crbug.com/832202 Original change's description: > Enable ServiceWorkerScriptFullCodeCache by default > > Bug: 768705,788619 > Change-Id: I18474261a0bb443b5ed7186adb8bc68227ece26c > Reviewed-on: https://chromium-review.googlesource.com/994492 > Commit-Queue: Tsuyoshi Horo <horo@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#547946} TBR=horo@chromium.org,kinuko@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 768705, 788619, 832202 Change-Id: I53d3a401dfb83fbf54184588ca889b1a4f9f0474 Reviewed-on: https://chromium-review.googlesource.com/1014310Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#551258}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/38262cca..b08b074b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I6094c8bafa10382de5ffe1d86bcc422fc8f9f641 Reviewed-on: https://chromium-review.googlesource.com/1014323Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#551257}
-
Christopher Lam authored
This CL changes MojoWebUIController to use a templated AddHandlerToRegistry function which allows subclasses to add multiple interfaces to the binder registry. TBR=khorimoto@chromium.org Change-Id: I943e3d583c9a3c8bb08873001cc533c2d23a0bcf Reviewed-on: https://chromium-review.googlesource.com/991497 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#551256}
-
Fumitoshi Ukai authored
Bug: 821261 Change-Id: If9e14e0f503839955c159da7e18d402e50d0875b Reviewed-on: https://chromium-review.googlesource.com/1013021Reviewed-by:
Shinya Kawanaka <shinyak@chromium.org> Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Fumitoshi Ukai <ukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#551255}
-
Ken Rockot authored
This avoids large bitmaps yielding large messages, as BigBuffer falls back onto shared memory beyond a certain size threshold. Bug: 829659 Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: I82f907144944f2e8ebea51264fc00afc171ce3bf Reviewed-on: https://chromium-review.googlesource.com/1004598 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#551254}
-
Qiang Xu authored
changes: Remove ShowAccessibilityNotification in AccessibilityObserver. That is only used in TrayAccessibility, while TrayAccessibility should be pure views code. Move the function and tests to AccessibilityController. Bug: 800270 Test: covered by tests Change-Id: I0551c8b36d1a4bfb030b786bd78d610627113828 Reviewed-on: https://chromium-review.googlesource.com/1007891Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#551253}
-
Hirokazu Honda authored
VDA client can request Flush() after Reset() and waits for NotifyFlushDone(). After FinishReset() is done, input stream becomes off. Even doing V4L2_DEC_CMD_STOP at this time, the buffer with V4L2_BUF_FLAG_LAST will never be returned from driver. As a result, NotifyFlushDone() will not be invoked and client waits permanently. To avoid this, V4L2VDA is changed as it tries to call NotifyFlushDone if input stream is off. BUG=chromium:833223, chromium:833221 TEST=Change resolution manually on crosvideo.appspot.com TEST=VDA unittest on hana TEST=CtsMediaTestCases on hana Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4245bdcee1e537dc7061e7833530ae59fc4aecb7 Reviewed-on: https://chromium-review.googlesource.com/1013787 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#551252}
-
Gabriel Charette authored
Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /third_party/blink/renderer/platform/scheduler/child This is another scripted pass done by a slightly modified version of https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1 which has a better notion of "scope". The script should have replaced a MessageLoop::ScopedNestableTaskAllower in the same scope as a RunLoop with a RunLoop of Type::kNestableTasksAllowed. Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=alexclarke@chromium.org Bug: 781352 Change-Id: I3ffef78836b7c4ffe22be0bc8043c39d9397729f Reviewed-on: https://chromium-review.googlesource.com/1013216Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#551251}
-
Gabriel Charette authored
Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /third_party/blink/renderer/platform/scheduler This is another scripted pass done by a slightly modified version of https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1 which has a better notion of "scope". The script should have replaced a MessageLoop::ScopedNestableTaskAllower in the same scope as a RunLoop with a RunLoop of Type::kNestableTasksAllowed. Includes should have been stripped if that was the last usage of message_loop.h in that file. Please CQ if LGTY This CL was uploaded by git cl split. R=altimin@chromium.org Bug: 781352 Change-Id: I471d4462277bf67332939a1cfce7f6f17d642cc7 Reviewed-on: https://chromium-review.googlesource.com/1013214 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
The current ng_caret_rect.h/cc contains two different parts: 1. Computation of NGCaretPosition 2. Conversion from NGCaretPosition to LocalCaretRect The two parts are very different that, NGCaretPosition is a building block of other Layout NG components (e.g., ng_line_utils), while LocalCaretRect is only passed to legacy. For better code health, this patch splits them into different files. Bug: 822575 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I1dbc1b683d54c2f066cf84c21e7388bb07f8e3f1 Reviewed-on: https://chromium-review.googlesource.com/1014800Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#551249}
-
Paul Dyson authored
Need to DCHECK has_brightness, instead of DCHECKing brightness itself. Bug: 833692 Change-Id: I1f3f6667f4b3ae83e1bbbd30402864a539581390 Reviewed-on: https://chromium-review.googlesource.com/1013847Reviewed-by:
Jia Meng <jiameng@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Paul Dyson <pdyson@chromium.org> Cr-Commit-Position: refs/heads/master@{#551248}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/90906cbf2fc5..745ac35bed03 $ git log 90906cbf2..745ac35be --date=short --no-merges --format='%ad %ae %s' 2018-04-13 pwang autotest_quick_merge: Follow the symlink Created with: roll-dep src/third_party/chromite BUG=chromium:832564 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ia6c5df358bae5acea0588fe9dcf9ae70528d0621 Reviewed-on: https://chromium-review.googlesource.com/1014674Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551247}
-
Kenichi Ishibashi authored
This fixes S13nSW specific failures on external/wpt/service-workers/service-worker/fetch-canvas-tainting-video-cache.https.html. Note that "fix" here means that the result would be the same as non-S13nSW. There are still some failures on the test page. Bug: 833241 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I8c6dce03475cc50f0fb8900b73a8d7407606f170 Reviewed-on: https://chromium-review.googlesource.com/1013362Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#551246}
-
Daniel Erat authored
Change DiskMountManagerImpl's "Found disk" warning messages to DVLOG(1). I don't think that these indicate problems. Bug: 826990 Change-Id: I60a8ae1e032d209f4649d774ee4fb60d91842197 Reviewed-on: https://chromium-review.googlesource.com/1014376Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#551245}
-
Renee Wright authored
Add a dbus client method for the DestroyDiskImage Concierge service. Add a method to CorstiniManager to check the input. This is not used yet. Will be used in my next CL which adds a button in the Settings page to delete Crostini VMs. Bug: 833125 Change-Id: I6dd817a23764b484f4ac507adb0566ccbfeac5df Reviewed-on: https://chromium-review.googlesource.com/1013657Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Renée Wright <rjwright@chromium.org> Cr-Commit-Position: refs/heads/master@{#551244}
-
Lei Zhang authored
Also remove checks for |ServiceWorkerContextCore::observer_list_| being NULL. That cannot happen. BUG=558179 Change-Id: I33685dd6d113aab2e6d2fbe85c62365131fc07d3 Reviewed-on: https://chromium-review.googlesource.com/1014659Reviewed-by:
-
Erik Chen authored
This CL is a refactor with no intended behavior change outside of tests. Test behavior change: * TestDriver::CheckOrStartProfiling now waits for the allocator shim to be initialized even if profiling was enabled for the current process via command line flags. This is because initialization is asynchronous. * TestDriver::ValidateRendererAllocations no longer makes any checks if the renderer is not being profiled, since on Android WebView there may not even be a renderer process in this case. Refactor: * Moves the C++ side of the android test shim into components/heap_profiling, so that the logic can be shared with Android Webview. * Renames the test shim from TestAndroidShim to HeapProfilingTestShim. * Removes redundant checks in TestDriver::ValidateRendererAllocations. Change-Id: I4755f6169b0f9c556a86005916aa9150dec6853b BUG: 827545 Reviewed-on: https://chromium-review.googlesource.com/1012542Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#551242}
-
Kent Tamura authored
Move check-webkit-style and lint-webkitpy from //third_party/WebKit/Tools/Scripts to //third_party/blink/tools. This CL also adds add_webkitpy.py to blinkpy/common. Bug: 829697 Change-Id: I592d0b2c5076bc89ee30fa6a7afbb15e8cb77319 Reviewed-on: https://chromium-review.googlesource.com/1013820 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#551241}
-
Xiaocheng Hu authored
The above mentioned function is symmetric when adjusting left and right edge of an inline box. This patch enforces the symmetry by unifying the algorithms with a template. It is also preparation for crrev.com/c/997134. Bug: 822575 Change-Id: Iacb6a77c3e43c598d2405d7f859e5f619e138a0b Reviewed-on: https://chromium-review.googlesource.com/1013059 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#551240}
-
Nico Weber authored
The clang tot bots moved off chromium.fyi to chromium.clang a while ago, and the testers were removed altogether since all the tests now run on swarming and can hence be triggered by the builder. Bug: none Change-Id: Ie6951241a375d397d98768811483a522ac589ad7 Reviewed-on: https://chromium-review.googlesource.com/1013611 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#551239}
-
Jinho Bang authored
Related spec change: https://github.com/w3c/payment-handler/pull/294 Bug: 833530 Change-Id: I65d0e01bb5b6bfdd44925b90ba98837161cc136b Reviewed-on: https://chromium-review.googlesource.com/1013664Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#551238}
-
Christian Biesinger authored
See the comments in the patch for why this is necessary. R=eae@chromium.org, ikilpatrick@chromium.org Bug: 635619 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I0a4042c0782c98fab1bfd27cb3bf6ca29c820542 Reviewed-on: https://chromium-review.googlesource.com/1013306Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#551237}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6d63741e. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15673 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/service-workers/cache-storage TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: I47a23cc232874b9640034a4fce27ffbfc196b8bf Reviewed-on: https://chromium-review.googlesource.com/1014377 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#551236}
-
Jamie Madill authored
This reverts commit 5f77b73e. Reason for revert: Roll has landed, reinstating tests. Original change's description: > Temporarily disable angle_vulkan_deqp_tests. > > Unblocks the Vulkan roll. > > Bug: angleproject:2482 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I9577f331977e9add28bb7875e70260d428ad0cd5 > Tbr: kbr@chromium.org > No-try: True > Reviewed-on: https://chromium-review.googlesource.com/1014322 > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551102} TBR=jmadill@chromium.org,kbr@chromium.org Change-Id: Iab80706a6e74c442533d4df60c753e7dc270c380 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: angleproject:2482 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1014726Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#551235}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I043e19c9bfd8e620851878c96c962cf7c6124293 Reviewed-on: https://chromium-review.googlesource.com/1014725Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#551234}
-
Joel Hockey authored
Turn off FileManagerUITests from CQ until current audit of tests by noel@ is complete. Bug: 819478 Change-Id: I14dca567de4fb7919d94b1d89a0cb2dada5b8d67 Reviewed-on: https://chromium-review.googlesource.com/1013668Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#551233}
-
https://chromium.googlesource.com/angle/angle.git/+log/aa8b3982aeeb..08b9e046c1b6 $ git log aa8b3982a..08b9e046c --date=short --no-merges --format='%ad %ae %s' 2018-04-16 jmadill Vulkan: Disable warning in Mock ICD. 2018-04-16 tobine Roll (2/2) to latest LVL as of 4/16/18 Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org No-Try: True Change-Id: I34309b2c8fc6f4d49ba465929378687aaaa181a1 Reviewed-on: https://chromium-review.googlesource.com/1014671 Commit-Queue: Jamie Madill <jmadill@chromium.org> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#551232}
-
Ken Rockot authored
Impending changes to Mojo IPC will require that handles serialized as shared memory handles are actually shared memory handles. DXGI resources are not, but are being transported using GpuMemoryBufferHandle's shared_memory field. This introduces a Windows-only GpuMemoryBufferHandle field for a generic HANDLE to be used for DXGI resources, as well as a corresponding mojom field for the same purpose. There should be no net effect on the behavior of the system wrt handle lifetime or usage. Bug: 826213 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5d510e0ebdb60d4872fc428a95ce681dd18369dc Reviewed-on: https://chromium-review.googlesource.com/1011600Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#551231}
-
Stephen Martinis authored
Forces layout tests to run in a debug mode. Bug: 818832 Change-Id: I860e41169ea759e32806ba4ab45ca4e0d72ba4cd Reviewed-on: https://chromium-review.googlesource.com/1014634Reviewed-by:
-
Christian Biesinger authored
To help with debugging R=xiaochengh@chromium.org,ikilpatrick@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ie56254eef3aaa3d21e0f74d2323211197ecd127a Reviewed-on: https://chromium-review.googlesource.com/1013616Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#551229}
-
Noel Gordon authored
In a FileManagerBrowserTest...SetUpInProcessBrowserTestFixture happens after SetUpCommandLine and before SetUpOnMainThread. Move it there, so its code location in this file is in call-order. Bug: 831074 Change-Id: I999a057c3163ebe13146a54c44d8ba3deb7e0d8c Reviewed-on: https://chromium-review.googlesource.com/1013783Reviewed-by:
Tomasz Mikolajewski <mtomasz@chromium.org> Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#551228}
-
Sergey Ulanov authored
headless_example fails to compile on fuchsia with https://chromium-review.googlesource.com/c/chromium/src/+/985648/15 . The problem is that headless_shell_lib implicitly depended on //base but that dependency wasn't in the gn file. Added //base to public_deps for headless_shell_lib to fix this problem. Bug: 831384 Change-Id: Ib4664a33a3c649063434911e0a4ee074233c3319 Reviewed-on: https://chromium-review.googlesource.com/1011631Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#551227}
-
Andrey Kosyakov authored
- let consumers create streams directly with DevTooolsStreamFoo::Create() rather than through different methods of DevToolsIOContext; - get rid of Close() methods, do all cleanup in destructors; - eliminate RWStream, let its consumer use DevToolsStreamFile directly; Bug: 831887 Change-Id: I1aa28f8dea4a4e00c0323cb4101dc8db274a9bd4 Reviewed-on: https://chromium-review.googlesource.com/1014303 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: -
Igor Kobylin authored
R=dschuyler@chromium.org Bug: 677338 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I84fa57c20af482de22ff31dd09c223b4f4331770 Reviewed-on: https://chromium-review.googlesource.com/1007443Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#551225}
-
Jennifer Apacible authored
This consolidates some of the similar exit-Picture-in-Picture behavior from both WebMediaPlayerImpl and PictureInPictureWindowController sides. When exiting from WMPI, we need to run an additional callback to signal that the window should be closed. From user gesture, the window tear down has already been handled. BUG: 823172 Change-Id: I4ee6e03a519a7564f7eb8b195f2dc7ddeacf4a88 Reviewed-on: https://chromium-review.googlesource.com/1012521 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#551224}
-
