- 27 Sep, 2018 40 commits
-
-
Nico Weber authored
Bug: 887392 Change-Id: I5de7b4d218cd31fe637d52d94f9ba888b88a4c1d Reviewed-on: https://chromium-review.googlesource.com/1249446 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#594869}
-
Xianzhu Wang authored
The fast paths handles cases that source is the parent of destination or visa versa. This simplifies client code of GeometryMapper in PaintLayerClipper and can get the similar performance. Bug: 875991 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4d3a465d3e40f453b389ca51b9e23918db3b95fb Reviewed-on: https://chromium-review.googlesource.com/1236555 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#594868}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7a4e890f252c..8e0212945b13 git log 7a4e890f252c..8e0212945b13 --date=short --no-merges --format='%ad %ae %s' 2018-09-27 mattm@chromium.org netlog_viewer: appengine files and deployment instructions Created with: gclient setdep -r src/third_party/catapult@8e0212945b13 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:888816 TBR=sullivan@chromium.org Change-Id: If30b1d87f4dc1ab7ffae61bc1e609fc6275ff0d1 Reviewed-on: https://chromium-review.googlesource.com/1249513Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594867}
-
Xianzhu Wang authored
Previously ContainingBlockFor(Fixed|Absolute)Position was used to get the clip state of the container of fixed|absolute descendants. However, if the container is not a LayoutBlock, the mentioned functions will return the containing LayoutBlock which may not be a layer thus may not have LocalBorderBoxProperties to get the clip state. Now use ContainerFor(Fixed|Absolute)Position instead, and add test. Bug: 889734 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6a1c95f81259a566791b40867b666b5c9852066a Reviewed-on: https://chromium-review.googlesource.com/1249827 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
Mikel Astiz authored
The hypothesis here is that the test outcome is, strictly speaking, non-deterministic, because a server with an eventual consistency model cannot guarantee how exactly a conflict will be resolved (although it will guarantee that clients converge). In this model, the last commit will win. We fix the previously existing test by making sure which of the two clients commits first to the server. This is achieved by mimic-ing an offline state (or poor connectivity compared to the other client). In order to verify the hypothesis, we add a second test that enables strong consistency model on the server (implemented as part of this patch), and hence relies on that mechanism to expect a deterministic outcome without having to put clients offline. Bug: 810408 Change-Id: I2fa3fd8c941674344030a76e76f7855131c1908e Reviewed-on: https://chromium-review.googlesource.com/1249482 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#594865}
-
manuk authored
1. addResultToOutput 2. addResultTableToOutput 3. createAutocompleteResultTableHeader, 4. addParagraph instead of 1. createAutocompleteResultTableHeader 2. addParagraph 3. addResultToOutput 4. addResultTableToOutput). Change-Id: I3fa7553993fe2256a5c1efb0f3b69bffaa56aa49 Reviewed-on: https://chromium-review.googlesource.com/1249830 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#594864}
-
Xing Liu authored
The download guid in DownloadInfo.java is not plumbed from OfflineItem. This will cause DownloadItem.getId() or DownloadInfo.getDownloadGuid() to return null. Bug: 889369 Change-Id: I73fc66e16d2fa3b6e7a0e8d02dff9655f259f7d1 Reviewed-on: https://chromium-review.googlesource.com/1249835Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#594863}
-
Christopher Grant authored
A recent improvement to the APK wrapper scripts queries the target APK for its native ABI, so it can ignore devices that don't match. Unfortunately this broke bundle installation, since we can't yet run the same ABI query on a bundle. BUG=887964 Change-Id: I52c18a39ebb5b2714731826e2797e1fc18ab0a0e Reviewed-on: https://chromium-review.googlesource.com/1249901Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#594862}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b15eae0a955c..1814174dbc2e Created with: gclient setdep -r src-internal@1814174dbc2e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id5243bda5bfbfebd2001d000e198135a7123243f Reviewed-on: https://chromium-review.googlesource.com/1249512Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594861}
-
Jacob Dufault authored
CurrentBigUserView() could be null if - there are no users on the device yet - enterprise policy disables showing the logged in users Bug: 889580 Change-Id: If7eea97b84697dfc2ced137741489a41f7520993 Reviewed-on: https://chromium-review.googlesource.com/1249815Reviewed-by:
Quan Nguyen <qnnguyen@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#594860}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dbdd151b1cb9..656cefe65d62 git log dbdd151b1cb9..656cefe65d62 --date=short --no-merges --format='%ad %ae %s' 2018-09-27 dmazzoni@chromium.org Add initial support for generating tagged PDFs. 2018-09-27 halcanary@google.com SkPDF: Fix skia:8397, reduce RAM use, stop copying ClipStacks. 2018-09-27 herb@google.com Move ARGB fallback helper into Painter 2018-09-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 1c1d5560df11..dfd5b3a4a61f (1 commits) 2018-09-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skia/third_party/skcms 0eb21d4ecadd..1c1d5560df11 (1 commits) 2018-09-27 bsalomon@google.com Call XInitThreads in sk_app startup 2018-09-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 40a6005e7a14..8c5ca8d1a7ea (5 commits) Created with: gclient setdep -r src/third_party/skia@656cefe65d62 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=bsalomon@chromium.org Change-Id: I36d5984c7dd08d6394e7906be1ca0ee513133686 Reviewed-on: https://chromium-review.googlesource.com/1249511Reviewed-by:
-
Robert Ogden authored
Removes the except on HTTPS verbage ahead of the launch of HTTPS Server Previews. Bug: 889696 Change-Id: I42aae90651b1924f21cef46fccbf2acf06aa063f Reviewed-on: https://chromium-review.googlesource.com/1249981Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#594858}
-
Robert Ogden authored
Adds the same string as the Infobar would show according to the UI mocks. Also cleans up PageInfoController a bit from my last adventure there. Bug: 888029 Change-Id: Iba1bae14ba05ecd912431463db73ec7a72ebb7f5 Reviewed-on: https://chromium-review.googlesource.com/1246782Reviewed-by:
-
Etienne Bergeron authored
This CL is adding the GPU events to the whitelist. We do not accept any args yet, since some of them may contains PII and are not yet useful to investigate GPU issues. We will update the |kGPUAllowedArgs| array when needed. For now, let assume no args. R=oysteine@chromium.org Bug: 888580 Change-Id: Ia23ba1c0e2ed6a49328416678062074ffab472a6 Reviewed-on: https://chromium-review.googlesource.com/1249914Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#594856}
-
Raymond Toy authored
The spec says the channelCount should be 2 not 1 for an AnalyserNode. Remove the test expectations too since we pass the tests now. Bug: 889640, 888870 Change-Id: I814fc31d0e15c371f9ae74dd8e3ce2fb0a906197 Reviewed-on: https://chromium-review.googlesource.com/1247241Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#594855}
-
Brian White authored
Bug: 836238 Change-Id: I4714f80e7a0796327bce606f89ce1f889752f39f Reviewed-on: https://chromium-review.googlesource.com/1249396Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#594854}
-
Joshua Peraza authored
For Chromecast, Content Shell, and non-monochrome Clank/Webview: The Crashpad handler is a standalone executable, packaged like a loadable module and named libcrashpad_handler.so in order to not be ignored by Android's APK installer. For Monochrome: The Crashpad handler is linked into libmonochrome.so. At crash-time /system/bin/app_process{32,64} is exec-ed, running CrashpadMain.java which loads libmonochrome.so and runs the native HandlerMain(). This strategy is not used for non-monochrome APKs (i.e. pre-N) because on L, Android's loader is not yet capable of loading native libraries from the APK. This is normally performed by the Chromium linker which can't be used by CrashpadMain.java because /system/bin/app_process doesn't initialize the process like a normal Android application (specifically, no ContextImpl has been created, so any calls to e.g. appContext.getApplicationInfo() will segfault). Binary-Size: MonochromePublic.apk increases in size by 100 KB. ChromeModernPublic.apk increases in size by 203KB (587 KB increase in install size because libcrashpad_handler.so is extracted from the APK). Possible mitigations for this increase are TODO: For J, K: We could link the handler directly into libchrome.so and let that be our handler executable. This would de-dup portions of libbase that are currently linked into both libchrome.so and libcrashpad_handler.so. For L, M: It might be possible to get the chromium linker (or Bionic's linker on M) to dlopen libchrome.so from the APK for a trampoline libcrashpad_handler.so to de-dup libbase. Bug: crashpad:30 Change-Id: If5b3752f26455e5c7aef3278b4bd2076ef1b7b65 Reviewed-on: https://chromium-review.googlesource.com/1150774Reviewed-by:Bo <boliu@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#594853}
-
Danyao Wang authored
Bug: 885274 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Iead2e9e13997d6d12987c4a40e02876d55108523 Reviewed-on: https://chromium-review.googlesource.com/1244596 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#594852}
-
Parastoo Geranmayeh authored
The feature "use invalid data" for possible type uploads should always be on, meaning that the client will send up votes regardless of the validity states. This is because we are uploading the validity states of each possible type, and we can evaluate the relevance of invalid data on the server side. Also, the validity of UNKNOWN types should be set to UNVALIDATED for the consistency. Change-Id: Ia7234a128b04b975f6fb1bfd4d4dc131547530a8 Reviewed-on: https://chromium-review.googlesource.com/1249907Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#594851}
-
Lei Zhang authored
BUG=860827 Change-Id: I403f2b4ada07242cc035ebb12ec1d1f6145ac42d Reviewed-on: https://chromium-review.googlesource.com/1249838Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#594850}
-
Jennifer Apacible authored
Change-Id: I138c4e57f47af2750dc66cea9981a455e5d5b60f Reviewed-on: https://chromium-review.googlesource.com/1246786 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#594849}
-
James Cook authored
This is a first step toward mash support for multiple remote mojo apps supplying AX node trees. * Let AXHostService generate the AXTreeID as a side-effect of being an AXHostDelegate * Inform the remote app of its AXTreeID when it connects * Push the ID into ash so it can be used for views focus support. This won't work for multi-process mash, but is fine for today's shortcut viewer app and probably for SingleProcessMash. Longer term we should probably use aura::Window properties for this. See go/mash-ax-node-tree for notes Bug: 888147 Test: updated views_mus_unittests, unit_tests, etc. Change-Id: I2400ab02d8c504a0a041646bc694976458b3228b Reviewed-on: https://chromium-review.googlesource.com/1246595 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#594848}
-
Scott Violet authored
views_mus_unittests was calling mojo::core::Init() multiple times, which leaks. The fix is to move the Init() call to the TestSuite as well as setting up the ipc thread. BUG=888533 TEST=test only changes Change-Id: I852ca0ab4736aa7a4a18d3c650fa6122b320eb9d Reviewed-on: https://chromium-review.googlesource.com/1249810Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#594847}
-
Etienne Bergeron authored
This CL is adding the stack sampling tracing category to the GPU scenario. Slow-reports will now get the stack sampling on the GPU main thread when the user is running the "BENCHMARK_GPU" scenario. R=piman@chromium.org, ssid@chromium.org, oysteine@chromium.org Bug: 888580 Change-Id: Ib6d6e6c98a77a11a1ee24d6223e6358115467a84 Reviewed-on: https://chromium-review.googlesource.com/1249909Reviewed-by:
Siddhartha S <ssid@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#594846}
-
Seth Hampson authored
The RTCQuicTransport web API needs to use the underlying core QUIC library. In order to use this API we need to create a shim of the library that subclasses the QuicSession and QuicStream. This change subclasses the QuicSession and has some basic implementation for establishing a connection. Bug: 874296 Change-Id: I63acd4913abc23733521157bd1aca4a3d1301c65 Reviewed-on: https://chromium-review.googlesource.com/1170125Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Seth Hampson <shampson@chromium.org> Cr-Commit-Position: refs/heads/master@{#594845}
-
erikchen authored
X events have a timestamp which is only well defined relative to the X11 Server time. The previous computation for timestamp for X11 events was making the assumption that Server time and Chrome time were the same. This assumption is not always true -- this is likely the root cause of "bad" timestamps observed in https://bugs.chromium.org/p/chromium/issues/detail?id=650338#c1 This CL changes event timestamp computation to make a roundtrip to the X11 Server to get an accurate base::TimeTicks. This logic was lifted out of the responsiveness calculator, which was already doing this computation. The latter will subsequently be changed to use the computation in this CL. Change-Id: I963019cd8bfb8ce14e06b3743a159c9c85f2cb82 Bug: 859155 Reviewed-on: https://chromium-review.googlesource.com/1249383Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#594844}
-
Jao-ke Chin-Lee authored
BUG=790343 Change-Id: Ifb62914414b09eed794387ab5073fc973532f162 Reviewed-on: https://chromium-review.googlesource.com/1249807Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#594843}
-
Ryan Cui authored
Bug: 888188 Change-Id: I9056c918ceda50d5c50d7dfbadef5c22f7e80d34 Reviewed-on: https://chromium-review.googlesource.com/1246948Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ryan Cui <rcui@chromium.org> Cr-Commit-Position: refs/heads/master@{#594842}
-
Donn Denman authored
When Contextual Search selects a word in response to tap there's a potential race condition between two messages in the SelectionClient interface: onSelectionChanged and selectWordAroundCaretAck. In cases where the Ack is called first the selection controller doesn't have a valid word and asserts. This change extracts the word from the surrounding text and updates the selection controller to ensure that it knows about the selected word. BUG=889657 Change-Id: Ifbc65d199b179df31fed65ae4b0b06dc13cf6213 Reviewed-on: https://chromium-review.googlesource.com/1248021Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
-
Jonathan Metzman authored
Since we can't rely on no_sanitize attributes on Windows, use the gn configs to ensure LF isn't instrumented with ASAN. This fix is hopefully temporary, ideally we can get clang-cl to respect the no_sanitize attribute. Bug: 883948 Change-Id: Ia4854d5f5b9148d175fa2f5f90bd9b34f064e064 Reviewed-on: https://chromium-review.googlesource.com/1249150Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#594840}
-
David Trainor authored
Add a separate asynchronous loading view for downloads and integrate it into the image class. This includes the following view classes for downloads home: - AsyncImageView - SquareAsyncImageView - ForegroundRoundedCornerImageView Each of these will be used for different components in the future downloads home UI. BUG=868554 Change-Id: I1b5afbaba85be701e607f1f97ae705b4ae83095d Reviewed-on: https://chromium-review.googlesource.com/1240507Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#594839}
-
Devlin Cronin authored
Add a unittest to verify that permissions.contains() and permissions.getAll() correctly return the current permissions for an extension, even if it's affected by the runtime host permissions feature. Bug: 889654 Change-Id: I1ec42ed12208647cbee5784e4908a196e4b69994 Reviewed-on: https://chromium-review.googlesource.com/1247226Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#594838}
-
Chris Harrelson authored
This improves BGPT testing, and slims GraphicsLayer a bit. Bug: 883949 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I77d5108dd2309de33a52ca90e3592c2d22ea28a0 Reviewed-on: https://chromium-review.googlesource.com/1247037 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
-
Yue Li authored
Added histograms for: - Assistant Service start time - Get settings request time - Count number of timout triggers Also update the timeout to 15s. Bug: b/116466382 Test: Manual Test Change-Id: I0bf23962e28b61cb08970d11e47b702eb1c721f9 Reviewed-on: https://chromium-review.googlesource.com/1246664Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
-
Sebastien Seguin-Gagnon authored
The issue here was the autocomplete feature, not autofill. Autocomplete is disabled when the attribute is set to off. Bug: 869516 Change-Id: Ib18953ed5e147cf6bab87b2c389ac75e83be13cd Reviewed-on: https://chromium-review.googlesource.com/1249506 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#594835}
-
Randy Rossi authored
This CL moves common logic between chrome & chromecast into a common ui/views class. Chrome/Chromecast specific logic differences are handled in a delegate class. Name/scope of this delegate may change as we refactor move duplicate code out. Part of an on going effort to eliminate duplicate code introduced when automation API was added to Chromecast. Test: Manual verification on chromecast (estelle) and chromeos (tidus) Bug: 837773 Change-Id: Ia73513b09550d089daf09c89dd1fdda11bcacd4a Reviewed-on: https://chromium-review.googlesource.com/1234363Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#594834}
-
John Chen authored
Getting size of full screen window now works correctly on all desktop platforms. Re-enable Python-based ChromeDriverTest.testWindowFullScreen. Bug: chromedriver:1945 Change-Id: I57a4b4003b37d174a8a9a5573453fd861845b948 Reviewed-on: https://chromium-review.googlesource.com/1249831Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#594833}
-
Peter Wen authored
Switch stability proto's renderer crash count to include all renderer crashes that result in a minidump rather than just foreground. Pros: - Align renderer crash counting with GPU crash counting - Closer alignment with crashes that are uploaded - Every crash resulting in a minidump is a candidate to be uploaded - Background renderer crashes are real crashes and should be fixed Cons: - Foreground renderer crashes are certain to cause a bad user experience while background crashes do not necessarily do so. We are testing this out and keeping the rest of the crash pipeline the same so that we can continue to compare old vs new metrics. If it does not result in poor prioritization, this change will stick. Full context: http://g/clank-crash/hZJyq3PJC3g Bug: 839017 Change-Id: Iab8d6bdae993fbe3d41932719b9cecc5a6c450b8 Reviewed-on: https://chromium-review.googlesource.com/1246462Reviewed-by:
-
Ryan Sturm authored
This CL adds logic to dismiss the heavy page capping InfoBar after 8 seconds of no requests being finished on the page. The actual time is field trial configurable. This also adds a browser test to check this behavior. Bug: 888817 Change-Id: I7332918b4590f2f8cd70db365af8dce60f26956c Reviewed-on: https://chromium-review.googlesource.com/1242173Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#594831}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4e651334d46b..7a4e890f252c git log 4e651334d46b..7a4e890f252c --date=short --no-merges --format='%ad %ae %s' 2018-09-27 simonhatch@chromium.org Re-enable symbolize_trace_end_to_end_test_slow.SymbolizeTraceEndToEndTest.testMacv2 Created with: gclient setdep -r src/third_party/catapult@7a4e890f252c The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:888947 TBR=sullivan@chromium.org Change-Id: I122717fbc2aebcff1d1d190b2a75049b420c2d07 Reviewed-on: https://chromium-review.googlesource.com/1249634Reviewed-by:
-
