- 15 May, 2018 40 commits
-
-
Rayan Kanso authored
It would be useful to be able to store and reinitialize full fetch request data (not just the url). As a specific example, this is needed for background fetch to resume a fetch after a browser restart. TBR=avi@chromium.org Bug: 826257 Change-Id: I3dd388b94bac0d9fa37477967d556118304dd9c9 Reviewed-on: https://chromium-review.googlesource.com/1057271 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#558687}
-
Joel Hockey authored
Bug: 834103 Tbr: noel@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If1e8186e560ef53674fe1a2a5c1bc05d443aac7d Reviewed-on: https://chromium-review.googlesource.com/1059633Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#558686}
-
Jonathan Backer authored
This will add ".RenderWorker-0x0123456789ABCDE" to debug annotations, both tracing and --enable-gpu-service-logging debug logging. Mostly just copy-pasta from GLES2. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1c824c09ab3f1c6f75412bb2222273d32d3b93f6 Reviewed-on: https://chromium-review.googlesource.com/1058121Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#558685}
-
Anders Hartvoll Ruud authored
The return value is useless, so might as well use the generated function. R=futhark@chromium.org Bug: 807503 Change-Id: I402edb2b2a70e5ec14e06c3be0fcf5836b46c083 Reviewed-on: https://chromium-review.googlesource.com/1057710Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#558684}
-
Moe Ahmadi authored
Bug: 842746 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie69687c50368a84ae97f1d648ce33645ce94402b Reviewed-on: https://chromium-review.googlesource.com/1057895 Commit-Queue: Peter Lee <pkl@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#558683}
-
Victor Costan authored
While installing, a service worker may call cookieStore.subscribeToChanges() to express interest in observing the changes to the list of cookies sent in a request to a specific URL. After the service worker becomes active, it is notified of changes to the cookies it is interested in via "cookiechange" events, which are dispatched to the service worker's global scope. This CL lays the last piece in the foundation of the Async Cookies API, which is currently gated by the Experimental Web Platform Features flag. This CL focuses on the core functionality and plumbing. Follow-up CLs will add more tests, fix the handling of edge cases, and improve performance. Bug: 729800 Change-Id: I52f2e550d7901d746ed1a973426d3181ea091147 Reviewed-on: https://chromium-review.googlesource.com/979334Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#558682}
-
Mirko Bonadei authored
This CL changes the way Abseil headers are included. On GCC and clang, -isystem will be used, on clang-cl -imsvc while MSVC will continue to use -I. This is a follow-up of: https://chromium-review.googlesource.com/1026650. The goal is to avoid to use warning suppression flags in Abseil clients (they will be needed when MSVC is used because there is no such thing as -isystem/-imsvc). Bug: webrtc:8821 Change-Id: I05a31d0244528bf5d0143e6a2e700b940d15a004 Reviewed-on: https://chromium-review.googlesource.com/1059593Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#558681}
-
Boris Sazonov authored
This reverts commit 203117d9. Reason for revert: broke downstream and official builders. Builder: http://uberchromegw/i/official.android/builders/official-arm/builds/3216 Original change's description: > Rename U2f* to Fido2* > > In GmsCore v19, the Fido2 APIs will provide the unified functionality > of the U2F and Fido2 APIs so it will no longer be necessary to call > both of them. > > Since the rename spans upstream and downstream, will initially add > all Fido2* classes and then later remove the U2f* classes once > downstream changes have landed. > > Bug: 842006 > Change-Id: I4775682b428c0ffdc4aa6f699136a2c7d15ee40c > Reviewed-on: https://chromium-review.googlesource.com/1054778 > Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org> > Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> > Cr-Commit-Position: refs/heads/master@{#558479} TBR=mariakhomenko@chromium.org,kpaulhamus@chromium.org Change-Id: I20e10d48e1630d8a084003287f2dda9365d030be No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 843011, 842006 Reviewed-on: https://chromium-review.googlesource.com/1059595Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#558680}
-
Joel Hockey authored
Bug: 834103 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If3bb0d2604f9778ebb3cf3bdbb799e234755472d Reviewed-on: https://chromium-review.googlesource.com/1059533Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#558679}
-
Joel Hockey authored
Update FilesApp to expect crostini to mount with sshfs and show up as a disk volume rather than using sftp and mounting using the File System Provider API. Bug: 834103 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iede287504e2d6af50fc60d1c175c21360b3d0882 Reviewed-on: https://chromium-review.googlesource.com/1059494Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2817a4f1. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17649 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts hta@chromium.org: external/wpt/webrtc yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=markdittmer No-Export: true Change-Id: I4bed765e11dc807d1054a6f537815cec6ff0d119 Reviewed-on: https://chromium-review.googlesource.com/1059309 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#558677}
-
Bruce Dawson authored
This reverts commit 7f4f1890. Reason for revert: This CL breaks non-goma builds (any build that uses precompiled header files) Original change's description: > Remove unnecessary include_dirs settings from BUILD.gn in Blink > > Now we have no Blink-relative #includes. > > Bug: 836071 > Change-Id: I33bbab6340def20dcd07a72fcc5d1a4d08254a1b > Reviewed-on: https://chromium-review.googlesource.com/1058876 > Reviewed-by: Hitoshi Yoshida <peria@chromium.org> > Commit-Queue: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#558629} TBR=peria@chromium.org,tkent@chromium.org Change-Id: I087e3344be78d3cc3a764ae6536ede3f6f0b0563 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 836071 Reviewed-on: https://chromium-review.googlesource.com/1059515Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#558676}
-
Eric Seckler authored
When TaskQueueManagerImpl is sampling CPU time, align the sampling of tasks for UKM reporting with the CPU time sampling, so that UKM-sampled tasks always report CPU time. Bug: 842112 Change-Id: I56ebc8c1f8a82165e5cb71cc4ea8bbf4c161ba43 Reviewed-on: https://chromium-review.googlesource.com/1057167 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#558675}
-
Noel Gordon authored
No change in behavior, no new tests. Bug: 843030 Change-Id: I7ee2385d419c637da4ced0491e50cde3ed6558b5 Reviewed-on: https://chromium-review.googlesource.com/1059367 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Cr-Commit-Position: refs/heads/master@{#558674}
-
Kent Tamura authored
Apply snake_case to generated V8GeneratedCoreBindings.cpp, initPartialInterfacesInModules.cpp, and V8ContextSnapshotExternalReferences.cpp. Bug: 770603 Change-Id: I9e7ab97fe7b0fab5dfe2e4ded6f8becba9d47d1c Reviewed-on: https://chromium-review.googlesource.com/1059097Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#558673}
-
Koji Ishii authored
Following bot results are included. 5415 5420 5423 5428 5448 5469 5476 5479 136 lines were removed and 30 lines were deflaked by consecutive results since 5389. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I8496c844c4089e00487e053f8da2400c025fd178 Reviewed-on: https://chromium-review.googlesource.com/1056655 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#558672}
-
Olga Sharonova authored
Muting: * There is an AudioSessionMuter class which manages muting for a group. * InputStreamBroker has one in case source should be muted. * ForwardingFactory also has one if webcontents should be muted. Bug: 824019 Change-Id: I41c26e8de38912f9dac1409ff9dba86cd43631ea Reviewed-on: https://chromium-review.googlesource.com/1046052 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#558671}
-
Charlie Harrison authored
These metrics are unmonitored, and the predictor is being replaced by a new system. Bug: 831006 Change-Id: I2f3260637581960b059319e92f434091426252bb Reviewed-on: https://chromium-review.googlesource.com/1057461Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#558670}
-
Joel Hockey authored
Add a new ContentScanner class for crostini that shows an empty directory and spinner whilst starting and mounting the crostini container. Bug: 834103 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5dd83c7db3783fff2d0298234d16bb00478ba3d8 Reviewed-on: https://chromium-review.googlesource.com/1059427 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
Chris Pickel authored
This reverts commit fc95501f. Reason for revert: Findit (https://goo.gl/kROfz5) identified this CL at revision 557680 as the culprit for introducing flakiness in the tests as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZmM5NTUwMWZiMjllM2U3NDg3ZmZmOThjMTdlNmFhYmExMDQ2YjMzMAw Original change's description: > Create BrowserThread::IO thread before browser main loop to start > ServiceManager. > > We need a thread to post/execute tasks when starting the > ServiceManager. This thread needs to be created before the browser > main loop is initialized, and will be registered as the > BrowserThread::IO thread which is currently used by ServiceManager > connections. > > The creation of such a thread is moved to service_manager::main via > MainDelegate::CreateIOThreadAndGetTaskRunner(). Since it requires no > thread created before calling fork() on posix, we also move the setup > of sandbox before creating the IO thread. > > Bug: 740677, 729596 > Change-Id: I23ef57eb52bfb1eb363682dadf98c571c12afcd1 > Reviewed-on: https://chromium-review.googlesource.com/969098 > Commit-Queue: Xi Han <hanxi@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557680} TBR=gab@chromium.org,jam@chromium.org,hanxi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 740677, 729596 Change-Id: Ia548067acbf640010f4c8fbed29a0012a274af05 Reviewed-on: https://chromium-review.googlesource.com/1059167Reviewed-by:
Chris Pickel <sfiera@chromium.org> Commit-Queue: Chris Pickel <sfiera@chromium.org> Cr-Commit-Position: refs/heads/master@{#558668}
-
Kent Tamura authored
Thew new test is added to SmokeTests in order that Android build bots run it. Bug: 838898 Change-Id: I18f8320550a82fb5fddc0c98f0b8f0417f1e4d80 Reviewed-on: https://chromium-review.googlesource.com/1056947Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#558667}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/558cf7d7..df9ba269 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I356073fdce19d4bd2454a3c84969bdc7726b64d7 Reviewed-on: https://chromium-review.googlesource.com/1058917Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#558666}
-
Joel Hockey authored
Set NavigationListModel.linuxFilesItems async from FileManager to allow directoryTree redraw which is required to show the item when FilesApp first launches. Remove specialized SFTPMountItem class and combine Recent and Linux Files to use NavigationModelFakeItem and DirectoryTree/FakeItem. Bug: 834103 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie840c8826368df5c63b608dcc5be59601f6452cb Reviewed-on: https://chromium-review.googlesource.com/1059368 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
Currently CompleteSweep() is forced in the epilogue of Scavenger. If the Scavenger is scheduled close after a BlinkGC then completing sweeping can introduce large pause. Blink GC should synchronize with V8 Mark-Compact GC and should be independent from Scavenger. Change-Id: I8ae10c1d914a1182f3848d20252123795cd931a9 Reviewed-on: https://chromium-review.googlesource.com/1059148 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#558664}
-
Colin Blundell authored
On ChromeOS, IdentityManager has its primary account info set by UserSessionManager (see crbug.com/814787). At this point in the flow, the email address that UserSessionManager knows about is the sanitized email address. Hence, that is what gets set with IdentityManager. However, this email address can be updated in AccountTrackerService later on in response to the user info being fetched (see details in crbug.com/842041); in particular, if the user entered a non-sanitized version when creating their gmail account (e.g., f.o.o@gmail.com vs. foo@gmail.com), it will get updated to the user-entered version (note that the accountID used by AccountTrackerService to track the account is not changed; it is only the email address that is updated). This behavior is causing an IdentityManager DCHECK to go off, as it sees that its view of the primary account's email address doesn't match that of SigninManagerBase. This CL inserts a hack so that IdentityManager updates its email address in these cases. crbug.com/842670 tracks the need for a long-term solution for this problem. This CL also adds a unittest that fails before this change. Note: On other platforms, the email address passed to SigninManager's signin flow is already the user's originally-specified version. To test, sign in on a ChromeOS debug build with an email address that was created in non-canonical form (e.g., when the gmail account was originally created, the user added some periods in the email address). Verify that no DCHECK goes off. TBR=msarda@chromium.org Bug: 842041 Change-Id: Ic4097e2091640fc44d242a7aba5062a3a85b367c Reviewed-on: https://chromium-review.googlesource.com/1057233 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#558663}
-
https://webrtc.googlesource.com/src.git/+log/8a150d9c2134..5702736f7e46 $ git log 8a150d9c2..5702736f7 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:none,chromium:None,chromium:none,chromium:None,chromium:None,chromium:None,chromium:755660 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ib0593ca5d9f2ccf1eb7f7df04b2df6faa21eeb94 Reviewed-on: https://chromium-review.googlesource.com/1059014 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558662}
-
Noel Gordon authored
NOT_IN_GUEST_MODE is the default guest mode for a TestCase. Remove it in TestCase calls by adding an explicit, one-arg TestCase constructor (which is therefore NOT_IN_GUEST_MODE by default). No change in behavior, no new tests. Bug: 843030 Change-Id: Ib46f5f047c74c426d56ceacb1f6ab8334ccd88a7 Reviewed-on: https://chromium-review.googlesource.com/1059101Reviewed-by:
-
Noel Gordon authored
Bug: 843030 Change-Id: Idf992fd81fa8647b13458ded9f47a83b8bc5a222 Reviewed-on: https://chromium-review.googlesource.com/1059099Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium c185e5a2. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17648 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=markdittmer No-Export: true Change-Id: I797f4b7b0cab5d35567f22fcdfa443e7299ae48f Reviewed-on: https://chromium-review.googlesource.com/1058915 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Joel Hockey authored
Add fileManagerPrivate.isCrostiniEnabled and fileManagerPrivate.mountCrostiniContainer. Add paper-progress polymer lib to test.html. Bug: 834103 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If90e8005100286229219a9771b488722b0f14275 Reviewed-on: https://chromium-review.googlesource.com/1059098Reviewed-by:
-
Boris Sazonov authored
A follow-up to https://crrev.com/c/1047870. This CL removes initPreference, onBindViewToPreference and onClickPreference helper methods from ManagedPreferenceDelegate interface, adding corresponding static methods to ManagedPreferencesUtils instead. It also moves null checks into these methods, making ManagedPreferenceDelegate param @Nullable. Bug: None Change-Id: I53e3669962c21e68a00b83dcde38b229d0b44364 Reviewed-on: https://chromium-review.googlesource.com/1057472Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#558657}
-
https://webrtc.googlesource.com/src.git/+log/739351d4760f..8a150d9c2134 $ git log 739351d47..8a150d9c2 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I743dfb844b5bcb91958897af64d58704f36d8d80 Reviewed-on: https://chromium-review.googlesource.com/1059012Reviewed-by:
-
Guido Urdaneta authored
With this patch, the network state of elements playing inactive streams is NETWORK_IDLE and the state of elements playing active streams is NETWORK_LOADING. Before this CL, the network state was always NETWORK_LOADING, which prevented media elements from being garbage collected, which was a source of JavaScript memory leaks and made it easy to reach limits in the number of active low-level audio streams. Drive-by: Fix the case of addition of stopped tracks to a stream. Bug: 771550 Change-Id: Id0d8e27fc30c9850e5ad43d7a3887c03a9415a18 Reviewed-on: https://chromium-review.googlesource.com/1057808 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#558655}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ia6931b2d1840af16c0752c7af744b9b94c5777d2 Reviewed-on: https://chromium-review.googlesource.com/1059013 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558654}
-
Noel Gordon authored
std::tuple<> is not a good passenger to have on the great browser test renaming ship. Throw it overboard, and replace with TestCase: a struct to cargo all our test options into the future. Current options are the GuestMode and |test_name| so no change in test behavior here. Bug: 843030 Change-Id: I85636ae502aa1b46f434884eeafaa0b2c2dcadd2 Reviewed-on: https://chromium-review.googlesource.com/1057747Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#558653}
-
Hayato Ito authored
We don't need to have virtual/incremental-shadow-dom test suites because IncrementalShadowDOM became experimental (or stable, which would be done later). Bug: 776656 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I80a10d95aa5ba0135305ca8245efd1625dc9b729 Reviewed-on: https://chromium-review.googlesource.com/1059091Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#558652}
-
Chris Pickel authored
This reverts commit b54641a0. Reason for revert: Findit has detected a flake at test All/PasswordManagerBrowserTestWithViewsFeature.NoFormElementTest/1. Culprit (70.0% confidence): https://chromium-review.googlesource.com/q/I4dd593c829c25e8f45ad816f6a3ddd3b941d76af Regression range: None Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyxAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKNAWNocm9taXVtLndpbi9XaW4gNyBUZXN0cyB4NjQgKDEpLzM4NDY3L2Jyb3dzZXJfdGVzdHMvUVd4c0wxQmhjM04zYjNKa1RXRnVZV2RsY2tKeWIzZHpaWEpVWlhOMFYybDBhRlpwWlhkelJtVmhkSFZ5WlM1T2IwWnZjbTFGYkdWdFpXNTBWR1Z6ZEM4eAwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Original change's description: > Change some password browser tests to produce user input. > > This is a preparation CL for removing some code from PasswordAutofillAgent. Most of the tests in the file do not test the real behavior. We fill the username/password using JavaScript and it's a different code path from typing them manually. > The tests changed here are necessary to update. Let's land them first and observe if it introduces some flakiness before proceeding. > > Bug: 842643 > Change-Id: I4dd593c829c25e8f45ad816f6a3ddd3b941d76af > Reviewed-on: https://chromium-review.googlesource.com/1054675 > Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Dominic Battré <battre@chromium.org> > Cr-Commit-Position: refs/heads/master@{#558296} TBR=battre@chromium.org,vasilii@chromium.org Change-Id: I3f54c76a4e3bb797f894750b16e1cdd6970e0d2b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 842643 Reviewed-on: https://chromium-review.googlesource.com/1059168Reviewed-by:
-
Marton Hunyady authored
kErrorCodeNoUpdate introduced in http://crrev.com/c/1055857 kRollbackNotPossible introduced in http://crrev.com/c/1047610 BUG=840432 Change-Id: Id6a7697b6db70a01503e10196997c800a3522a5a Reviewed-on: https://chromium-review.googlesource.com/1047866Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Marton Hunyady <hunyadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#558650}
-
Ricky Liang authored
The original CL broke the component build due to a typo in the export macro. It should have been CAPTURE_EXPORT instead of MEDIA_EXPORT in camera_3a_controller.h, and the functions in camera_metadata_utils.h should be exported as well. Original change's description -------------------------------------------------- media: implement TakePhoto in Chrome OS camera HAL VideoCaptureDevice This CL implements the TakePhoto() API for the Chrome OS camera HAL VideoCaptureDevice, including the following features: - Full size still capture - Auto-focus, auto-exposure, and auto-white-balancing stabilization BUG=chromium:832772 TEST=Run capture_unittests on DUT TEST=Make sure TakePhoto() API works on https://googlechrome.github.io/samples/image-capture/grab-frame-take-photo.html TBR=wuchengli@chromium.org,emircan@chromium.org Change-Id: Ia44506b30315df2aaff9047ff725fff95d3ba118 Reviewed-on: https://chromium-review.googlesource.com/1058881 Commit-Queue: Ricky Liang <jcliang@chromium.org> Reviewed-by:
Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#558649}
-
Hans Wennborg authored
Apparently lambdas are non-literal types before C++17, and Clang errors about this after r332286. TBR=thakis Bug: 843046 Change-Id: I9ec058e9e4e74e418d36d1875f7e51bf0d1165c1 Reviewed-on: https://chromium-review.googlesource.com/1059111Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#558648}
-
