- 20 Apr, 2018 40 commits
-
-
Miguel Casas authored
This reverts commit 3c753781. Reason for revert: Observed content tearing e.g. on video, see https://crbug.com/835362 Original change's description: > Perform glFlush only on NVIDIA platforms > > EGL_EXT_image_flush_external is broken on NVIDIA and causes image > corruption. > > corruption. > > Bug: 833975 > Test: Ran on nyan_big, samus and veyron_jerry and verified there is no > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I218bb111470e7db18906834f43fd1ad92f28b4bc > Reviewed-on: https://chromium-review.googlesource.com/1017236 > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> > Cr-Commit-Position: refs/heads/master@{#552121} TBR=reveman@chromium.org,kbr@chromium.org,dnicoara@chromium.org,dcastagna@chromium.org,hoegsberg@chromium.org Change-Id: Id81eaa6c2ff74e5ab5f7935d5a0fcf470e5317f8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 833975 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1021973Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#552389}
-
James Hawkins authored
The log occurs each time devices are (re-)loaded. R=asvitkine@chromium.org, khorimoto@chromium.org Bug: 831371 Test: none Change-Id: I03030039b720980667b6edcdd7cf7b2b4b55b0f2 Reviewed-on: https://chromium-review.googlesource.com/1020464 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#552388}
-
Nico Weber authored
This should've been part of https://chromium-review.googlesource.com/c/chromium/src/+/1020010 Bug: 835319 Change-Id: Ibad6a9b3f686ed8305ffc77c866917124fef9ba5 Reviewed-on: https://chromium-review.googlesource.com/1021597Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#552387}
-
bsheedy authored
Adds support for clicking on fallback UI in VR such as JavaScript dialogs or permission prompts in VR instrumentation tests. Also adds several new tests to excercise this functionality. Since granting permissions on file:// URLs is not allowed (hits DCHECKS), also adds support for loading test files from a local server. Bug: 826841 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I897eb48a4f861df8cd4b27a4667b75e1f595c6cc Reviewed-on: https://chromium-review.googlesource.com/1015235 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#552386}
-
Kent Tamura authored
NOTRY=true Bug: 829697 Change-Id: I8d002bb1f346ad3743d396a78f6e12a1b9b76885 Reviewed-on: https://chromium-review.googlesource.com/1018920 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#552385}
-
Vadym Doroshenko authored
Bug: 831123 Change-Id: I704c821bd615a69ae79bb5c35c6d9595c8cff79b Reviewed-on: https://chromium-review.googlesource.com/1021411 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#552384}
-
Kent Tamura authored
Bug: 829697 Change-Id: I2ea10cc5b7eaf89268eaec73e40773658e6d63f0 Reviewed-on: https://chromium-review.googlesource.com/1019121Reviewed-by:
-
Kent Tamura authored
The suffix part of the new name is 'tool' instead of 'patch' because this command doesn't handle patches so much. Bug: 829697 Change-Id: I90f34b6260032a7bbaf562d9b58ffc1a55c3922f Reviewed-on: https://chromium-review.googlesource.com/1018700 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Tim Zheng authored
This change flip the default value of device policy for managed devices only. When the device policy VirtualMachinesAllowed is not set for managed devices, the default is now False. Please note that this change doesn't modify the policy value for unmanaged devices. It's always True. BUG=chromium:800120 TEST=Manual test with YAPS tool. Change-Id: Iddcfc4ad818db5be076b05c23d0f51f960fef059 Reviewed-on: https://chromium-review.googlesource.com/1017308Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Tim Zheng <timzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#552381}
-
bsheedy authored
Adds the --bisect-repo option to the VR bisect script. This disables the automatic syncing and causes the script to bisect in the specified repo instead of Chromium src. This is meant to be used if an initial bisect points to a DEPS roll (e.g. V8 or Skia auto-rolls) and the exact CL within that repo needs to be determined. Also drive-by removes the branch creation before starting the bisect. The bisect is already run in a detached head state, so all it was doing was clogging up peoples' git instances with junk branches. Change-Id: Ie66fa4b966f3d59387bd39ba1ef0dda26f9fe9e8 Reviewed-on: https://chromium-review.googlesource.com/1019972 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#552380}
-
Becky Zhou authored
Test whether the switch preference reflects the corrent enabled and checked state. Bug: 831788 Change-Id: I03e6287f8a005f5e7b4e409815012c266a6c3889 Reviewed-on: https://chromium-review.googlesource.com/1018163 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#552379}
-
Qiyu Hu authored
Also pass CtsVerifier test on fitler scan Test: ./out/Default/components_unittests --gtest_filter="BluetoothStructTraitsTest.*" Bug: b:73743210 Change-Id: If1568f54152044f80bd970d4f28cfaef124e0679 Reviewed-on: https://chromium-review.googlesource.com/1020661Reviewed-by:Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Qiyu Hu <qiyuh@google.com> Cr-Commit-Position: refs/heads/master@{#552378}
-
Kevin Bailey authored
We've all but decided to use the tab switch button, so only support enabling tab switches or not. This CL only removes references to that particular setting/value, not the setting itself. Bug: 780835 Change-Id: I4d50cb998b71c95dcef8f9cf18d814501836010a Reviewed-on: https://chromium-review.googlesource.com/1020401Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#552377}
-
Moe Ahmadi authored
autofill_agent.mm does not need to fetch forms on form activity of type focus, input, change, for the purpose of getting server predictions. webState::didRegisterFormActivity: is implemented in FormInputAccessoryViewController. On form activity (incl. before page load) autofill_agent is queried for suggestions, thereofore it ends up fetching the relevant forms and informing the autofill_manager to get server predictions. This change eliminates the duplicate fetching of the forms. It also avoids fetching the forms for input, form_changed events until after the page load; And checks to see if the form activity is of type 'input' before fetching the relevant form, not after. This change results in a performance gain based on Speedometer2 benchmark: after: 34.65 +/- 0.57 before: 33.66 +/- 0.29 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5747780a90fff1385bcade71705d4d16551e15fa Reviewed-on: https://chromium-review.googlesource.com/1012979 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#552376}
-
Filip Gruszczynski authored
Bug: internal b/73122541 Change-Id: Ia1de4b0de7179f4274a33f7fbbb3c9c7e0cfa031 Reviewed-on: https://chromium-review.googlesource.com/1017919 Commit-Queue: Filip Gruszczynski <gruszczy@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#552375}
-
Weiyong Yao authored
When desktop capturer, screen/window, has permantent error, the corresponding media track will end internally. Lacking of such statistics causes many trouble to track related issues recently. This cl is to add those stats. Bug: 831756 Change-Id: I86377be4919bbbc2eca5388a4e12a1749d4dc943 Reviewed-on: https://chromium-review.googlesource.com/1014365Reviewed-by:
Zijie He <zijiehe@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Weiyong Yao <braveyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#552374}
-
Samuel Huang authored
Some architectures (e.g., ARM) have references that mix operation bits with payload bits. ReferenceBytesMixer is a class to isloate operation bit changes to Layer 1 patching. This CL introduces only the stub for ReferenceBytesMixer (the remainder would require ARM support). Having this now brings Zucchini-gen closer to trunk code, and sets up upcoming work for a mock disassembler. Change-Id: I2e1aa56bf265e4b61b33d323be2ed9a456e14f3b Reviewed-on: https://chromium-review.googlesource.com/1021650 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#552373}
-
Jamie Madill authored
This test is too flaky to be marked flaky, it should be marked as fail to avoid failing tests. Bug: 832238 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I57f1e398d86eace64c731a578edc75d30a6eae01 Tbr: kbr@chromium.org No-Try: True Reviewed-on: https://chromium-review.googlesource.com/1022171Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#552372}
-
Elly Fong-Jones authored
This DCHECK is testing for a real problem, but in a way that breaks a lot of test cases. The problem does need to be addressed (see the linked bug) but this DCHECK is not the right approach. Bug: 834926,667602 Change-Id: I3735030562eecca32a9d48135285eb645e49e89b Reviewed-on: https://chromium-review.googlesource.com/1021836Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#552371}
-
Shimi Zhang authored
Self-nominate myself to Android printing OWNERS. dgn@ left the team recently, so removing dgn@ :( Bug: None Change-Id: I5973d62e0d78291c33fbba737542c18dc477f10a Reviewed-on: https://chromium-review.googlesource.com/1020667Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#552370}
-
Kent Tamura authored
* bisect-test-ordering -> bisect_web_test_ordering * debug-renderer -> debug_renderer * debug-webkit-tests -> debug_web_tests * print-stale-test-expectations-entries -> print_stale_test_expectations_entries.py * print-json-test-results -> print_web_test_json_results.py * print-test-ordering -> print_web_test_ordering.py * print-layout-test-times -> print_web_test_times.py * print-layout-test-types -> print_web_test_types.py * read-checksum-from-png -> read_checksum_from_png.py * run-blink-httpd -> run_blink_httpd.py * run-blink-websocketserver -> run_blink_websocketserver.py * run-blink-wptserve -> run_blink_wptserve.py * try-flag -> try_flag.py * update-flaky-expectations -> update_flaky_expectations.py Note that we decided to rename LayoutTests to web_tests. https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/KKNbuzj-3HY/H8FWgtKrBgAJ Bug: 829697 Change-Id: Ia3dd95f6b42e337deb79deb3e4524aded378d78f Reviewed-on: https://chromium-review.googlesource.com/1018702Reviewed-by: -
https://chromium.googlesource.com/catapult.git/+log/9e4fce06f3a2..19f413e51156 $ git log 9e4fce06f..19f413e51 --date=short --no-merges --format='%ad %ae %s' 2018-04-20 rmistry Changes necessary to support a browserless shared story Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I33b14b966232b1c777cc170406fff9ca62c2fc8b Reviewed-on: https://chromium-review.googlesource.com/1021999 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#552368}
-
danakj authored
Add an instance of SharedBitmapManager for the display compositor on TestLayerTreeFrameSink. Remove all plumbing into cc for the SharedBitmapManager. R=piman@chromium.org TBR=pdr@chromium.org, sky@chromium.org Bug: 730660 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iafdb85431051d51d70960390201c7d9d0a0a9c93 Reviewed-on: https://chromium-review.googlesource.com/1020369 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#552367}
-
Dave Schuyler authored
This CL changes - AnswerImageObserver to RichSuggestionImageObserver - SetAnswerImage to SetRichSuggestionImage - answer_bitmap to rich_suggestion_bitmap - SetAnswerBitmap to SetRichSuggestionBitmap This is for the request made at https://chromium-review.googlesource.com/c/chromium/src/+/1016127/1/chrome/browser/ui/omnibox/chrome_omnibox_client.cc#82 There are no logic changes in this CL. Bug: None Change-Id: Ib530665c16b1ab3a34ff347aaaf0a6634f37aa67 Reviewed-on: https://chromium-review.googlesource.com/1018521Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Justin DeWitt authored
Previously the MHTML parser would use ParseDate which has bugs for several values of the date string. This issue is fixed by using WTF::Time::FromString instead. Fuzzer group link: https://clusterfuzz.com/v2/testcases?q=group%3A6154265509494784 Note that this does not fix the underlying issue in ParseDate. Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Bug: 831864,834629 Change-Id: Ib0f8210e42667bb031dd13b0c6c86204bab08822 Reviewed-on: https://chromium-review.googlesource.com/1020362 Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#552365}
-
Brian White authored
There is a disproportional number of SIGBUS errors (92%) with Linux kernel 4.4.0. Stop using file-backed memory for persistent histograms on these systems. Using local memory will still provide proper persistence for Renderer processes. A typical OS version string would be something like "4.9.0-6-amd64". Bug: 753741 Change-Id: I8dfa1d0a558c4b255fba14b3981f96203ac60684 Reviewed-on: https://chromium-review.googlesource.com/1020100 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#552364}
-
Michael Wasserman authored
This reverts commit cdb8b201. Reason for revert: Black window on startup http://crbug.com/832538 Original change's description: > windows/linux: make compositor hidden when minimized > > ShowWindowWithState() for windows and linux always calls > SetVisible(true), even when minimized. This makes the compositor > hidden when minimized. > > BUG=none > TEST=none > > Change-Id: Id8a48ab0096797904d894f6138cd9458afe60e61 > Reviewed-on: https://chromium-review.googlesource.com/996249 > Commit-Queue: Scott Violet <sky@chromium.org> > Reviewed-by: Michael Wasserman <msw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#548851} TBR=sky@chromium.org,msw@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: none Change-Id: I8be0a1fc287e9e4aae6344901e93641091f1a5ad Reviewed-on: https://chromium-review.googlesource.com/1022013Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#552363}
-
Justin Cohen authored
Reason for revert: xcode's clang now supports const default initialization. Original issue's description: > Explicitly call SequenceToken's default constructor. > > This CL is to workaround a clang bug occurring when building > sequence_token_unittest.cc for Chrome iOS. > > BUG=632330 > > Committed: https://crrev.com/0240044e435a3708d3f082771943a498a4cf3592 > Cr-Commit-Position: refs/heads/master@{#408515} BUG: 632330 Change-Id: Ic4fafd8d9ee302056682091bfab2c929aa30072f Reviewed-on: https://chromium-review.googlesource.com/1021593 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
Chris Mumford authored
leveldb::InMemoryEnv is not exposed with no official support for calculating memory usage. However, this is a pretty decent estimate and will be helpful for tracking in-memory Env RAM use. Bug: 750803 Change-Id: I4e07327bf4480bdb786290c82d8f66412868f36a Reviewed-on: https://chromium-review.googlesource.com/601207Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#552361}
-
Christian Fremerey authored
An enum VideoPixelStorage was previously used for two purposes: 1. Allow clients to specify when opening a video capture device if they want frames to be delivered via SharedMemory buffers or GpuMemoryBuffers 2. When instances of media::VideoFrame are delivered, indicate which type of buffer it is using. Support for frame transport via GpuMemoryBuffers has since been removed. The enum was kept around since it was anticipated that we support for buffers other than SharedMemory would be added again soon. Even though we are now about to add support for textures (via MailboxHolder) as buffer type, the VideoPixelStorage is not going to be useful for both of the above purposes. It is not useful for purpose 1, because we do not currently have a need to implement virtual devices for which clients can choose the transport buffer type. If the need arises in the future, we can add it then. It is not useful for purpose 2, since the API design is now such that buffers are identified by buffer ids, and from the buffer id, the type of buffer is already clear. With the possibility of devices delivering frames using MailboxHolder, it is now quite confusing to keep the VideoPixelStorage enum with a single option “CPU” around, so it is best to remove it at this time. Design Doc: https://docs.google.com/document/d/1Vt8ME9foAR7vs9azwTP0mAQYUxAEbA1SOQ7hzrcXxP8/edit?usp=sharing Bug: 834478 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Idbd1d966ea2fc50aae9b512ca7b9383eb28e33ed Reviewed-on: https://chromium-review.googlesource.com/1017916Reviewed-by:Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
-
Antoine Labour authored
It's not used any more. Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib9dac18f827dbcb3d2cac3fe9f3ebdaa84851d4d Reviewed-on: https://chromium-review.googlesource.com/1020410 Commit-Queue: Antoine Labour <piman@chromium.org> Reviewed-by:
-
James Wallace-Lee authored
Deflake LayerTreeHostTestEarlyDamageCheckStops by calling PostSetNeedsCommitToMainThread in each frame. The failed on tsan builds because PostSetneedsCommitToMainThread was only called after a frame invalidated, and so the test would time out halfway through when an invalidate was skipped and no new BeginFrame occurred. Bug: 817973 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia6469126b05da939eaa58b5fbc73558ebf686786 Reviewed-on: https://chromium-review.googlesource.com/1020363Reviewed-by:
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8b2b38b482ee..b915daddaea1 $ git log 8b2b38b48..b915dadda --date=short --no-merges --format='%ad %ae %s' 2018-04-20 achuith cros_chrome_sdk: Comment for _GetFullVersionFromStorage. Created with: roll-dep src/third_party/chromite BUG=chromium:832406 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I892fe6bb766d6f040bb1ec50f2f66f9b3b604394 Reviewed-on: https://chromium-review.googlesource.com/1021991Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#552357}
-
Benjamin Pastene authored
This adds support for test sharding and json results. See https://ci.chromium.org/buildbot/tryserver.chromium.chromiumos/chromeos-amd64-generic-rel/103454 for this patch in action. Bug: 832374 Change-Id: I1a1bea2412e25af9d5ba7a8daf0b6cb34e7b6ae4 Reviewed-on: https://chromium-review.googlesource.com/1020535Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium a4bdf3ba. With Chromium commits locally applied on WPT: 303956b6 "Enable WPT tests for the Generic Sensor classes" afb472c0 "Try to fix crash when terminating a worker while it is XHR-ing to a blob." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15914 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch TBR=ajuma No-Export: true Change-Id: I89ceabb6280507ada7ecdb31193e2d573fb592ed Reviewed-on: https://chromium-review.googlesource.com/1021833 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#552355}
-
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3e6ddaf232b2..35c78637d354 $ git log 3e6ddaf23..35c78637d --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src-internal BUG=chromium:0 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia36ed2292226d76f27bb39be0e611d52979f7120 Reviewed-on: https://chromium-review.googlesource.com/1021656 Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#552354}
-
Nico Weber authored
gn: Don't write invalid output when pool //:console exists; treat all other pools named 'console' as invalid. Before, defining and referencing pool "//:console" would make gn write a ninja file that tries to redeclare ninja's built-in console pool, causing ninja to reject the generated manifest file. Don't write pools definitions that cause this. This means //:console now represents ninja's built-in console pool. Disallow pools in other scopes or in the non-default toolchain to be called "console". If this was allowed but these pools behaved like regular pools instead of like the console pool, that'd be confusing. If they'd all behave like the console pool, that would be inconsistent with how regular pools work in gn -- the pool depth there is per-toolchain, while it'd always be globally 1 shared among all console pools in all toolchains. While here, also improve the source location for the "pool depths must not be negative" diagnostic. Bug: 835319 Change-Id: Idbec9c08f42a0de7b316d8e5e8819c6c8c3c3c45 Reviewed-on: https://chromium-review.googlesource.com/1020010 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
wutao authored
This patch addes Settings to shelf. Changes: 1. Add class InternalAppIconLoader. 2. Add class InternalAppWindowShelfController. 3. Extract common AppWindowBase for ARC++, Crostini, and internal apps. 4. Remove class CrostiniAppWindowShelfItemController. Bug: 824437 Test: Coverred by new test ChromeLauncherControllerTest.PinUnpinInternalApp Change-Id: I7ed59f572f6e8563f5ffe8a91ba08f2dc15a0056 Reviewed-on: https://chromium-review.googlesource.com/1013219 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#552352}
-
Xi Cheng authored
Change-Id: Ie198a7573769008366ffd70b62af1089c38102c9 Reviewed-on: https://chromium-review.googlesource.com/1020412Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#552351}
-
Kouhei Ueno authored
This CL removes an unused method. We originally planned to use the method to parse SignedExchanges, but they no longer require this. Bug: 803774, 811717 Change-Id: I5bd3f89891f046e4b6b1f128a63584cd78918266 Reviewed-on: https://chromium-review.googlesource.com/1017420Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#552350}
-
