- 04 May, 2018 40 commits
-
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I209953453e1e0e64eb253f1d673c9c6f96c0f493 Reviewed-on: https://chromium-review.googlesource.com/1044268 Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556064}
-
Sahel Sharify authored
When a GFC arrives, the fling controller doesn't cancel the active fling immediately. If the user starts a new scroll sequence while the fling cancellation is deferred, the controller suppresses the GSB/GSU events till either a new GFS arrives and the current fling gets boosted, or the controller decides that it is gonna cancel the fling and resume the new scroll sequence. To resume the new scroll sequence the controller sends a GSB since the original GSB of the sequence is suppressed. This cl changes the GSB event to have the timestamp of the last suppressed event instead of using the current time. This change is necessary to make sure that the monotonic time of a scroll sequence is not violated. Bug: 839051 Change-Id: I295de64deaad4b072ec69a1bbbc192f182577cf4 Reviewed-on: https://chromium-review.googlesource.com/1043017Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#556063}
-
Robert Ma authored
These tests already declare to be slow (long timeout), but due to a bug we previously didn't parse the manifest correctly so we missed them. https://crrev.com/c/1043160 fixed the issue so we can now remove these expectations. TBR=tkent Bug: 803943, 818324, 803558, 831975 Change-Id: I8f978d025e026b77dd6f42ade6de8e283886c024 Reviewed-on: https://chromium-review.googlesource.com/1044293Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#556062}
-
Gaofeng Huang authored
Bug: internal b/77653377 Test: on device Change-Id: If07a4b9af7a97779c08817fbdd4ba7b9740cdd15 Reviewed-on: https://chromium-review.googlesource.com/1043390Reviewed-by:
Stephen Lanham <slan@chromium.org> Commit-Queue: Gaofeng Huang <gfhuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#556061}
-
Paul Jensen authored
NetworkChangeNotifier::DNSObserver::OnInitialDNSConfigRead() may not be called if the initial DNS config has been read prior to the DNSObserver being registered. HostResolverImpl accounts for this already, but the test did not. I've updated the test and added an API comment to explain this. Bug: 833659 Change-Id: I0c7eeb296a990fb69c9f0fac58483243079c3481 Reviewed-on: https://chromium-review.googlesource.com/1035222Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#556060}
-
kylechar authored
This CL stops using layered windows on Windows 8 and higher. Layered window provide a way to add transparency effects on HWNDs. This is a legacy API and DWM natively supports transparency. DWM will always be there on Windows 8 and higher, so layered windows aren't needed. Layered windows present GPU sandbox problems with OOP-D. Layered windows also can't be partial updated, the entire window needs to be updated at once. Bug: 826633 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I6d0ab96392ee603b3b6ed680114f9e8a43c6134f Reviewed-on: https://chromium-review.googlesource.com/1024874 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#556059}
-
Mihai Sardarescu authored
This CL uses the "Get more from Chrome" welcome page always when Desktop Identity Consistency is enabled. Bug: 837403 Change-Id: Ief4228e57962557373c0e97c1a11f96b35bcbc62 Reviewed-on: https://chromium-review.googlesource.com/1042307Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#556058}
-
Mihai Sardarescu authored
This CL enables Dice M2 by default in Chromium that have API keys configured as those are mandatory for DICE. It also ensures that unit and browser tests have DICE M2 enabled, even for builds when the API keys are not configured. Bug: 829220 Change-Id: I752bf7e9e03da0ddd33841e42ec1c550fcaf91c7 Reviewed-on: https://chromium-review.googlesource.com/1044210 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#556057}
-
Matthew Jones authored
This reverts commit 4f02e64d. Reason for revert: Breaks Nougat Phone Tester: [FATAL:scoped_gpu_trace.cc(23)] Check failed: fence_->HasCompleted(). https://luci-logdog.appspot.com/v/?s=chromium%2Fandroid%2Fswarming%2Flogcats%2F3d3b6cf0bfd12611%2F%2B%2Flogcat_logcat_org.chromium.chrome.browser.vr_shell.VrShellTransitionTest.testStartActivityTriggersDoffChromeActivity_20180502T205516-UTC_HT73X0204522 Original change's description: > Add GPU time trace for VrShellGl browser rendering path > > > Bug: 837647 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I9c07ca3bfe5df595b9973b6ab0b18d3e629cd6eb > Reviewed-on: https://chromium-review.googlesource.com/1035208 > Commit-Queue: Biao She <bshe@chromium.org> > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Reviewed-by: Klaus Weidner <klausw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555430} TBR=bshe@chromium.org,piman@chromium.org,klausw@chromium.org,tiborg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 837647 Change-Id: I3abcf1dd51ea93b81c517ee6b982aa92a218346d Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1043225Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#556056}
-
jonross authored
On Linux Asan DownloadContentTest.CancelResumedDownload is flaky, this disables the test on that configuration. TBR=qinmin@chromium.org TEST=DownloadContentTest.CancelResumedDownload Bug: 836689 Change-Id: Idc8bba6213e15c1726bbac842d1bf4ed2e01b225 Reviewed-on: https://chromium-review.googlesource.com/1044309Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#556055}
-
Fan Yang authored
Flip flags. https://chromium-review.googlesource.com/c/chromium/src/+/1042357 Put HasRetransmittableData last in if checks in QuicSentPacketManager because it will become fairly costly when session_decides_what_to_write is true. Merge internal change: 194716021 https://chromium-review.googlesource.com/c/chromium/src/+/1042209 In QUIC, add received_ack_ranges_for_debugging_ to debug the packets being acked multiple times issue. Merge internal change: 194562236 https://chromium-review.googlesource.com/c/chromium/src/+/1042208 Fix a bug where a connectivity probing packet is not recognized as so when it is reordered. Protected by existing flag FLAGS_quic_reloadable_flag_quic_enable_server_proxy2. Merge internal change: 194280190 https://chromium-review.googlesource.com/c/chromium/src/+/1040594/1 Add framer/deframer code for IETF QUIC New Connection ID Frames Merge internal change: 194271751 https://chromium-review.googlesource.com/c/chromium/src/+/1040473/1 Change name of some IETF-QUIC packet framer/deframer methods Merge internal change: 194265540 https://chromium-review.googlesource.com/c/chromium/src/+/1040591 Add IETF error code to the RESET_STREAM frame Merge internal change: 194231167 https://chromium-review.googlesource.com/c/chromium/src/+/1040585/1 Pull apart QuicFramer's IETF Application- and Connection- close methods. Merge internal change: 194069265 https://chromium-review.googlesource.com/c/chromium/src/+/1040466/1 Deprecate FLAGS_quic_reloadable_flag_quic_respect_http2_settings_frame. Merge internal change: 193975549 https://chromium-review.googlesource.com/c/chromium/src/+/1040545/1 Deprecate FLAGS_quic_reloadable_flag_quic_remove_redundant_ping. Merge internal change: 193964291 https://chromium-review.googlesource.com/c/chromium/src/+/1040209/1 Set stream_id to 0 for IETF BLOCKED frames, fix some error message typos. Merge internal change: 193962014 https://chromium-review.googlesource.com/c/chromium/src/+/1040208/1 In QUIC, declare in flight packets lost via early retransmit, even if the packet has no retransmittable frames. Protected by FLAGS_quic_reloadable_flag_quic_early_retransmit_detects_in_flight_packet_lost. Merge internal change: 193959628 https://chromium-review.googlesource.com/c/chromium/src/+/1040428/1 Remove flag count of FLAGS_quic_reloadable_flag_quic_fast_is_disjoint. Merge internal change: 193956066 https://chromium-review.googlesource.com/c/chromium/src/+/1040426/1 Add IETF QUIC STOP_SENDING frame to the QuicFrame. Merge internal change: 193953297 https://chromium-review.googlesource.com/c/chromium/src/+/1040408/1 Pull IETF QUIC Path Challenge frame into QuicFrame. Merge internal change: 193948876 https://chromium-review.googlesource.com/c/chromium/src/+/1040407/1 Remove flag count of FLAGS_quic_reloadable_flag_quic_fast_path_on_stream_data. Merge internal change: 193945925 https://chromium-review.googlesource.com/c/chromium/src/+/1040406/1 Bring IETF Path Response frame into QuicFrame. Merge internal change: 193944997 https://chromium-review.googlesource.com/c/chromium/src/+/1040405/1 R=rch@chromium.org Change-Id: Id5cfdbee80b51475fdd3182f17867012c3ca08fb Reviewed-on: https://chromium-review.googlesource.com/1042218 Commit-Queue: Fan Yang <fayang@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#556054}
-
Emily Hanley authored
NOTRY=true TBR=ashleymarie@chromium.org Bug: 817872 Change-Id: Ib6b85a069c46e0e1a1f2c03a08dbea95d2ed1d41 Reviewed-on: https://chromium-review.googlesource.com/1044294Reviewed-by:
Emily Hanley <eyaich@chromium.org> Commit-Queue: Emily Hanley <eyaich@chromium.org> Cr-Commit-Position: refs/heads/master@{#556053}
-
Friedrich Horschig authored
This CL adds the wiring that finally renders actions as clickable views into the keyboard accessory. Bug: 828832 Change-Id: I9aa72cda71843b1d96a8f9fd99969065600954e4 Reviewed-on: https://chromium-review.googlesource.com/1015420 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#556052}
-
Philip Jägenstedt authored
https://chromium.googlesource.com/chromium/deps/flac.git/+log/7d0f5b3a173f..af862024c8c8 $ git log 7d0f5b3a1..af862024c --date=short --no-merges --format='%ad %ae %s' 2017-07-26 agable Upload flac reviews to Gerrit by default Created with: roll-dep src/third_party/flac Change-Id: I0c610ae7e6ed4686cbedee9cd141c07c0ed9670c Reviewed-on: https://chromium-review.googlesource.com/1044192Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#556051}
-
https://webrtc.googlesource.com/src.git/+log/a1f566b28a69..9d96e923169d $ git log a1f566b28..9d96e9231 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:None,chromium:None,chromium:839379,chromium:836790,chromium:839351,chromium:637666,chromium:None,chromium:None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Idaf4dcb114cbe96a981c6eba39aab8a3be42c19b Reviewed-on: https://chromium-review.googlesource.com/1044265 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556050}
-
Abhishek Arya authored
R=mmoroz@chromium.org Bug: 836663 Change-Id: I55c7a7b6d5df87bec04b32b369969787321941e4 Reviewed-on: https://chromium-review.googlesource.com/1044308 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#556049}
-
jonross authored
Currently on chromium.win/Win10 Tests x64 (dbg) the viz_content_browsertests are timing out a lot. Affecting CQ. This disables them on that bot until we can debug them ourselves. TBR=dpranke@chromium.org TEST=viz_content_browsertests Bug: 839824 Change-Id: Ifbba13cc4ffb28baa70825aa0fff9b398ce79f7d Reviewed-on: https://chromium-review.googlesource.com/1044226Reviewed-by:
-
https://chromium.googlesource.com/catapult.git/+log/4f42243e85c8..f0ae6bb58a45 $ git log 4f42243e8..f0ae6bb58 --date=short --no-merges --format='%ad %ae %s' 2018-05-04 nednguyen Define simple_perf attribute in BrowserFinderOptions directly Created with: roll-dep src/third_party/catapult BUG=chromium:839645 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Iad036eef3380833c35c375601aec69225c3189e5 Reviewed-on: https://chromium-review.googlesource.com/1044225Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556047}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8672346ad7ce..abd74feb3dc4 $ git log 8672346ad..abd74feb3 --date=short --no-merges --format='%ad %ae %s' 2018-04-26 rrangel cros_gdb: Pass extra gdb args when running in remote mode 2018-04-27 yunlian cros_setup_toolchain: install compiler-rt for armv7a-cros-linux-gnueabihf Created with: roll-dep src/third_party/chromite BUG=chromium:none,chromium:833969 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I0d0418b6c529c1da25a7b186e2e98e411b9ae959 Reviewed-on: https://chromium-review.googlesource.com/1043659Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556046}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5226b777edee..76c01c930ca4 $ git log 5226b777e..76c01c930 --date=short --no-merges --format='%ad %ae %s' 2018-05-04 angle-skia-autoroll Roll third_party/externals/angle2/ 03bb2231a..d7b56642c (2 commits) 2018-05-03 anmittal Fix skia compilation error Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: Ia254f548f5e6af0f6d2085d6999ffea432794b01 Reviewed-on: https://chromium-review.googlesource.com/1044228Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556045}
-
John Abd-El-Malek authored
Bug: 838406 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I19a1e40a87bad542c99e3c0abe83559dff9a4199 Reviewed-on: https://chromium-review.googlesource.com/1042807Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#556044}
-
Robert Ma authored
When running WPT in web_tests, test names are more like URLs instead of file paths (to be precise, the part of a test name after external/wpt is a WPT URL), because WPT can generate multiple tests (variations) for a single test file (e.g. .any.js, ?run_type). Therefore, when asking questions like "is a test slow?", we need to find the manifest item for that test by URL instead of by file path; whereas if we want to know if a file in external/wpt is a test file, we find the manifest item(s) for that file by file path. This CL separates the two types of manifest queries, and chooses the correct one for each call site. Besides, unit tests are improved to cover the WPT variations (.any.js & ?run_type). Bug: 831975, 800570 Change-Id: I230d5ec7df06b7df1387da1b93788d6cae55d153 Reviewed-on: https://chromium-review.googlesource.com/1043160 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#556043}
-
jonross authored
Previously it was found that virtual/video-surface-layer/media/color-profile-video-seek-filter.html was flaky on Windows. It has now become flaky on Linux as well. This updates the test expectations for the test to include Linux. TEST=virtual/video-surface-layer/media/color-profile-video-seek-filter.html TBR=treib@chromium.org Bug: 839833 825733 Change-Id: I16cc78b71aa104f30252ea23a7cc276c52cbfa1c Reviewed-on: https://chromium-review.googlesource.com/1044286Reviewed-by:
-
Ned Nguyen authored
NOTRY=true TBR=eyaich@chromium.org Bug: 836446 Change-Id: Id47c16c1231fac76cf7f07bf8aa4f9bd7b5a1067 Reviewed-on: https://chromium-review.googlesource.com/1044307Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#556041}
-
gogerald authored
This CL also enables localhost on Desktop for debug. This is the counter part of the desktop CL, https://chromium-review.googlesource.com/c/chromium/src/+/1012451 Test: 1), go to 'https://rsolomakhin.github.io/pr/bob/' 2), click 'buy' button 3), choose 'personal bobpay' from 'https://gogerald.github.io' 4), click 'PAY' 5), login if necessary (any more than five characters name and passowrd). 6), click 'Navigate to http page' 7), the window should close, the payment request dialog is shown to allow users choose different payment method. Bug: 828431 Change-Id: I0bbe5e97d364f7cd172ae7cfc43962dd314398e2 Reviewed-on: https://chromium-review.googlesource.com/1031056Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#556040}
-
jonross authored
The test benchmarks/system_health_smoke_test/SystemHealthBenchmarkSmokeTest/system_health/memory_desktop/browse:news:reddit is flaky. While the cause is being investigated I am disabling it to help with the trybots TEST=benchmarks/system_health_smoke_test/SystemHealthBenchmarkSmokeTest/system_health/memory_desktop/browse:news:reddit TBR=perezju@chromium.org NOTRY=true # test are covered by PRESUBMIT Bug: 789041 Change-Id: I2dde56c0fb64f71821b94f2072463bf85ca745e0 Reviewed-on: https://chromium-review.googlesource.com/1044108Reviewed-by:
-
Steve Kobes authored
Bug: 823365 Change-Id: I29537cc8d749eb426a9ae5624789b95b34121b13 Reviewed-on: https://chromium-review.googlesource.com/1042802Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#556038}
-
Jinsuk Kim authored
Embedders have to do a bit convoluted initialization for SelectionPopupController (its action mode callback to be set requires a helper instance from the SPC itself). This CL makes it simpler by delegating the helper initialization to action mode callback constructor. |ceateContentViewCore| in Tab.java, For instance: From: SelectionPopupController controller = SelectionPopupController.fromWebContents(webContents); ChromeActionModeCallback actionModeCallback = new ChromeActionModeCallback(this, controller.getActionModeCallbackHelper()); controller.setActionModeCallback(actionModeCallback); SelectionPopupController.fromWebContents(webContents) setActionModeCallback(new ChromeActionModeCallback(this, webContents)); to: Change-Id: Ifec52ce2c1f9446f47de72295be1abc5e1c361d7 Reviewed-on: https://chromium-review.googlesource.com/1029757Reviewed-by:Ted Choc <tedchoc@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#556037}
-
Vadim Petrov authored
Part 1: Refactoring and improve background filters shaders. Bug: 613233 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I93c7ecf0933f6c7095bfc94d0d404097b6e1a384 Reviewed-on: https://chromium-review.googlesource.com/899350 Commit-Queue: Vadim Petrov <lof84@yandex-team.ru> Reviewed-by:
Stephen White <senorblanco@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#556036}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cfcbf96b..ac9b5ca0 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I8cd20e38126579cdda5f46189046d44c96815cda Reviewed-on: https://chromium-review.googlesource.com/1043692Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#556035}
-
Raphael Kubo da Costa authored
This fixes the build with libstdc++ after a4c19797 ("Shatter partition_alloc.h into smaller files"). In file included from ../../base/allocator/partition_allocator/partition_bucket.h:11:0, from ../../base/allocator/partition_allocator/partition_bucket.cc:5: ../../base/allocator/partition_allocator/partition_alloc_constants.h:140:53: error: ‘CHAR_BIT’ was not declared in this scope static const size_t kBitsPerSizeT = sizeof(void*) * CHAR_BIT; ^~~~~~~~ ../../base/allocator/partition_allocator/partition_alloc_constants.h:140:53: note: suggested alternative: ‘WCHAR_MIN’ static const size_t kBitsPerSizeT = sizeof(void*) * CHAR_BIT; ^~~~~~~~ WCHAR_MIN Bug: 819294 Change-Id: Ie61cd7a1b55adf77e1f584bd5447ac11b6980b02 Reviewed-on: https://chromium-review.googlesource.com/1043748Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#556034}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d8a189fca3cd..5226b777edee $ git log d8a189fca..5226b777e --date=short --no-merges --format='%ad %ae %s' 2018-05-03 ethannicholas fix for SPIR-V sk_in definition which was upsetting Intel NUC Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I5e41c49c321193f51399b7ce39cfb870102dc166 Reviewed-on: https://chromium-review.googlesource.com/1043662Reviewed-by:
-
Friedrich Horschig authored
This CL introduces the sheet that can replace the keyboard if triggered by the keyboard accessory. Beyond showing or hiding, it has no functionality yet. The next steps will introduce the layout for passwords as started in https://crrev.com/c/951588. The latter CL is deprecated with this CL. The minimalist root component only simplifies testing at this point. Bug: 811747 Change-Id: I2aaa2b5c3fbf782866301125f5a81307165efbfe Reviewed-on: https://chromium-review.googlesource.com/1030551 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
-
Karl Wiberg authored
It's about to become mandatory. Bug: webrtc:9062 Change-Id: I430f9af008bb1e41c435ac0bcb06fd45645d26b5 Reviewed-on: https://chromium-review.googlesource.com/1044104Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Karl Wiberg <kwiberg@chromium.org> Cr-Commit-Position: refs/heads/master@{#556031}
-
Rayan Kanso authored
I was getting build errors when using ImplementedAs on a dictionary and referencing it from another dictionary idl file. The file referencing the ImplementedAs dictionary wasn't using the ImplementedAs value. Bug: 839782 Change-Id: I3c3f91cecf9d6be0b33a7d990a32aabe2a48eefc Reviewed-on: https://chromium-review.googlesource.com/1042710 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#556030}
-
https://chromium.googlesource.com/angle/angle.git/+log/7a8fe15682f3..983460e6cd51 $ git log 7a8fe1568..983460e6c --date=short --no-merges --format='%ad %ae %s' 2018-05-02 oetuaho Rewrite repeated assignments to swizzled vectors on NVIDIA Created with: roll-dep src/third_party/angle BUG=chromium:798117 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I795f13f9b18a037065b9a1dcbe9419f3b99e2b06 Reviewed-on: https://chromium-review.googlesource.com/1043661Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556029}
-
Bence Béky authored
This is necessary to avoid creating a DefaultClientSocketFactory, which is a leaky singleton and therefore would hold a reference to ScopedTaskEnvironment's reference counted MockTimeTaskRunner forever, thus preventing the creating of another ScopedTaskEnvironment. This is prework for https://crrev.com/c/1037405. Bug: 791831 Change-Id: Iba9e17cc51d7002318f3a27d694b3d9230f36d4e Reviewed-on: https://chromium-review.googlesource.com/1037324Reviewed-by:
-
Marc Treib authored
This reverts commit 79b28587. Reason for revert: performance-return-real-time.js fails on MSAN: https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty%20MSAN/ Original change's description: > Using non-override time in InspectorPerformanceAgent.cpp. > > Right now the InspectorPerformanceAgent returns incorrect performance metrics > (such as LayoutDuration, ScriptDuration, etc.) if there is an time override in > place. The InspectorPerformanceAgent needs to return real time elapsed. > > Per offline discussion with Pavel(pfeldman@), the reason we don't expose the > non-override time API in the web platform (<blink>/platform/time.h) is that time > override is to abstract the web platform from the time. The web platform should > just deal with time and not know about whether the time is overridden. Exposing > the non-override time API in the very core part of blink will leak the override > aspect and hence compromising the whole design > > BUG: 830033 > Change-Id: If3140892ac60bc853ef5f98f7b478a98ae332806 > Reviewed-on: https://chromium-review.googlesource.com/988833 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Commit-Queue: Johnny Ding <jnd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556012} TBR=dgozman@chromium.org,jnd@chromium.org,haraken@chromium.org,pfeldman@chromium.org,jochen@chromium.org Change-Id: Ic6f8feb1c77147e8b18fad12a95b1761cd13c2a0 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1044145Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#556027}
-
Marc Treib authored
This reverts commit fd8a3a1f. Reason for revert: The depended-on CL has been relanded as https://crrev.com/c/1030451 Original change's description: > Revert "Sync: Use IdentityManager instead of SigninManager" > > This reverts commit aab57914. > > Reason for revert: Depends on crrev.com/c/1025898 which was reverted > > Original change's description: > > Sync: Use IdentityManager instead of SigninManager > > > > This CL migrates ProfileSyncService to IdentityManager for getting > > info on the primary account. This includes switching from > > SigninManagerBase::Observer to IdentityManager::Observer. > > The only remaining use of SigninManager within PSS it to call > > SignOut() which isn't exposed by IdentityManager yet. > > > > Bug: 825190 > > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > > Change-Id: Icf9398d63794cab03cb559adba5c767e18c31c0a > > Reviewed-on: https://chromium-review.googlesource.com/983914 > > Commit-Queue: Marc Treib <treib@chromium.org> > > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#553973} > > TBR=blundell@chromium.org,treib@chromium.org,mastiz@chromium.org > > Change-Id: Ib40dbff0f1c8e5fba95cb9881681361abec5aeec > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 825190, 837201 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Reviewed-on: https://chromium-review.googlesource.com/1030372 > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#553997} TBR=blundell@chromium.org,treib@chromium.org,mastiz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 825190, 837201 Change-Id: If6858f033ac8390acfc904379afbf9726a6301c2 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/1043885Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#556026}
-
Marc Treib authored
TBR=wangxianzhu@chromium.org Bug: 839734 Change-Id: Ic35abab341a46e52d2586f2f5515bf0701f96fec Reviewed-on: https://chromium-review.googlesource.com/1043985Reviewed-by:
-
