GitLab

Whoops. No test unfortunately since there's no good way to test
this other than hard coding the expected default values in the
test itself, which is generally not a good test.

BUG=779192
TEST=none
TBR=mlamouri

Change-Id: I00d26ef715fac4884017ce295639ee6aab37d777
Reviewed-on: https://chromium-review.googlesource.com/1138648Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575376}

Bug: 841643
Change-Id: I28d6ec0af4aa8ad77eeb9e140a3dac58097002ea
Reviewed-on: https://chromium-review.googlesource.com/1136064Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575375}

Simple cleanup and refactoring from abandoned crrev.com/c/1134423

Bug: None
Test: Child modal example works in ash_shell_with_content
Change-Id: I3d58eb3c5341e42bf6bda99a51d1caa977cf48f9
Reviewed-on: https://chromium-review.googlesource.com/1138412
Commit-Queue: Michael Wasserman <msw@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575374}

      +591,635 bytes normalized apk size
            +3 zip entries file count
       +25,004 bytes main lib size
      +386,116 bytes main dex size
      +205,519 bytes APK size
 +1,765,427.64 bytes Estimated installed size
InstallBreakdown (+1,764,154.64 bytes):
        +1,572 bytes Non-compiled Android resources size
       +25,004 bytes Native code size
          +183 bytes Package metadata size
 +1,722,871.64 bytes Java code size
       +14,524 bytes Compiled Android resources size
        +1,928 entries fields
        +2,655 entries methods
          +649 entries types
        +1,331 entries strings

Specifics: 
InstallSize: 
Dex: 
Change-Id: Ibe4ff1f2778fb1a885a304f57bfaeb289809894a
Reviewed-on: https://chromium-review.googlesource.com/1135944Reviewed-by: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575373}

The original CL for this (https://chromium-review.googlesource.com/1105569)
was reverted because of a null pointer bug. This CL does the same thing
as the reverted CL and fixes the null pointer exception by having
ToolbarManager#getMenuButton() return the bottom toolbar menu button when
the bottom toolbar is enabled.

Bug: 852117

Change-Id: Ic2668a3cac6a552bee4476d1cfb58f8e6c290bfd
Reviewed-on: https://chromium-review.googlesource.com/1135776Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575372}

Adding CHECKs to verify that we did not miss any cases when it's called
for browser-initiated navigation. Will cleanup after a couple of Canaries.

Bug: 789577

Change-Id: I36890e1cb653a7f1795a187be0d80f2a99e10aaf
Reviewed-on: https://chromium-review.googlesource.com/1135934
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575371}

VLOG() has a high overhead due to pattern matching. Calling it per-frame accounts for ~0.3% of all cycles spent in Chrome on ChromeOS devices.

Bug: 489441

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I5d6fc6d829601f6ad501e1676fd8114ab99d82c2
Reviewed-on: https://chromium-review.googlesource.com/1132422
Commit-Queue: Chong Jiang <chongjiang@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575370}

https://skia.googlesource.com/skia.git/+log/e7e3bb4d2006..b965fcb47296


git log e7e3bb4d2006..b965fcb47296 --date=short --no-merges --format='%ad %ae %s'
2018-07-16 benjaminwagner@google.com Re-add Android Vulkan tryjob to CQ.


Created with:
  gclient setdep -r src/third_party/skia@b965fcb47296

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=bungeman@chromium.org

Change-Id: I29ef3ca7d0ab11c88236e06f432787241cc0daeb
Reviewed-on: https://chromium-review.googlesource.com/1138375Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575369}

When a tab is being dragged, the current instance of TabDragController
calls FocusManager::SetFocusedView()  and passes the tab strip that is
the source of the drag. Since the tab strip is not focusable, the
focus is moved to the next focusable element. In MacViews (when
keyboard accessibility is not turned on), this is the omnibox,
resulting in the omnibox being focused during a drag.

Instead of calling SetFocusedView(), FocusManager::ClearFocus() should
be called. This way, whichever element is currently focused will lose
focus during a drag, as is desired. However, no new element will be
focused, so there is no chance that an undesired focus occurs. When the
drag finishes, TabDragController restores focus to the previously
focused element as it previously did.

On ClearFocus(), the window associated with the top root view gets
focus, so key events are still forwarded properly and hitting Esc
still cancels the drag in progress.

The interactive UI test was slightly modified to check that the window
of the attached tab strip has focus rather than the tab strip itself
to reflect the new behavior.

Bug: 835550
Change-Id: Iff846e24e31428737ae204dd9e68f2f57ee83bad
Reviewed-on: https://chromium-review.googlesource.com/1132133
Commit-Queue: Tessa Nijssen <tnijssen@google.com>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575368}

OverlayWindowViews handled KeyEvents as a workaround for a11y
navigation. Now that the buttons are tab navigable, this is no longer
needed.

OnKeyEvent() also causes some issues if the initially focused button
on the window is the close button, rather than play/pause. This is
determined by the built in view::Views keyboard navigation. Keeping
track of this separately in OverlayWindowViews makes no sense.

Change-Id: Ide8cca038452781790d2d80a9545f1a2a7b474e9
Reviewed-on: https://chromium-review.googlesource.com/1136228Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575367}

We are attempting to improve visiblity into why RejectedExecutionExceptions happen. This change includes any Runnable that appears more than 50 times into the exception message.

Bug: 843745
Change-Id: Ifa383cfc0be3b7c58298ff48399d120bd7ab45ba
Reviewed-on: https://chromium-review.googlesource.com/1133776Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575366}

Used this to display the overflow bubble more easily.

R=msw@chromium.org

Test: manual
Bug: 863822
Change-Id: Id7cb6147c5ce4b699ed5c3573ab23388cdb0b465
Reviewed-on: https://chromium-review.googlesource.com/1138404
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575365}

Bug: 853869
Change-Id: Ifa67aef8421b4169d8c34711df72293135ce7f8b
Reviewed-on: https://chromium-review.googlesource.com/1123764
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575364}

Currently when empty allow list is passed on as a parameter to
GetAssertion request, all requests to U2F devices are dropped. This is
in accordance with current version of the CTAP spec, as empty allow list
implies resident key credentials and U2F devices do not support resident
keys.

However, this behavior causes requests to U2F devices to be dropped
without U2F devices blinking, which causes user confusion. In order to
minimize user confusion, sent fake registration call to U2F devices for
GetAssertion request with empty allow list.

Bug: 860062
Change-Id: I8e62d01e46cd90f393035149254286b58a932e78
Reviewed-on: https://chromium-review.googlesource.com/1132456
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575363}

This CL adds a JNI bridge for DownloadMediaParser. Since Android
currently doesn't support browser test, a high level java test needs
this bridge. Also the UI code may call through this routine.

Bug: 826021
Change-Id: I58dfb770fc03bcc567b55a98eb0a8c51d0f02052
Reviewed-on: https://chromium-review.googlesource.com/1136523Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575362}

TouchIdContext implements the Touch ID authorization prompt. After
receiving the OS reply callback from the Security framework it forwards
the result to the user-supplied callback, but doesn't do so on the
original TaskRunner that it was invoked on. As a result, Touch ID
authenticator requests fail some sequence checker tests. This fixes that
by posting the user-supplied callback back on the original runner.

Bug: 678128
Change-Id: I0e7a8730ec898f288cd25323134aa95ef50ddbdf
Reviewed-on: https://chromium-review.googlesource.com/1136496
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575361}

content_browsertests takes almost 7 minutes to run and is currently on the
critical path of the bot since it's not swarmed, so this should reduce
the cycle time of cast_shell_linux by almost 7 minutes.

Bug: 843511,861843
Change-Id: I95dc87ca2b844b2bf0363b4a8b1915aeaed30938
Reviewed-on: https://chromium-review.googlesource.com/1129042
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575360}

- gin_unittests on "Linux - Future (dbg)"
- unit_tests on "Win10 Tests x64 (dbg)"
- telemetry_unittests on "Win10 Tests x64 (dbg)"

Bug: 843511
Change-Id: Iabd54c3330a25b14d0bf4773e4862bfa5d10aabb
Reviewed-on: https://chromium-review.googlesource.com/1138254
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575359}

These tweaks are based on feedback from UX.  See the linked bug
for details.

BUG=863043

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I159c77e16c567b5b670ca727425253fc8a393ebe
Reviewed-on: https://chromium-review.googlesource.com/1135289
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575358}

This patch supports NGLineBreaker to rewind unpositioned
floats.

When rewinding floats occurs, LayoutNG either position them
incorrectly, or hit DCHECK in paint due to duplicated ID.
This patch fixes it for unpositioned foats by matching to
Edge and Gecko.

Blink considers such floats as if it were committed
(positioned in LayoutNG terminologies) and thus the position
is incorrect.

Bug: 636993
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I884879b2034d2f63ae248f70de3edeb27d71cafe
Reviewed-on: https://chromium-review.googlesource.com/1136262
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575357}

This is a reland for 1133315. A global function was mistakenly moved lower, and was not visible to calls that happened before it.

Refactor BrowserDMTokenStorage for easier platform implementations.

This CL refactors BrowserDMTokenStorage & BrowserDMTokenStorageWin to move code that is common to all platforms.

After this CL, adding a new platform requires implementing the following methods:

-  virtual std::string InitClientId();
-  virtual std::string InitEnrollmentToken();
-  virtual std::string InitDMToken();
-  virtual void SaveDMToken(const std::string& token);

Note that this CL keeps the existing Windows implementation, it only refactors the code (no functional change).

BUG=812641

TBR: pastarmovj
Change-Id: I51d6b4efef6066d602a59c514e9db88e414e4337
Reviewed-on: https://chromium-review.googlesource.com/1138539Reviewed-by: Georges Khalil <georgesak@chromium.org>
Commit-Queue: Georges Khalil <georgesak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575356}

This should make no difference whatsoever in practice (in case of an
unrecoverable error, we won't try to start up again anyway), it just
makes things a bit simpler to reason about.

Bug: 839834
Change-Id: Ie3ac83b172f9fab100b1a176421025aa1f3699dc
Reviewed-on: https://chromium-review.googlesource.com/1138252
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575355}

Change-Id: I9d55f53735ab13fcc835673b9eef687d587128f1
Reviewed-on: https://chromium-review.googlesource.com/1137751
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Reviewed-by: Steven Valdez <svaldez@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575354}

Using wpt-import in Chromium d80b0273.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21462

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
mcasas@chromium.org:
  external/wpt/geolocation-API

TBR=raphael.kubo.da.costa@intel.com

No-Export: true
Change-Id: Ic10b935af281a05a087702df437dae12fd1731f3
Reviewed-on: https://chromium-review.googlesource.com/1138541
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575353}

Bug: 863945
Change-Id: I1708b8512bea5f86072030a8badb6d09ed261297
NoTry: True
Tbr: takumif@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1138694Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575352}

URLFetcher will stop working with advent of Network Service, and
SimpleURLLoader is the replacement API for most clients.

This also removes the no-longer needed URLRequestContext-based methods
in GCMRequestTestBase, and fixes the regression of CompleteFetch
overrides being bypassed in the previous RegistrationRequest port.

Bug: 844986, 844988

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Icdb2e768b274618ce5c6d1fceda6ae9b76c4c275
Reviewed-on: https://chromium-review.googlesource.com/1135291Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575351}

https://android.googlesource.com/platform/external/perfetto.git/+log/e79ac55dc0ea..4d831cea60c7


git log e79ac55dc0ea..4d831cea60c7 --date=short --no-merges --format='%ad %ae %s'
2018-07-16 primiano@google.com Add bug link to docs


Created with:
  gclient setdep -r src/third_party/perfetto@4d831cea60c7

The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: Iaf90cf9219667a865b9d61699f59372af667beef
Reviewed-on: https://chromium-review.googlesource.com/1138553
Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575350}

Picture-in-Picture window should be closed after navigating away while
same document navigations should not close Picture-in-Picture window.

Bug: 726619
Change-Id: Ibd07dfd2f62af23573ab2221138b4776df26f22c
Reviewed-on: https://chromium-review.googlesource.com/1137818
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575349}

A learn-more question mark is added to the syncSetup page.

Bug: 863138
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I3da65e76a7054c6c5256dc96f746c83968dc2e28
Reviewed-on: https://chromium-review.googlesource.com/1138247Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575348}

https://aomedia.googlesource.com/aom.git/+log/6eecfe927de9..000f2f686d60

$ git log 6eecfe927..000f2f686 --date=short --no-merges --format='%ad %ae %s'
2018-07-05 sanampudi.venkatarao Facilitate eob support in inverse transform for neon
2018-07-10 ddvfinite Add Masked sad avx2 code
2018-07-12 ddvfinite Add Wedge utils avx2 code
2018-06-12 kylesiefring x86: Add subpixel obmc variance
2018-07-12 binpengsmail Change allowed_tx_mask to bit mask
2018-07-13 anorkin film grain: set luma grain to 0 when num_y_point is zero
2018-07-12 yunqingwang ext_tile: allocate tile list buffer in example
2018-07-06 deepa.kg Implement row based multi-threading of decoding stage
2018-07-11 yunqingwang ext_tile: add image format support in example

Created with:
  roll-dep src/third_party/libaom/source/libaom

Change-Id: I33c92eb0f442e479c1201ef1f184622371b98e1d
Reviewed-on: https://chromium-review.googlesource.com/1138398Reviewed-by: Tom Finegan <tomfinegan@chromium.org>
Commit-Queue: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/heads/master@{#575347}

Data pointer must be 4-byte aligned for mipmap generation to succeed,
add an alignment call to ensure this is always the case.

Bug: 863659
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I64c3806c1d1bfcd34fff48baedc5abfc8fb37ef4
Reviewed-on: https://chromium-review.googlesource.com/1137922
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575346}

Bug: 862099
Change-Id: Ia44305fa49a3605f0d5aa7fe09a6363730cf8ab9
Reviewed-on: https://chromium-review.googlesource.com/1138348
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575345}

The 'immersive' is more intuitive term than 'exclusive'[1].

[1] https://github.com/immersive-web/webxr/pull/371

Bug: 852524
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: If5c5ab6563df40a783f9d346d319dceed1f7cc58
Reviewed-on: https://chromium-review.googlesource.com/1101601
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575344}

Bug: none
Change-Id: Ice0fed66fd7176a3b6ae5b356e20a01d839bb30e
Reviewed-on: https://chromium-review.googlesource.com/1137484Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575343}

We were duplicating code to handle VR entry failing, so I de-duplicated
and refactored some code here.

Might fix issue 862829.

TBR=yfriedman@chromium.org

Bug: 862829
Change-Id: I357d40112f4d9a67e0b5206ff2dc2788e1d5d205
Reviewed-on: https://chromium-review.googlesource.com/1138400Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575342}

This reverts commit 3b9b2cca.

Reason for revert: The test is flaky on Win 10 and Win 7

Original change's description:
> Fix invalid password save offer in some cases.
> 
> Here we fix few password save flaws:
> 1. Invalid password save offer when a password form was filled and then a non
> password form was submitted.
> 2. A proper password form handling when a form is submitted into about:blank
> iframe using "target" attribute. This is a valid flow which some websites use to send private information via iframe.
> 
> The iframe test is implemented exactly for the #2 flaw.
> 
> Bug: 854171
> Change-Id: I39aec0d9b1f5fcbda551efb145f0c3be2456c0da
> Reviewed-on: https://chromium-review.googlesource.com/1106137
> Commit-Queue: Alexey Khoroshilov <sense@yandex-team.ru>
> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#575239}

TBR=dvadym@chromium.org,kolos@chromium.org,sense@yandex-team.ru

Change-Id: Ic89f7474943072def85f97f75033fa6ebe2ba736
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 854171
Reviewed-on: https://chromium-review.googlesource.com/1138518Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575341}

Frame eviction shouldn't just reset the fallback to an unvalid surface but should reset the primary too. This is done by replacing the SurfaceLayer with a SolidColorLayer.

Bug: 861764
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I18b9ee11c9d0132dd41eb34a8dc79bdae09af393
Reviewed-on: https://chromium-review.googlesource.com/1136847
Commit-Queue: Andre Kaba <akaba@google.com>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575340}

chromium_gtests_for_devices_with_graphical_output means "not cast".
The cast build doesn't include anything at the //chrome level, and
unit_tests lives at the //chrome level.

Currently we have unit_tests in chromium_gtests which runs on all bots,
and then an exception to remove it again on the cast bots.

Instead, put it in chromium_gtests_for_devices_with_graphical_output so that
it only runs on non-cast bots in the first place.

(It also ends up removing unit_tests from linux-blink-heap-incremental-marking
and linux-blink-heap-verification on the fyi waterfall, since these bots run
chromium_gtests instead of chromium_linux_gtests -- that looks like a bot
config bug, but it's only FYI bots anyways.)

This removes the last "unclear why" comment from test_suite*.pyl!

Bug: 843511,817779,812533
Change-Id: I76e0a2b30e0ca87c02c73cb46d8135d9ab7030d8
Reviewed-on: https://chromium-review.googlesource.com/1138333Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575339}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ff508d10..d75ef78a

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I765881f3c4a3ac1826dca2e46b8e73de42db3fc9
Reviewed-on: https://chromium-review.googlesource.com/1138393Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575338}

Bug: 863971
Change-Id: I7401eaf54693c83145b5a67c17da1ca1e69c9184
Tbr: nasko@chromium.org
NoTry: True
Reviewed-on: https://chromium-review.googlesource.com/1138376Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575337}