• Maxim Kolosovskiy's avatar
    Revert "Fix RunOnceClosure(OnceClosure) to take a OnceClosure by value" · 00758091
    Maxim Kolosovskiy authored
    This reverts commit 5bf31665.
    
    Reason for revert: this CL probably caused GmockCallbackSupportTest.RunOnceClosureValueMultipleCall failures. 
    The first failed build https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/3283
    
    Test 'GmockCallbackSupportTest.RunOnceClosureValueMultipleCall' completed with the following status(es): 'FAILURE','FAILURE'
    
    Test 'GmockCallbackSupportTest.RunOnceClosureValueMultipleCall' had the following logs when run:
    
    ================================================================================
    
    [ RUN      ] GmockCallbackSupportTest.RunOnceClosureValueMultipleCall
    ../../base/test/gmock_callback_support_unittest.cc:174: Failure
    Death test: check.Call()
        Result: died but not with expected error.
      Expected: contains regular expression "copyable_cb->data"
    Actual msg:
    [  DEATH   ]
    Stack trace:
    #0 0x57c25d527cd4 base::test::GmockCallbackSupportTest_RunOnceClosureValueMultipleCall_Test::TestBody()
    
    [  FAILED  ] GmockCallbackSupportTest.RunOnceClosureValueMultipleCall (26 ms)
    [ RUN      ] GmockCallbackSupportTest.RunOnceClosureValueMultipleCall
    ../../base/test/gmock_callback_support_unittest.cc:174: Failure
    Death test: check.Call()
        Result: died but not with expected error.
      Expected: contains regular expression "copyable_cb->data"
    Actual msg:
    [  DEATH   ]
    Stack trace:
    #0 0x58a33c3f9cd4 base::test::GmockCallbackSupportTest_RunOnceClosureValueMultipleCall_Test::TestBody()
    
    [  FAILED  ] GmockCallbackSupportTest.RunOnceClosureValueMultipleCall (29 ms)
    
    Original change's description:
    > Fix RunOnceClosure(OnceClosure) to take a OnceClosure by value
    > 
    > Bug: None
    > Change-Id: Iddf32bab6d0ab7ca195db02cc24d31e669a49051
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037184
    > Commit-Queue: Anand Mistry <amistry@chromium.org>
    > Reviewed-by: kylechar <kylechar@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#740079}
    
    TBR=amistry@chromium.org,kylechar@chromium.org
    
    Change-Id: I913831e1a782e9e684417582b5a8503c2f9a9fd2
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: None
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050491Reviewed-by: default avatarMaxim Kolosovskiy <kolos@chromium.org>
    Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#740296}
    00758091
gmock_callback_support_unittest.cc 3.85 KB