• Tommy C. Li's avatar
    [omnibox] Rename ZeroSuggestRedirectToChrome · 0099c854
    Tommy C. Li authored
    This CL is nearly a pure rename.
    
    It renames the ZeroSuggestRedirectToChrome flags and parameters to
    OnFocusSuggestionsCustomEndpoint.
    
    I think the new name is more descriptive, as the old name implied to me
    that the request was redirected locally to Chrome, when it was actually
    redirected to a Chrome-team maintained custom endpoint.
    
    Going forward, we may be using an endpoint that is NOT maintained by
    Chrome-team, so this will become particularly inaccurate if we don't do
    the rename.
    
    This feature that's being renamed is currently enabled via field trial
    for versions up to 76. This CL renames that feature, but the feature is
    still enabled by default in the binary, so it should continue with the
    server-side specified behavior.
    
    In other words, only 76 binaries without this feature enabled by
    default need the server-side config.
    
    That being said, for good measure it may be good to land this in 77.
    
    Bug: 966462
    Change-Id: I4c9f1c1ae285f7d1be1a806b2f4c3b6bd8cd47ee
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633229
    Commit-Queue: Tommy Li <tommycli@chromium.org>
    Reviewed-by: default avatarMark Pearson <mpearson@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#665327}
    0099c854
omnibox_features.h 2.85 KB