GitLab

This reverts commit 8f219b08.

Reason for revert: broke base_unittests on win-asan
First failure
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win-asan/3559

Original change's description:
> [Sampling profiler] Make ModuleCache::Module a reference type
> 
> Changes ModuleCache::Module from a value type to a reference type,
> with ModuleCache maintaining ownership of the Module. ModuleCache needs
> to own its Modules to properly support Windows, which reference counts
> its modules.
> 
> ModuleCache is retained as a struct to minimize the size of this change,
> but will be changed to a class in a later CL.
> 
> Bug: 931418
> Change-Id: Ifa5bb0e763de14d91c1663ba01aeb3bab09447be
> Reviewed-on: https://chromium-review.googlesource.com/c/1477817
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Reviewed-by: Charlie Andrews <charliea@chromium.org>
> Reviewed-by: oysteine <oysteine@chromium.org>
> Commit-Queue: Mike Wittman <wittman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#634408}

TBR=wittman@chromium.org,alph@chromium.org,oysteine@chromium.org,charliea@chromium.org

Change-Id: Iad9daf5933823b3139d4a81d5d2d6ba6b8e655f6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 931418
Reviewed-on: https://chromium-review.googlesource.com/c/1482894
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#634601}