-
Rohan Pavone authored
Determines if platform supports overridden status of permission by querying PermissionControllerDelegate. Since most delegates have static permission statuses, this queries the permission status by default. Overridden classes, such as PermissionManager (used for Chrome) and WebTestPermissionManager, have dynamic permission settings which are queried in a different fashion. If permission is not supported, this is indicated. PermissionControllerImpl, which controls overrides, uses this decision to choose whether or not to override, which is then forwarded to the callee. Browser.setPermission uses this to indicate if setting permission failed/succeeded. Browser.grantPermission ignores the result. Design doc: go/chromedriver-permissions-ext Bug: 976308 Change-Id: I0124ea1b2238a33c379476b74d6ef322327413a2 Tested: Adds unit tests to each affected level. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752176 Commit-Queue: Rohan Pavone <rohpavone@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#689139}
013c4006