• Oksana Zhuravlova's avatar
    Implement a check for import/deps consistency in mojom files · 015487b3
    Oksana Zhuravlova authored
    This changes adds a new target to the mojom template which depends on
    the parse target and is a dependency for all generation targets. A new
    action has been added to the mojom_bindings_generator.py script that
    compares the list of sources for all dependencies of a given mojom file
    target to the list of imports in this file. If missing dependencies are
    found, they are printed and the script exits with an error.
    This changes also fixes missing dependencies and not fully-qualified
    import statements.
    
    Dependency check has been disabled for //content/common:mojo_bindings
    and //content/public/common/interfaces since it caused multiple
    definitions linker errors on Windows (they have both direct and indirect
    dependencies on specific targets).
    
    Bug: 753219
    Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng
    Change-Id: I64613ad14af41f1fc2a77b81ac76507e26f9dfcc
    Reviewed-on: https://chromium-review.googlesource.com/947384
    Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
    Reviewed-by: default avatarKen Rockot <rockot@chromium.org>
    Reviewed-by: default avatarScott Violet <sky@chromium.org>
    Reviewed-by: default avatarTom Sepez <tsepez@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#542054}
    015487b3
app.mojom 11.6 KB