• Dan Beam's avatar
    Reland "Local NTP, Realbox: fix navigation to chrome:// URLs" · 01f7c688
    Dan Beam authored
    This is a reland of f5946a0a
    
    It was reverted as 9948fd01
    
    Fix: just exclude ASAN/LSAN bots from running this test.
    Context: I was able to produce flaky failures locally, and I
    believe these bots are simply timing out because there's now
    30 realbox tests. Because these tests are basically just
    Javascript, there's really no benefit from running them under
    leak/address sanitizer bots (generally only helpful to C++).
    
    Original change's description:
    > Local NTP, Realbox: fix navigation to chrome:// URLs
    >
    > Partially borrowed from https://crrev.com/c/1836021 by Archana Simha <archanasihma@chromium.org>
    >
    > Bug: 1020025
    > Change-Id: I7de22a41d872ec624f25d1633782d27448988c58
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893824
    > Commit-Queue: David Bokan <bokan@chromium.org>
    > Reviewed-by: David Bokan <bokan@chromium.org>
    > Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
    > Reviewed-by: Nasko Oskov <nasko@chromium.org>
    > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    > Auto-Submit: Dan Beam <dbeam@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#715106}
    
    TBR=dcheng@chromium.org,bokan@chromium.org,nasko@chromium.org,mahmadi@chromium.org
    
    Bug: 1020025
    Change-Id: I666c372b76a058702c29b88eff765c2cd90c0bb2
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917982Reviewed-by: default avatarDan Beam <dbeam@chromium.org>
    Reviewed-by: default avatarMoe Ahmadi <mahmadi@chromium.org>
    Commit-Queue: Dan Beam <dbeam@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#715459}
    01f7c688
searchbox.h 11.3 KB