GitLab

This CL is part of a larger project to remove the LOAD_DO_NOT_* privacy
load flags and replace them with the allow_credentials setting. See
https://crbug.com/799935 and
https://docs.google.com/document/d/1ntn9N7Ce2jozvvpWI0XbzJ7lJdwUjJXK07wp7rxrIN4
for the motivation for this change.

network::mojom::CredentialMode::kOmit is equivalent to
LOAD_DO_NOT_{SEND_COOKIES,SAVE_COOKIES,AUTH_DATA}. For features which
did not include LOAD_DO_NOT_SEND_AUTH_DATA, this change has two
implications:

- The request will no longer participate in HTTP auth if the server requests
  it. HTTP auth credentials identify the user, so private requests should
  not send them. Note this only affects server auth, not proxy auth.
  Requests through the network service already deny HTTP auth
  challenges if not attached to a WebContents, so this should be a no-op
  for these features.

- The request will be pooled with sockets used for uncredentialed requests,
  rather than credentialed requests. This is not expected to meaningfully
  change behavior.

TBR=mdjones@chromium.org, wutao@chromium.org

Bug: 799935
Change-Id: I6036193c0be4fa8a177a9cb79b84ca963fe435b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893957
Commit-Queue: David Benjamin <davidben@chromium.org>
Reviewed-by: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Rachel Blum <groby@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714751}