• sdy's avatar
    Revert of BackgroundGradientView: -drawBackground: → -drawRect: (patchset #2... · 02a48496
    sdy authored
    Revert of BackgroundGradientView: -drawBackground: → -drawRect: (patchset #2 id:40001 of https://codereview.chromium.org/2336453002/ )
    
    Reason for revert:
    AnimatableView inherits from BackgroundGradientView, so a number of
    other views which *don't* want backgrounds end up inheriting from
    BackgroundGradientView. This widened the scope of the change beyond what
    I intended.
    
    Original issue's description:
    > BackgroundGradientView: -drawBackground: → -drawRect:
    >
    > BackgroundGradientView had a -drawBackground: method that its clients
    > were expected to call. This change moves background drawing to
    > -drawRect: so that the it happens by default.
    >
    > Subclasses that did custom drawing already override -drawRect:, but this
    > removes a couple of overrides that just forwarded to -drawBackground:.
    >
    > BUG=589943
    >
    > Committed: https://crrev.com/6b1939a26d2839136aeeba2aa0e359fce0c20281
    > Cr-Commit-Position: refs/heads/master@{#418358}
    
    TBR=thakis@chromium.org
    # Not skipping CQ checks because original CL landed more than 1 days ago.
    BUG=647018
    
    Review-Url: https://codereview.chromium.org/2339143003
    Cr-Commit-Position: refs/heads/master@{#418714}
    02a48496
background_gradient_view_unittest.mm 1.37 KB