• Eugene But's avatar
    Fixed Navigation callbacks for failed provisional navigation. · 02bddfd9
    Eugene But authored
    Verified callbacks correctness with
    NavigationCallbacksTest.FailedNavigation integration test.
    
    Before this CL DidStartNavigation was called twice (second time
    for presenting error in Native Content). DidFinishNavigation was
    called once (also for presenting NativeContent). First
    DidStartNavigation did not have a matching DidStartNavigation
    call.
    
    This CL removes DidStartNavigation/DidFinishNavigation callbacks
    for for presenting error in Native Content and adds balanced
    DidFinishNavigation callback in handleLoadingError:.
    
    Bug: 725241
    Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
    Change-Id: Id15ef8c9422e571f74f9c00bf88ea98ccbf6607c
    Reviewed-on: https://chromium-review.googlesource.com/758718
    Commit-Queue: Eugene But <eugenebut@chromium.org>
    Reviewed-by: default avatarKurt Horimoto <kkhorimoto@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#517420}
    02bddfd9
navigation_callbacks_inttest.mm 38.9 KB