• Darin Fisher's avatar
    Move ContentSettingsManagerImpl to be a per-process rather than per-frame object. · 02db15e9
    Darin Fisher authored
    This is an attempt to avoid a renderer hang that may be explained by trying to
    get an interface via BrowserInterfaceBroker (BIB) and then make synchronous calls
    on that interface.
    
    This is an experimental change. It is unfortunate to introduce render_frame_id
    parameters here, and my intent is to come back and remove them once I understand
    how to do so without the observed hang.
    
    The experiment with this CL is to confirm that the observed hang goes away. If it
    does, then it confirms that there is some interaction with BIB that is causing the
    issue. If it does not, then we know BIB is off the hook, and we can look elsewhere.
    
    Bug: 1023519
    Change-Id: I696b63f057605b3cd5fe7f0c8182b044f2a60578
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949036Reviewed-by: default avatarKen Rockot <rockot@google.com>
    Reviewed-by: default avatarKinuko Yasuda <kinuko@chromium.org>
    Commit-Queue: Darin Fisher <darin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#721382}
    02db15e9
chrome_browser_interface_binders.cc 11.2 KB