• Jan Krcal's avatar
    [Sync] Patch a crash in AutofillWalletSyncableService · 03148944
    Jan Krcal authored
    This is a speculative patch for a bug causing a crash in
    AutofillWalletSyncableService. This CL stops the generic change
    processor from talking to the syncable service when the service gets
    stopped.
    
    GenericChangeProcessor only talks to the service because it gets pinged
    by SyncBackendRegistrar. The registrar should not talk to the
    GenericChangeProcessor after a data type gets deactivated. Normally, a
    data type should get deactivated before it gets stopped. However, we
    see crashes in Canary that seem to contradict this expected behavior.
    
    Bug: 880029
    Change-Id: I64b9ea1c3521a347983a530bc16c1f8e266769b6
    Reviewed-on: https://chromium-review.googlesource.com/1230714
    Commit-Queue: Jan Krcal <jkrcal@chromium.org>
    Reviewed-by: default avatarMikel Astiz <mastiz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#592485}
    03148944
shared_change_processor.h 7.06 KB