• Avery Musbach's avatar
    overview: Correct for changes to the |kTopViewInset| window property. · 03dd856b
    Avery Musbach authored
    The |kTopViewInset| window property can change during overview.
    Particularly, the Settings window behaves that way if overview starts
    during transition to tablet mode as another window carries over from
    clamshell snapped state to tablet split view. Now, when the
    |kTopViewInset| window property changes, consistent with existing
    behavior for bounds changes, the visual appearance of overview shall
    generally be corrected at the expense of interrupting animation effects.
    The one exception is if the |kTopViewInset| window property changes
    while overview is being prepared. In this case, still consistent with
    existing behavior for bounds changes, nothing shall be done, because
    when the overview preparation has been completed, overview will look
    right anyway.
    
    Test: ash_unittests OverviewSessionTest.TopViewInsetChangeDuringOverview
    Bug: 932816
    Change-Id: I482d5ce5c24ff40ccc28e898ae3668f6831b71bd
    Reviewed-on: https://chromium-review.googlesource.com/c/1495444
    Commit-Queue: Avery Musbach <amusbach@chromium.org>
    Reviewed-by: default avatarSammie Quon <sammiequon@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#636633}
    03dd856b
overview_session_unittest.cc 166 KB