• Nico Weber's avatar
    Remaining tricky bits to build webkit_unit_tests with -Wimplicit-fallthrough. · 04196014
    Nico Weber authored
    Follow-up to https://chromium-review.googlesource.com/c/889942/
    
    Also update a very old comment that I believe tries to say that the fallthrough
    is intentional: In https://websvn.kde.org/trunk/kdelibs/khtml/rendering/bidi.cpp?r1=56133&r2=56134&pathrev=65933
    the code and comment looked like so:
    
        switch(dirCurrent) {
          ...
          case QChar::DirEN:
            if(status.lastStrong != QChar::DirAL) {
              // if last strong was AL change EN to AN
              ...
            }
          case QChar::DirAN:
            dirCurrent = QChar::DirAN;
            ...
    
    All the constants have been renamed several times, but the comment was touched just once
    after being added in https://websvn.kde.org/trunk/kdelibs/khtml/rendering/bidi.cpp?limit_changes=0&view=markup&pathrev=42417
    in Mar 2000 (in a commit saying "merge of the new_rendering branch." -- I couldn't find
    where the new_rendering branch is. Probably in some CVS repo, but I didn't manage to find it)
    and that's in 56134 linked above, which changed it from
    
        // if last strong was AL change EN to AL
    
    to
    
        // if last strong was AL change EN to AN
    
    which looks like a typo fix.
    
    This CL was uploaded by git cl split.
    
    R=fmalita@chromium.org
    
    Bug: 177475
    Change-Id: I55de0202f9a67436a4abb630291d1280ee489d4d
    Reviewed-on: https://chromium-review.googlesource.com/890430
    Commit-Queue: Nico Weber <thakis@chromium.org>
    Reviewed-by: default avatarFlorin Malita <fmalita@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#532979}
    04196014
BidiResolver.h 45.7 KB