• Rushan Suleymanov's avatar
    Reland "[Sync] Postpone reupload of bookmarks until next updates received" · 045839fc
    Rushan Suleymanov authored
    This reverts commit 8ebf771a.
    
    Reason for revert: revert didn't fix win-asan failures, it doesn't affect them and must be safe to reland.
    
    Original change's description:
    > Revert "[Sync] Postpone reupload of bookmarks until next updates received"
    > 
    > This reverts commit 56f7b697.
    > 
    > Reason for revert: win-asan failures
    > https://bugs.chromium.org/p/chromium/issues/detail?id=1106392
    > 
    > Original change's description:
    > > [Sync] Postpone reupload of bookmarks until next updates received
    > > 
    > > When reupload is initiated after loading from the disk right away, it
    > > may lead to upload bookmarks which were removed from the other device.
    > > This would restore removed bookmarks. In practise it may be caused by
    > > some devices which a rarely used.
    > > 
    > > Initiating reupload after receiving latest updates from the server helps
    > > to prevent such behaviour.
    > > 
    > > Bug: 1061411
    > > Change-Id: Ibc5646b19bf133de496140fa152b544bc06ebcf9
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299721
    > > Commit-Queue: Rushan Suleymanov <rushans@google.com>
    > > Reviewed-by: Mikel Astiz <mastiz@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#788775}
    > 
    > TBR=mastiz@chromium.org,rushans@google.com
    > 
    > Change-Id: Ib00d0dfc3cd570aaf1081482cf1bd727b3dbdf8e
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 1061411
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302773
    > Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
    > Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
    > Cr-Commit-Position: refs/heads/master@{#789078}
    
    TBR=mastiz@chromium.org,jonahr@google.com,rushans@google.com
    
    # Not skipping CQ checks because this is a reland.
    
    Bug: 1061411
    Change-Id: Id4884cd8d26c73142fb5772ee0ab617613c7a8d4
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302752Reviewed-by: default avatarRushan Suleymanov <rushans@google.com>
    Reviewed-by: default avatarMikel Astiz <mastiz@chromium.org>
    Commit-Queue: Rushan Suleymanov <rushans@google.com>
    Cr-Commit-Position: refs/heads/master@{#789427}
    045839fc
synced_bookmark_tracker.h 16 KB