-
Filip Gorski authored
This reverts commit 3481a5a7. Reason for revert: Broke TranslateBrowserTest on android-pie-x86-rel https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/2212 Test output https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8869167939689927152/+/steps/weblayer_browsertests/0/logs/Deterministic_failure:_TranslateBrowserTest.TranslateInfoBarNeverTranslateSite__status_FAILURE_/0 It is possible that that specific test needs an adjustment to go in together with this. Original change's description: > [WebLayer] Add ability to override translate target language > > This CL adds the ability to override the target language used by the > translate feature on a per-Tab basis. This is analogous to the > functionality of CCT's TRANSLATE_LANGUAGE intent extra. Once the > override is set, all translate infobars in the given Tab will appear > with the specified language as the target language. Calling > Tab#setTranslateTargetLanguage() with an empty string clears the > override and causes behavior to revert to normal. > > Note that even with the override set the translate infobar will not > appear for pages that are in the user's locale. This is internal > behavior of Chromium's translate component and is common to CCT and > WebLayer. > > I marked the added method as since 86 as this CL will be targeted for > cherrypicking to 86. > > Bug: 1116394 > Change-Id: Ic4f08c16a64a3f0ceebed5feab7cdc9401001279 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397716 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Clark DuVall <cduvall@chromium.org> > Commit-Queue: Colin Blundell <blundell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806633} TBR=jam@chromium.org,blundell@chromium.org,cduvall@chromium.org Change-Id: Idbb50b93aea9a4037e2956ba63a570047e50944b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1116394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410610Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#806686}
0505b6f2