• Gabriel Charette's avatar
    Revert "[MessageLoop] Disable hi-res timers when not sleeping" · 050feaa7
    Gabriel Charette authored
    This reverts commit 62973d1b.
    
    Reason for revert: results in more churn in
    base::Time::ActivateHighResolutionTimer()
    without much benefits (decreased 97th and 98th percentile of
    Windows.HighResolutionTimerUsage from 100% to 97% and 99%
    respectively). See crbug.com/863938
    
    Original change's description:
    > [MessageLoop] Disable hi-res timers when not sleeping
    > 
    > Time::ActivateHighResolutionTimer(bool activating) is a per-thread vote
    > for a system-wide side-effect. For a given thread, hi-res timers are
    > only useful when going to sleep (if it has pending hi-res tasks).
    > 
    > Deactivating a thread's vote while it's active will prevent other
    > threads on the system which do not have hi-res requirements from
    > being forced to use hi-res timers in that period.
    > 
    > Bug: 854237
    > Change-Id: I1393e184cac6c9321d13b92b6077a38c62b1f590
    > Reviewed-on: https://chromium-review.googlesource.com/1107110
    > Reviewed-by: danakj <danakj@chromium.org>
    > Reviewed-by: kylechar <kylechar@chromium.org>
    > Commit-Queue: Gabriel Charette <gab@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#574259}
    
    TBR=danakj@chromium.org,gab@chromium.org,kylechar@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 854237, 863938
    Change-Id: I7c26646cac8548ae7b02c90e045bc857ae890ce7
    Reviewed-on: https://chromium-review.googlesource.com/1140753Reviewed-by: default avatarGabriel Charette <gab@chromium.org>
    Commit-Queue: Gabriel Charette <gab@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#576157}
    050feaa7
message_loop_unittest.cc 78.1 KB