GitLab

This CL cleans-up URLLoaderFactoryBundle[Info] in preparation for adding
initiator-origin-keyed factories in the future (for supporting
URLLoaderFactories with extension-specific permissions for requests
initiated by content scripts).

Changes in the CL:

- s/factories/scheme_specific_factories/
- s/factories_info/scheme_specific_factory_infos/
    Rationale for the changes above:
    - Making it more explicit that these factories are keyed by a scheme
    - Differentiating the name from |initiator_specific_factories| that
      is planned to be introduced in a follow-up CL
      (https://crrev.com/c/1228478).

- Introducing URLLoaderFactoryBundle::SchemeMap
- Introducing URLLoaderFactoryBundleInfo::SchemeMap
- Fixes for some of issues reported by: git cl lint
- Removing URLLoaderFactoryBundle::RegisterFactory that had no callers.
- Making URLLoaderFactoryBundle::GetFactoryForURL protected
  (it used to be unnecessarily public)
- Having ChildURLLoaderFactoryBundle delegate to its base class
  (URLLoaderFactoryBundle) in its implementation of GetFactoryForURL
  and CreateLoaderAndStart methods.

There are no intended behavior changes in this CL
(well except skipping a DCHECK in GetFactoryForURL method so that
the method can be reused by subclasses with more relaxed invariants).

Bug: 846346
Change-Id: Ibbd07debaf518e2b71cf09a2fd92c8b8104b7411
Reviewed-on: https://chromium-review.googlesource.com/1227135Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593316}