• Emily Stark's avatar
    Simplified domains: undo transparency when showing full URL · 05f7b76b
    Emily Stark authored
    In the simplified domain field trials, the path, scheme, and
    optionally subdomains get faded to transparent when the user interacts
    with the page or after the user hovers and exits the mouse. But there
    are various ways that it's possible to transition from this state
    (path, scheme, subdomains faded out) to showing the full URL. However,
    the method that shows the full URL wasn't applying any color changes,
    only changing the display area/offset. This could lead to some
    situations where the full URL is scrolled into view, but some parts of
    it were still transparent (see bug for repro). To fix this,
    ShowFullURL() now resets the text color and applies emphasis by
    calling EmphasizeURLComponents(). This ensures that all components of
    the URL are not just scrolled into the display area but also colored
    properly and not transparent.
    
    Bug: 1106478
    Change-Id: Ifc57b33c8e6604764ca004a7035c382465711b67
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305031
    Commit-Queue: Emily Stark <estark@chromium.org>
    Reviewed-by: default avatarTommy Li <tommycli@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#789691}
    05f7b76b
omnibox_view_views.cc 98.8 KB