GitLab

With this change, all DialogBrowserTest should be abled to verify pixel correctness.
To use them as pixel test, add flag --browser-ui-tests-verify-pixels.
TEST: browser_tests.exe --gtest_filter=PermissionDialogTest.*
--browser-ui-tests-verify-pixels --enable-pixel-output-in-tests
--build-revision=b6aaf42b --no-luci-auth
I've approved the following images so these tests can pass now.
https://chrome-gpu-gold.skia.org/detail?test=BrowserUiDialog_PermissionDialogTest_InvokeUi_protocol_handlers&digest=877f6df6101e926f24c5b9bc3cf111b3
https://chrome-gpu-gold.skia.org/detail?test=BrowserUiDialog_PermissionDialogTest_InvokeUi_camera&digest=cf09792802b243e0a33bf4d45e2e8047
I didn't start with test_browser_ui because most of the tests are inherited from test_browser_dialog.

Next step:
1 Add some tests to fyi bots to monitor the stability.
2 Fix some tests that don't have stable UI. Eg disable animation for
https://chrome-gpu-gold.skia.org/detail?test=BrowserUiDialog_AuthenticatorDialogViewTest_InvokeUi_default&digest=2442c011949e9f98f4442f066bb90e55

Bug: 958242
Change-Id: I7bc048b792a5e303e8ee948fda228fa664395ca1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756604
Commit-Queue: Sven Zheng <svenzheng@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688211}