• David Black's avatar
    Use OnConversationTurnStartedInternal API in Assistant. · 06767a26
    David Black authored
    Previously we used the OnConversationTurnStarted API to notify us of
    when an interaction was starting in LibAssistant. This API did not give
    us any metadata about the interaction, so we couldn't match it with
    confidence to one of our requests.
    
    The new API exposes an ID through the |metadata| param. We can use that
    ID to match an interaction request with a conversation turn. Once fully
    wired up, this will allow us to stop pending a query before a conversation
    turn starts and instead only do so within our interaction lifecycle. Once
    lifecycle has been fixed, a number of downstream bugs will be resolved.
    
    The CL to fix lifecycle will be a follow up. This CL only exposes the
    interaction metadata that we will need in order to do so.
    
    Bug: 941259, 973680
    Change-Id: I32edf71251272aa21dc571df40f15b8de12cefba
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757425
    Commit-Queue: David Black <dmblack@google.com>
    Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
    Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
    Reviewed-by: default avatarXiaohui Chen <xiaohuic@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#689578}
    06767a26
assistant_interaction_controller.h 5.86 KB