• Robert Sesek's avatar
    [Mac] Stop performing direct NSColor lookups in the renderer process. · 0694f7c1
    Robert Sesek authored
    In blink::LayoutThemeMac, various system color properties are retrieved
    from NSColor. These system colors are part of the "dynamic system color
    store", and trying to access them may cause issues with the sandbox.
    
    This augments the blink::WebSandboxSuport interface on Mac to look up
    system colors via a shared memory segment that is populated by the
    browser. In addition, this centralizes the various Mac implementations
    of that interface into a single one.
    
          System Prefs>General and change the Highlight Color. Upon going
          back to Chrome, the new highlight color should be visible.
    
    Bug: 641509, 36032
    Test: Highlight some text on a web page. Then go to
    Change-Id: I3bc05c08ecab62b1fc68442d3edd93ec7edb8590
    Reviewed-on: https://chromium-review.googlesource.com/c/1331133Reviewed-by: default avatarAvi Drissman <avi@chromium.org>
    Reviewed-by: default avatarKent Tamura <tkent@chromium.org>
    Commit-Queue: Robert Sesek <rsesek@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#609719}
    0694f7c1
ppapi_blink_platform_impl.cc 6.14 KB